From nobody Mon Jun 8 06:40:53 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E549436B067 for ; Mon, 1 Jun 2026 11:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314885; cv=none; b=TlDvL89J1gmMwrii2duxfy4Rf0yYQE+SPgfQq3h7S6oDGW6YDB790d8RUM/af2dPUtjEzgqlXsTLeVVIHTC84PWca4JgaqvW7EunrYUVdo2MwDfmMbww0GR0lUbh9Ysond1kg4bx3N9JKH+fUuBqcFIJOHySYX1y56OOJcmztwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314885; c=relaxed/simple; bh=ZcygQpq65NFcCBaadUwAem+AMnv6hoXOkkw6vRgkg/E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WdoT7blT/SL+KmhhfBF9LbNbgfLR/WKy8Vpu/yuBK0PAXrHzJRVdDiYjO+LVN3TBZ06ghsg+ztviCagSkywUGVejk7pVU0zk2T8lZnyDYWqdnhfJngvtKzCvFQkxKpSzdRtODx6/YoVNP2NTNEtJufYCzus1j+IOM4bgBVh7YS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=skgQD6Px; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="skgQD6Px" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49068493267so55424605e9.1 for ; Mon, 01 Jun 2026 04:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780314881; x=1780919681; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9rz09+2Oyjjy41by5WLRiYGv3p7hWYKkZKSAJAJXeH8=; b=skgQD6Pxeb16haiwkBPV52/iv+cpmo8cgmqxGxTBCCJBlX3JxEjME81gXscqdbmVhW F6bf30J2z1E3zZtXyWeaSn4d8wuDbQUM7OcOcSvZ7NuT0uFxi01sGCdZN+Biom1rEjnr QZv2fURcszMczqEUS48H8XA5tltVhPhNQk6GHLbtfe8ENqE1Y/8JNXd/W0uPQV2C22mf KOYg2JlnOAWZHsJd9WthCC2z8bGbHdvjwrLjlbDCZJkuORtPInGzwKqNw5FXDY6kJrtC rhFpvX+4H62N9WwWt7S2H+FZF5rYxac8L1vKJcIJDdktJp5qGNg6/baCjb+WPOUvGLpr P7Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780314881; x=1780919681; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9rz09+2Oyjjy41by5WLRiYGv3p7hWYKkZKSAJAJXeH8=; b=AVHPtShSCac5DPnba9Z9Fq6aStyy5/WB1cMNSNRfITklaGfqkEo7tNIRVt5XMufMkB lA4ufcT0vamy7cZy/SUb3reJ7IOmQ06wzKzexIoUmWeYWznU39zhcM8ylWLsPaxuQXXY BiIELPGOcR2KTaYvIwwXdIiCTdcD1pmT96fEyh3uhFxVS83Zl+wB14F/SIMVEL9+Y9LJ Pg4I3P93qlE8ha6BJKEz1As16B/EBcv6T0m3XUMEwCKlnWptPWjuN7soMmwaxt64aH2a L/co4k2krYLso6n73dP7PwtU8rkVAV/aAwoaUxHN372P2U7YOjaLd+OS6USzxcZpPm8B eWcg== X-Forwarded-Encrypted: i=1; AFNElJ+11QuTUaX4LlX7RXkK2NbPfJM/j0muc+f2V9DQiLiG4h/X/ZX14sfGehIArEJzuoy2UZ2Z/VGiesbNiMg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj6Pk1KSNkbSb6Hhj7+QhjqXFJaJuCHlyR+CrdDZXo2gMu1YCu tP1tmKKw2SqKs/R1bMnxLykEKB7fEwMj+UZx10T5wI2hPrMq9U1zOUUx X-Gm-Gg: Acq92OEad94ENlb7DHpCSkZ3q3EgNPGkoJQOxwAxUrTNac5Y4FvhcETJzXkQ00+1qlK ADY/KV0LxPcOduCEyGecC6icfYbfamrb4U6SiGTrTYz/UtFefQVr9sTElRaNkiw7JfYfFoeViVZ hsG0ixfZwizydxCA1LFWZME95s18zJ7ZTYNFPAX1B8pxK7KSmemrm7byow5CtB9rtr7GhfhVPC/ ly9K7EY8BHecDxynF1S4pIgELumikpdw62oN2ZfxmxpSalZcIKdXvaUt+6ejm7ENdeIK9e75HKW Eh/5xC9UVP/SQ1xpftY5MpMVH+fPjbnF/JfVaAtkBSbM1LOAemXUKr9/rToIQO5K/y/rFobeya/ PUl9vvfqS5do4mmiWJ/xd97MqWJpKQkZv0pdpJUqodUKZH2V26lPdag2uClgCQOAtSqBdOVUvVY HcMHdqdDl4COaTNRfm2HzPu+xFQazUHpCfmkKsK6qoprt16lZRXpm2dVr4zjCg1hgJrisLm/WAG Swaj7DD6alLbH+BUCkt X-Received: by 2002:a05:600d:640f:10b0:48f:f7cc:f6f5 with SMTP id 5b1f17b1804b1-490a2945b99mr143668415e9.31.1780314881094; Mon, 01 Jun 2026 04:54:41 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c121d63sm74376765e9.29.2026.06.01.04.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:54:40 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 13:54:12 +0200 Subject: [PATCH net-next v8 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v8-1-cfa102cf62c0@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780314877; l=8184; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=ZcygQpq65NFcCBaadUwAem+AMnv6hoXOkkw6vRgkg/E=; b=/g44HpjbIcLxXvtf1NGoxIxMn/GzTg1o4t+aRiiTkihQWCTRglBdbtMwMjSHpccAekYW0QdPU HjWYPdh6J92BsbzL1emq0gHIVoYVoC/DAl/5quXDg0fK24oIbSNuYyy X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Implement the KSZ87xx short cable workaround. This patch implements the KSZ87xx short cable erratum described in Microchip document DS80000687C for KSZ87xx switches and the following support article: Link: https://support.microchip.com/s/article/Solution-for-Using-CAT-5E-or-= CAT-6-Short-Cable-with-a-Link-Issue-for-the-KSZ8795-Family The issue affects short or low-loss cable links (e.g. CAT5e/CAT6), where the PHY receiver equalizer may amplify high-amplitude signals excessively, resulting in internal distortion and link establishment failures. KSZ87xx devices require a workaround for the Module 3 low-loss cable condition, controlled through the switch TABLE_LINK_MD_V indirect registers. This change models the erratum handling as vendor-specific Clause 22 PHY registers, virtualized by the KSZ8 DSA driver and accessed via ksz8_r_phy() / ksz8_w_phy(). The following controls are provided: - A boolean =E2=80=9Cshort-cable=E2=80=9D preset, which applies a documente= d and conservative configuration (LPF 62 MHz bandwidth and DSP EQ initial value 0), and is the recommended interface for typical use cases. - Separate LPF bandwidth and DSP EQ initial value controls intended for advanced or experimental tuning. These are orthogonal and independent, and override the corresponding settings without requiring any specific ordering. The preset and tunables act as simple setters with no implicit state machine or invalid combinations, keeping the API predictable and aligned with the KISS principle. The erratum affects the shared PHY analog front-end and therefore applies globally to the switch. Fixes: e66f840c08a2 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver") Signed-off-by: Fidelio Lawson Reviewed-by: Marek Vasut Reviewed-by: Nicolai Buchwitz --- drivers/net/dsa/microchip/ksz8.c | 89 ++++++++++++++++++++++++++++++= ++++ drivers/net/dsa/microchip/ksz8_reg.h | 23 ++++++++- drivers/net/dsa/microchip/ksz_common.h | 4 ++ 3 files changed, 115 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8.c b/drivers/net/dsa/microchip/k= sz8.c index 0f84b2e7d25d..b8a7b9004142 100644 --- a/drivers/net/dsa/microchip/ksz8.c +++ b/drivers/net/dsa/microchip/ksz8.c @@ -798,6 +798,40 @@ static int ksz879x_set_loopback(struct ksz_device *dev= , u16 port, u16 val) stat3); } =20 +static int ksz87xx_apply_low_loss_preset(struct ksz_device *dev, bool enab= le) +{ + /* Apply the Microchip erratum short-cable preset (LPF 62 MHz, EQ init 0) + * providing a conservative configuration for short or low-loss cables. + */ + u8 lpf_bw, eq_init; + int ret; + + lpf_bw =3D KSZ87XX_PHY_LPF_62MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS; + + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + + if (!enable) { + /* Restore default values (LPF 90 MHz, EQ init 15). */ + lpf_bw =3D KSZ87XX_PHY_LPF_90MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_FACTORY; + } + + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, lpf_bw); + if (ret) + return ret; + + dev->lpf_bw =3D lpf_bw; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, eq_init); + if (ret) + return ret; + + dev->eq_init =3D eq_init; + + return ret; +} + /** * ksz8_r_phy_ctrl - Translates and reads from the SMI interface to a MIIM= PHY * Control register (Reg. 31). @@ -1046,6 +1080,22 @@ static int ksz8_r_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 *val) if (ret) return ret; =20 + break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D !!(dev->lpf_bw =3D=3D KSZ87XX_PHY_LPF_62MHZ && + dev->eq_init =3D=3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS); + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->lpf_bw; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->eq_init; break; default: processed =3D false; @@ -1272,6 +1322,41 @@ static int ksz8_w_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 val) if (ret) return ret; break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + ret =3D ksz87xx_apply_low_loss_preset(dev, !!val); + if (ret) + return ret; + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + /* Only accept LPF bandwidth bits [7:6] */ + if (val & ~KSZ87XX_PHY_LPF_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, (u8)val= ); + if (ret) + return ret; + dev->lpf_bw =3D val; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + /* Only accept DSP EQ initial value bits [5:0] */ + if (val & ~KSZ87XX_DSP_EQ_VALID_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, (u8)val); + if (ret) + return ret; + dev->eq_init =3D val; + break; default: break; } @@ -2070,6 +2155,10 @@ static int ksz8_setup(struct dsa_switch *ds) return ret; } =20 + /* Initialize KS87xx short-cable preset control */ + dev->eq_init =3D KSZ87XX_DSP_EQ_INIT_FACTORY; + dev->lpf_bw =3D KSZ87XX_PHY_LPF_90MHZ; + ret =3D ksz8_handle_global_errata(ds); if (ret) return ret; diff --git a/drivers/net/dsa/microchip/ksz8_reg.h b/drivers/net/dsa/microch= ip/ksz8_reg.h index 332408567b47..981ab441d9b7 100644 --- a/drivers/net/dsa/microchip/ksz8_reg.h +++ b/drivers/net/dsa/microchip/ksz8_reg.h @@ -202,6 +202,10 @@ #define REG_PORT_3_STATUS_0 0x38 #define REG_PORT_4_STATUS_0 0x48 =20 +/* KSZ87xx LinkMD registers (TABLE_LINK_MD_V) */ +#define KSZ87XX_REG_DSP_EQ 0x08 /* DSP EQ initial value */ +#define KSZ87XX_REG_PHY_LPF 0x4C /* RX LPF bandwidth */ + /* For KSZ8765. */ #define PORT_REMOTE_ASYM_PAUSE BIT(5) #define PORT_REMOTE_SYM_PAUSE BIT(4) @@ -342,7 +346,7 @@ #define TABLE_EEE (TABLE_EEE_V << TABLE_EXT_SELECT_S) #define TABLE_ACL (TABLE_ACL_V << TABLE_EXT_SELECT_S) #define TABLE_PME (TABLE_PME_V << TABLE_EXT_SELECT_S) -#define TABLE_LINK_MD (TABLE_LINK_MD << TABLE_EXT_SELECT_S) +#define TABLE_LINK_MD (TABLE_LINK_MD_V << TABLE_EXT_SELECT_S) #define TABLE_READ BIT(4) #define TABLE_SELECT_S 2 #define TABLE_STATIC_MAC_V 0 @@ -729,6 +733,23 @@ #define PHY_POWER_SAVING_ENABLE BIT(2) #define PHY_REMOTE_LOOPBACK BIT(1) =20 +/* Vendor-specific Clause 22 PHY registers (virtualized) */ +#define PHY_REG_KSZ87XX_SHORT_CABLE 0x1A +#define PHY_REG_KSZ87XX_LPF_BW 0x1B +#define PHY_REG_KSZ87XX_EQ_INIT 0x1C + +/* LPF bandwidth bits [7:6]: 00 =3D 90MHz (default), 01 =3D 62MHz, 10 =3D = 55MHz, 11 =3D 44MHz */ +#define KSZ87XX_PHY_LPF_MASK GENMASK(7, 6) +#define KSZ87XX_PHY_LPF_90MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 0) +#define KSZ87XX_PHY_LPF_62MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 1) +#define KSZ87XX_PHY_LPF_55MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 2) +#define KSZ87XX_PHY_LPF_44MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 3) + +/* Low-loss workaround DSP EQ INIT VALUE */ +#define KSZ87XX_DSP_EQ_VALID_MASK GENMASK(5, 0) +#define KSZ87XX_DSP_EQ_INIT_LOW_LOSS 0x00 +#define KSZ87XX_DSP_EQ_INIT_FACTORY 0x0F + /* KSZ8463 specific registers. */ #define P1MBCR 0x4C #define P1MBSR 0x4E diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/micro= chip/ksz_common.h index b67038cf1bd0..45613b9aeb1e 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -222,6 +222,10 @@ struct ksz_device { * the switch=E2=80=99s internal PHYs, bypassing the main SPI interface. */ struct mii_bus *parent_mdio_bus; + + /* KSZ87xx low-loss tuning state */ + u8 lpf_bw; /* KSZ87XX_PHY_LPF_* */ + u8 eq_init; /* DSP EQ initial value */ }; =20 /* List of supported models */ --=20 2.54.0 From nobody Mon Jun 8 06:40:53 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD2335B646 for ; Mon, 1 Jun 2026 11:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314887; cv=none; b=HymqMgL7o5VfpUjEg2DjhAoe66K0ZzrZET5+r1fjxmPicu0r8wgURsiDRW7HytKTiSpEclCYuCzujnZazg0RRFKjpO7urOY6r52lgE8A3Akn8g6+BQrkz/ku7ZxeQiAn6rRuS1pktMK4+09jlNshIUz5yh9bMhCDDFoavSm6820= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314887; c=relaxed/simple; bh=/MJFSPlvs5mZWGhdecQ4fcijYscXLZSLokdxWNxoZuI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SWbk66GMU9kQwp5IZzodQXzxDMe9OdpKVw4rdlwXmb3NSJ981LqoFX5wrLoqnCh33N1Tx19mwATYywjg/OkS/FLA/0GxknJfMY0zREby9oHoaqRjsn107BYU/lyYDkc+Fjl4YAMD0llI+nP81jWGQdDlGQ/Cak6xDBxKyL520MM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bAd8ziZp; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bAd8ziZp" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4904c1ce4c1so111865335e9.3 for ; Mon, 01 Jun 2026 04:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780314883; x=1780919683; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=trrNXQGXY7+MtELdar3MOROhYjZWKsC5AzJ+xzOQrGI=; b=bAd8ziZpHepexlgs3YvuqLHGLg0nlcC0RspV+SrYJNr/31LVT/UCR60i/6A1Za0mOH iRv4AL4MVuG3E0bUGQXdrMySZQkYhCFe6wJRUyS+EOulEH9TYpFmMaLVbArHJNHDwtBz fQ5ted5UucfUJF9zVdq+pTPxhgY3JZiZPd527n42w5OpIRP/LZfIL/4QG789VgeW5feN 9+3rJNUe2rzcwQUIkr3RW0HWMcOgPfwezcjIxAO2wMeklZc+aikjNdreuHXfpGOZgauK F5BLhCE3Y8DaJNJiPSP1ua9UUXF1sVodQAabX9CmKoLIMAl5POPurnTJjS39ye+43WUB zQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780314883; x=1780919683; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=trrNXQGXY7+MtELdar3MOROhYjZWKsC5AzJ+xzOQrGI=; b=pn7VZNaY0J7AIpPvrRrL42Yks0fDo/1d1i2/27G75sXlNex54lvnsET/MEkVXfpA1K mjzF3S2Vj3MTfEDsUc4OHo0cloSl3RafBHC97XwLD578Jtg7z9p7qjLbTfZAnShmYWWH ud05zeLdyeivaZqxr/zEhmw2EvixXSCNRcsKmvEszKyCBAZGgWA/vfbJjh58RxfIM4QR /GZz6wPCzqXgY4qH67Td3KHUXKX8rdbeRk92EgZ+nf2Fu/p5NvR3sNB4Qo4AFQfRgqHZ 62jFXQkVzCTb7q4o5Bx1saygkISG5GqE7ftoPO0JtFkmQXJlfZfeHtGY130y6HZLiDb+ lUvw== X-Forwarded-Encrypted: i=1; AFNElJ8xo+J1dSDei131Vu0wb7seIzji1wVcBeKsiz7m9Y99FCWmZq3nkcYhbSQZjTC9w7oT53G69vj2GEp9knE=@vger.kernel.org X-Gm-Message-State: AOJu0YwrJGueizq6CAd600Vzx1g9U/kJVnPr2KqB+aAX62wL8eln1JIG kL4A6+lHi7XKqVrpTaORHaYswkM2V/11UttJHZWnm/6pV08BSYXcHUMS X-Gm-Gg: Acq92OF6mhmLj8FYcbjjpehsSwktgJrMDmmYKeGz7W5OoRM1A0/vQmMevMPZ6taZ4ZS vnRSqvmi6qK/YwPciHgYLaoXutt7GIoOwjravBVAloJT6R1NgHiNXkxSknxPiIrRSk2+DNO7cMs rXtJSCCUaPDIk/nHVDCSR298czxJrchqRtg7XXWr8vspiiqtbCLF1v2KB6cOtxV5qhDEM1ukUyk sYuZMqdf5MoaEmc2AW78rvXcoTVq+0jWOFbJQmiT2r2aByLO144vQ/SOfFnzCfbgBshxLhC8fUy OmFQ+NwKDTLONAeh4V+X9m583IXCGHacfYlPPpn7NoaaacHxWliuHnGEBlZkClAPvVvH47rCM6u n6dFwLzSaOsZRFnC4TacG0WbqjCZYDQiQaogQ3a271RlGxFNoOboiWyB38G6vad/NWi/fSoGaH/ ElInENiwdpvYi7kpZHkJ8wHFsVI1dXm3fL7e+6MnKjP9M0Foxw/TVJy3AL9engO4P7KyuN+ZxKW hQw7u4FajE3/8goiBvk X-Received: by 2002:a7b:c854:0:b0:490:9699:4428 with SMTP id 5b1f17b1804b1-490a2964057mr139027225e9.26.1780314882815; Mon, 01 Jun 2026 04:54:42 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c121d63sm74376765e9.29.2026.06.01.04.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:54:41 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 13:54:13 +0200 Subject: [PATCH net-next v8 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v8-2-cfa102cf62c0@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson , Marek Vasut X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780314877; l=2628; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=/MJFSPlvs5mZWGhdecQ4fcijYscXLZSLokdxWNxoZuI=; b=JC/m7aYSN+Sm1pL5b5qBroXrn2nvj+teX04iGXNoCFfOFa3XXDmvBS0CbP2cdkNof8k97AlCz /TEYDRUt/ZeDhWY4a2xsHlpRSOl9EEJr0TyLXCF1mkDicLLJB0gsQJn X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Introduce vendor-specific PHY tunable identifiers to control the KSZ87xx low-loss cable erratum handling through the ethtool PHY tunable interface. The following tunables are added: - a boolean "short-cable" tunable, applying a documented and conservative preset intended for short or low-loss Ethernet cables; - an integer LPF bandwidth tunable, allowing advanced adjustment of the receiver low-pass filter bandwidth; - an integer DSP EQ initial value tunable, allowing advanced tuning of the PHY equalizer initialization. The actual behavior is implemented by the corresponding PHY and switch drivers. Reviewed-by: Marek Vasut Signed-off-by: Fidelio Lawson Reviewed-by: Nicolai Buchwitz --- include/uapi/linux/ethtool.h | 3 +++ net/ethtool/common.c | 3 +++ net/ethtool/ioctl.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 1cdfb8341df2..a2091d4e00f3 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -291,6 +291,9 @@ enum phy_tunable_id { ETHTOOL_PHY_DOWNSHIFT, ETHTOOL_PHY_FAST_LINK_DOWN, ETHTOOL_PHY_EDPD, + ETHTOOL_PHY_SHORT_CABLE_PRESET, + ETHTOOL_PHY_LPF_BW, + ETHTOOL_PHY_DSP_EQ_INIT_VALUE, /* * Add your fresh new phy tunable attribute above and remember to update * phy_tunable_strings[] in net/ethtool/common.c diff --git a/net/ethtool/common.c b/net/ethtool/common.c index 84ec88dee05c..a24d3a8a9ec1 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -101,6 +101,9 @@ phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GS= TRING_LEN] =3D { [ETHTOOL_PHY_DOWNSHIFT] =3D "phy-downshift", [ETHTOOL_PHY_FAST_LINK_DOWN] =3D "phy-fast-link-down", [ETHTOOL_PHY_EDPD] =3D "phy-energy-detect-power-down", + [ETHTOOL_PHY_SHORT_CABLE_PRESET] =3D "phy-short-cable-preset", + [ETHTOOL_PHY_LPF_BW] =3D "phy-lpf-bandwidth", + [ETHTOOL_PHY_DSP_EQ_INIT_VALUE] =3D "phy-dsp-eq-init-value", }; =20 #define __LINK_MODE_NAME(speed, type, duplex) \ diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index bd97f9b9bf18..fc2542422824 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -3114,6 +3114,9 @@ static int ethtool_phy_tunable_valid(const struct eth= tool_tunable *tuna) switch (tuna->id) { case ETHTOOL_PHY_DOWNSHIFT: case ETHTOOL_PHY_FAST_LINK_DOWN: + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + case ETHTOOL_PHY_LPF_BW: + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: if (tuna->len !=3D sizeof(u8) || tuna->type_id !=3D ETHTOOL_TUNABLE_U8) return -EINVAL; --=20 2.54.0 From nobody Mon Jun 8 06:40:53 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0180F374E42 for ; Mon, 1 Jun 2026 11:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314889; cv=none; b=OLyA/fEE6zhPRH4wLbNcebJ8ueICqGNVaUJp5vXQTA1bb3okJpeu7RS7/Ri9a4Xye6eNab5w8Vg/2y5X5zX7gMJbokvXWPtj+WRwaLAfpF+usYTP7oXCcpljCLeMhb6heXA/n/kxlVkiArNCINDXZa7rUopKYYC1ZYc9YdMBxPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314889; c=relaxed/simple; bh=Tu4FNa6kgf7cLgHKjrxiYsyzSpQdRdNBBC/3eIfUIJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kH9p7SRnXvsZVEew3ksk+1e3FDuwLQM67O2E/YNShBbmqE3TArlTC9KY8S5Rs4AzSD6rb3tJ5agAGz6YKShWzQaf3IzFkAGyYY3MKY99RJhj2P/HgWZ5M6et1MH8sfH1brMB1knln+wYF4w3vkzAlaSVtV1VR6ZxKmvpvpkvTBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MbcK9ryq; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MbcK9ryq" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49050ff7cbdso91012485e9.2 for ; Mon, 01 Jun 2026 04:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780314884; x=1780919684; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wS3u9JAWCCtJAD5b759FtzMVcsYv3WpkvZULsXjkNRQ=; b=MbcK9ryqn4ACCXjiTuTojRjNQRLTTPwtoQuRMyBkfEYPOAJIV35nptHQxioFh/UwLc M3Tn33UWLRW4Fz1Ko94KO8ozRBub0HaoXVR3/+yR5qcEzj9HYU1D/Ku6n5rE7AspD36T o6drHqWLcGJFcqUAO4KDCUt7h8AMMCprmvjptWqDZ6uWnbbEz6HUei8L47/RQPu59NjJ fUJBlvopeZxx3cmAM1yKzKiSmbAfHxxXhJgkGiFbfsjWs/zEDblEqSxfjnsUHfuWf/K4 Wdm2jxdG0f055W2R9rN0KfW2RGeQVuDphAKB1hyAG0+OeWd+dSS9GC4xRzRlkTNjB5FR kiRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780314884; x=1780919684; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wS3u9JAWCCtJAD5b759FtzMVcsYv3WpkvZULsXjkNRQ=; b=DXIdIUZrNNO3VoBeM8eOs13Pk1FNm52ty1R8lYhZAIc8TAFIeuWchw0pgrD6JBiePH E7LHAlHQx208X4j0aS/fQKu5r73Pir/6+87YB4/EW/jIx2HQt0joZtvdBmC4AwlptsmV 2631tbzhd2q5gS5ChHkBTiEC8Dv0PflywmgwxHEhOMqQKfaoY2d0QaOudWKDNBNLwtpQ yrizDrouypeQC3l7F5TVvXGoATYAKbTA31RR4Te1gwo0uH6jgvpT3CfYXtnI73xMd0Y1 DhP0f1cMJhAjNVflUt6uCIl5egujfT8fDgwkKLQNlSJGHIJ5U1/EHCVZvrx6QcM25sv9 MLYw== X-Forwarded-Encrypted: i=1; AFNElJ/40aQV9gacY2uqKdzLilbnd2SFD6HlQPHJvcvqHeOKHoez3C68Xt4SwhdFJ47mpyIO6ECUACUgoI/4SlI=@vger.kernel.org X-Gm-Message-State: AOJu0YzBBsfPQp7+aCcv4YJZbfn3zZV8BuWYVHoAUG9ioS6fZ7t8jljR 1VHOalnFueixy1UClQ89AqTOwPZke5ap2JKm+NcnYYxlTIK1s0B2AGxFaPOYDJHX X-Gm-Gg: Acq92OEtqj4pg2/nQZxtc8YuFZt72L29P7eYTT7h0K9zXtnifXDRev1bNjiSo3vE1Q0 AjJoaZijt0Z/vWtFnGqnYNVQBvOUZCCTiQPlwXwbb7tzJVVkoJDjyO3k6NN5YlDvJf+/y4ECCTt heO3TJZ8oW5c2WnfimDKSPM6rYlvQ7PTCV/AJkK25dHBB+3YuWy6WVC5xGZ2xovvYIjsIMtYy8Z X8JAWspA1j4Ca4IgM+D0lFvybUCMyiXw/GAYweN6yUP4OwtFhHWIwIzib/jjyK3jYwKQURkeE3w L6L/uX6P+VWCcMQqFHuq0RM/GRxjfkdOAh7FJ8WsajrbBlOq6enjzBMrJXQTutQPkFULfJuBwaE RrFS4H35Tlw7V8SiBSHgFxl55C9nEIULow/qbCfcvJNkxC38qre1pquFdl0ykUUfUk1aKltxgRI RbJxM6NiuB7ZI/fB1LkHYNYNC34Tn86EXcdCW1axyTXqIMhX+4p8lEdHtt8GrXxoLlraF8zhdxs I/TMwhVpCEp3iy5EnPw X-Received: by 2002:a05:600d:644e:20b0:48a:53ea:140b with SMTP id 5b1f17b1804b1-490a296b260mr148872025e9.28.1780314884313; Mon, 01 Jun 2026 04:54:44 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c121d63sm74376765e9.29.2026.06.01.04.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:54:43 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 13:54:14 +0200 Subject: [PATCH net-next v8 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v8-3-cfa102cf62c0@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v8-0-cfa102cf62c0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson , Marek Vasut X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780314877; l=3427; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=Tu4FNa6kgf7cLgHKjrxiYsyzSpQdRdNBBC/3eIfUIJs=; b=5YgGHs8nNpXaLP4gMbeFIv/1q5ep4+istH4HSSrnQH+7TR+wJeQ6LOb+Nls/Tpf59hB+Wa8uQ RtY9JggFvMIBTDjmr8wz4qPt+J2If6g58tm2TbQhMxdS+zbg7SGiQ8k X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Add support for the KSZ87xx low-loss cable PHY tunables in the Micrel PHY driver by implementing get_tunable and set_tunable callbacks. These callbacks expose vendor-specific PHY tunables used to control the KSZ87xx embedded PHY receiver behavior when operating with short or low-loss Ethernet cables. The tunables provide: - a boolean short-cable preset applying known good settings; - an integer LPF bandwidth control; - an integer DSP EQ initial value control. The Micrel PHY driver forwards these tunables via standard phy_read() / phy_write() operations, which are virtualized by the KSZ8 DSA driver and translated into the appropriate indirect switch register accesses. Reviewed-by: Marek Vasut Signed-off-by: Fidelio Lawson Reviewed-by: Nicolai Buchwitz --- drivers/net/phy/micrel.c | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index e211a523c258..bb8f3054e257 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -287,6 +287,12 @@ /* PHY Control 2 / PHY Control (if no PHY Control 1) */ #define MII_KSZPHY_CTRL_2 0x1f #define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2 + +/* Vendor-specific Clause 22 register, virtualized by KSZ87xx embedded PHY= s DSA driver */ +#define MII_KSZ87XX_SHORT_CABLE 0x1a +#define MII_KSZ87XX_LPF_BW 0x1b +#define MII_KSZ87XX_EQ_INIT 0x1c + /* bitmap of PHY register to set interrupt mode */ #define KSZ8081_CTRL2_HP_MDIX BIT(15) #define KSZ8081_CTRL2_MDI_MDI_X_SELECT BIT(14) @@ -940,6 +946,52 @@ static int ksz8795_match_phy_device(struct phy_device = *phydev, return ksz8051_ksz8795_match_phy_device(phydev, false); } =20 +static int ksz8795_get_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, void *data) +{ + int ret; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + ret =3D phy_read(phydev, MII_KSZ87XX_SHORT_CABLE); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_LPF_BW: + ret =3D phy_read(phydev, MII_KSZ87XX_LPF_BW); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + ret =3D phy_read(phydev, MII_KSZ87XX_EQ_INIT); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int ksz8795_set_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, const void *data) +{ + u8 val =3D *(const u8 *)data; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + return phy_write(phydev, MII_KSZ87XX_SHORT_CABLE, val); + case ETHTOOL_PHY_LPF_BW: + return phy_write(phydev, MII_KSZ87XX_LPF_BW, val); + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + return phy_write(phydev, MII_KSZ87XX_EQ_INIT, val); + default: + return -EOPNOTSUPP; + } +} + static int ksz9021_load_values_from_of(struct phy_device *phydev, const struct device_node *of_node, u16 reg, @@ -6961,6 +7013,8 @@ static struct phy_driver ksphy_driver[] =3D { /* PHY_BASIC_FEATURES */ .config_init =3D kszphy_config_init, .match_phy_device =3D ksz8795_match_phy_device, + .get_tunable =3D ksz8795_get_tunable, + .set_tunable =3D ksz8795_set_tunable, .suspend =3D genphy_suspend, .resume =3D genphy_resume, }, { --=20 2.54.0