From nobody Mon Jun 8 05:26:07 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C0C2C0294 for ; Mon, 1 Jun 2026 16:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330446; cv=none; b=tzp6kICZEFhJ8MwZ4G7Cj8579f+tpnL4E/0lBmnn/njsrehc6wS3YyKZXUxlP4Srtzvlf4njgYBsIxXLBQpUc8eBsVkT56kJ8Vwnk20VbR+c+gyhXs1nnJ0F6YTkeq+g7HPyY0EGkARDDpBJ7xD7hb+dsGFU0o9It+UhDkteSKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330446; c=relaxed/simple; bh=sokoSsyWgTcHZSa0ZifzWSPZUKXC898Oh68D+flm33o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rWs960S2goNXZn56yjuv/9f5UE9jFDbmOMEkh6Fg1/5GpGptZxBz5kflnH0P9fHNKbqr1D2RtWGnI0EfFtX2H1msjrTP6KDo0V3s+oB4keLKrARhyNfef8UlwwZ59Iq8OHdI22K2qjU6sBDhWQB2MJcEtbwzo2aGAS1qNOFDvuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MNnmM6iM; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MNnmM6iM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780330443; bh=sokoSsyWgTcHZSa0ZifzWSPZUKXC898Oh68D+flm33o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MNnmM6iM84BXz/e4nyF14i+tXwAgEt2hMDyAlks6zFbKuGBM3Amvn+oKFW3+b1ueB qnh3duYa8i+7iRSP5ijgSJBo00qSMYf18G4oXZEMRNFc3hsPqrOyxfhw1lc9wKoeg8 qljgV9aNXGiMmMoiaB0co7fWG7SntMNPN0VJNGBirH4rCTR//aTqAamGAkrjh3vLOg ltS3WscDp4h+m/j/sld6SKJYuOb75adbgdq6jXKLH5u59Pjvfz7H4ytnuHDJzPzim8 9WL6w5uzLs3+xPYfTRUJ6lUoQ6QxVGcJwBDsr81HWniyC+VapUQHPFaRvcWz9PcUSy FROAbHDIW+Fog== Received: from localhost (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id AE09E17E05DE; Mon, 1 Jun 2026 18:14:03 +0200 (CEST) From: Cristian Ciocaltea Date: Mon, 01 Jun 2026 19:13:44 +0300 Subject: [PATCH v4 1/3] drm/bridge: synopsys: dw-dp: Support unregistering the AUX channel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-drm-rk-fixes-v4-1-c3f3f123e1da@collabora.com> References: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> In-Reply-To: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The DisplayPort AUX channel gets initialized and registered during dw_dp_bind(), but it is never unregistered, which may lead to resource leaks and/or use-after-free. Add the missing dw_dp_unbind() function to allow the users of the library to handle the required cleanup, i.e. unregister the AUX adapter. Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support = library") Reviewed-by: Andy Yan Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 6 ++++++ include/drm/bridge/dw_dp.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 21541be094c4..36ee6e027af5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2093,6 +2093,12 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct = drm_encoder *encoder, } EXPORT_SYMBOL_GPL(dw_dp_bind); =20 +void dw_dp_unbind(struct dw_dp *dp) +{ + drm_dp_aux_unregister(&dp->aux); +} +EXPORT_SYMBOL_GPL(dw_dp_unbind); + MODULE_AUTHOR("Andy Yan "); MODULE_DESCRIPTION("DW DP Core Library"); MODULE_LICENSE("GPL"); diff --git a/include/drm/bridge/dw_dp.h b/include/drm/bridge/dw_dp.h index 25363541e69d..22105c3e8e4d 100644 --- a/include/drm/bridge/dw_dp.h +++ b/include/drm/bridge/dw_dp.h @@ -24,4 +24,5 @@ struct dw_dp_plat_data { =20 struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder, const struct dw_dp_plat_data *plat_data); +void dw_dp_unbind(struct dw_dp *dp); #endif /* __DW_DP__ */ --=20 2.54.0 From nobody Mon Jun 8 05:26:07 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D8241FC7C5 for ; Mon, 1 Jun 2026 16:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330448; cv=none; b=RDGx7OBhxu5xPHX+HXwfHURE9YTfvA4XMsxrK6bUQCNy8yJgpYcK8AuLcdscB80zGfFEanL/k40KrjD8GM5UqFh7Ywnrq6q3MqP/ir6nRiduzGEyXfto9Ec9M6aCsk1JGYMFthku6gq8s3ZWtGjHQhsRc23lOb9pTe01LKlYujw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330448; c=relaxed/simple; bh=VlC/qSkXRHe1XHonNDu7WZ4SGBpZ/1wCRHaV181IEg0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hobMVUlTBQhI/t85VIAfZ3cEUavuFGh/rFEb78JwCCUZlxDpYSbkOrO85ZUZPFJJcg5B17XaLwSJjW2uVXM5BbXgGRC+OP74TEFdN3ZTA/LLeuIFHZ0+EwChNtYJjoV6G2unFSZ02qYkx9mg9qB5GmY0LeWHqqUoR5Yx9kMXKec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MN34eHFV; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MN34eHFV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780330444; bh=VlC/qSkXRHe1XHonNDu7WZ4SGBpZ/1wCRHaV181IEg0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MN34eHFVkCDT20BHVot1vjZ8uiNSZRY6VBXX5g6qZZ4+I3yyoNWUbCPhhGq33vBW+ ccG6TU8SI3vn5XyZDP/o9ZI0YOsyMY4rVoy9r4I6TeoCiEy0ZEm8jn1k9rpN5F1SES y5unEMQ08MWEQxIDg6CRllM+1BJGpTito1EHsqACHx7O0kxHXp9xoU7t00AmAtiyR0 HVqre3RqAUk7SURh/k/GYvWOU1cnLJmh8EerjOYYFxxkp9+zT9ltghyOnaBUG5WP3C UKV1iKgIPePC24cMSG3itCGCI5BOiMbl8tIdO5IH7bwy6QteQvq+yznZThx2DLAu1r 0I82/K+FoWq3g== Received: from localhost (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 69AAC17E093F; Mon, 1 Jun 2026 18:14:04 +0200 (CEST) From: Cristian Ciocaltea Date: Mon, 01 Jun 2026 19:13:45 +0300 Subject: [PATCH v4 2/3] drm/rockchip: dw_dp: Add missing newline in dev_err_probe() message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-drm-rk-fixes-v4-2-c3f3f123e1da@collabora.com> References: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> In-Reply-To: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 Add the missing trailing newline to dev_err_probe() call in dw_dp_rockchip_bind(). Fixes: d68ba7bac955 ("drm/rockchip: Add RK3588 DPTX output support") Fixes: 26cb3e26efa7 ("drm/rockchip: dw_dp: Simplify error handling") Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/ro= ckchip/dw_dp-rockchip.c index 32bc73a1d5e4..f137f699737c 100644 --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c @@ -109,7 +109,7 @@ static int dw_dp_rockchip_bind(struct device *dev, stru= ct device *master, void * connector =3D drm_bridge_connector_init(drm_dev, encoder); if (IS_ERR(connector)) return dev_err_probe(dev, PTR_ERR(connector), - "Failed to init bridge connector"); + "Failed to init bridge connector\n"); =20 return 0; } --=20 2.54.0 From nobody Mon Jun 8 05:26:07 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C237F2C11E8 for ; Mon, 1 Jun 2026 16:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330448; cv=none; b=C47sNtk8Lebuhzm3AzpKeFi0ZeDgwMgXuKQutyT+STZiZfqGions+jw8BVQDU/dBaa4Df+IhYamxOX+xSgZQOtbeHtcERpXITLIUp3HrKj6LuTzqjKYa5iAgaSoj6udrdIBz1m9pzE2vM1WvDru1pN5irYSK/nP7G4dO3m5LA5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330448; c=relaxed/simple; bh=oWaRZrCK6p6EhmYmIaUvimw67y77UHwLcU6Pm0N+SeM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MyaqHUaJhsepj5iM/draZbu9+hzkhs08F+Pg9zvUVBkkPFzlUNDf2u6grjqB0ZqtQL8dDNdsApJyOHLd2N0kLzhZB9UW+BpFYiGGE2gZDpqYtDT9l7QnfeJ0Iz2aqxc9kzID9q+4kCZnT9mHT6yTgGhoKpsckwB4Ddo8YnGAGag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=VdwC11Cu; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="VdwC11Cu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780330445; bh=oWaRZrCK6p6EhmYmIaUvimw67y77UHwLcU6Pm0N+SeM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VdwC11CumGLjmVexkqo9rjyudUduE8Hcdwz2Y/imx5cgfXqMyjVp6GqgyO2R3XZEk XdhXVL4wIheu797YPSxgNh4kxVuYlHMiWdH8+wLlRalHGv5lxbxcNe7jY8vAoCInoX RBUVxTmjo6UWp3TlT2XjQky0LaDAxaIqYROl0Y9OyAKWrriyEDwzvjRobD3eUkmo6C muMJP6Zrkt+ELYcqrTTryGKTKO4PLh6qfmBGZuSAA6migPhMZxbw4zxzE6rV6YaHf6 dUzX928vOVVAOJ1+QZyjLHK5MZDuAc0sB4mVlfdv+NqCVkaflSS9nYkc/JAuzZxWGX +4cvj3BwNPEjw== Received: from localhost (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2A35B17E09A3; Mon, 1 Jun 2026 18:14:05 +0200 (CEST) From: Cristian Ciocaltea Date: Mon, 01 Jun 2026 19:13:46 +0300 Subject: [PATCH v4 3/3] drm/rockchip: dw_dp: Release core resources Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-drm-rk-fixes-v4-3-c3f3f123e1da@collabora.com> References: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> In-Reply-To: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 Core resources such as the DisplayPort AUX channel get initialized and registered during dw_dp_bind(), but are never unregistered, which may lead to memory leaks and/or use-after-free: [ 224.661371] BUG: KASAN: slab-use-after-free in device_is_dependent+0xe0/= 0x2b0 [ 224.662015] Read of size 8 at addr ffff00011aee8550 by task modprobe/658 [ 224.662612] [ 224.662752] CPU: 7 UID: 0 PID: 658 Comm: modprobe Not tainted 7.0.0-rc2-= next-20260305 #14 PREEMPT [ 224.662759] Hardware name: Radxa ROCK 5B (DT) [ 224.662762] Call trace: [ 224.662764] show_stack+0x20/0x38 (C) [ 224.662772] dump_stack_lvl+0x6c/0x98 [ 224.662777] print_report+0x160/0x4b8 [ 224.662783] kasan_report+0xb4/0xe0 [ 224.662790] __asan_report_load8_noabort+0x20/0x30 [ 224.662796] device_is_dependent+0xe0/0x2b0 [ 224.662802] device_is_dependent+0x108/0x2b0 [ 224.662808] device_link_add+0x1f8/0x10b0 [ 224.662813] devm_of_phy_get_by_index+0x120/0x200 [ 224.662819] dw_dp_bind+0x34c/0xb10 [dw_dp] [ 224.662830] dw_dp_rockchip_bind+0x194/0x250 [rockchipdrm] [ 224.662864] component_bind_all+0x3a8/0x720 [ 224.662869] rockchip_drm_bind+0x120/0x390 [rockchipdrm] [ 224.662899] try_to_bring_up_aggregate_device+0x76c/0x838 [ 224.662904] component_master_add_with_match+0x1f4/0x230 [ 224.662909] rockchip_drm_platform_probe+0x420/0x538 [rockchipdrm] [ 224.662939] platform_probe+0xe8/0x168 [ 224.662945] really_probe+0x340/0x828 [ 224.662950] __driver_probe_device+0x2e0/0x350 [ 224.662954] driver_probe_device+0x80/0x140 [ 224.662959] __driver_attach+0x398/0x460 [ 224.662964] bus_for_each_dev+0xe0/0x198 [ 224.662968] driver_attach+0x50/0x68 [ 224.662972] bus_add_driver+0x2a0/0x4c0 [ 224.662977] driver_register+0x294/0x360 [ 224.662982] __platform_driver_register+0x7c/0x98 [ 224.662987] rockchip_drm_init+0xc4/0xff8 [rockchipdrm] Since a previous commit exported dw_dp_unbind() function in DW DP core library to take care of the necessary cleanup, use this in the component's unbind() callback, as well as in its bind() error path. Fixes: d68ba7bac955 ("drm/rockchip: Add RK3588 DPTX output support") Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/ro= ckchip/dw_dp-rockchip.c index f137f699737c..0de822360c8d 100644 --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c @@ -107,15 +107,26 @@ static int dw_dp_rockchip_bind(struct device *dev, st= ruct device *master, void * return PTR_ERR(dp->base); =20 connector =3D drm_bridge_connector_init(drm_dev, encoder); - if (IS_ERR(connector)) + if (IS_ERR(connector)) { + dw_dp_unbind(dp->base); return dev_err_probe(dev, PTR_ERR(connector), "Failed to init bridge connector\n"); + } =20 return 0; } =20 +static void dw_dp_rockchip_unbind(struct device *dev, struct device *maste= r, + void *data) +{ + struct rockchip_dw_dp *dp =3D dev_get_drvdata(dev); + + dw_dp_unbind(dp->base); +} + static const struct component_ops dw_dp_rockchip_component_ops =3D { .bind =3D dw_dp_rockchip_bind, + .unbind =3D dw_dp_rockchip_unbind, }; =20 static int dw_dp_probe(struct platform_device *pdev) --=20 2.54.0