From nobody Mon Jun 8 08:28:38 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8E8E1A5BAE for ; Sun, 31 May 2026 02:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780194159; cv=none; b=ajPxAHD9lvrOhEM1AQXGvAY7vAPjTIMGMLBwGGkS5X0y7+iA+rgbNlb18x73maSaW02AxSiYs6B/h9fF9ECcc2k609JwMbm2MPnvJG5CMbOQEk16XGbeMgpKmFIgUsi2vEO0p/z59RdfOxXsMkWpMceozM6eQ4bSAZ7TvAEBgdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780194159; c=relaxed/simple; bh=cW27X/qs8nPmYocEmOprbNiNOpAaiqTRwBkoXCq9sg8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VE7pAHi++HTg3HlQdw002i7zHCcUUJ2KzNRd5nGYOhxID5ZivIINoamrOgw4t7MWje6ntZrHyRL/uikRdgDk8hFXBEyzyPh2z+FreAzCRi/1neI0Y0rxCGXUZsIEjVnafXoWU2dsZB4HAsAN0gic14O3mh9dF1pbBLkPlu1NHbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QeMo4PFK; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QeMo4PFK" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf1cda2b17so15639565ad.1 for ; Sat, 30 May 2026 19:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780194158; x=1780798958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7zdMO1aum1o0cEFtC+dVHwvB8dCMTjDC9zp/l6WfwTQ=; b=QeMo4PFKR4BC/IiHYR5jAfiZ2p9de4ZKyp5qvdAFyx5VJ0GL5eq3Nodk4QKaNhggoI H7gV2v1zDzHdWAwHbma69l+fs2kl6pMkCV3rAq10NzsU1KCkyHN0P11i/S5eoQ8g/Of9 I9XEVC2r+bTjREoAvr3OGZmTkb2sIIgyixOIBM7v/BVyPgKchFS+mjs+ZWjHFghWByY5 RveZmI3YSM6ESoN5bziiih6oa/Fp6wWPP+QA6WEqeANh3OTPgYWVHw+1icfu/fpjX3PY TLiGcshk5oQBrj6bPXNJURRPPubqUc8OKNziFWoqhHbDo7e4oyznGq/ibhCByTXQOPR5 hw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780194158; x=1780798958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7zdMO1aum1o0cEFtC+dVHwvB8dCMTjDC9zp/l6WfwTQ=; b=KR4Ck+OXXhta8H3cYococOVfMol5rjjCwrnAEyrfqAHPlfPryitHw9RB8X05VurjRj j859+PRJz7oJsmlTWmYHi0psjaC08CcMPntM8mk+LdJbXeCtbsDbd893YvXNomtdUDUO DHEd8g1SEllu5UdpzI01m9AR+KZCK3x+uwwYo32QUDPjh+GaOcZSms9KFoL997WIzyab axjrOjGn83tyiiJOcB4GCxEkXksxmKVdXdCG0yzdlZTuvcCsfyhcjgaFix1pGuLf+Nho iGO6Sv8+EXioCM2eHqI/okVamQvPWWBBmA80MPupN27U8x13VW/MWId8pcHD/tyfhL+F dmQg== X-Forwarded-Encrypted: i=1; AFNElJ917bebS13HthX4XzFXvS865sCVMg9NmAwDNv0mifAwd38cQR5K3G3bWovp4R7SrlcpATa7bg274c3VYQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YwIQP7wx3mePyfCKpx9lAHMt+ees0+O4PfVitaJfq7g6E0+eFq8 +b0RHneWsnh5k/JXijYdOhSAOrw3BFYp5zbVdY4CPh6uuQ5kySMl5GpS X-Gm-Gg: Acq92OH6lwALFfNbLo1/I7j9PNpRzkWxWVrtiucIITjdw+7VT74azCnrreRCWLmxaDV 59VX2DsDe2Q62sRgH2PA6fsd3XgGEu4lN+7E7eLRuVgk0b6NKWB7jADn3qYGZ5fuyfvglmlrU3d dp8EHQ+CiA74DLWfdg8BhvdInjL8CZyFVRmmelFIm4kXWyYzUzENQ3XTi4rrmsZmqGyqQ2rK4ai GmTgZDp5jTDTQPzkDYjxEhum8oTtSQ3eN30wNfH0HHnV58Y0WHi+7hsDpCQahUC2yGxT6kp8vse w8pj2jDU5PCjvuQOlc9DtJ/q6ok1Oo/GEqHwlVTs2yPSCzWmMwU8O2A+S85pMIa+bApn0zwNzO9 iX9W944EVehvT3mRvcM4WjwfL0TIMC7a2ZKyjUNssG90aj40n6uDWDXyXH9C3Laf2GDZrbbx7zf wDNmz6dXlmN9RK0gz6Cr6qO83c/e5ashOl9KQNcpEKjVnW04y2sjiphc7SlKMzYPcmMKRfRrneQ HeNgRcA4sbvtbC3wPQydrrhmXfFcR7pPMtF6S5UgPmEXg== X-Received: by 2002:a17:903:38c5:b0:2c0:ccdf:5e61 with SMTP id d9443c01a7336-2c0ccdf603emr2689255ad.6.1780194157851; Sat, 30 May 2026 19:22:37 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd7bfsm60576395ad.19.2026.05.30.19.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 19:22:37 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rosen Penev , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: ibm: emac: Fix NULL pointer dereference in emac_probe Date: Sat, 30 May 2026 19:22:19 -0700 Message-ID: <20260531022219.607001-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move devm_request_irq() after devm_platform_ioremap_resource() so that dev->emacp is mapped before the interrupt handler can fire. An early interrupt hitting emac_irq() would dereference the NULL dev->emacp and crash. Fixes: dcc34ef7c834 ("net: ibm: emac: manage emac_irq with devm") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev --- drivers/net/ethernet/ibm/emac/core.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ib= m/emac/core.c index b060795dace7..3e8ea0b05619 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -3044,6 +3044,13 @@ static int emac_probe(struct platform_device *ofdev) if (err) goto err_gone; + dev->emacp =3D devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(dev->emacp)) { + dev_err(&ofdev->dev, "can't map device registers"); + err =3D PTR_ERR(dev->emacp); + goto err_gone; + } + /* Setup error IRQ handler */ dev->emac_irq =3D platform_get_irq(ofdev, 0); err =3D devm_request_irq(&ofdev->dev, dev->emac_irq, emac_irq, 0, "EMAC", @@ -3056,13 +3063,6 @@ static int emac_probe(struct platform_device *ofdev) ndev->irq =3D dev->emac_irq; - dev->emacp =3D devm_platform_ioremap_resource(ofdev, 0); - if (IS_ERR(dev->emacp)) { - dev_err(&ofdev->dev, "can't map device registers"); - err =3D PTR_ERR(dev->emacp); - goto err_gone; - } - /* Wait for dependent devices */ err =3D emac_wait_deps(dev); if (err) -- 2.54.0