From nobody Mon Jun 8 08:37:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88538371893; Sat, 30 May 2026 22:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780181829; cv=none; b=rKOpfa1K0yWQL2/JUjcHm+Sx3pLMEtb28m/Ux8vphGhb54jdZLHQzME2DVQspwQnVm4yK8cLeTPzqh3DJjhMHROHWb+XrLuKSUj5NSzeBIx1mO8DZFAsDcsFuzs03sESeRik25dzNxoOyzkEgU6xXQ2rEgLs8caLd7mAshqof+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780181829; c=relaxed/simple; bh=44NA6rUhVair067G7uXMUjokLii9afZLzuTWi8578y8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EymR+9C5+GsDZKVqs81fh7wWS6+sslCcymMf/nA9rNfdJH1GVXGnAKIZr7ROwrEZEjbA1BfpfsTwFgrF8Q6jAnKNWz2NegWn12UNx+wAinkeD0jhpLb4zILfZ8mh7xaJf1zz3V7ld8oN7mzw0pwa+gPnjJ+ZQElruKAOmz2rsLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j8ivEsVD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j8ivEsVD" Received: by smtp.kernel.org (Postfix) with ESMTPS id 22373C2BCC6; Sat, 30 May 2026 22:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1780181829; bh=44NA6rUhVair067G7uXMUjokLii9afZLzuTWi8578y8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=j8ivEsVDYAK4+6V1TB0kivqElMbcACCCYM9u+Qhum+PA91gWjdr6nBHDr2PTOXeUF yUPFDFjNJYDmofARWZbws5iDS9LHtcSuIXCNPbbucn8qYIo2JJ+hS4o5tshXrHeivq Rm6/0or1WjCUsexN1e0aNgkYQNr4pT1I+SEFb89PCo2Cp1BkcHVQb5lM320YvdqNxz LfYo/wjYqbTxzbCTQlRrfUKTOWbnJXRWraRpc9IxtuvCHgSv/zCdoDeSggDg2d9X/A Ju+0eUNfmpXWnpc+0XJhUoCqbFnjiii6gaxuWyaCM9VMEBGYoOqN/4sv0jgRASPU3p JYG4ByDCFEOZQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C9B6CD6E52; Sat, 30 May 2026 22:57:09 +0000 (UTC) From: Markus Probst via B4 Relay Date: Sun, 31 May 2026 00:57:03 +0200 Subject: [PATCH v14 1/2] dt-bindings: embedded-controller: Add synology microp devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-synology_microp_initial-v14-1-1377d425b24b@posteo.de> References: <20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de> In-Reply-To: <20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Markus Probst , Krzysztof Kozlowski X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4079; i=markus.probst@posteo.de; h=from:subject:message-id; bh=alrwaULuLrijlaEQo59qC6IZr7fepf0GBhjIrFXTxGk=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqG2tDpH2N0DmGK97Cj9v3F+bHBvgysbSrf6sac aMtq2CieX+JAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCahtrQxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9I/kQ//Q7V+yRjNY/qA5dFnDKcc+BzTcG03ABm iYlxpI+HOguMmly4OhT1x9a7gocRS6egbJWeeaayS9T0V+sG2k0FEz38+TaCAJBV4nbhMXnuVbD UjAEhEIzJNaCUuXmnGkaqfu0EOhs1ZsT8In0NP37M3zUB26icJw5d2TZEKKmBScGB2YwI2egET+ 22YAXY9cNOLfjzmub1IChH+zkYCzU3bbf1t1BBessJucp0AHw8EDzh7JmgaDD01oE23KgqR0+RS wFSjmAjXHtWpez1FF1Bvzyl4k9k8hJ/n+LtFM/yWlMgZFaJ6H4Z4yLd1jK5+KXdaZLZ+PL5Wdp+ saY1UY5MFf2DWz8EUOZmDz4kqv5MD++1RPn8Zg2GwtXHAIEdzElKZSLnx3fwgTWu2jthIzHMSUs /yXm0aau2OKkcCAYPN30V4hGnwxX//dafXhghmQ+u5F9FGk8E4Q1gQqur7FvCoyh+DVd00Mppep ZXpT8l33eXpUMGZ/pjCOXM4cGNNh3cNnB/qxqMgjU7CTJkarvnSecxqA7guYDQnvqT1jkZvI1mF LPxMjmkLCLAaiBNEC8IyxfoQMz+tiEs+GL+SBJLEMQMQlqNcZ1ckG4Y4ECasXYsX21djyyiuHyv 5xC+XwTsmY/IyuZVcOD/3VvOnIP8JwbMukOpOArgIiRYscFOQytg= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 X-Endpoint-Received: by B4 Relay for markus.probst@posteo.de/default with auth_id=680 X-Original-From: Markus Probst Reply-To: markus.probst@posteo.de From: Markus Probst Add the Synology Microp devicetree bindings. Those devices are microcontrollers found on Synology NAS devices. They are connected to a serial port on the host device. Those devices are used to control certain LEDs, fan speeds, a beeper, to handle buttons, fan failures and to properly shutdown and reboot the device. The device has a different feature set depending on the Synology NAS model, like having different number of fans, buttons and leds. Depending on the architecture of the model, they also need a different system shutdown behaviour. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Markus Probst --- .../synology,ds918p-microp.yaml | 100 +++++++++++++++++= ++++ 1 file changed, 100 insertions(+) diff --git a/Documentation/devicetree/bindings/embedded-controller/synology= ,ds918p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller= /synology,ds918p-microp.yaml new file mode 100644 index 000000000000..eb1c9d3fac07 --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p= -microp.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/synology,ds918p-mic= rop.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synology NAS on-board Microcontroller + +maintainers: + - Markus Probst + +description: | + Synology Microp is a microcontroller found in Synology NAS devices. + It is connected to a serial port on the host device. + + It is necessary to properly shutdown and reboot the NAS device and + provides additional functionality such as led control, fan speed control, + a beeper and buttons on the NAS device. + +properties: + compatible: + oneOf: + - items: + - enum: + - synology,ds1221rpp-microp + - synology,rs822p-microp + - synology,rs422p-microp + - const: synology,rs1221p-microp + + - items: + - const: synology,ds1825p-microp + - const: synology,ds1823xsp-microp + + - items: + - enum: + - synology,ds725p-microp + - synology,ds225p-microp + - synology,ds723p-microp + - synology,ds710p-microp + - const: synology,ds214play-microp + + - items: + - enum: + - synology,ds425p-microp + - synology,ds1525p-microp + - synology,ds925p-microp + - synology,ds923p-microp + - synology,ds1522p-microp + - synology,ds1010p-microp + - synology,ds411p-microp + - const: synology,ds918p-microp + + - items: + - enum: + - synology,ds124-microp + - synology,ds223j-microp + - synology,ds223-microp + - const: synology,ds118-microp + + - enum: + - synology,ds118-microp + - synology,ds1823xsp-microp + - synology,rs1221p-microp + - synology,ds918p-microp + - synology,ds214play-microp + + fan-failure-gpios: + description: GPIOs needed to determine which fans stopped working on a= fan failure event. + minItems: 2 + maxItems: 3 + +required: + - compatible + +allOf: + - if: + properties: + compatible: + contains: + enum: + - synology,ds918p-microp + - synology,rs422p-microp + then: + required: + - fan-failure-gpios + else: + properties: + fan-failure-gpios: false + +additionalProperties: false + +examples: + - | + #include + + embedded-controller { + compatible =3D "synology,ds923p-microp", "synology,ds918p-microp"; + + fan-failure-gpios =3D <&gpio 68 GPIO_ACTIVE_HIGH>, <&gpio 69 GPIO_AC= TIVE_HIGH>; + }; --=20 2.53.0 From nobody Mon Jun 8 08:37:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79AAF280A56; Sat, 30 May 2026 22:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780181829; cv=none; b=skLWeCrwO4+j+VfS8lRY72roI2W57UpLDnYjxOuAhCtb3zjQ1envTHRbzNeem3Mjai69/q86O8Z4a2nVQb9KMCmYCa6QthgJ5ddrziAfJjyrISTVAKdg/TYooXGGvVtreZ9ZUqTaVBH67lbA2Al7C2qtylqFxsMmv6s0LVF783Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780181829; c=relaxed/simple; bh=oBh8rSLedMnT1aRFTUkdbrdk3gJSdkwKkFBkb0YUq2A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oO1/NlMi800dwRkyiEV++NpfqVVm2wPf6JiqUeaKEBgVYjuZYCTh00fdlSvnQuGamky40flD9+Iodfbh2om0fKJUGF0cKW+C8Do5Gqxc3g0osZ9jTeRkLO589Rtb5SSFzpIadOOHpoRjRVUnSHun+af1Hjfhy71p7frR1KXNjj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZhcMefqU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZhcMefqU" Received: by smtp.kernel.org (Postfix) with ESMTPS id 30258C2BCC9; Sat, 30 May 2026 22:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1780181829; bh=oBh8rSLedMnT1aRFTUkdbrdk3gJSdkwKkFBkb0YUq2A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ZhcMefqUo2VKFE3dW87eyGDLPG0wCX4+eYzGwUA22HI8D5JUdeUHINGdG9zZVjg4j DdWT8kE4xN8ebMNcMEfa0ldO0fVkfpGOVReQ+4k7FEbOIjDUoS+wOjaxMXyDXT0qVB 3dJu4PDLjJUrm+nlqOYUcE1ENVZ5kpKJHTGxPCZJWL+1neiie0XGUSPmESbhU/0mff yr3BFnlrvh/HDrYO1qebhAEy9Fn5id9WHWX1P6qsgs746diJyT9EbXkgnHbm+yd/8S roFk2UWVJKYBqFA9N4ruElV9ZfKgRbSBzcWgJkg6Wfs6tN/R8htRNfmPUvfaQX6mLU IuyD2GHDeYYcg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D1A9CD4F54; Sat, 30 May 2026 22:57:09 +0000 (UTC) From: Markus Probst via B4 Relay Date: Sun, 31 May 2026 00:57:04 +0200 Subject: [PATCH v14 2/2] platform: Add initial synology microp driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-synology_microp_initial-v14-2-1377d425b24b@posteo.de> References: <20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de> In-Reply-To: <20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de> To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Markus Probst X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=19547; i=markus.probst@posteo.de; h=from:subject:message-id; bh=amH62Z6HJa3CGHenmZNIudg6jVE4PkD+ZlY3QBfjlxQ=; b=kA0DAAgBNHYf+OetQ9IByyZiAGoba0PIINz9MfaYPG+2yQBDp+ZU3gTcCP9JN0Y0QSolnPGkL okCTwQAAQgAORYhBIJ0GMT0rFjncjDEczR2H/jnrUPSBQJqG2tDGxSAAAAAAAQADm1hbnUyLDIu NSsxLjEyLDIsMgAKCRA0dh/4561D0jxVD/9UT0WzHj5rrUT73vmUKq3e2kHaM2IQo1iQlCCTHhO NWzSqkFTpL6F/QX2gTA8cU9ujIED5UhdO1xCPqrsTBN/7bAgvqeHhfWhDD4Hvmxj1HiZbJPuNeI TVoh5berrXR94LspPO9s2eVYmzLKILpfgusmgzOfvQIo8hmoIPWLVE9oz5+aYusUxugkOunGoHr OV3h76QgTNG+ksj36drUdpROAplxv/yU96v8Biq6J9RL9ePugwGxyIfdoe8rKf8kXdeTj/xqq5z VE4loq/ZpdnYq1c7r6tg9/wTlG5+8uuk9m+rCaT8zasKWGI49MFr4PxAie6C5GezgYRAioDMkdg piUSkjahr0AqEuhCc262mstFF/MeYXSm8U71gL99/EYQXRmO2U/AGtlX2fg6K87ZZkO5tgy5bej eQLvKu34m2czqApADnjkTspPaoLgjxsZCPfEeHCrTEX+k3nRAS/K4xWEy6bbXpsj8BdpSGq4A66 PMsR/uTmZfdMfhrAn5YCH2soB3TQ1z++vhFRDfcgKHH3fixMvGM3AATcK3HGjv5PcsyG8OmesRe WMKsLRiyc1jH0lC8JCIfqhPyaa7HQXoQLAKN/5OUObzzpLZPjz2TC9XUTGu4U1qxHGS10FKYww0 xZot1MUzDoOBzMUxFK/n7YifUDRF/tLub6oI5u/Y9lA== X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 X-Endpoint-Received: by B4 Relay for markus.probst@posteo.de/default with auth_id=680 X-Original-From: Markus Probst Reply-To: markus.probst@posteo.de From: Markus Probst Add a initial synology microp driver, written in Rust. The driver targets a microcontroller found in Synology NAS devices. It currently only supports controlling of the power led, status led, alert led and usb led. Other components such as fan control or handling on-device buttons will be added once the required rust abstractions are there. This driver can be used both on arm and x86, thus it goes into the root directory of drivers/platform. Tested successfully on a Synology DS923+. Signed-off-by: Markus Probst --- MAINTAINERS | 7 + drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/synology_microp/Kconfig | 13 + drivers/platform/synology_microp/Makefile | 3 + drivers/platform/synology_microp/command.rs | 54 ++++ drivers/platform/synology_microp/led.rs | 297 +++++++++++++++++= ++++ drivers/platform/synology_microp/model.rs | 49 ++++ .../platform/synology_microp/synology_microp.rs | 91 +++++++ 9 files changed, 517 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6e974a518a25..e032b4a1566c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -25838,6 +25838,13 @@ F: drivers/dma-buf/sync_* F: include/linux/sync_file.h F: include/uapi/linux/sync_file.h =20 +SYNOLOGY MICROP DRIVER +M: Markus Probst +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/embedded-controller/synology,ds918p-m= icrop.yaml +F: drivers/platform/synology_microp/ + SYNOPSYS ARC ARCHITECTURE M: Vineet Gupta L: linux-snps-arc@lists.infradead.org diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig index 312788f249c9..996050566a4a 100644 --- a/drivers/platform/Kconfig +++ b/drivers/platform/Kconfig @@ -22,3 +22,5 @@ source "drivers/platform/arm64/Kconfig" source "drivers/platform/raspberrypi/Kconfig" =20 source "drivers/platform/wmi/Kconfig" + +source "drivers/platform/synology_microp/Kconfig" diff --git a/drivers/platform/Makefile b/drivers/platform/Makefile index fa322e7f8716..2381872e9133 100644 --- a/drivers/platform/Makefile +++ b/drivers/platform/Makefile @@ -15,3 +15,4 @@ obj-$(CONFIG_SURFACE_PLATFORMS) +=3D surface/ obj-$(CONFIG_ARM64_PLATFORM_DEVICES) +=3D arm64/ obj-$(CONFIG_BCM2835_VCHIQ) +=3D raspberrypi/ obj-$(CONFIG_ACPI_WMI) +=3D wmi/ +obj-$(CONFIG_SYNOLOGY_MICROP) +=3D synology_microp/ diff --git a/drivers/platform/synology_microp/Kconfig b/drivers/platform/sy= nology_microp/Kconfig new file mode 100644 index 000000000000..8878cfb7bcdd --- /dev/null +++ b/drivers/platform/synology_microp/Kconfig @@ -0,0 +1,13 @@ +# SPDX-License-Identifier: GPL-2.0 + +config SYNOLOGY_MICROP + tristate "Synology Microp driver" + depends on LEDS_CLASS && LEDS_CLASS_MULTICOLOR + depends on RUST_SERIAL_DEV_BUS_ABSTRACTIONS + help + Enable support for the EC found in Synology NAS devices. + + This is needed to properly shutdown and reboot the device, as well as + additional functionality like fan and LED control. + + This driver is work in progress and may not be fully functional. diff --git a/drivers/platform/synology_microp/Makefile b/drivers/platform/s= ynology_microp/Makefile new file mode 100644 index 000000000000..63585ccf76e4 --- /dev/null +++ b/drivers/platform/synology_microp/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-y +=3D synology_microp.o diff --git a/drivers/platform/synology_microp/command.rs b/drivers/platform= /synology_microp/command.rs new file mode 100644 index 000000000000..58cb2f3cb3da --- /dev/null +++ b/drivers/platform/synology_microp/command.rs @@ -0,0 +1,54 @@ +// SPDX-License-Identifier: GPL-2.0 + +use kernel::{ + device::Bound, + error::Result, + serdev, // +}; + +use crate::led; + +#[expect( + clippy::enum_variant_names, + reason =3D "future variants will not end with Led" +)] +pub(crate) enum Command { + PowerLed(led::State), + StatusLed(led::StatusLedColor, led::State), + AlertLed(led::State), + UsbLed(led::State), + EsataLed(led::State), +} + +impl Command { + pub(crate) fn write(self, dev: &serdev::Device) -> Result { + dev.write_all( + match self { + Self::PowerLed(led::State::On) =3D> &[0x34], + Self::PowerLed(led::State::Blink) =3D> &[0x35], + Self::PowerLed(led::State::Off) =3D> &[0x36], + + Self::StatusLed(_, led::State::Off) =3D> &[0x37], + Self::StatusLed(led::StatusLedColor::Green, led::State::On= ) =3D> &[0x38], + Self::StatusLed(led::StatusLedColor::Green, led::State::Bl= ink) =3D> &[0x39], + Self::StatusLed(led::StatusLedColor::Amber, led::State::On= ) =3D> &[0x3A], + Self::StatusLed(led::StatusLedColor::Amber, led::State::Bl= ink) =3D> &[0x3B], + + Self::AlertLed(led::State::On) =3D> &[0x4C, 0x41, 0x31], + Self::AlertLed(led::State::Blink) =3D> &[0x4C, 0x41, 0x32], + Self::AlertLed(led::State::Off) =3D> &[0x4C, 0x41, 0x33], + + Self::UsbLed(led::State::On) =3D> &[0x40], + Self::UsbLed(led::State::Blink) =3D> &[0x41], + Self::UsbLed(led::State::Off) =3D> &[0x42], + + Self::EsataLed(led::State::On) =3D> &[0x4C, 0x45, 0x31], + Self::EsataLed(led::State::Blink) =3D> &[0x4C, 0x45, 0x32], + Self::EsataLed(led::State::Off) =3D> &[0x4C, 0x45, 0x33], + }, + serdev::Timeout::Max, + )?; + dev.wait_until_sent(serdev::Timeout::Max); + Ok(()) + } +} diff --git a/drivers/platform/synology_microp/led.rs b/drivers/platform/syn= ology_microp/led.rs new file mode 100644 index 000000000000..4454f06bca4c --- /dev/null +++ b/drivers/platform/synology_microp/led.rs @@ -0,0 +1,297 @@ +// SPDX-License-Identifier: GPL-2.0 + +use kernel::{ + device::Bound, + led::{ + self, + LedOps, + MultiColorSubLed, // + }, + new_mutex, + prelude::*, + serdev, + str::CString, + sync::Mutex, + time::Delta, // +}; +use pin_init::pin_init_scope; + +use crate::{ + command::Command, + model::Model, // +}; + +#[pin_data] +pub(crate) struct Data<'bound> { + #[pin] + status: led::MultiColorDevice<'bound, StatusLedHandler>, + power_name: CString, + #[pin] + power: led::Device<'bound, LedHandler>, + alert: Option>>>, + usb_copy: Option>>>, + esata: Option>>>, +} + +impl<'bound> Data<'bound> { + pub(super) fn register<'a>( + dev: &'bound serdev::Device, + model: &'a Model, + ) -> impl PinInit + 'a + where + 'bound: 'a, + { + pin_init_scope(move || { + Ok(try_pin_init!(Self { + status <- led::DeviceBuilder::new() + .color(led::Color::Multi) + .name(c"synology:multicolor:status") + .build_multicolor( + dev, + try_pin_init!(StatusLedHandler { + blink <- new_mutex!(false), + }), + StatusLedHandler::SUBLEDS, + ), + power_name: CString::try_from_fmt(fmt!( + "synology:{}:power", + model.led_power.as_c_str().to_str()? + ))?, + power <- led::DeviceBuilder::new() + .color(model.led_power) + .name(power_name) + .build( + dev, + try_pin_init!(LedHandler { + blink <- new_mutex!(false), + command: Command::PowerLed, + }), + ), + alert: { + if let Some(color) =3D model.led_alert { + let name =3D CString::try_from_fmt(fmt!( + "synology:{}:alarm", + color.as_c_str().to_str()? + ))?; + Some(KBox::pin_init( + led::DeviceBuilder::new().color(color).name(&n= ame).build( + dev, + try_pin_init!(LedHandler { + blink <- new_mutex!(false), + command: Command::AlertLed, + }), + ), + GFP_KERNEL, + )?) + } else { + None + } + }, + usb_copy: { + if model.led_usb_copy { + Some(KBox::pin_init( + led::DeviceBuilder::new() + .color(led::Color::Green) + .name(c"synology:green:usb") + .build( + dev, + try_pin_init!(LedHandler { + blink <- new_mutex!(false), + command: Command::UsbLed, + }), + ), + GFP_KERNEL, + )?) + } else { + None + } + }, + esata: { + if model.led_esata { + Some(KBox::pin_init( + led::DeviceBuilder::new() + .color(led::Color::Green) + .name(c"synology:green:esata") + .build( + dev, + try_pin_init!(LedHandler { + blink <- new_mutex!(false), + command: Command::EsataLed, + }), + ), + GFP_KERNEL, + )?) + } else { + None + } + }, + })) + }) + } +} + +#[derive(Copy, Clone)] +pub(crate) enum StatusLedColor { + Green, + Amber, +} + +#[derive(Copy, Clone)] +pub(crate) enum State { + On, + Blink, + Off, +} + +#[pin_data] +struct LedHandler { + #[pin] + blink: Mutex, + command: fn(State) -> Command, +} + +/// Blink delay measured using video recording on DS923+ for Power and Sta= tus Led. +/// +/// We assume it is the same for all other leds and models. +const BLINK_DELAY: Delta =3D Delta::from_millis(167); + +#[vtable] +impl LedOps for LedHandler { + type Bus =3D serdev::Device; + type Mode =3D led::Normal; + const BLOCKING: bool =3D true; + const MAX_BRIGHTNESS: u32 =3D 1; + + fn brightness_set<'bound>( + &self, + dev: &'bound Self::Bus, + _classdev: &led::Device<'bound, Self>, + brightness: u32, + ) -> Result<()> { + let mut blink =3D self.blink.lock(); + (self.command)(if brightness =3D=3D 0 { + *blink =3D false; + State::Off + } else if *blink { + State::Blink + } else { + State::On + }) + .write(dev)?; + + Ok(()) + } + + fn blink_set<'bound>( + &self, + dev: &'bound Self::Bus, + _classdev: &led::Device<'bound, Self>, + delay_on: &mut usize, + delay_off: &mut usize, + ) -> Result<()> { + let mut blink =3D self.blink.lock(); + + (self.command)(if *delay_on =3D=3D 0 && *delay_off !=3D 0 { + *blink =3D false; + + State::Off + } else if *delay_on !=3D 0 && *delay_off =3D=3D 0 { + *blink =3D false; + + State::On + } else { + *blink =3D true; + *delay_on =3D BLINK_DELAY.as_millis() as usize; + *delay_off =3D BLINK_DELAY.as_millis() as usize; + + State::Blink + }) + .write(dev) + } +} + +#[pin_data] +struct StatusLedHandler { + #[pin] + blink: Mutex, +} + +impl StatusLedHandler { + const SUBLEDS: &[MultiColorSubLed] =3D &[ + MultiColorSubLed::new(led::Color::Green).initial_intensity(1), + MultiColorSubLed::new(led::Color::Amber), + ]; +} + +#[vtable] +impl LedOps for StatusLedHandler { + type Bus =3D serdev::Device; + type Mode =3D led::MultiColor; + const BLOCKING: bool =3D true; + const MAX_BRIGHTNESS: u32 =3D 1; + + fn brightness_set<'bound>( + &self, + dev: &'bound Self::Bus, + classdev: &led::MultiColorDevice<'bound, Self>, + brightness: u32, + ) -> Result<()> { + let mut blink =3D self.blink.lock(); + if brightness =3D=3D 0 { + *blink =3D false; + } + + let (color, subled_brightness) =3D if classdev.subleds()[1].intens= ity =3D=3D 0 { + (StatusLedColor::Green, classdev.subleds()[0].brightness) + } else { + (StatusLedColor::Amber, classdev.subleds()[1].brightness) + }; + + Command::StatusLed( + color, + if subled_brightness =3D=3D 0 { + State::Off + } else if *blink { + State::Blink + } else { + State::On + }, + ) + .write(dev) + } + + fn blink_set<'bound>( + &self, + dev: &'bound Self::Bus, + classdev: &led::MultiColorDevice<'bound, Self>, + delay_on: &mut usize, + delay_off: &mut usize, + ) -> Result<()> { + let mut blink =3D self.blink.lock(); + *blink =3D true; + + let (color, subled_intensity) =3D if classdev.subleds()[1].intensi= ty =3D=3D 0 { + (StatusLedColor::Green, classdev.subleds()[0].intensity) + } else { + (StatusLedColor::Amber, classdev.subleds()[1].intensity) + }; + Command::StatusLed( + color, + if *delay_on =3D=3D 0 && *delay_off !=3D 0 { + *blink =3D false; + State::Off + } else if subled_intensity =3D=3D 0 { + State::Off + } else if *delay_on !=3D 0 && *delay_off =3D=3D 0 { + *blink =3D false; + State::On + } else { + *delay_on =3D BLINK_DELAY.as_millis() as usize; + *delay_off =3D BLINK_DELAY.as_millis() as usize; + + State::Blink + }, + ) + .write(dev) + } +} diff --git a/drivers/platform/synology_microp/model.rs b/drivers/platform/s= ynology_microp/model.rs new file mode 100644 index 000000000000..715d8840f56b --- /dev/null +++ b/drivers/platform/synology_microp/model.rs @@ -0,0 +1,49 @@ +// SPDX-License-Identifier: GPL-2.0 + +use kernel::led::Color; + +pub(crate) struct Model { + pub(crate) led_power: Color, + pub(crate) led_alert: Option, + pub(crate) led_usb_copy: bool, + pub(crate) led_esata: bool, +} + +impl Model { + pub(super) const fn new() -> Self { + Self { + led_power: Color::Blue, + led_alert: None, + led_usb_copy: false, + led_esata: false, + } + } + + pub(super) const fn led_power(self, color: Color) -> Self { + Self { + led_power: color, + ..self + } + } + + pub(super) const fn led_alert(self, color: Color) -> Self { + Self { + led_alert: Some(color), + ..self + } + } + + pub(super) const fn led_esata(self) -> Self { + Self { + led_esata: true, + ..self + } + } + + pub(super) const fn led_usb_copy(self) -> Self { + Self { + led_usb_copy: true, + ..self + } + } +} diff --git a/drivers/platform/synology_microp/synology_microp.rs b/drivers/= platform/synology_microp/synology_microp.rs new file mode 100644 index 000000000000..f7168309e611 --- /dev/null +++ b/drivers/platform/synology_microp/synology_microp.rs @@ -0,0 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Synology Microp driver + +use kernel::{ + device, + led::Color, + of::{ + DeviceId, + IdTable, // + }, + of_device_table, + prelude::*, + serdev, // +}; +use pin_init::pin_init_scope; + +use crate::model::Model; + +pub(crate) mod command; +mod led; +mod model; + +kernel::module_serdev_device_driver! { + type: SynologyMicropDriver<'static>, + name: "synology_microp", + authors: ["Markus Probst "], + description: "Synology Microp driver", + license: "GPL v2", +} + +#[rustfmt::skip] +of_device_table!( + OF_TABLE, + MODULE_OF_TABLE, + Model, + [ + // apollolake + (DeviceId::new(c"synology,ds918p-microp"), Model::new()), + + // evansport + (DeviceId::new(c"synology,ds214play-microp"), Model::new()), + + // geminilakenk + (DeviceId::new(c"synology,ds225p-microp"), Model::new().led_usb_co= py()), + + // pineview + (DeviceId::new(c"synology,ds710p-microp"), Model::new().led_esata(= )), + (DeviceId::new(c"synology,ds1010p-microp"), Model::new().led_alert= (Color::Amber)), + + // rtd1296 + (DeviceId::new(c"synology,ds118-microp"), Model::new()), + + // rtd1619b + (DeviceId::new(c"synology,ds223-microp"), Model::new().led_usb_cop= y()), + + // v1000 + (DeviceId::new(c"synology,ds1823xsp-microp"), Model::new()), + (DeviceId::new(c"synology,rs1221p-microp"), Model::new().led_power= (Color::Green)), + ] +); + +#[pin_data] +struct SynologyMicropDriver<'bound> { + #[pin] + led: led::Data<'bound>, +} + +#[vtable] +impl serdev::Driver for SynologyMicropDriver<'_> { + type IdInfo =3D Model; + type Data<'bound> =3D SynologyMicropDriver<'bound>; + const OF_ID_TABLE: Option> =3D Some(&OF_TABLE); + + fn probe<'bound>( + dev: &'bound serdev::Device>, + model: Option<&'bound Model>, + ) -> impl PinInit, kernel::error::Error> + 'bound { + pin_init_scope(move || { + let model =3D model.ok_or(EINVAL)?; + + dev.set_baudrate(9600).map_err(|_| EINVAL)?; + dev.set_flow_control(false); + dev.set_parity(serdev::Parity::None)?; + + Ok(try_pin_init!(SynologyMicropDriver { + led <- led::Data::register(dev, model), + })) + }) + } +} --=20 2.53.0