From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDA69306767 for ; Sun, 31 May 2026 05:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206935; cv=none; b=DOZE9UZ+c+FujH/L/ZcdoDIZUo0P6BYsF/u3QgwLt3VURI8SHi3vpzDcdPU8ooNAhMt8qnKGVyXbC4KXGt3P2NC+LT+RDpPDpG5ZihQupkcKbIKceArtBfWTM+NDkR813kBv2AtjLqMxIc9Q1imw4lznKdbdJjLmXvxeqc0oZ4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206935; c=relaxed/simple; bh=2wDUGwNJnnoaQiVEwY7nGl7/imywJz1LeFcyb3cZxEc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ORxoSi90K6MdWRptiiHfxpwpiR9tvIt9AUGMHKyWNyWWkGs08mBDutEJJ1iG+yg6rLQfdnGneS3pJJNKLogWuAvE1ZQOEEwtINFuYfamVj1p8KFiwILAoA4GnTp+QrbJBipPGsj1gzQ4IA8GAxVZ4RQz4OlUaGwLRHH9VIgGeQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eLuF/427; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Omz2gJHL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eLuF/427"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Omz2gJHL" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V4X2fP581303 for ; Sun, 31 May 2026 05:55:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BXM56e/y7AP/IChoOzUGo6IPhuY5BvOU0TGBXjBtMEM=; b=eLuF/427Mw84TC4r Z9WzOCmiWQZVcSDN1H98pOsKVWoaX7DZPz9kfC7x4NlGqhzodNklTolZzWHVhldz RBLnD57v7cIw9TnXGUwNHPjBM/JRqSvZOJ0Iui8DLjOY2VJ2Fwk6NZF391cLE4/0 2nUAlFTre/Q7u3XLNiIPlsxb1CxWZTOy2ca+FhbM0iyN8aaZGu5tJIZbF5a02sIt JnlWtY1KHRUBBB0IxAL2BrZzK+fZLiVBHzlSJK5Aha7Sc0rCBsnZbA8kgT+LM25s oB+4oHjMYinkdDs3WeiYWwMwDzeTaa0/4/DEastswHH1l0+j2xMyzY+Y4+LtFz7x BCHyXA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efn8pkf5b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:32 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2bd04e4fe3dso135997895ad.3 for ; Sat, 30 May 2026 22:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206931; x=1780811731; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BXM56e/y7AP/IChoOzUGo6IPhuY5BvOU0TGBXjBtMEM=; b=Omz2gJHLMV7OQm8OlvWjbmN2Te1VkH1opAPfMTX4pNqCtXNc155vvLsnBsGL3+0NfZ xtg1THGtDR1HD2bGRq6PvM3uYGwnahxGMudeB7CscCZC2AdfM1RmBgCcxuCEaYzgMBlT E6MgEQmJglsFg9obF/MhsYy8w4RqwBcCSCle9bx+tZtkj7MQbrUtIPfDmWt6NbP+6ve7 6fcE71ZZeGncHpQAaKDOUMIOEdb1sC74QoXe9DBCwBMWucTDEtlisje6z5U6Ic7Z1Afm NzvjpMxa44X6JkJVNUO5w6r5Q1hfvxx+x9YXlueAyKzVYlflwoyjrgk2+ekKWgmsOvEK BBpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206931; x=1780811731; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BXM56e/y7AP/IChoOzUGo6IPhuY5BvOU0TGBXjBtMEM=; b=juTjmVrXByZvHb9NqbpPdKmiGC85VLYe6K1+Zqvn5OUITwy0aW9BvKECxjS9rxzDCp 051z9OTa7xX9HaNQrJbXaxz3Z4Ny19rfyzcdXh6YReyhdMh7bh58aTvd4Tdrb0QA6EI7 ABshNMlTTnE5M+U2sSk06VKZTK5wb6bbk5yq0RVet0Y/Ay91vkU/xVRYJGbDoCk00MjO QCxSl30Zlgn1TgrI9S2vYx19ymNFKHPEOj9GYMNKfIdG5wroi3D7L6fOHHTozZHV9UI5 EoKP37PTnLz+p1kLqeTC6bb00DLMXpR15Rae2jMLWmpagUsbyH3FU9rWUYu0ayD8feXz yg8Q== X-Forwarded-Encrypted: i=1; AFNElJ9/9ZzgC2fV9fS+y/V+HOE7JJDm1pmyGPeqJGa7xZ2Fmh5LdLjjTxApeUnKKosuNJoAqqTJNETxw2ZXNJA=@vger.kernel.org X-Gm-Message-State: AOJu0YwSGMTlddDG8tv9tHfgHUxH0rRxLpuwmPjkdmWwUDDN9XZYpg+5 HGp4d1KATcW8oPTIlok5JMJah57f878XXYTx7wpHvAew1uIRUG+Yvi5hEL4gPMTh9ynGDz4/4Ku lPVeHuCZkKs9ALzejq7WGYnqWNHLalitSgJr4mCHLbpqhukxCgp97kHJHNb5QYUhBtc0= X-Gm-Gg: Acq92OGM4ITMt1DLAMtNvpJ8fxOcvDSUUdmx2svjSP9/WSgJrmp5eA5laDc8HoWFNhf GJKmOVfJAoN7WErcJuqVqOJo/ABaKab0OZfwhdUFOAlRfK9nARfV4x+93IdKnlUldNOB2hLwLrq AkU3j70WSzaPlqvpW0b0ZZ4FY92FhirJVkTu+fr0zSCo5s+U6vIsetrOUP1+33N+D5hOFItBX5+ BzRFcefUF5sIPSdc6Ls+5cEuq7wM0q6iA+713nyfcUJ8ieRw9oate8AP3te9jA9whgFW6vL5We7 ubEHDo6fRFN54LkhzEeSv603PmrqBGnC98D3Nf7vYUZgBZqNkKROPYnZohcKVezInQo/Tpr/06+ 5u1bP5Qr3wBUXbnGj0Gdd0cPq+gBq2szLQBCjkTUIS+2Yp01UHVFdUJcdxmYQ4lT5xw== X-Received: by 2002:a17:903:1905:b0:2ba:924b:3948 with SMTP id d9443c01a7336-2bf367e4391mr77834255ad.15.1780206931499; Sat, 30 May 2026 22:55:31 -0700 (PDT) X-Received: by 2002:a17:903:1905:b0:2ba:924b:3948 with SMTP id d9443c01a7336-2bf367e4391mr77834065ad.15.1780206931035; Sat, 30 May 2026 22:55:31 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:30 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:35 +0530 Subject: [PATCH v3 1/7] media: qcom: iris: Centralize internal buffer table selection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-1-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=8143; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=BZOdvz5iarQDnl8uGdnmlUoVqz3/4hTjx21nuSXgFvI=; b=03jCnFQheIXzUvky9qOzq4x7dQ6FDyu4wTNiebYH+IT83uTXII/QHXGW3d850PoMWl+Vl2dv4 g/sZ2OfV9pUCvX81x/TV69lArDXznK7qjtYbno6SRKncTfZlw3/Dj0L X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: VeNmGRZEiLXhRueXYTh68-TResVZKx0Z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX9lPbzkMUtlcA mHisPV6JLJDGqCUYGiSs88ssacqzSH1UHiwfCjAmtSAA0MxoQI4HMDEddfjiNPobO3aFMWgMBxc EFYjk37aAWLQpkHMf+wvsxqL4IsH7aRHWZVgjVmQHk6lb1NQ4qvQ27UeYa2liDGJ9CTysKNTm9w KU9p4Yvv0vPL9dWPKJgvLiILdKERfMpuRU5gr3W0ZgY3yRuiF1T3DN1k2gv0DjChCleFXsaTJrQ c0tNlrsBEWd0IBmewS17l9Ja24kAxvFi4XcJOw3LQ2WuXkg9bYpLO0711yG1VNC1jADpwYpbAaa E8W0TTLYSD7QS/6tLGLbW1qV7CYIV/EMDqfh8n9Zu6c1SmhWcYlE+y0CO9CbMF664z+UmY/J5a8 QSJkKdCECK45lNd/WVa+dQx4ZhYDQKnLJ2IcaqSWQho+tb1ox3XWaYZICI6HqVRyKnKgd5daqq2 Db76seyad6fdV1NIiGw== X-Authority-Analysis: v=2.4 cv=NvvhtcdJ c=1 sm=1 tr=0 ts=6a1bcd54 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=22hBRqbxvLe5Obw_dBcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: VeNmGRZEiLXhRueXYTh68-TResVZKx0Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal Internal buffer table dispatch is duplicated across multiple Iris code paths, which is error=E2=80=91prone and makes future changes harder to reas= on about. Consolidate the buffer dispatch logic into a single helper so that table selection is defined in exactly one place and keep call sites minimal. No functional change intended. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_buffer.c | 107 ++++++---------------= ---- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index ef7f6f931557..73b4d3381e47 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -299,39 +299,41 @@ static void iris_fill_internal_buf_info(struct iris_i= nst *inst, buffers->min_count =3D iris_vpu_buf_count(inst, buffer_type); } =20 -void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +static void iris_get_int_buf_tbl(struct iris_inst *inst, u32 plane, + const u32 **internal_buf_type, u32 *internal_buffer_count) { const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; - const u32 *internal_buf_type; - u32 internal_buffer_count, i; =20 if (inst->domain =3D=3D DECODER) { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; + *internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; + *internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; } } else { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; + *internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; + *internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; } } } =20 +void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +{ + const u32 *internal_buf_type; + u32 internal_buffer_count, i; + + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); + + for (i =3D 0; i < internal_buffer_count; i++) + iris_fill_internal_buf_info(inst, internal_buf_type[i]); +} + static int iris_create_internal_buffer(struct iris_inst *inst, enum iris_buffer_type buffer_type, u32 index) { @@ -366,29 +368,12 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, =20 int iris_create_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; u32 internal_buffer_count, i, j; struct iris_buffers *buffers; const u32 *internal_buf_type; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -442,30 +427,13 @@ int iris_queue_internal_deferred_buffers(struct iris_= inst *inst, enum iris_buffe =20 int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; struct iris_buffer *buffer, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -501,30 +469,13 @@ int iris_destroy_internal_buffer(struct iris_inst *in= st, struct iris_buffer *buf =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; struct iris_buffer *buf, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - len =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - len =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - len =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - len =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 for (i =3D 0; i < len; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -593,18 +544,12 @@ static int iris_release_internal_buffers(struct iris_= inst *inst, =20 static int iris_release_input_internal_buffers(struct iris_inst *inst) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } + iris_get_int_buf_tbl(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + &internal_buf_type, &internal_buffer_count); =20 for (i =3D 0; i < internal_buffer_count; i++) { ret =3D iris_release_internal_buffers(inst, internal_buf_type[i]); --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C313233E8 for ; Sun, 31 May 2026 05:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206938; cv=none; b=geeEIL+X/rV39/VyX33CpFvvWGIWylnD0rovwVmxHeg8tQ+IKl5QrjGAn3pPhKuceQf4IZkX6dE1rJyg78QuvApWElNNAVrVQyXDjN7sufXfF9TNoCUcv9LnE3H+oasD+/v7hyopRodZ3zZWGpO8EsTGGb7/bkYTu23IMBUOXzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206938; c=relaxed/simple; bh=bVPxoi85jbZFO9af2Hg2HjePj0L5XNSg5j6catQYaJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DYxwqr1+w9A+DVElOFjSDwpzTScxTP4JelakZRaVcZDkmpl4woz7emOhKMJasVeQ+ezvMmdp5odyabHfDej2c515s72tZ9cL9a8BpNg3JkhoOZCCVY8lTYUJNMzl2FfS1/eEv+fdMDYsNiE9WcRG9zAKXOhn0vvPw+kXZKf0zb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jffAadAE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eCdLUOKS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jffAadAE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eCdLUOKS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V59h3Q701184 for ; Sun, 31 May 2026 05:55:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=jffAadAEzOpKIi7d b9X0gR2i7tkBD8SGtjY6kjv7S2CcFpxdE0fIYM0bEaoHbdClzUTUWKe66wiKWSny XJ73AFe+qmtoddOuZeFe3c1EuGu7+uHWUmldYJpESXQ32wZ94vmDIcTz0ehi1sFU peVUaGggejxNE04boNZpDZZDET+6Jx5V7rxtUslVdafSxgfXyEcCkCqqZCpoxhg9 SlsBD/O1jhSL5t3Ky4nGOs3XIma90wia/wEjqUFyJGiXlPP5DXuAjjUCKbHlvxln SgATFDd0ve3D0rOJoAt8p+HWsjLhpBTwMcgu+CXjo7yJeQk1fuYlx+LfGZWhM2yj 38V5cg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efxy7t37x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:37 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c0c272e532so3386145ad.1 for ; Sat, 30 May 2026 22:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206936; x=1780811736; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=eCdLUOKSJ6Wh6YKqhcVAdTLkpAmy3WMrZb7cRdkvkQtBVsOv3buCMMS2I1+oeiwLgc H9YwwIBxONYG9NJuI5664Odv4MrolNt/3dSjDMqcaMUfhxrScFwc64qKrip3Djj2ntId j90mESU65BS0/wYoGED5qMiwU4ZPtY6rQsI60XTbrYQxzo8RsseXkzU0k0piLZ187KFz v2phfrNDypeWsu3TwqDlUdR6DKTHKoUxOlOvYKWl/bEpbTw8cf994VtwGYIGq3E6bTW1 poTd5+AJBz9LuRhUHuqLUs7gFFk6NS+oM/mrNsK8KoQ3oq2Jt4xuukzigpovYTsRetnD V0sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206936; x=1780811736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=bcYwXRp9aoaFiYra/gJZoJzIr7sdcKHWoKCRwpW3OVlQgeMXExXBcn5/s86RutqEuX ntuOUE4WLwUlRSf1z84CUx759WiS3wLUmPbIVZvxFbAysfKQhh7h5FNlipNyilTx6ZI/ xcT5Gb4/dMhWGSbxZocNxz2ttAfUBwT4fsnliiZHTiOWZI2bOraBTVXJRX5RHuO4fEqA bjYTqpCxZ9IN9wcFr6wFtUq8URwyDp7XxYZuqaxmiQvK15peLJa0XoCDWIqNayI/NBZo muAQSCUqA7wzcXqra7FmnZIjGcDu3HPxPgu3CFjsSqE2+pglEZqFiKxiG6ux3V4gW5cu FYrw== X-Forwarded-Encrypted: i=1; AFNElJ9v92Y6lZy3atn6mVcx4LxwIVbQbbNzWwi0ZqzDLqnRU7/kwE6flhSk1tPZh5fj5OI0sMWjf+DObmtuKd4=@vger.kernel.org X-Gm-Message-State: AOJu0YwnFBhC7jg6BpwOaHWmzo23OWHasDaXfUENWMnJsRFIHE+nBQZz iSgAbPwBdvTYyUSgTlLXkUg7BftyJrUQCFiCMdSaGUNRoj2tgb76VL7j57NRCCn1bfu8jo47oby OH9zpRPy/aA4SxmdnwXqRoX/RjztYCvAs8Ukg3Y/fH+uTxAA3ZY00IwlDefsXrvTTIlU= X-Gm-Gg: Acq92OFdtRD499Wp7I9tl0vEt7GsFjtj1IQsbOhGdWegKTUOidylttzfocV4g599ef7 YV2PK8u9wsxvnVuX+eodJ6QnHQ0vKG7YvxHM+ppWVf3D5QcBXis1N/i3SqN5RUwmq53PqAHhXN/ HNE+5NG+PoSQ6/sh4Iyw+C5IYMwyd3jjT0dbyRSUvcezZM/fb6+uPV9FWckS6bnxf2AVWPJOwKd uIsn8O7pkNdWt/3K00jnn5kCecdaJzb419H6tq1+eaxwIPuJRFH3mqZyAuMkkqTYQ6ZBjsyHKAY ic8kZZVKYGIpZd4xGpHS3YNfmljyuI8vLFXHlo61HDIsc0RIITCsMsa/7WYCoz7bizcT38sJhtD 5Ho/jxplMX5LbzCniu8Df9Hg7AXqHUM3yi57IDpoLq1gFElIc9ZPMa7l+jjmhKTjiJQ== X-Received: by 2002:a17:903:1c6:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2bf36877582mr69541555ad.32.1780206936351; Sat, 30 May 2026 22:55:36 -0700 (PDT) X-Received: by 2002:a17:903:1c6:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2bf36877582mr69541295ad.32.1780206935919; Sat, 30 May 2026 22:55:35 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:35 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:36 +0530 Subject: [PATCH v3 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-2-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1345; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=Uq29RriGWpbhBmOAxORGoqBD0WkHutgpBJXYyBKyE+o=; b=rQ1wFVhrzKpX8UHQdt+tbafWMw7piYPyv23/irop9qOXHIN6lTu8pOwBn9djV1SJY/P3OynUd pAI5c0BEm1ECcW/Mq8LOmwDxRzkN/o3mqWum2ZHCXY1SeeMaMltKMjM X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=POg/P/qC c=1 sm=1 tr=0 ts=6a1bcd59 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=iF4bBz5rOIv4ZkufqEYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX3udAM8i0CkQ/ FaataHlpUumiZp/xPjsJqf9FXDeHM4ISiV/NfDoS5ghIvFtaFaiCX/tTmaZ0fUKpz1McVLz0Qm5 +13D4bFkXU1/S1Dxe/2I1Wq/OnHJVvjHDsiwpzzrV/jj2uBOIJy2JxnETMcnUlKeH56A5+VERRx BF4iNWWBLbZR9XRfB/7ScCYRBraAwxs3pzdLEgkwGxaModwL+eOEvolnkPhx94/PLrvQRoELUeG RBLVo9NocLi7gKWS9ICneOQ/3I9AEZ1kefSY8M9qgrwz+Pn1wNke/jvu2S34QeC06AlozKwbGW3 kMIm6WakgaQUtMhcB9LjIlm8n1B8+DfgOt1Xb25AJbJpnlmKJIpUCIdXlXtOO2LtD20JFj1k6ES IH3l8O74kPdbS6hXnkEggXkDRnLxWuR+ps/g1AU5girbyxIw6kNIaUugkr2axV1AqGwiWuEoqCH r90x0l9LLnE1T79zxTA== X-Proofpoint-ORIG-GUID: L95Uyb-ouXtcRwNkPjKrrPWQcVHHOk4G X-Proofpoint-GUID: L95Uyb-ouXtcRwNkPjKrrPWQcVHHOk4G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal The state=E2=80=91change debug log in iris_inst_change_state() always print= s the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub=E2=80=91state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index d14472414750..e991f34916ec 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; =20 change_state: - inst->state =3D request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state =3D request_state; =20 return 0; } --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4447DA66 for ; Sun, 31 May 2026 05:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206944; cv=none; b=YUHE6SWVKd7Zpf/9IBoa52C/dMucfkZrX5LpW6soHQ7VWu9+ettqHNr6KIpJENLzCWBv+ZL+8aA/+I3G8U2IY/skACxsgiVajd4bjpw4LAoc78dUjas+jv3y/Xxg0krYKXW8sj1fQA3SFraephXpjyxzZtToF/0OYJvSvBFKHII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206944; c=relaxed/simple; bh=XrExrogGyNY8zefzhUS+pWbzmqCVYgThgf2zASOamL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MJNVY1xrvNNfgzZbqTpI1vxvs2r5SgzVwkRBI5VSM35w9hTu4PGYVuW4+zQeEN1jmp37Rmpa80RX+vuyZSDb2SdSBO9luIhfxzmOcyRiM43E5KJnlbOnH2gImPk9+WdjF6nbskPQIHN61PeT8/gpeuDblfMmAW4/N4KaVHUII94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z9335Ei2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g492gi1u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z9335Ei2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g492gi1u" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V1e1cG235321 for ; Sun, 31 May 2026 05:55:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=Z9335Ei2cE9IT7R9 B0ZWeVG8LC/oACCwxbnVG8y/sXZ/gVBXtRY6uGKvKytbQnQ5ug3C0P7cFndGKcqP qRvGEPAfKqfqn0B0oVEmDmHuPM4tGbr/MPNvHJXZZecJpPUIloTPqpbDna7860fS UUDRIb1Grt0YbJkM+oP+RpCOmm1JOEqHJKwnancsZvNe2UzAVPJhm969c3QGMdAO Hi7xlQke/qodnS9rjpNcWWR853coBFEd648QDvz02tjQrZ/Q23hGSHhvBZJ5Ybaf 1InvIpFl5hZZ75pPUafHo1gE6kmsFwxwBA/siv7lz3if7lF3D5i4fgb6K9h1wuO8 59GTeA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efn8pkf5h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:42 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bf32fb7cb2so10635635ad.2 for ; Sat, 30 May 2026 22:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206941; x=1780811741; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=g492gi1udpsyo/idnz5wAVzOUBoJkr9yrDpdzufOjg2OUHG4cWjse7wQe+DSBnPqQm P5kb6UbArLyuqQFaJykC6iKOh7O05wt86vXj0eY5snuj3FYOeGkFLyxQzsVEt7bVM0Bc iEAAHUtI4c2ME4ESCydXAmWpHx5/xwyZehpti23ZZp9FhJAwywnBYnYtFgZJcjwz8TwZ lpVh/uZqSV2Du04PDATrJ/u7gGXK8X1LbzggVAm8GTFNe9HV45qC6FQL8vS1V4qvOXFe owln1XxLh6XmrpPC/I8vvO1S6ZCuevvVqR5VG7oYUiOHQ1igODYRc9qL1wzlW+x2wdpW YqOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206941; x=1780811741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=Prh0CLQ+fpCv3QPgJXjHeZIMij0qiOE7/6+b74euByaL+46Vm5n57ToXnj0SANjtF5 GKrf2ER9UfWIEo2e/pJezBE2ttxjy6SDe3ICLhx8B95T660gMzM5V7ZhdjGq5JxGcUoU decmh8NEiC49pEhm9Sj8Obcb93cLOfWNojXMhAus0Rx3/Z5tVK1T6vpufmmuPscIIQj6 dI0+VYs7P41mdDC491hO2w+siuBPcWzdfw8ey6wQlaCrnUJPMidqXTsBs1/5sRzHNMg+ WBrme2MHOtL1xHGu2SX/BsGgqJb38W9+Jz/M1ezosEjgrs7oU7mBgwhZehIY5jey/2l7 asiA== X-Forwarded-Encrypted: i=1; AFNElJ9Yy2RbPHqfr2Ew0Gz6PyaqWaGUxYTM/950A7SVDHBqK7TKRsdUC/lo2i18t1xU1Dm4/MHeOZj/uEHoctk=@vger.kernel.org X-Gm-Message-State: AOJu0YxVBDEUvxRIO2ShT3pAwk1XG+6t1j2Q+7/KMK5q0jjybMFV1goF pFuGXLzy4oguNV6cC68+IK5LVjLbZtyded0eZ4NhdYlV9M5n/mJuEHL4r8VamB9U2PJmJd46v4K O5/DSbFfqLbajdJQxzGZjTJ2xZcomzYy86+6VC4brfdwv6SXsZjemclo/mAHwmrwiR2M= X-Gm-Gg: Acq92OGiD9vUx4hpipZASFzQizMbebOJQlte4r1L8PH3PttA7Iyh5wxnt03U00A0prU l6EEwF31u+f+qJkvG+y05yNIzQzoQk1eRwiICb/g1reuwON07keZJaypsOcTqlFkRleGiy2kjns od4s+cakRIp96AF0J/XkkwoToo8JsUUPZfNrZUgtx5v5X3XZCB4bzb5jmgM4QeCPy11GKk7FobH ENk9ZF8XBr13OQJiPz1ilX5u4LOFzaw+9OukY/0pP8Ullm3mmVoygu84QwIewaZJ/82lcQAkFI/ P1ocPT+rri9/TF6dV0ImseyeipK24YWqPFgfyCt7ctABK6cq1Ne5JlynyqZomFddEdraiVnEus7 9rXhadkkqWatSgtFf8nTaptF2i3I53D01IJ/+KVR8+VFY+a5xZ6o9yE404mXrf1eiNA== X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864355ad.24.1780206941180; Sat, 30 May 2026 22:55:41 -0700 (PDT) X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864035ad.24.1780206940705; Sat, 30 May 2026 22:55:40 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:40 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:37 +0530 Subject: [PATCH v3 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-3-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1251; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iUPNcmr9LcDxjiMweUrnUvGUJcwSJce63MellJNuucw=; b=ezIbKToaQmXP9xrtCwyXd3cvyElME/u6McvNG0gJrzRBMRPzxp9VgdhzZ1lVOin6PB/Y4Q1uf KI5UOD0wO2NDhzuNfub60AKW9lZcLUwelb8Wff/DO4ktese6hNlqfQw X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: o9S1bagrD8VKn49aHP-m4em43wOz4vA8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfXx/CtIjRDz64/ o+grNTxigbzZSUJM0FL0RR16MbpnycpKK4jeThw7t0fJTrqJ8ncYLqdxLKl8qrR+oDEYYDJ+xSr DBbZsXFYCaV/neF93zyvQNuw0lF2E1/gt69GygkwIAH4MEVwwQlon8i6wYnxwWlLWQ+Irzv29EQ A1J2mSF7dm1NIyexuxaCxPB2ZHEhkesmmZlJ6Wzgn5AMNS7/slIEdNpm2s5hxJKTgYcNlxoRFH9 eGVwoiEVEh8yCwsYWtnASu5H/mkVaJIFdZzOQJ8F/FuBQk8Rcbm1DealTLFIgFYatupbq9zzLsb aoamSmACj2silhhPHG5PK9NO1P4qKClerlQ6n36axaZE4KR2OryVmR3zcblEToUZir+e1MD0cfP K391pEwdjVuzmyP9jsr3bEkdOeVEnbp4722fwiAj/i35sdcPXpZDSl5hQV8AMV3I8sZbGHF3gcB runqB8ineB3e3GMeTTg== X-Authority-Analysis: v=2.4 cv=NvvhtcdJ c=1 sm=1 tr=0 ts=6a1bcd5e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=qiYeaxkneK40FgSAABkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: o9S1bagrD8VKn49aHP-m4em43wOz4vA8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal iris_allow_cmd() incorrectly checks a sub=E2=80=91state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index e991f34916ec..5552725c614e 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd =3D=3D V4L2_DEC_CMD_STOP || cmd =3D=3D V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state !=3D IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } =20 --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1160B3264EF for ; Sun, 31 May 2026 05:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206949; cv=none; b=cCMc9hnDyBhERTIcr4AcqklK3eXvej5XCvSsAdBfyoc9qVzatQsvPjnpE/LShxft/UMWVL2KxMrXIom2USgf5jOuKiYNd/pHmSdJen12gzb5b3FpDA7fHP6qHraA/JQe3IxDwQ+Gp4haARyXjw/8Aigpk4NiW5IapRIORlp54V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206949; c=relaxed/simple; bh=GAAkIIXQjYZWxC6zM1mlm9QigG1B8h92fJVsYMtHq4Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=noUTgwFJgQoOaUDi6L1XsaTps/O5E8YfY1k68AIV2uMDiQQKPCEMSavZXcIyTRpvM4XMqkOXwmbGs06xALig/bIileMI6eZtYxoV4a9beG32YduUKA32JbRlmp7v00JJT7OmIlP20jT/NPND49h7MHu7yY5rQBin5wkA6Serh0Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kLnXbKzl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OVoM6Kx/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kLnXbKzl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OVoM6Kx/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V3lfNg696762 for ; Sun, 31 May 2026 05:55:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=kLnXbKzlwyN7Ykqc yrh4wD6vfzhwZqdC9Ea9+0Ez6f3XZar9CRdsMyD6oh4Ol79sSt0fqu/Kew7hELJM WEg9tYwThhSK/3QlEKfTpzfHFEd9Wacg94nNZZ2NhrOjmeDd1yC2EUAQGt4bmK78 n1wM12IgNzIi8BA8uer46L/W+Chg+u3vd4U8nzKilhDEs9asiQ4Bt4vmq/PfXVdy g1QP4g//GarbqiTKMuSTQpeR8ZTMjRYzNAWoqZMwhs5AHCQa19rpgVowbKosjIz+ C5SpTnYsmcSkN6qOHNObDEyoHTcAVUtW+SNfLiccwQe87Rny6LlF+0LsZepOihTN nPToMg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efq7fayb8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:46 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bfdd99f6b7so18711425ad.0 for ; Sat, 30 May 2026 22:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206946; x=1780811746; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=OVoM6Kx/7QyN+S0TEos07JyMHPSG7ZDiyQaKD+ECnBZb6fKqJAuX9snM+/bllztx2y DyTtp+7Qnhc+p6HkqSZv2vYo+dHHAjnKqd658g6KYSZ0PBT58Hz8Iw+pBsl+7cY73ng0 17Ec2P6G59bcZ//UCZ51G4fk6oubj8Wflq9pC1jjNoOsXmflZJLHt/7Ka4UiAH6Bp7Rx wSW3AIA9ZmV8DWEvi2Q3XxxuIf59m7z7uOJsWRwkCes2xjeutWNDETqCHx421kOXjcoG kRB00udvEIhWAsher4MXXMcKcOICXLtMYhw9+u/BPamrpAGMquQdg+Pecu+DEJg1ksTV K58A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206946; x=1780811746; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=VTJD7S39vtDPP1NLvOiAVOLE2T/E0yxZYCxy6jofYKtNzTMqARMdFEAXRa0/GWjej5 YgTwZLPJ2pLck5FTVbzM5NZ4kxu7skWmFutzKhObehMEtGPopwXNBHKOpBOLjqKtzp9K 5tkQ/Qrr2iEohpKzbV7jPD5+f1xQ+C85JOQKEHWZdlQ++yJxX8R7hbv+rN3ZX9KBsCBS 23cIBqnl+xjEO0+woWrUng3YeR1NpsP8+TqDct7BUVzV5EN0hLr9i0E5OM1iqrEwhbMy I/KH06o7etPe+VSKUr6cpDkgYRUf/LMmqvZZNExZiCoXJLJEr8RkWzV/MAzGqZW3Fohp DldQ== X-Forwarded-Encrypted: i=1; AFNElJ9GJ5PZff0qvLkFPrYn4jcjv/5mCAzHtjnRaQmK2p4gQ4zbQH6frMZOHzstwWRBORvl6iMZvef1wBq2v0c=@vger.kernel.org X-Gm-Message-State: AOJu0YwNKeYS+JA4FuqK6qJ199BHND8P+Zp1QVPgPuMWmQsZbAbiLqZ/ 7y5BBmkDZcHtXQBPd8nDNQm7OazlsycrlzQsJ3URQrDqWntDiPWz/1GNl5/l8rqwiUDddCZomdU lnxOtpCVzTUe5SbAduwBNdxZ3FO4kTG/JDvdcQh9SJ7V7hEAWkavcw6mA++r67rarJpA= X-Gm-Gg: Acq92OEnJO4wmMzx/Na8w35Grjx5rUkVYTxbzp1OoPXz6Ol6ty/ysIvu18Ukmd/s5U5 2VVNq0+pE8RfemDjHpNXPeDEYD1SlZbcPyG3DjTIxmpiDX7HQdMV0ttuA6ZCibHcrqq+Vy3FlcK a75R5xLjHEQBGXa+KzJMfHksS9xe7a4IXBtQEnUu02YcHW9a7WQA287GbcILo2ssDdfj4GIhw2L 3AjWnQF3+nf6oFlxpxsCueqgS9QmaL1ijWIgg047UA+VKk/JU96L1blIlmJ+D/HXiZkWsRHxcRq XHLPc+saIF3xTMAJAUQK7KXN9XELSyYKp283b7vVPToXa5Y+wWqlxMBX/k2cjUt8o1JGuSGcqPZ Ol/gsEqGuz/nsd0VB+250nHZtd+qSkOL8npwtnk9phaNsscqZvyrm7SX3X79dYN3UrQ== X-Received: by 2002:a17:903:2f05:b0:2bd:c925:3a16 with SMTP id d9443c01a7336-2bf367b1670mr72469375ad.2.1780206945809; Sat, 30 May 2026 22:55:45 -0700 (PDT) X-Received: by 2002:a17:903:2f05:b0:2bd:c925:3a16 with SMTP id d9443c01a7336-2bf367b1670mr72469165ad.2.1780206945385; Sat, 30 May 2026 22:55:45 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:45 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:38 +0530 Subject: [PATCH v3 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-4-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1375; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=aqhs4jaqkXidlgjr5SFVJnDOR/verJ9BG22AWDOERv8=; b=fBrM22ZPdY7kkmJhmuG30GdvcjhBdE1aNrF8V8DZcDUn5/mV/L0n3klpalCLskDNABeLyMmaq j3SlJUD5JI+AI2Chvgb2tcNg297mCrmG95ZGw3yXBwMxBkKgO/QesQp X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-ORIG-GUID: LcB0xM4h2rihuBPXpFki2IJKipEcFoR8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX7NM4hklmmNM1 Mz22Pz04Mr18JntIHAz1HUQrLXzc32bWk8nm3tfWTfXRbyekdzWTV7Wj2Q6nfxW0bt6IPSC9k/U 8T4ae4bB1yG3QPss8RibMw5F8/RUIPbkuX57gjOShpCZnN+EN0zG15sAy5HxZzD0gemkvgb9Gjw lXbFpDZdIrxLFUcOCb8aliNVRfVMBH2JkwQ/QYLlQCE1G/kvB1x/xvzsjdFe49TL60pKC1k/dIx msjbZpqmXI/BQxiShSKYJ0638gyiSmjKfvPr6FNPjf/PlEgGIsTa9mo+giOOt+e6e5htUiXh2+e rgJgztWa4hnLWNy60u4XexNvmYEinNy1CwU4sYZpaiCtFFACF+iC8dMj9WrmIupcfI744PKXO/q 3bfXFcQ1vzfwwDSwu8AtP+aX5slBDTce25j0NH6bL+xYcskFpXeJ+PL6DzKrw467H2LETbO/Ctx bF4IjCT2qDDckJH6Xug== X-Proofpoint-GUID: LcB0xM4h2rihuBPXpFki2IJKipEcFoR8 X-Authority-Analysis: v=2.4 cv=XqzK/1F9 c=1 sm=1 tr=0 ts=6a1bcd62 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=7A-KeLSbcoVXy4yL1OsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal Fold the ternary initialiser directly into the variable declaration, removing the dead store that was immediately overwritten. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index c90b22a75bc5..fe67ad0ffb4f 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst *in= st, u32 plane) { u32 port =3D iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLA= NE); struct iris_inst_hfi_gen2 *inst_hfi_gen2 =3D to_iris_inst_hfi_gen2(inst); - u32 tier =3D inst->fw_caps[TIER].value; + u32 tier_cap =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? TIER_AV1 : TIER; + u32 tier =3D inst->fw_caps[tier_cap].value; =20 - tier =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_AV1].= value : - inst->fw_caps[TIER].value; inst_hfi_gen2->src_subcr_params.tier =3D tier; =20 return iris_hfi_gen2_session_set_property(inst, --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C5B306767 for ; Sun, 31 May 2026 05:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206954; cv=none; b=R+GPo9rxL0sacV9GwVGARFv/SFXxTOYsaJDG7wCfTR4pNKKPGJpvHCucNtsXsr7K8vWFAcV/G+NdkUsY0DnAqTuj7i+yj/4DxQwuAc9u7ChN0dLaWlMHUjb25dyuDcCEmkxF6OXtsd/0Az+lQoq8gkQdUj7qyEAxEYqqwAmQhCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206954; c=relaxed/simple; bh=+qL/hBSTWBuxNiFK2MIAANTOJ8DrM/Sqlp9Ov3W2cvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Efjn+QK2Eg/dgkrgRGAhNEFkZ6oTwpmdwQ2xEhWmtgyof4yNckUvubAuy6AeDmcu078t8s5VzUFcgZqCOHTbjtfcKHKaJ2RyQMmMGk/qskwXXafl5j0iNYtgqWS1kLOMRQUNwNxQcM86dZ11OJWEKPDRGqRt76QZS4mUcP7a66g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ORZwSWsj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DDOrb5M9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ORZwSWsj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DDOrb5M9" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V1j23e640294 for ; Sun, 31 May 2026 05:55:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m48eV0xUesXIRVTMJrkjrvdiGFvsY6A6Ikb+qrJ/+rg=; b=ORZwSWsjW37wyi5D TW/ayu8nhicAS0ZqJqFNMJwNLjAcCf3AWT2J9cohKjvbsxAFGN4834fcD+om+eHZ yLr173AphtU3bkGnOSUgwlcjrLZ48vTSB2H3i9ni5vuczBjLvNyoxj+w0m14Hho0 xVXWUfeTEooxAlEGGBSDLqMH3BRMaUHmBfwIlENXwDFKHqp+84nt8ONZFRTgOQh6 Pib2cEJlWOE8YMV/FaBRdz/KeyizvTD4vqmbtzLUn+CP0yD6IeP8wh8J/5FSHQFX +5dF/P6hi6NZ2UwZPlQg8SNHpOi9D01Qqkjtt9VQtUDjk1M8qYoauuLr4aBLE7sW Tcq7Bg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efr98asmh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:52 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2bf32fb7cb2so10636025ad.2 for ; Sat, 30 May 2026 22:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206951; x=1780811751; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m48eV0xUesXIRVTMJrkjrvdiGFvsY6A6Ikb+qrJ/+rg=; b=DDOrb5M9eDnJut9rC64hiOcXCo0ZouIp93r1eZjqzKxhTspTINHEzxIgJtXjuQI1XQ p4KfNuM3rapwXaMdTIXHocPkOlvHBZnk1K4j6MPwGb9h5HjqhkjcnGa2ckdSZkbwvCK+ Tnk/ACwCezYTqo8451P3V9oVvqy7XOkL25x78dTMMMl+PXJ4RhCWO6v537hyN3ooX/nE JJniKhZjFpwLx6DNvJJ4CRIYwqHnRIxuMNGLjv8HsL8PFmHMexqnflC5RyDKS5ckEyXC RCKPp1dwx6U2ImKBX7KoGhSunRvHlZBhxVA91oivJrX/b5Ug6vUIJI7EIe+V/hClS+5e 4aZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206951; x=1780811751; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=m48eV0xUesXIRVTMJrkjrvdiGFvsY6A6Ikb+qrJ/+rg=; b=dftpgzdAwyQp+7MsAN0dmHR3u7wlKs/g/ZMMejPYD7qG/VDnWS+o2KI6ELXJYo6SuP XKGyWUnQ9PnfPEE97x0qB4ZnAx4SUaREuT2lNFFI+hyCDdrpUd9y94hR9zkGX0v20Nr9 th65NC8RH4oNWCmfiviNYaZ6StpGIDiSU4/135rOqbVlIe9Bqpe8gCfLIsPuDJlmb36o 3KTIlkoqWG8KBLeYIrYh1Yx2EGuvPRcEQpzoHEtcqQDMVZJTM0ClEI4Xos9QWxsN0Ja2 vkeklsowZOtmmqEP4RpHWB6ZQG+8HcE2gPN2l2dwBHsFlEFcj9ilhkIbW71GVDQKZVWF lNyQ== X-Forwarded-Encrypted: i=1; AFNElJ/awqvJYjL0s6qf0DHob0f7n6kDJ84Ch1FzwhOnWIh+ey6YdM6xptrl9TBeGRkzI/DIErqK+Di5V5tIeHE=@vger.kernel.org X-Gm-Message-State: AOJu0YwrI/i5oLshtv2XLmIBtJL1NPeiOYuZH4J9d6db+T6ef+pjtiwt M8qIqiTFJBK58py8C76OO090MlR/AFnNvDkSpa01wpCJioD8mE0kjGeem4lXtfS0L3FpYOuWJDP ihq3ZZ020y2rgs/uQcnCs0De0s09r8HnIq3GudWYWOh8zSwYQaukzYLQDvKJmJV7vghc= X-Gm-Gg: Acq92OFmeGwGNU/oH/wviSJsLpwkaQ7iXgBzaSZacNZI8SmCxmqcWFBIYFykmoZSIlK +WbPrFRQg1i8j9RqOZm2FoPdDLG/BLmcDjreK5GfpbbI65a7jFOqZCimRfWLsIv1AZNjDgE0wys vxMW8hD8G8MAlNpdK834ixVAfIqZzCOIb4d8B+XjCYlIx+tbMPunmqZldVvhdsYnOFIa5GsjDb9 JMWZB02pG3cJJkYB8WVXiXb1KkjkrkU5noI+QTJiS6Cmd3ZbKjXB0Nv40skEXpB16htPpZWI730 /p0IY/i2TKx5Yet9Rtx5HbEXMgQmNnGPQkKKdO2PT6iOSHpx8gNS2Si4FOsDo3rzwqIryr4W7Xn sZ/Mb2SiKH8tYaAIvPYGqvbg8TjyJ56UOVy7hVEzlJ6LY6ttE67Sv4lJkpRAxrX5tKQ== X-Received: by 2002:a17:903:286:b0:2bf:2369:a131 with SMTP id d9443c01a7336-2bf368786bbmr73823585ad.34.1780206951168; Sat, 30 May 2026 22:55:51 -0700 (PDT) X-Received: by 2002:a17:903:286:b0:2bf:2369:a131 with SMTP id d9443c01a7336-2bf368786bbmr73823365ad.34.1780206950734; Sat, 30 May 2026 22:55:50 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:50 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:39 +0530 Subject: [PATCH v3 5/7] media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-5-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1365; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=J4ckhmDMHxWwy+HpYLt1Dv45ile/JlEk5pzQRopA4mA=; b=nkOUzQg7r0oO4vvuYLPQyOBJg/0FtKpEBP+kJyu7DUXnzstucOVW24t5WDBHWnhSrroqr2Dv5 xGkDPSOY/kVCuhTp4Qf59ARpmySmvvs/VYu99Ee2p93zAZgDKr76ey5 X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=BaDoFLt2 c=1 sm=1 tr=0 ts=6a1bcd68 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=1vCIiHQokKioWWC5pcsA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: kacQnLzg45fGROSJCi2yRxWK-hTWbgRp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfXz3d6FK5Fo9yw U6CaFC8G9l1IwBTl4OoM+BhzaEnr702cD9BHDaMSBUh8vkqByuWbpF50qW7H84M/YBhdntukX7T QcDcyBU9aoupXJhCR+MaqDI8yKQ7BynevuDOB5KM7D3ezGFPqYfzYww7Zd5mftj0XoBIZwNuC67 Rrj9OWWhz0R56KW9fs8ODWOmyKHSMPBa2U9NEv3AV2rsD86vfigqWlG7lkUwgrFmOMuxCx8p2pS QA0Tm4Or6cIBmOfSSdomRuP3CwZgqSe3bL4FilqKkA7UPKiK+mosuWTNF4dSr0LKoZy8BttPdrP /52NdEf93ecN5cXWSVOr5WSKANjMqW4RoyJuHCUx365e1UyBDXpz7TqZwb/6A9GrzpNwwa7F+hi C+ymEaXRXilQctvezUSnIYzL0CFMPRMbnoQlR1LFXl3r1Xhjuw/VznWnMSW0nkYaaLGa/lRTVAG RvoKVi6YqUsyhya6hjw== X-Proofpoint-ORIG-GUID: kacQnLzg45fGROSJCi2yRxWK-hTWbgRp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal HFI_PROP_OPB_ENABLE/iris_hfi_gen2_set_opb_enable appeared twice in the dispatch table, causing the property to be sent to firmware twice on every config-params call. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index fe67ad0ffb4f..516bc468c72c 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -623,7 +623,6 @@ static int iris_hfi_gen2_session_set_config_params(stru= ct iris_inst *inst, u32 p {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate = }, {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain = }, {HFI_PROP_AV1_SUPER_BLOCK_ENABLED, iris_hfi_gen2_set_super_block = }, - {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable = }, }; =20 if (inst->domain =3D=3D DECODER) { --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7964A323417 for ; Sun, 31 May 2026 05:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206959; cv=none; b=qW9kScX12zl9aqOrLOQxREg9vbOgXAh9MFTOd+cZd+uzLyhiHKzao4JlqaFeRnbQgkCsUaZe4Tlyd/H3Tj2+ozRGdcn3TyUnRsViu9Rpzw696PQ9a1/jkwEVSpN29M7J3Kk1ei5MYQPZD301558XdmsdGWfNqSSnRImAQ19Zyh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206959; c=relaxed/simple; bh=alP24qX7DhfjrijXtmZLs7Pqi9WftD4XbQsop7LdBKw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bVHSCPVg7dJfbHDuwmh61Cn/jyIAMQOb+8Q5sxlqt+Kf504R+QLhX/1TRQCZnMckrdS6DANG0IXmqN8MWP1YiYg/a3epLMl/5IMOw/lR3Vm9lMxhBPkCH+tErJAX4JXYXyNoflwqV7Y4o2EO9DIoBlr7Kuoxx3yrlz1m+BVYGF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SQKNiB80; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DHm3DrXc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SQKNiB80"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DHm3DrXc" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V1RobS3903749 for ; Sun, 31 May 2026 05:55:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U3Jm2LCWMeiItYyzNb5FlmstRZ2VQtC2wNQk+gG0Iig=; b=SQKNiB80V217qYVT 34PkLP4x6Uk4GzCGcfFQREvAKzBDSfMbPBUaszhQdrbvRef5U+ud6C7hAmeqZbEm H3CtBIZ6DY1Rf5jHpoNMvnkiFyIskd5xzW2SXTM8nU5WpLTkA5QAe1NjCYbeF4Z3 Y02/+j/AfT+yN2CdA+dXmIAj54SojHzSe/AFS7ppaGtV++W2XFGJyR6po56MpwiD Jr8cEQVuddHSwf6QBIvRDs4UdBHLCgTzR4M8FYShJ/a7msMYFRCa+yCxIG3OlOyJ 2T4DOCz2zj5BSaaF7H6YqRAFsGQA6WKAtirvlufyZ1cN9uUymwiBZxO4qBXIrj8C /PvF1g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efqfxtxc1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:57 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf1dece2ecso25116735ad.1 for ; Sat, 30 May 2026 22:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206956; x=1780811756; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U3Jm2LCWMeiItYyzNb5FlmstRZ2VQtC2wNQk+gG0Iig=; b=DHm3DrXcukmwIlyq5dIrCtTSNEeS1CdkjvNwmguJGBhrHl+DtDIaBlGVmeomfGIDiR OuRoEmIU5UwbIezlj/uHOQMWCDh9UBbuxt0R4zm0KbNqIbfK70DJliYKvZnz4GlRvI6U 6tcEEfNIuDG/iwBF8BGwLY2be8xmHG4GclrB5SWHlszgQfvqVxXnAEDFL9vKgBhlVe7i nwTYYbrVIqMItrQfZ1wY8ii1xrSiNfaA3djwz/55+LVaM0fMoQBFBkxCpato3gsrz9qJ ZIjSVKmwu0IxClJ92TmXGLPA7IJc/16V2P+jKWQt8YJDpDA9FPLtqcBUzjbOWwM2ZeSb mxvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206956; x=1780811756; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=U3Jm2LCWMeiItYyzNb5FlmstRZ2VQtC2wNQk+gG0Iig=; b=tEJ+m9AJqY1FSjs7zOqNKuW9YHYPWzzoYfmlpojRJYoZzP0M17jlT4fUzy1goU8+hU P3x9ZhC8QMETJ8kh0S4bHecHSNyRvXO1OYyxksa8Y+ENnL8+Leb7ggYtYSQ5SLcHFwAW hThetQXvB3dSPZ8kbOSN5KG+qzlmnkp9agRytfIVodetoYn43qaa/ITaMCnHvCp/EVuh kR7QevMcV3oskZYQCexAASiq+IM3YgSBzdA2Pad/KY97Q/jFwH6fnGoU/Hh+AcJQWbgr FKc5Bv+mBlcOqKsQXaHrwv5s/enqKZMxc7yr09LoPY5eiofcvjyShaYnuBK5GFlz3Fo1 5bJg== X-Forwarded-Encrypted: i=1; AFNElJ9tUqMCZABh8E8dzYXZcZ8l6fgWb0WQz6isH0AAk4zcPz6b8+LXBlk2fwvU8KOk03s4bsqDIwbufv4XuwY=@vger.kernel.org X-Gm-Message-State: AOJu0YwWHfyXBPEmEtEq99OJl5B0hneIYILvveIeR+ABICf8UjQi3I8N QFsq3Z5y8qj9GQ1rrjMec88InwPUN50wIYHMO88IdJVsnHKSqZTc2m9H6qUXxwmgi8QLGI+4hBz BodFwrYVtKHSIu/dRIaTjZuEfZf5zANxr4L6lG6j0oH2fBYYZtRQ8CobDZaTF2VazF/4= X-Gm-Gg: Acq92OGX2hB1bjg95xqeTUUYmWBAo/zG0sCejUhV/PARHjXVxwM8mpcEPYtzh6aJKrF fjo3MWCpkNNHopH2MSsmDqbyDN9583OCB5JEpcEkh1jzkRkGULCauxpE16GntXXv3o8nc04fKhY t6ept5JU2/8FRYKMrHo7VOfOsp2R4fvsUrL54lmeQq7UbF2rIpAy3c/aiLIBoIgUFOlFzTe3h19 YAYo2XVSfpAh1uEjk/TKQfqZ6NLuPMqCVJQYqLUqpQZBhsgtAyiB5IDs1qh+4NKVBMCZoFM+asH wfoM7mw4TOkA8fsipPWJNLIgtmf9XdyXVSAcD10myTBvXXTjz3WiSDCi3/sB+vtB3pwHGa/INFR 16DaLOTVEQry6a37kBx/T+TbFfQa7qgVKql0Z+QeBaUuljZWOlg8MXjtv6zRY4a4ghg== X-Received: by 2002:a17:902:f610:b0:2c0:c389:d99c with SMTP id d9443c01a7336-2c0c389dd89mr19582595ad.15.1780206956097; Sat, 30 May 2026 22:55:56 -0700 (PDT) X-Received: by 2002:a17:902:f610:b0:2c0:c389:d99c with SMTP id d9443c01a7336-2c0c389dd89mr19582295ad.15.1780206955617; Sat, 30 May 2026 22:55:55 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:55 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:40 +0530 Subject: [PATCH v3 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-6-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1008; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=Epm1IKP1y3YypBiDQmS8q4B6XeOav7jYm04d3gKp/TE=; b=NZZG5FNBcf9RC63vZ+mr1u26VmtIZoWhEUGQ2riAIUczEpgPpkN1sT7pqGBNRNVJzLGOLvao8 IWd9KWIvoWrB5kpvr/aOCWN3HqwBCEog3lYq0MpqGJah7zPqZV0uQ5m X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-ORIG-GUID: rejOAP-Nx74N_IgITHVczjokJ3u1F06n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX4FrSWlHuELxf qsaRSqibuAvMyOJ64SHXaH/Pjcoa37r60hYFZMDQP/Cehbr+0vy4S/ZJTs90UmVKkc0/++zgg+s ealEbCev/eqCcWKDPiZvo4wJBZS0Y4kHRpkbNG/jgZm3o1ebKEbRTcq/zYHpowaaS93aZJDmYKV tozfX/5s25Ngtr4PGItkg6LSc8lWgxtpYAIRbPTFbPGtwFlYfqRPaTSv8IKcMevb2G/OZfMql2b +oNSxtTy0MN7Bl5e9EnwHh7g06CxA8OyGqLy9PGigsBnIQU1X72j8DpQgPD9BRjjD8AcIuaYqjx XDUYB2ev4Azz4GSHNxD1Yz2ZQboDnV9W9IyeYdBhIu4l8HAtEUfC28oHrw7XuGU7ZL1oceJLTx8 KQgKjq5lpFU5PmZNxdrcTwfQrxh2WX8gUSXo4pL3vIlZEtPf4LoCPAXnFSyieXsKpK3YUmQEVZx jHbSjpeq9fmWtJE1gJg== X-Proofpoint-GUID: rejOAP-Nx74N_IgITHVczjokJ3u1F06n X-Authority-Analysis: v=2.4 cv=Zq/d7d7G c=1 sm=1 tr=0 ts=6a1bcd6d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nqERTrTL3htJ2auDmasA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal Without the break the AV1 case falls through, risking unintended behaviour if new cases are added after it. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 516bc468c72c..1d21ddd84f41 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -696,6 +696,7 @@ static int iris_hfi_gen2_session_set_codec(struct iris_= inst *inst) break; case V4L2_PIX_FMT_AV1: codec =3D HFI_CODEC_DECODE_AV1; + break; } =20 iris_hfi_gen2_packet_session_property(inst, --=20 2.34.1 From nobody Mon Jun 8 08:28:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A13931E859 for ; Sun, 31 May 2026 05:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206964; cv=none; b=S6MIpKqKUOl6C2ZcbwQnwMCI2uy7IicFQH1sFeTzXdaSDW4ZEBZhfUHMEctWzzDaa+lVDblFLSunk7tKY6/XpEB/gqOqFaFaaV7+VBIZmDe+GtPnXNOaxFY51hoFQnVJWO3hsmRVDiW7KO7z+4gRIJV8dKQBgrmzz7udtE/RjGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206964; c=relaxed/simple; bh=dfU6+dokRmdLHFqF1O48cBLlUXiRI2PArZA5+lK6pus=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=scVtyh12pokprmDPrlcZwoenkVavkbjMWnq13CBexzFDEQySf1HhT0XIr7sOO0o6aRqT8i36dgI5j50vrTe3KtBMWXgjzYwYRb/fRylcjygABHG+o/fZmrbuHdtKa2KNpOhO1FZOsP378ZADLktpVOhkC7dMUjFVArvYk7vqvvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pCOD7ycQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RaJtn0zH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pCOD7ycQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RaJtn0zH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64UNt2hQ023799 for ; Sun, 31 May 2026 05:56:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u5VzfpyDmVjM775VKxwIpIo0dFf4yb7OgSjGOH8Q/3Q=; b=pCOD7ycQM4pDCl5I Ytn/zrgRMi5PBiJAk+AS+UGW9BI9dfH6MLeVDajCQlEkIebBG3hUTyCYusiPC9j6 EezxCPQnvXgGW1wHjQCobNljjT/siEUlOmkXppi79CDPk4yLL9Gbw3rl7XX9zKIk jzBKJmZgpgc/+djaF2NyVHNZyc3J3kJqhBjUkwrcI7oKi95EPkKJw26cyFVlprHC w44gOa+TaJBp//RNRfY0SHOrPr97JbMKPEI3AZlcvBdwRY0cVvtyRJyvOZvp2sP+ hoD57QdmmJ7J6V9tcA8dhbHGZ1OrcSyVBPhXCLbQWONrlqa2jUeCD8tKiLuMEcPq +qyN6A== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efn8pkf5w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:56:02 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2bf0453031aso44196115ad.2 for ; Sat, 30 May 2026 22:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206961; x=1780811761; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u5VzfpyDmVjM775VKxwIpIo0dFf4yb7OgSjGOH8Q/3Q=; b=RaJtn0zH9mfcS+3MYaa5va7x4VA1yniNjlPmipVKIuWW7dAvDc0UVnkk/1vMU7UKVq YGseIofUak3J3V3GVOOop6hY+kxoGAxRU3a30Ec6jYR4Y+i4LE28eypcn4PlMZyt07Hm vEokxZ75v7IxFv3RkZGd+GRn/BRTOJUuPVNs2lEHE8lAmirOjYfJUnvpIloaqpjxu/uz aRwGzc0Urn64SJYJ8i6lkS1pFhoL8hIrRrMGfii6RrX+mazCPryJm6VnnQbvLDbM3JbT nBgSHtWomkQddA1/sIUK74Ig+KCEMaVsMr5/FLkO7BmEviXeiCSzLsgfvtr9cfloJkUn pnFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206961; x=1780811761; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u5VzfpyDmVjM775VKxwIpIo0dFf4yb7OgSjGOH8Q/3Q=; b=b2mUg4mVzy2NueY9CpW5/SvOEEHTAF9MQcin9DOqFe1/YVgU5AEZ2fsjfcH3Tm3R4E 9Mwqa8t9znhAyy+J1fqeKiGYeZooq6vczgzmY4uaTmU9OUQGhhvgRXqJRAqfwYsrDJsE /HBhZARiQaQQaLJk1RH60s/DlTNqsGB4K/z0sVpg8qVnxUdcF05LBq8ptPtRc4tojH/P iGzO32FxCoXlvrHA7SvS+t2ieXE7c2sgzrxAflIgpzRn2IHtLYhahWI5+qizDVukstby KIBzGC6CEM19fPxLVm9U+H913Jro1kISaDprjv+x7aIzEBihE0jLctt0bWX9jZzkMvpP C1ig== X-Forwarded-Encrypted: i=1; AFNElJ/C7Osqskv0lUOHDyBNZD1A5HhrtFFrwk3897C249C99ibBIIxj9qFOv399TmlqvlFGvYLHPQpHY7ywcPc=@vger.kernel.org X-Gm-Message-State: AOJu0YzjPYYs5iBcdvjk2oiU/tWskMNsuhA/f3NwkJXN4fmaKngSdnTl j4UaWfzC7wx6IBelLsyx4tVKNdI8oiub9NE69mj30VPJx63lvHNLQ0ir8ctKzPgtw/SQncaiZO+ f9qHGQ4SLZLRGj0PcNtYgrdnPp6vfw8N3yb2R6vmEt3uqkcovQb7hTKXISbmy/pf2Bfs= X-Gm-Gg: Acq92OGHSglWsscdd4cqCuODGJ0rLZe9lwa+xMkZhQcRpD4rD9usUidFQZ6ZHWW2L1P yQnUm33/Fs0ozkU3LIqfLNmJsFhGBSN2NcyJpf3U6F5pe9BXRg2JC8Ja8xvYuQygc/lvVrV4zCB qmquD098SdupNSh4PCaCEKT4uvp4e524mOYcfht1loafKSVxVyLMrcnCVteJyqB9P8JOZ7c6iI2 qQSakZVfAmP1MOO9X5zkHpaXncU2vexodkalYtYH//XVgl1+jOazN0cVmy8Ifqp+44YQSEjQ6vn gGG9cesFZ51VSOrfurI5UZcgvpnF0+ugCpCKK3fsA6ozaNo0a5Y1dtL/LMsBMcrYKqWi9cn+5SC ytuk10ntzhfoaNfwKl1havK/bZVMFTkWuJx9cmu6wM5VVF5yza1ZVTgwVkhK3kEVYow== X-Received: by 2002:a17:902:e749:b0:2c0:b4f5:41d4 with SMTP id d9443c01a7336-2c0b4f5428bmr35522395ad.41.1780206960989; Sat, 30 May 2026 22:56:00 -0700 (PDT) X-Received: by 2002:a17:902:e749:b0:2c0:b4f5:41d4 with SMTP id d9443c01a7336-2c0b4f5428bmr35522215ad.41.1780206960547; Sat, 30 May 2026 22:56:00 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:56:00 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:41 +0530 Subject: [PATCH v3 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260531-iris-code-improvement-v3-7-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=5062; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=4TfJehBE92h1hmWIguFxpHCkAJHvwkJ4iRehblWu+mA=; b=X/pafYCT4rNyM2SQ94vqgs6EbNJDMQ3yis79ZD+UWKFyo95X3v/T3/xiWqKLDBOwqhVf3ZgOn OGUb19o252PChB6BS1VZzGHfoCV5fWqFsmDMPgnpqDcmAoxmOi+z5eu X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: AoDE_qeLP_tAtMoljyi7HAjO45vQlRBY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfXwBnyGhwjQALZ jSLNnxEEKyixzt4A/4U4PNdjuMs54TYLFZ77xaeTXSTXEm8+ifmLLr5LdoVLE5AVa1MKfoRmrIk Kg0jmnAqA7m1xCZ3Djr+NyvsO7YARb7w7zHQvr598ez2YZLEslVxkrwvB4tH5hCPu2pMvC6WqGI UAxEB9haB5bJNWsB/oFFxxm6IuEFghmX7cvz22aKK+Q1510r0XQsbMz+UGEHlTJLmNb4kvXmp3K wCl4Rpik7snoe9Qx5ejJ8ViMj6qdqfb+FLgp8eFPkIfIevS/k1s8YTl8twLiMfecN/w3rwtoO6Z wghR9vW9r64ka3/iKNQLI2HQDapbk+7Hl4h/qYtjv07pab8HZ3xdAa33m6uwJurtliuikhg+g+m S/OejKaimsEFas9cZ2L79NAS2q7Z7Y/AgKaT0/HGa+luma+R37i8CyWxx3fnI1TkJzztjds/a+b wc0ubQPQq3PaLOjXgWg== X-Authority-Analysis: v=2.4 cv=NvvhtcdJ c=1 sm=1 tr=0 ts=6a1bcd72 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=CWBAsx5YQZKXPYp8bPkA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: AoDE_qeLP_tAtMoljyi7HAjO45vQlRBY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal iris_destroy_internal_buffer() is guaranteed to succeed and never reports an error. Returning an int is misleading and forces callers to handle a meaningless status value. Convert it to return void to match its behavior and simplify callers. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_buffer.c | 16 ++++--------= ---- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 4 +++- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 73b4d3381e47..2a4a813c9c57 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -455,7 +455,7 @@ int iris_queue_internal_buffers(struct iris_inst *inst,= u32 plane) return 0; } =20 -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer) +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer) { struct iris_core *core =3D inst->core; =20 @@ -463,8 +463,6 @@ int iris_destroy_internal_buffer(struct iris_inst *inst= , struct iris_buffer *buf dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, buffer->device_addr, buffer->dma_attrs); kfree(buffer); - - return 0; } =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) @@ -473,7 +471,6 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; - int ret; =20 iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 @@ -488,9 +485,7 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool if (!force && buf->attr & BUF_ATTR_QUEUED) continue; =20 - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; + iris_destroy_internal_buffer(inst, buf); } } =20 @@ -500,11 +495,8 @@ static int iris_destroy_internal_buffers(struct iris_i= nst *inst, u32 plane, bool else buffers =3D &inst->buffers[BUF_ARP]; =20 - list_for_each_entry_safe(buf, next, &buffers->list, list) { - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; - } + list_for_each_entry_safe(buf, next, &buffers->list, list) + iris_destroy_internal_buffer(inst, buf); } =20 return 0; diff --git a/drivers/media/platform/qcom/iris/iris_buffer.h b/drivers/media= /platform/qcom/iris/iris_buffer.h index 75bb76776182..ab8e5d953101 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.h +++ b/drivers/media/platform/qcom/iris/iris_buffer.h @@ -112,7 +112,7 @@ void iris_get_internal_buffers(struct iris_inst *inst, = u32 plane); int iris_create_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_deferred_buffers(struct iris_inst *inst, enum iris= _buffer_type buffer_type); -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer); +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer); int iris_destroy_all_internal_buffers(struct iris_inst *inst, u32 plane); int iris_destroy_dequeued_internal_buffers(struct iris_inst *inst, u32 pla= ne); int iris_alloc_and_queue_persist_bufs(struct iris_inst *inst, enum iris_bu= ffer_type buf_type); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 83373862655f..e6fd38ad8e36 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -442,7 +442,7 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir =20 ret =3D iris_wait_for_session_response(inst, false); if (!ret) - ret =3D iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/dr= ivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index c350d231265e..917d2775612c 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -447,7 +447,9 @@ static int iris_hfi_gen2_handle_release_internal_buffer= (struct iris_inst *inst, =20 buf->attr &=3D ~BUF_ATTR_QUEUED; =20 - return iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); + + return 0; } =20 static int iris_hfi_gen2_handle_session_stop(struct iris_inst *inst, --=20 2.34.1