From nobody Mon Jun 8 08:35:57 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227D426ACC for ; Sat, 30 May 2026 22:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780179905; cv=none; b=QOMl1YB0A4A4ZbnnUfCWtufB70NwvNk526k6CYml9vqeLz8NwpGyjMetqJ3g+p1FAvWas6JSgzlO4SFlDLUUkc7slkRGqpQIx7jDGSWsjUdA7oT7sZSxpLt8krkuhrrNBNjWwIPERwhhHCDS9qJ7i+azY0pIPGUC/U4pD/15090= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780179905; c=relaxed/simple; bh=irRS0E0WNpV0JJa4KmvA6GS2V1l8IcIewGxGelaGXw4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=k2HwTQb4+ZURK/j2MwRmL5EJuF7lVw7KU9yWsewddGqQs5EgD3+/Y4+GPzIgAo24JA/pcpe8SGesrIsRAC6qR+T3bgVQdDkO6ua7hZBVrBOEC4WN+0JhXl7ws61Bk4ICNNPiMs34AxUFtwpcZOvjXoyFO0WXd+tuaJElh/dp9OU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=km8kRd9O; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="km8kRd9O" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-137dd51129bso530067c88.1 for ; Sat, 30 May 2026 15:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780179902; x=1780784702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=16XrvrNvVvEtWVpkr/gib/lTKnAIl2lm3W0ZrZwaDCw=; b=km8kRd9OLonpLT8KQl8BLQpAJ4riXvpO58f+LSPunObBas+lO/7StyoEiJlMy6k5A4 Vc5eqFjM3trX7U9AG8PD0VsPRtuuwrzUv0BBiqGBoU8bZV0mwYU5X/k8p+pXW/lPdb6s CRkcUtbPNd42SkK9Zk+z/yxdyPNOW77/ayIY2c3196UqUsi8R1Xp85tp3TVGk/w7dmvt 9CtcYsf3cuEFm5KoduEDDwiNG/nl1Grqw+DR5GPkGiZcM8AkJC0c3DqqI0ziF1M377Ix RpP0I2IhqKjWKj0ChPR6rQw1HNst9D+kjzF/4r+aa+QgGOV3QCyUgQMrc9fJE9VLD3Yz P1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780179902; x=1780784702; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=16XrvrNvVvEtWVpkr/gib/lTKnAIl2lm3W0ZrZwaDCw=; b=UBImZr12QSa6Ud2NvLpjuYMIZovfxlCgLBhAWkIL5IWrZ8N6BQu9L3+OZFCTrUGk8A 7qgEyWe34PVGHOpER2UPevFEEdYkywvnKPUfO5nGBXVGGYvOIJtGkui/kwaNWDG3QxOh bgHV9kZJ5h+IOxaUhU0HF45QaUcK7jJekRJYFEb9JNnRTo/jecanR5AfQG7ZJPU/apui Efb+mA/qDUuVvUILWr8D1k5wHEzWnwubZDzkrXB+26K7MD8UysKV802Mz1SgAYnWTaJi 6T998whVcOv6JbZGASjGPbQBso4clBfUb3Ko+I30mG+fsncMVMl8UR7xSLHiNHF68eV9 1/cg== X-Forwarded-Encrypted: i=1; AFNElJ+xOVXP3Yb8WoNLz8wg85wyyjowAl53lZwpihWb3q4lQxathNsIWRcqwubdB+dF+vHrs7r7E1SlI7Oqtz0=@vger.kernel.org X-Gm-Message-State: AOJu0YwEs8qTd/VKGSUhJrSxI4n3rVHA4qHn82MeINYGIlThuwFCE7RN ZWDV2Jx8eTEFLT+5XJ45c2ARqZnNjXR4JEUkwDpbmSj8lxpuTKTspYRJ X-Gm-Gg: Acq92OGF32UqrQ5cMT9o26GLLzLE/IdZKPxX/FGs3jB4xL4HT4eZQo5qcDozY2R5SJJ DPN6sWwo5MrMGi9CkkGZleKFAxpH/jvWvvM9hSVBSIWixu+kzd/f6OK1YW8daGVyQ5D0qEO7qnI YmsWZxGOIPYP2rYx9pleyuq5ftTmSMIGRHce/CCwmQE9hIOWIn4npoUoZiTbRogIDlvVufh5CnE R3/NQjhg83GInTLv0R1lP/yE4hrnyPo2yHp/hJ1IPjUnCms0isY+Wg6mva5nk/02/YX/az1pW4I UlaUU5Hp0lApP2xU9QP0bfKdzQ2poH0+19TYND2jhVW9F+iEcW5V1f+WiNfxfRaIbEUNLYig/55 BdUZTc64Tstb1xOX3Y2J7PWAokY3S07KiHpk4Cx7/1AIlcSkXHgu325yOEmkhvlA4fGKbUSj6ht hiYNN9DfgAvHUxdRs3lIqBO6qo/2Jej6OEFfdMCpiAuT1+2YE7X/rmz3eRxKuLm97eWw== X-Received: by 2002:a05:7022:11f:b0:134:d708:1a24 with SMTP id a92af1059eb24-137d412366amr2418768c88.17.1780179902065; Sat, 30 May 2026 15:25:02 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137b3d8f839sm3558661c88.15.2026.05.30.15.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 15:25:01 -0700 (PDT) From: Hungyu Lin To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH] staging: sm750fb: remove duplicate init_status structure Date: Sat, 30 May 2026 22:24:32 +0000 Message-Id: <20260530222432.4303-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct init_status duplicates struct initchip_param and is only used within the sm750fb driver. Replace the remaining users of struct init_status with struct initchip_param, remove the duplicate structure and eliminate the unnecessary cast in hw_sm750_inithw(). No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/sm750fb/sm750.c | 8 ++++---- drivers/staging/sm750fb/sm750.h | 12 ++---------- drivers/staging/sm750fb/sm750_hw.c | 16 ++++++++-------- 3 files changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75= 0.c index 89c811e0806c..5986dbef67c0 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -844,11 +844,11 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev= , char *src) =20 swap =3D 0; =20 - sm750_dev->init_parm.chip_clk =3D 0; - sm750_dev->init_parm.mem_clk =3D 0; - sm750_dev->init_parm.master_clk =3D 0; + sm750_dev->init_parm.chip_clock =3D 0; + sm750_dev->init_parm.mem_clock =3D 0; + sm750_dev->init_parm.master_clock =3D 0; sm750_dev->init_parm.power_mode =3D 0; - sm750_dev->init_parm.setAllEngOff =3D 0; + sm750_dev->init_parm.set_all_eng_off =3D 0; sm750_dev->init_parm.reset_memory =3D 1; =20 /* defaultly turn g_hwcursor on for both view */ diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm75= 0.h index d2c522e67f26..81fbf32865c3 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ #ifndef LYNXDRV_H_ #define LYNXDRV_H_ +#include "ddk750_chip.h" =20 #define FB_ACCEL_SMI 0xab =20 @@ -38,15 +39,6 @@ enum sm750_path { sm750_pnc =3D 3, /* panel and crt */ }; =20 -struct init_status { - ushort power_mode; - /* below three clocks are in unit of MHZ*/ - ushort chip_clk; - ushort mem_clk; - ushort master_clk; - ushort setAllEngOff; - ushort reset_memory; -}; =20 struct lynx_accel { /* base virtual address of DPR registers */ @@ -102,7 +94,7 @@ struct sm750_dev { /* locks*/ spinlock_t slock; =20 - struct init_status init_parm; + struct initchip_param init_parm; enum sm750_pnltype pnltype; enum sm750_dataflow dataflow; int nocrt; diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index 34a837fb4b64..54c1b241ae6e 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -66,20 +66,20 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pc= i_dev *pdev) =20 int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) { - struct init_status *parm; + struct initchip_param *parm; =20 parm =3D &sm750_dev->init_parm; - if (parm->chip_clk =3D=3D 0) - parm->chip_clk =3D (sm750_get_chip_type() =3D=3D SM750LE) ? + if (parm->chip_clock =3D=3D 0) + parm->chip_clock =3D (sm750_get_chip_type() =3D=3D SM750LE) ? DEFAULT_SM750LE_CHIP_CLOCK : DEFAULT_SM750_CHIP_CLOCK; =20 - if (parm->mem_clk =3D=3D 0) - parm->mem_clk =3D parm->chip_clk; - if (parm->master_clk =3D=3D 0) - parm->master_clk =3D parm->chip_clk / 3; + if (parm->mem_clock =3D=3D 0) + parm->mem_clock =3D parm->chip_clock; + if (parm->master_clock =3D=3D 0) + parm->master_clock =3D parm->chip_clock / 3; =20 - ddk750_init_hw((struct initchip_param *)&sm750_dev->init_parm); + ddk750_init_hw(&sm750_dev->init_parm); /* for sm718, open pci burst */ if (sm750_dev->devid =3D=3D 0x718) { poke32(SYSTEM_CTRL, --=20 2.34.1