From nobody Mon Jun 8 09:48:07 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B37CE272816 for ; Sat, 30 May 2026 03:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780110133; cv=none; b=XBFEFzzmT0ZPkNuWKZv7k4hyE5EQAbtiNxwUb8AKjN+pKSAZeCJdtt4Emiav9Uhata6FoTyLJu9ehY/2WX8P9yNsJQ8aZYU/nh1OXI3BW1zh/M9KSgrHdKmVHMjedPOX6YvpJZcWjN2bP0eEQ12A4+UFBnamoW5kZNp7TmhBfm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780110133; c=relaxed/simple; bh=6MC5Z+CZeXHDlr7J2cBLTyyetV1DPv3+TvICkqCetCY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RaHbMCmaqh03SypmvHsXXrc5mSwZMmta5+AsJSN3UJw0qTWTdv4pONKSykfShn7Tq079Iy61wUXuFnm+3rUvWeliAICi8voXKqy7COqVwFBGKv8BP38NM7DQ4ttIoU8G2PAGvGKrhwIusSl5JEaep5hyYZAtrwPRLZv7pz4XynY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aeOcj3Nt; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aeOcj3Nt" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2ba856db1c0so104817775ad.3 for ; Fri, 29 May 2026 20:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780110130; x=1780714930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mwp5qGHEC1XkmLGeEsXpK32Xm3+UL5wsm4s/A2RF7JY=; b=aeOcj3NtfbwBIvyokSA33s8Z1KhRS5rMJah3sJPtLjjTqrfP0hXwShR7TbR/9mMLHh PTfL8BaiHHNc+fSG9LXIwW3tFgMuhJY4ju+euxZyIVo+mun28F5aeXUjfBRR5+Q7MW5F Gk6dLwi0o9v9R5FKbIQcbQHbDFQ1HsLHDZrqyuSQ3g7kQU6hE1whw+SGjSKhKG/FaQ53 PdONyIEQXvx+XkBHt96p1QPpRYrMDbEZ4Ovs+UfLOXI+xbsY4WUYN843CSFnfjTDlKZo mQZkRggwaRH/jgxeBsUSDgWshyANTwGL+tOpZtkxcvmhBSrBs2hM2/X3SNXJrPni+fQ8 B8IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780110130; x=1780714930; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mwp5qGHEC1XkmLGeEsXpK32Xm3+UL5wsm4s/A2RF7JY=; b=T7reJBfwG/Y3FlqB046ax24ECSFDQSS+M+HoBqcPbHjNr8dbIbUBGAclh18VW3xtEg kvEazox+o+E3nt459TzK4Xi8yJ9zUaFTb0RZY5WxgIOLYaTRnUQLZEkeVNIO8vsg/7D6 qGwRZXN58hL3fbPXOopRLKBvYhUSCp1f0whYAm8SaPI0BCwKdEnqENCVrk7Iq4GkvRq9 7XOXq9aNKCNaQNRE8tJTHLuDJzhM29f+OUkzq+RSgCTrR6JcJ8j5b5bSQshI6w6BqoVh tnu10R91SJDFOVN3WSlcKQATI0sLQSJNfOQ0w/Di/XOlPG+vn844q2S7qjZRsAMSSkwu 38CA== X-Forwarded-Encrypted: i=1; AFNElJ9z9ukiESKycc0E14hiZmMDDQOKdGC6haEdX/YfAIWaAywyhsrtbdhAnpHy3gXrqJrWu75D+VCqR5XuDHc=@vger.kernel.org X-Gm-Message-State: AOJu0YxOq8eBlYxqr1sAlveDWQq1vhieFbdzCURKIUzSBOIJMJk0UF0y NGMB9xPye94JH6IrXiMa4lOx6qramNPnTS6GIN+C4oiAZk602kTHOP+F X-Gm-Gg: Acq92OHgLs1B9R0QKq6vtG6QMM0eCS0gSLKPY97fROLMvJTOiqe9xMXyFj1tXNO0yy2 gUw6xWy0s7gtYacjYpi6gurotZGYlmsiTmDuYeULJ7nMddUQu7PCI1nPFzUEVefEdfJVim9YVPz DXdZUCpDSBJedH/GCPueyA6gTMIR5zJkfO34FUhntTyz3hTRGPlh6AoUBOdIrddfCKayk1bb6P7 0hADB+JvUdfam785t05A0l8J2O5yihpUXO+pTPEq6z/cE3bvjigJpbfYviBQD54RezOXeqhzTsP 9LueDnZu3MMG/wccsA5ze9/k5si/FML0Uw6O7JuXGJCa+6yYdcW+r57CsEwBW6/y8S5tcXFQQiw UFYz2vke9fPSZY+VViYRyDD1gndSXSmQ5bZEKQ7EcMtipZVYfXfDhVkjnDr5hoSQ+bhEWb3r75+ t46gqGUvC9bRy8oPOhnlOPW2/MMoqJEyccWW5qlwBkUryadT30vP49k/+SG+mGrtDYHSutYnDRs l9cuHFK561ZkoWMXlTMbCnSqClLiprmhzR9EyiAauW9lA== X-Received: by 2002:a17:903:41c2:b0:2b2:6df1:1112 with SMTP id d9443c01a7336-2bf368d1b92mr27176235ad.40.1780110129873; Fri, 29 May 2026 20:02:09 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c26b3bsm34958975ad.64.2026.05.29.20.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 20:02:09 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] bestcomm/gen_bd: fix out-of-bounds access in PSC parameter lookup Date: Fri, 29 May 2026 20:01:52 -0700 Message-ID: <20260530030152.49759-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bcom_psc_params[] array has 6 entries (indices 0-5), but bcom_psc_gen_bd_rx_init() checked against MPC52xx_PSC_MAXNUM which can be 12 when CONFIG_PPC_MPC512x is set, allowing indices 6-11 to pass and read past the array. The tx init function had no bounds check at all. A malformed device tree with a large cell-index could therefore trigger an out-of-bounds read. The garbage initiator and ipr values would then be used for MMIO writes via out_8(&bcom_eng->regs->ipr[...], ...), potentially causing out-of-bounds MMIO accesses. Fix both functions to use ARRAY_SIZE(bcom_psc_params) for the bounds check. Also remove a stray unused 'struct psc;' forward declaration in bcom_psc_gen_bd_tx_init. Assisted-by: Opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/bestcomm/gen_bd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c index 61b5746e1a97..00dfdc4b8eba 100644 --- a/drivers/dma/bestcomm/gen_bd.c +++ b/drivers/dma/bestcomm/gen_bd.c @@ -321,7 +321,7 @@ static const struct bcom_psc_params bcom_psc_params[] = =3D { struct bcom_task * bcom_psc_gen_bd_rx_init(unsigned psc_num, int queue_len, phys_addr_t fifo, int maxbufsize) { - if (psc_num >=3D MPC52xx_PSC_MAXNUM) + if (psc_num >=3D ARRAY_SIZE(bcom_psc_params)) return NULL; =20 return bcom_gen_bd_rx_init(queue_len, fifo, @@ -342,7 +342,9 @@ EXPORT_SYMBOL_GPL(bcom_psc_gen_bd_rx_init); struct bcom_task * bcom_psc_gen_bd_tx_init(unsigned psc_num, int queue_len, phys_addr_t fifo) { - struct psc; + if (psc_num >=3D ARRAY_SIZE(bcom_psc_params)) + return NULL; + return bcom_gen_bd_tx_init(queue_len, fifo, bcom_psc_params[psc_num].tx_initiator, bcom_psc_params[psc_num].tx_ipr); --=20 2.54.0