From nobody Mon Jun 8 09:48:28 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D1B2E22BD for ; Sat, 30 May 2026 02:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780109701; cv=none; b=HQblS+YUwKyeLkgl8cOCOODNG48turzhsc8FOUp7SZoG4YyGoBkhc/cZw5HYBMlIVbPtL+Dpezpg5dQ81wh25r5U/xszQ9EZhDOdXpAaE4lwxE0QjNHM4LrMs0F40NQt2y4nNp4UHDv6u8Yyk+Ttgy15OVBONvYu/6VgJOC7ZFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780109701; c=relaxed/simple; bh=ANnqrdj8KyfUNmk/0JRlqx6jfz8VGeaznSo7wqngpcs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Eayzae++YEZIYShHo1iN7k9ACHe0MrdDF6VofZKWP+ZpB4SNRDJQkjQKsgsNpQwaIAah19kCje7DDVHpoTMxQXPxec+ndEr1aqE/NMThxwVBZBHq2HgbTjAW6qpg/b6OuUCTaT0wQuRM+aQmt5gSCgd/iv2wf1+kw5lzeN8WaXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lk/hASu6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lk/hASu6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bd9c3b550aso99295785ad.2 for ; Fri, 29 May 2026 19:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780109699; x=1780714499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E7CXfCEIYRdM6U6uM6cH4x4hmATdBRQ5XKyC3LDk+ZY=; b=lk/hASu67jtOE0hZmXWEh0g9wlzqo+ylHOWarlsoSmZ6oLC6nUDKw7To+M6melN0s5 lif7oSovCzyiWDmbzeC0lTPwpnIA5W1aOJKK2dRpifHj/r+zNZoVkSVwWPBeuauUQrzD wXgAKfuvvgFlbiaVvBuSupfNrZxQ3zGHRNdRYEfB/Ea+zZPwzAGl6xt15J9dyKVaR9xE kCtRWHZIu13Lf6sBPUHi9+fUAEX9RKVokFrZaW4gHe0kd/ivuawsa/Pz29G5zHsw5WGY f2g6Y+NitV5y1QLv+YUYFKf8fGa57T/ORYKfqHM236HhAgNAO4f9CJTpc/ckZoMoWduc g4Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780109699; x=1780714499; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E7CXfCEIYRdM6U6uM6cH4x4hmATdBRQ5XKyC3LDk+ZY=; b=NpSFP1/RricW2jAeJ/8TrkJjEHY9hZbLElLewrjMwwKC9F5nH9Bd9KhciBsMIEr/pl iwaMiZiPUQ6flUjyT4KmZHVWxL6FpFcSDQOrEowYj6nvhUuj1hj2jcdk8P4EP2NWO0ZW xkz7dusa9Xxho/aIuQo2xTebUP2nnAY1G4Jo2W2WROkNFOEv7oGfFil8QeOci8zri5lt l3VXeyubOFsz/5Sb5jEuw5bsQHTacXgX5d/0+XDSaXvlMrrL31LjozFkZ54lMD4drvxa ID7AzxCOEZPIug7jwX6dWINJ+jm2P9U3NxMURTQhfrFNld7Pu8ovfN2bu0gLnTvVPk0r tk2Q== X-Forwarded-Encrypted: i=1; AFNElJ+Ll+Wd1dU+OvOir26OhYvM7kSgulaeQDvH4BdOSXQNMKYsIDin7nE/ekGty1zD5FSXsk/CHvmVxgomqe8=@vger.kernel.org X-Gm-Message-State: AOJu0YyxLVJhr2AKa3caaec3i5pz9nPKJdft4tmCU8HdSa220CMWyliy MhXSpsb4EU7DYsK/UdX5q8kIJ8F19uGsIiYWrIB2CtybAJ+FWf97n8rp X-Gm-Gg: Acq92OFQ+2XT/HL7gqI0o11xun3ontM9MzxuKRFSjQKsAYXG0CWtWLIGVJDUzzMjGac vjUCfU6LWgWAbjY6GQSgEdMCbe1NLWjc0vqTPLpRvVTxft49fP5YVpmlEZPSK9K9a0EMgd2Knst okXLkzYPpFqU1nVDPXcFRXfYftWXXlqXlG4Gfjc1K4LLHtnP0C0ZXDG398BXuT0xfCRXaK6Jv1r ZeNEfOqIqwe+Hd5SDBTXJUyFI7VBlt0Vci9Cz/k6DM3EzKMqN9MpD7wp0GUzq2I23iZi7xefHLX PXAE/R1e/qO5WilL8zAt6IYq6AXqJNw4L/hCS90XpVbsXkdu+ZbxVFpa+zrTTWjQCYktcWPNPUX KPBnXCsFXyuQkytyxMMl5LPgULIKTR0D8dlKsw2gy91/oaggi3tJqIh/Bofkmk36SQeKXUTFcQO 84HRTebaJ4eR42+4yf7kIkNCgjhXFUaM9WIfQFVYUrbMQzpsBCgpw5xoSabehBh29pft6dpL7EI n5XBrkkYC+CZb9N+Co09T0IydglrZSPToDyyyYVBAzbmQ== X-Received: by 2002:a17:902:f60d:b0:2bf:1fbd:b946 with SMTP id d9443c01a7336-2bf3637fff3mr26572625ad.0.1780109699505; Fri, 29 May 2026 19:54:59 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c3a8afsm48165665ad.73.2026.05.29.19.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 19:54:58 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] dma: bestcomm: gen_bd: split struct bcom_psc_params from array definition Date: Fri, 29 May 2026 19:54:42 -0700 Message-ID: <20260530025442.48710-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The combined struct-definition-with-initializer pattern confuses the kernel-doc parser. Split into separate struct definition and array declaration. Also now that it's fixed, it warns on missing members. Add those as well. Since this is just a lookup table and not modified, make it const so that it can be moved to read only memory. Assisted-by: Opencode:Big-pickle Signed-off-by: Rosen Penev --- v2: add const and add variable descriptions drivers/dma/bestcomm/gen_bd.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c index 8a24a5cbc263..61b5746e1a97 100644 --- a/drivers/dma/bestcomm/gen_bd.c +++ b/drivers/dma/bestcomm/gen_bd.c @@ -254,17 +254,23 @@ EXPORT_SYMBOL_GPL(bcom_gen_bd_tx_release); */ =20 /** - * bcom_psc_parameters - Bestcomm initialization value table for PSC devic= es + * struct bcom_psc_params - Bestcomm initialization value table for PSC de= vices + * @rx_initiator: RX initiator ID + * @rx_ipr: RX interrupt priority register value + * @tx_initiator: TX initiator ID + * @tx_ipr: TX interrupt priority register value * * This structure is only used internally. It is a lookup table for PSC * specific parameters to bestcomm tasks. */ -static struct bcom_psc_params { +struct bcom_psc_params { int rx_initiator; int rx_ipr; int tx_initiator; int tx_ipr; -} bcom_psc_params[] =3D { +}; + +static const struct bcom_psc_params bcom_psc_params[] =3D { [0] =3D { .rx_initiator =3D BCOM_INITIATOR_PSC1_RX, .rx_ipr =3D BCOM_IPR_PSC1_RX, --=20 2.54.0