From nobody Mon Jun 8 08:28:16 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6B43A0E97 for ; Sat, 30 May 2026 17:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160824; cv=none; b=SurU83CRTaI1O3rTz4oITT8ihaGcfMNGive8F2yhp49bc4G8+/JSLkWjjo2ZSpuRU6bSpkUayopdqjr+5sBjV41FHW+oFkyTm6JEH9oLG82zEBhBoZF1MNkX6chJPWLXcznul+VC4ewDOzO/6P/olnmtU1qa9OgiujiDTcIOZQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160824; c=relaxed/simple; bh=wMgstDTG3Htg8sV956v99iFXbhtolrOjZNrDTHpa1gg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CR7LOjYZi4drsLYy9dK/J+/dJMphtu6BcxXupSAthOQKhxfyfgYzcq9qS+ea/ouEzDRUEbPb56Vl3wUusimMUSpM1IZj5+fnhUlBQOaJFZevFwcdv4092kjLbtTNWwwUUB43CEkECFh5Sa9bRNO5rECxvQ5souEvb07vBDcvn1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oe42Okgf; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oe42Okgf" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490a7629380so436315e9.0 for ; Sat, 30 May 2026 10:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780160822; x=1780765622; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=auC75XiHji4m/5c8v8bWvJiaMsYrhK57f/6mbMWrQHo=; b=Oe42OkgfqGsZq6fjXivRoOVeVThhwPpLde6FSKxqRi4RDRYpE/P1Ym8hTmJd2KJtdW vHASFVbLKO1NE9GuTFPFT+Vpj2dkCcL50ryUThZ4oOW5PG+S4EVh+jKBzQV9fY2B5wI0 u1DlUo7iagudWn5UJmsdwGgaADWy6F/ab+Z9T4q+4oEIjQkmFFpAgc35Sm4zgVSd9QMO X4+S20HNlBI6/mMymxVx2so425n+6LhZ+h3XG3T/uCh1M3wDwN0lqFb1UZvh+eevNPfl hsGvPdUC4QWZ0gwbaMuea4yNqb380Ve/GbjYMwRPAkGFZxYoV0XG5GhvvW4kTFlGSk7x BMmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780160822; x=1780765622; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=auC75XiHji4m/5c8v8bWvJiaMsYrhK57f/6mbMWrQHo=; b=DsGy9ymjLMtFOlqu9X0cNz7m3g3XUJPViu/YCFLI7AkitesbA8ArxrEmll0MFPa7Um ueCj0wsppd9wJ9MjAM2/K2a+yAE2auEr0Z1M199Y2E93S+vipxK1MKvR6QdrurFsvoBj Vimub58gx/HDZv4cTd1Is2Y4en0KDRLrTwnBsDqr5kJarkNhMJn/7q/Qwb4/48x1DwJR 1OIiXr3i75a079tGUk3YVKOAz/bFiK75Jwi8NzWAAC9iWYp6v5KqyIX/1VRUsjjs1BHP d5VZ67JnjQkAtu46kOjiOGlGoLxCDu/D7BAOdAYEKfuD5XakNuLmvi7NtCN49jV6FzsW yV/g== X-Forwarded-Encrypted: i=1; AFNElJ8H0X5MAUrTsm1+x9HEqCxCOOPeluTJ5qKBQWQoAe00a7qYj40rQA698HrfWIPC1ajuDs+oXX29vhEXNJw=@vger.kernel.org X-Gm-Message-State: AOJu0YyyJgC8/WDDqJSHyHURQiACz2gdjBn3K81OWewwNH8dtA/3HC// TB20h9w/g0QHFndubtFD8lkCbQvoo7/o0VqoP4bWHsh0xZd5t/OnK8vK X-Gm-Gg: Acq92OFNdmzZfqsV6y2spSN1Po7UJnzJfu04xWUUOiILLxWVv6qGt887a0U53ajVJ+w JqxjBcHkMmXk+cz9GlRh+pZwG9xqCrWxi009//1sI2pg+z1lBfwXneUtVDd630KQTtO7C9hVNQl +18Nu9SZBuMeP2T/RSM4oe2DoXvQPNgvjl4nLmiIjZ974UMPhVo+5CpkjTSz6A1kXsXIvREerwH ThG1IMKZYYuETkPKoYzDGAcOn5RuW2wyQo8cthZYkIJQYCiueWr3I1gJrocDsoIgVnIkA516Q4t QPhBqbBxJs8MKw7JtaaB/tpvfMKuBvk05rwk6LzuICx39qSCv6vGPLOwXmYMVhHdhe4UQlqux1/ pcQzpraKKNQndAcW1R+xoDIj8XbaqYiagN4HiDUHs9Jq22jo3WhBfR2qH5K+04gky9Bi7rl21XM r9O/W6p/KneSGxYUQXp0xPV9Nxs7gMIdp37uj3QUY3F4VsTQ4FQFsQEtOx8kUVFjac/B5Lx7o3A V/iUo25rMctmfqqtKSmQz6UQs25n6860A15UdZgHqJjgyWVIUMEJ0x6STUIR5ZjiZ0T86UEzPSN q00IY29EQw5Fir1/C3IdLJysnspqBPQXCeN1NOhXnZBsBOruJTFnLpWdgUrSiA== X-Received: by 2002:a05:600c:2158:b0:490:58ef:ce9b with SMTP id 5b1f17b1804b1-490a293df77mr50416235e9.16.1780160821738; Sat, 30 May 2026 10:07:01 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0:c287:187e:fb7a:66a4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cab0e79sm229144675e9.13.2026.05.30.10.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 10:07:01 -0700 (PDT) From: Joshua Crofts Date: Sat, 30 May 2026 19:06:46 +0200 Subject: [PATCH v3 1/2] dt-bindings: iio: light: veml6030: add veml3328 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260530-veml3328-v3-1-dd562eaee8d9@gmail.com> References: <20260530-veml3328-v3-0-dd562eaee8d9@gmail.com> In-Reply-To: <20260530-veml3328-v3-0-dd562eaee8d9@gmail.com> To: Javier Carrasco , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780160820; l=1857; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=wMgstDTG3Htg8sV956v99iFXbhtolrOjZNrDTHpa1gg=; b=aiW0KkSaI1EzHq1fpZ2Hs227JRUPIyp3AMZ1jRq1ky1jyrMeKlAlTifLyOLVIclJzLphK5Rm4 5vfpCsm3qdUAb0CSSGnOpCB5EmZZ0k3fW59ij1g4ynpvfnROpu/vsD6 X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= The Vishay VEML3328 is an RGBCIR light sensor that shares similar devicetree properties as other existing VEMLxxxx sensors in the kernel. Acked-by: Krzysztof Kozlowski Signed-off-by: Joshua Crofts --- Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml index 4ea69f1fdd63..0041e1db6838 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: VEML3235, VEML6030, VEML6035 and VEML7700 Ambient Light Sensors (AL= S) +title: VEML3235, VEML3328, VEML6030, VEML6035 and VEML7700 Ambient Light S= ensors (ALS) =20 maintainers: - Rishi Gupta @@ -21,6 +21,7 @@ description: | =20 Specifications about the sensors can be found at: https://www.vishay.com/docs/80131/veml3235.pdf + https://www.vishay.com/docs/84968/veml3328.pdf https://www.vishay.com/docs/84366/veml6030.pdf https://www.vishay.com/docs/84889/veml6035.pdf https://www.vishay.com/docs/84286/veml7700.pdf @@ -29,6 +30,7 @@ properties: compatible: enum: - vishay,veml3235 + - vishay,veml3328 - vishay,veml6030 - vishay,veml6035 - vishay,veml7700 @@ -79,6 +81,7 @@ allOf: compatible: enum: - vishay,veml3235 + - vishay,veml3328 - vishay,veml7700 then: properties: --=20 2.54.0 From nobody Mon Jun 8 08:28:16 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B1E33A7F5D for ; Sat, 30 May 2026 17:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160826; cv=none; b=bBUxE5M4KylDQVlZr7HX2Dhw2Vmlnf/fWurHIXv+1Py72I9WW+1kat2bYvYYXcGdLtoYseadH6Q5nIAiYPQaTk8jty+ROeg8jhnt6jQv1SljLIX/Hg5awCpCVCxE6qvYWlnQ92nZy/oy6g7aFWA7RQwvMfCqKBUZW3nSWKNevkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160826; c=relaxed/simple; bh=jMM9AGZQ1yhZL0bWDi+kjv/9mqJ4r/aXSTBbYH4dJH8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tgdx3mYZn5FTw6wl9QHDYwXo9Rc4dvf0XaPmnW7lHKzghetg6hwxwZ++92Y8ezfyRW7OzPcY+MEwwZtYnYhFVXQ6v27EM/J9HJ5c7h2xEYMcWhW0bXglSFuqjIEkG8sveqyhNbhDKGS34y+64GClfniKYZ2/hkry/jGWzUaqpsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YB1SKpB/; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YB1SKpB/" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490686877a1so47986005e9.0 for ; Sat, 30 May 2026 10:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780160823; x=1780765623; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=90TfCW3zN1Ef3sxTtmqfO0zZaMtigiDXfaKQLQneVQc=; b=YB1SKpB/JowEPmEGa2ODssfU+e4RbzzgU1dBk13QAdz6c+XLtPKjJjtoQOU+HFt0Oh wFGVvZoax7tqIKX4NrciwK9kvAm08sB90Pi0tL1SUsVwCiXxwHipWXEEcQFqKjqf2+gh dPdMuLp6MSEj8Jnmx62wyMvpXk8bWPbe17fI3vLkREXn19maGXLcGOGHtO6w2RwUUsIu VEyNtj/HZCvHKUs5YUb50M3xH0Xy3t9YkzHAz14WpDU5cvK9PFTOMUzvgfs6YLuAy93c yqBwP505sZkbIUPD29uo/MRFd95kg2JhKCO7wNMKvpsD808uQ442Uf9KnDutFfKB/CgY OEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780160823; x=1780765623; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=90TfCW3zN1Ef3sxTtmqfO0zZaMtigiDXfaKQLQneVQc=; b=oud7ZD0sqzjWybJynhqsV3KA8ubixHVP7r9lqJrhDwsdIspukTC52NzZY/SdU7TvEw PBhOmy6cGCwrCOFpSC/7Y5nAGRX7vN0F61Zd675D2UuZOzcV/eT1GogcAn3DQ6HuGw/w BTmwYTxrrpMG0DHcSj4z7UCq9wYCwDD2JG0XQVbteWLedV6PTXH//uoYHp2vxQ2axgL6 gmlDc9r8h4hx3B8R6daWD2FtXB4GB6ss/0vDNMr7Q+JLIx9drVkuxVyyG00utOOHfHAF Rmrsb8lIhD9vsLf8pdEDgtd8WdB5rix90qB/q6L0UJPBBEaVRhQRow0KVBY5oHiSRHlv Rd0A== X-Forwarded-Encrypted: i=1; AFNElJ++tN2feG1BrAjNhXQUOO82k01fPC0unk+LtSqemdk1/N7REr2JXZV2td6X8sqjAccLCGpwzWTc/OD9Jgg=@vger.kernel.org X-Gm-Message-State: AOJu0YwDVzhvaI08fDHD0g5+HADq0V4iU8B5fAnuYlkhyM6qCVE92fPL WOeZHoJ2XWv1pj2yyYlvFkfJ6bGdvPi8qK8bme9awqnVBdRhft8yhqFO X-Gm-Gg: Acq92OHFLOlrNt3YocFnH829ip1CFVT1h4M+oBAt7CQtEg2/rXPiImBfs8ENpyFD0iv xzml6KW9PKNDEyj3rhapAw3bS+SOV/c9fZVNJViw6NpQ2Onz1D0u6J4SDW16a4zM1H65GND5kn8 FEd7gooQvd2LjV5CiaMcm9ff9begzzTOfdrGLc4XsXyMLScjwRZK809ew1TqBjjhvTIhXBa6JyQ Rky/4bUBEzVuzpDtNv6vSVWsVfrc6xs2OLdnY9Fml8lrfTWiEBNtJ8ybPTQ5XekA2/XvAVl68Co 3l4eaIt1yE3DPjxhWpB+9oiak8jSt1htdcI0tdUknHQzcN4gHQV82yX6OnFKM/cpxyZxCcCad3C iX4lt5yJO5i8LY9l5G/OCPn+ba8/Ti/1/wUv5wk1Fzzbz8zbp8I6vdx+OHal8gQeuB3IS/opKos Acnsu8Hi8tTWqlaA0t4E/sr1I/ZGr6N5z3cpxZtgC5HwA3hj75DJtyuVEPwTmissee8ja9Ma8T9 SR7JaU/tPlb9pl7jFkMDqSzAtQXTmW0DhtCzxRjiYxIh+eI1Z4uHBKiuZ28GsbUKEzc3de2pHNp lSpRrZEMxW/f+Fn8YGBJnRdYCM2l7pCOLYO2zHTiPsUnyQvRE98NEapNUhpuVw== X-Received: by 2002:a05:600c:34c3:b0:490:7df7:9190 with SMTP id 5b1f17b1804b1-490a2a2aab7mr62392065e9.8.1780160822571; Sat, 30 May 2026 10:07:02 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0:c287:187e:fb7a:66a4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cab0e79sm229144675e9.13.2026.05.30.10.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 10:07:02 -0700 (PDT) From: Joshua Crofts Date: Sat, 30 May 2026 19:06:47 +0200 Subject: [PATCH v3 2/2] iio: light: veml3328: add support for new device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260530-veml3328-v3-2-dd562eaee8d9@gmail.com> References: <20260530-veml3328-v3-0-dd562eaee8d9@gmail.com> In-Reply-To: <20260530-veml3328-v3-0-dd562eaee8d9@gmail.com> To: Javier Carrasco , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780160820; l=14010; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=jMM9AGZQ1yhZL0bWDi+kjv/9mqJ4r/aXSTBbYH4dJH8=; b=qc/siRnPju+80nkB8SRvDUJ6/VKXfamWBXGB6b1wH61oK7WrHIcpZGTuAkUHfZtgO3pCJtblW YCEuHMPKbCzDMsjWvDvSX7xuDB7f007M4QfYTbBoISN6c2DcuDd/4qc X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= Add support for the Vishay VEML3328 RGB/IR light sensor communicating via I2C (SMBus compatible). Also add a new entry for said driver into Kconfig and Makefile. Assisted-by: Gemini:3.1-Pro Signed-off-by: Joshua Crofts --- MAINTAINERS | 5 + drivers/iio/light/Kconfig | 11 ++ drivers/iio/light/Makefile | 1 + drivers/iio/light/veml3328.c | 413 +++++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 430 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e9457c7bba6..a893a1a1181e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28402,6 +28402,11 @@ S: Maintained F: Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml F: drivers/iio/light/veml3235.c =20 +VISHAY VEML3328 RGB IR LIGHT SENSOR DRIVER +M: Joshua Crofts +S: Maintained +F: drivers/iio/light/veml3328.c + VISHAY VEML6030 AMBIENT LIGHT SENSOR DRIVER M: Javier Carrasco S: Maintained diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index da4807a3fd3d..ef36824f312f 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -713,6 +713,17 @@ config VEML3235 To compile this driver as a module, choose M here: the module will be called veml3235. =20 +config VEML3328 + tristate "VEML3328 RGBCIR light sensor" + select REGMAP_I2C + depends on I2C + help + Say Y here if you want to build a driver for the Vishay VEML3328 + RGB IR light sensor. + + To compile this driver as a module, choose M here: the + module will be called veml3328 + config VEML6030 tristate "VEML6030 and VEML6035 ambient light sensors" select REGMAP_I2C diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile index 39e62dfc10c7..64e354c49ed8 100644 --- a/drivers/iio/light/Makefile +++ b/drivers/iio/light/Makefile @@ -66,6 +66,7 @@ obj-$(CONFIG_US5182D) +=3D us5182d.o obj-$(CONFIG_VCNL4000) +=3D vcnl4000.o obj-$(CONFIG_VCNL4035) +=3D vcnl4035.o obj-$(CONFIG_VEML3235) +=3D veml3235.o +obj-$(CONFIG_VEML3328) +=3D veml3328.o obj-$(CONFIG_VEML6030) +=3D veml6030.o obj-$(CONFIG_VEML6040) +=3D veml6040.o obj-$(CONFIG_VEML6046X00) +=3D veml6046x00.o diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c new file mode 100644 index 000000000000..1def67fd9b51 --- /dev/null +++ b/drivers/iio/light/veml3328.c @@ -0,0 +1,413 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Vishay VEML3328 RGBCIR light sensor driver + * + * Copyright (c) 2026 Joshua Crofts + * + * Datasheet: https://www.vishay.com/docs/84968/veml3328.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define VEML3328_REG_CONF 0x00 +#define VEML3328_REG_ID 0x0c +#define VEML3328_REG_DATA_C 0x04 +#define VEML3328_REG_DATA_R 0x05 +#define VEML3328_REG_DATA_G 0x06 +#define VEML3328_REG_DATA_B 0x07 +#define VEML3328_REG_DATA_IR 0x08 + +#define VEML3328_CONF_IT_MASK GENMASK(5, 4) +#define VEML3328_CONF_GAIN_MASK GENMASK(11, 10) + +#define VEML3328_MAX_IT_TIME (400 * USEC_PER_MSEC) + +#define VEML3328_ID_VAL 0x28 + +#define VEML3328_SHUTDOWN (BIT(0) | BIT(15)) + +struct veml3328_data { + struct regmap *regmap; +}; + +static const struct regmap_config veml3328_regmap_config =3D { + .name =3D "veml3328", + .reg_bits =3D 8, + .val_bits =3D 16, + .max_register =3D VEML3328_REG_ID, + .val_format_endian =3D REGMAP_ENDIAN_LITTLE, +}; + +#define VEML3328_CHAN_SPEC(_color, _addr) { \ + .type =3D IIO_INTENSITY, \ + .modified =3D 1, \ + .channel2 =3D IIO_MOD_LIGHT_##_color, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE), \ + .info_mask_shared_by_type_available =3D BIT(IIO_CHAN_INFO_SCALE), \ + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), \ + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), \ + .address =3D _addr, \ +} + +static const struct iio_chan_spec veml3328_channels[] =3D { + { + .type =3D IIO_LIGHT, + + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_type_available =3D BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), + .address =3D VEML3328_REG_DATA_G, + }, + VEML3328_CHAN_SPEC(CLEAR, VEML3328_REG_DATA_C), + VEML3328_CHAN_SPEC(RED, VEML3328_REG_DATA_R), + VEML3328_CHAN_SPEC(GREEN, VEML3328_REG_DATA_G), + VEML3328_CHAN_SPEC(BLUE, VEML3328_REG_DATA_B), + VEML3328_CHAN_SPEC(IR, VEML3328_REG_DATA_IR), +}; + +/* + * Precomputed scale values (micro units). + * Formula for calculation: 0.384 * (50000 / IT_us) * (1 / Gain) + * Gain indexes: 0 (x0.5), 1 (x1), 2 (x2), 3 (x4) + * IT indexes: 0 (50ms), 1 (100ms), 2 (200ms), 3 (400ms) + */ +static const int veml3328_scale_vals[4][8] =3D { + { 0, 768000, 0, 384000, 0, 192000, 0, 96000 }, + { 0, 384000, 0, 192000, 0, 96000, 0, 48000 }, + { 0, 192000, 0, 96000, 0, 48000, 0, 24000 }, + { 0, 96000, 0, 48000, 0, 24000, 0, 12000 }, +}; + +/* integration times in microseconds */ +static const int veml3328_it_times[][2] =3D { + { 0, 50 * USEC_PER_MSEC }, + { 0, 100 * USEC_PER_MSEC }, + { 0, 200 * USEC_PER_MSEC }, + { 0, 400 * USEC_PER_MSEC }, +}; + +static int veml3328_power_down(struct veml3328_data *data) +{ + return regmap_set_bits(data->regmap, VEML3328_REG_CONF, + VEML3328_SHUTDOWN); +} + +static int veml3328_power_up(struct veml3328_data *data) +{ + int ret; + + ret =3D regmap_clear_bits(data->regmap, VEML3328_REG_CONF, + VEML3328_SHUTDOWN); + if (ret) + return ret; + + /* + * Sleep for maximum integration time to ensure sensor is powered on + * correctly. + */ + fsleep(VEML3328_MAX_IT_TIME); + + return 0; +} + +static void veml3328_power_down_action(void *data) +{ + veml3328_power_down(data); +} + +static int veml3328_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct veml3328_data *data =3D iio_priv(indio_dev); + struct regmap *regmap =3D data->regmap; + struct device *dev =3D regmap_get_device(regmap); + unsigned int reg_val; + int it_inx, gain_inx; + int ret; + + PM_RUNTIME_ACQUIRE_IF_ENABLED_AUTOSUSPEND(dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) + return ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + ret =3D regmap_read(regmap, chan->address, ®_val); + if (ret) + return ret; + + *val =3D reg_val; + return IIO_VAL_INT; + + case IIO_CHAN_INFO_INT_TIME: + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret) + return ret; + + it_inx =3D FIELD_GET(VEML3328_CONF_IT_MASK, reg_val); + if (it_inx >=3D ARRAY_SIZE(veml3328_it_times)) + return -EINVAL; + + *val =3D veml3328_it_times[it_inx][0]; + *val2 =3D veml3328_it_times[it_inx][1]; + return IIO_VAL_INT_PLUS_MICRO; + + case IIO_CHAN_INFO_SCALE: + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret) + return ret; + + it_inx =3D FIELD_GET(VEML3328_CONF_IT_MASK, reg_val); + gain_inx =3D FIELD_GET(VEML3328_CONF_GAIN_MASK, reg_val); + + if (it_inx >=3D ARRAY_SIZE(veml3328_it_times) || gain_inx >=3D 4) + return -EINVAL; + + /* Stride by 2 through the flattened array to match (val, val2) */ + *val =3D veml3328_scale_vals[it_inx][gain_inx * 2]; + *val2 =3D veml3328_scale_vals[it_inx][gain_inx * 2 + 1]; + + return IIO_VAL_INT_PLUS_MICRO; + + default: + return -EINVAL; + } +} + +static int veml3328_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + struct veml3328_data *data =3D iio_priv(indio_dev); + struct regmap *regmap =3D data->regmap; + struct device *dev =3D regmap_get_device(data->regmap); + unsigned int reg_val; + int ret, it_inx; + + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + *length =3D ARRAY_SIZE(veml3328_it_times) * 2; + *vals =3D (const int *)veml3328_it_times; + *type =3D IIO_VAL_INT_PLUS_MICRO; + return IIO_AVAIL_LIST; + + case IIO_CHAN_INFO_SCALE: + PM_RUNTIME_ACQUIRE_IF_ENABLED_AUTOSUSPEND(dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) + return ret; + + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret) + return ret; + + it_inx =3D FIELD_GET(VEML3328_CONF_IT_MASK, reg_val); + if (it_inx >=3D ARRAY_SIZE(veml3328_it_times)) + return -EINVAL; + + *length =3D 8; + *vals =3D (const int *)veml3328_scale_vals[it_inx]; + *type =3D IIO_VAL_INT_PLUS_MICRO; + return IIO_AVAIL_LIST; + + default: + return -EINVAL; + } +} + +static int veml3328_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct veml3328_data *data =3D iio_priv(indio_dev); + struct regmap *regmap =3D data->regmap; + struct device *dev =3D regmap_get_device(regmap); + unsigned int reg_val; + int i, it_inx; + int ret; + + PM_RUNTIME_ACQUIRE_IF_ENABLED_AUTOSUSPEND(dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) + return ret; + + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + if (val !=3D 0) + return -EINVAL; + + for (i =3D 0; i < ARRAY_SIZE(veml3328_it_times); i++) { + if (veml3328_it_times[i][1] =3D=3D val2) + break; + } + + if (i =3D=3D ARRAY_SIZE(veml3328_it_times)) + return -EINVAL; + + return regmap_update_bits(regmap, VEML3328_REG_CONF, + VEML3328_CONF_IT_MASK, + FIELD_PREP(VEML3328_CONF_IT_MASK, i)); + + case IIO_CHAN_INFO_SCALE: + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret) + return ret; + + it_inx =3D FIELD_GET(VEML3328_CONF_IT_MASK, reg_val); + if (it_inx >=3D ARRAY_SIZE(veml3328_it_times)) + return -EINVAL; + + for (i =3D 0; i < 4; i++) { + if (val =3D=3D veml3328_scale_vals[it_inx][i * 2] && + val2 =3D=3D veml3328_scale_vals[it_inx][i * 2 + 1]) + break; + } + + if (i =3D=3D 4) + return -EINVAL; + + return regmap_update_bits(regmap, VEML3328_REG_CONF, + VEML3328_CONF_GAIN_MASK, + FIELD_PREP(VEML3328_CONF_GAIN_MASK, i)); + + default: + return -EINVAL; + } +} + +static const struct iio_info veml3328_info =3D { + .read_raw =3D veml3328_read_raw, + .write_raw =3D veml3328_write_raw, + .read_avail =3D veml3328_read_avail, +}; + +static int veml3328_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct veml3328_data *data; + struct iio_dev *indio_dev; + unsigned int reg_val; + int ret; + + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); + if (!indio_dev) + return -ENOMEM; + + data =3D iio_priv(indio_dev); + i2c_set_clientdata(client, indio_dev); + + data->regmap =3D devm_regmap_init_i2c(client, &veml3328_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "Failed to initialize regmap\n"); + + ret =3D devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulator\n"); + + ret =3D regmap_read(data->regmap, VEML3328_REG_ID, ®_val); + if (ret) + return dev_err_probe(dev, ret, "Failed to read ID register\n"); + + if ((reg_val & 0xff) !=3D VEML3328_ID_VAL) + dev_warn(dev, "Unknown device ID: 0x%02x\n", reg_val & 0xff); + + ret =3D veml3328_power_up(data); + if (ret) + return dev_err_probe(dev, ret, "Failed to power on sensor\n"); + + ret =3D devm_add_action_or_reset(dev, veml3328_power_down_action, data); + if (ret) + return dev_err_probe(dev, ret, "Failed to register teardown\n"); + + indio_dev->name =3D "veml3328"; + indio_dev->modes =3D INDIO_DIRECT_MODE; + indio_dev->info =3D &veml3328_info; + indio_dev->channels =3D veml3328_channels; + indio_dev->num_channels =3D ARRAY_SIZE(veml3328_channels); + + pm_runtime_set_active(dev); + pm_runtime_set_autosuspend_delay(dev, 2000); + pm_runtime_use_autosuspend(dev); + + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + + return devm_iio_device_register(dev, indio_dev); +} + +static int veml3328_runtime_suspend(struct device *dev) +{ + struct veml3328_data *data =3D iio_priv(dev_get_drvdata(dev)); + int ret; + + ret =3D veml3328_power_down(data); + if (ret) + dev_err(dev, "Failed to suspend: %d\n", ret); + + return ret; +} + +static int veml3328_runtime_resume(struct device *dev) +{ + struct veml3328_data *data =3D iio_priv(dev_get_drvdata(dev)); + int ret; + + ret =3D veml3328_power_up(data); + if (ret) + dev_err(dev, "Failed to resume: %d\n", ret); + + return ret; +} + +static DEFINE_RUNTIME_DEV_PM_OPS(veml3328_pm_ops, + veml3328_runtime_suspend, + veml3328_runtime_resume, + NULL); + +static const struct of_device_id veml3328_of_match[] =3D { + { .compatible =3D "vishay,veml3328" }, + { } +}; +MODULE_DEVICE_TABLE(of, veml3328_of_match); + +static const struct i2c_device_id veml3328_id[] =3D { + { .name =3D "veml3328" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, veml3328_id); + +static struct i2c_driver veml3328_driver =3D { + .driver =3D { + .name =3D "veml3328", + .of_match_table =3D veml3328_of_match, + .pm =3D pm_ptr(&veml3328_pm_ops), + }, + .probe =3D veml3328_probe, + .id_table =3D veml3328_id, +}; +module_i2c_driver(veml3328_driver); + +MODULE_AUTHOR("Joshua Crofts "); +MODULE_DESCRIPTION("VEML3328 RGBCIR Light Sensor"); +MODULE_LICENSE("GPL"); --=20 2.54.0