From nobody Mon Jun 8 11:01:52 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B85367B83 for ; Fri, 29 May 2026 18:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780080881; cv=none; b=qu25QCOYzn815DiTI4BAmCS6s9XeMqRLfnD86x5QwfS9QNgvBTYQ4yyTLj+VfqSfe2M8GW6DpSaBWWiFM7IBz3qw4H/+4SG1wYfVieTv+ZL65CXvujE6b15ELaOv1DyHsank90HsHu8+4EzHDbWmg34dF1atbHomNzrr+9WWve8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780080881; c=relaxed/simple; bh=rNT7GRqXnggYft/A5mLGBISOO+u8FcUXQLXMMnXblTg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=rMwhoGO0LEK8mFNdzmB3BS/YcJtKlWGrX+qf+4rksBqG2hst5fVhJcj5FdmrSGMHbIKUPNonR3vVhMiHU3Ka9A2rS93XgUouiDvzri9YaUZ8Md68a+OM4fvoKmn8+aoFwfuG+ufOLuVeplo+Jz/8yl3kIbLM/PVZhnkHKdqqF7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QK8nLzWo; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QK8nLzWo" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36babe2c4bdso851408a91.1 for ; Fri, 29 May 2026 11:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780080878; x=1780685678; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=TUENhP2KHo/+lI+DBFuVMaFWaMTmN/hgL82LdNJmYVw=; b=QK8nLzWokvV+lplfENRhcR9BBzMOHYeSvGU2jbwfhq2ZvnxLTPCymIjPJHYBqyf2Ud rBZDpgNVW0pSR6G1gC3yZEqJdPSv26XoaYKR5GXVq3Zdmv/DbERCMtG/E8YPsxzzZtrM iX9Kq8woJRhpkCKwuF9+n6ilCTjHuzBNbM2OUohR4Ffjcg6B/t6S4qpGubeg7G3CaaEC RHmY6zeX2wM4HM24zuNrKrTHYus1NBMUB0MZoECkYs2S9vsYNmfiIcWuyJaTbU5VTXUQ YuGsFvnLtBZcHi7wW9au7JU5n9IMghv8fiOCN/6RO/PZooQHAmEOPsgbxkMXBlA5PYAm wkqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780080878; x=1780685678; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TUENhP2KHo/+lI+DBFuVMaFWaMTmN/hgL82LdNJmYVw=; b=ac1p7Zn7XBn+HFAE/aC2+zKQXSbf2vS+pDxAITrTM4q1lrZLPyfS1bxIc0H7TolvS9 YnwMz5S+SliT8jYq/0HMYt+yK8Z7bJMXE3Q4XVhgT3Lty5i3dkeSaQo24xZwvufebDVX udzUSrwXsm2GuhrSJhgfPUfDyilfLgUhOs+mo0Apbi+BayYkz/u7U7eQRsiRgpjQQzh2 wFBsKs0FZyRh84bldcGQA5HJmnu1GNvP9vT6t0o7LdGnlHq1HFVyT8834vGNBg9q8cvb 4a6PybOwvoR7I3TXSx54U3tcF8+k9yMWFcIOGvtiY6jRxvN7QSu9re+/3s9Cm8NBIjJU AAHw== X-Forwarded-Encrypted: i=1; AFNElJ9CxT2fHYShow0n7bzn10Y4BiEZch1XP3WrfD/qEFgGXTBqHhv1Mu5VinUev4Z2+Yr3rDr03zPh3BD3bYk=@vger.kernel.org X-Gm-Message-State: AOJu0YyP6LjgScLBnbGWgkIpHSYobBk7NalP7t6U5jZFwlzcQOYyJqOE 0/fO8InAuE9VL36wXtg8/dcecCREzOs9+CESB40hm7DCVCbWDc9HOjkK5PyJCFm7RoY= X-Gm-Gg: Acq92OHXmVFWP3gr7wQTuGMIqhzLW4aowbHDsurYuz9Jr+I0Vhw8890iRRlCjfxCLoV +W2F1K5wXM/PYBMVX+5ffV+yGOeXCH80xGMAP4ByYNoBK1JSmMlHy2V+DTIJhfIKzR7nUdUIoi9 4ZMhfvzDqW/MjrBh1ane0L41Yvme9uT7ZJUqE0a0aR47LkGGhp+jtpKj0tFSFxoLFmtkj2ChOCi +pjSLsFWAoQj5rfbVwrVV00gXdS2+L9wFPiw+MPOZxXOmIVEbnwfUQnJu4V3rvXDuKoBlDCKt6F BOQ3hmyoFcam7e4p9G/I2KVLlQay5rzFZWLC9HFnLFzSXOvr1KZx9bvcQxcegi8lgHKnXxn0/Ta iFBfO1EvYq0yCXW0dusKHWsWxvY9oCLLpU6sDPWDjoVxmQl9RZxz0LZ4lzUkYIg90O/6Fto6PQr VmVVXuFUgDqVO9otifOu/it1REOoaiG/f6fvNGyxOvZkl19OL64yj6M/OIuBl4R5AfRrWSI72b5 ddyQhy+Hm2XiA== X-Received: by 2002:a17:90a:10c8:b0:368:83e6:ca95 with SMTP id 98e67ed59e1d1-36c2eb8fc62mr285773a91.0.1780080877400; Fri, 29 May 2026 11:54:37 -0700 (PDT) Received: from [127.0.0.1] ([151.242.180.11]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc0c341dasm3017599a91.15.2026.05.29.11.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 11:54:37 -0700 (PDT) From: Felix Gu Date: Sat, 30 May 2026 02:54:31 +0800 Subject: [PATCH] spi: dw-pci: remove redundant pci_free_irq_vectors() calls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260530-dw-pci-v1-1-5d2cf798b3c3@gmail.com> X-B4-Tracking: v=1; b=H4sIAObgGWoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDU2MD3ZRy3YLkTN0Uc1OzRBOLpDTjRCMloOKCotS0zAqwQdGxEH5xaVJ WanIJSLdSbS0ArL0bRmoAAAA= X-Change-ID: 20260530-dw-pci-d756a48bf3a2 To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780080875; l=1741; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=rNT7GRqXnggYft/A5mLGBISOO+u8FcUXQLXMMnXblTg=; b=iAnymNGDeWwT6575iqoa5TCzOTheuE5sR8xsquefh3o70OBauQ8JHF6ymRNgfBHIUbVp0ybmk uM4edz6KUv2AMBVpof/A1orzYsaM0dxK76LncGRIxMXp+1FqTbz6CSx X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The driver uses pcim_enable_device(), so IRQ vectors are automatically freed by devres on driver detach. The explicit pci_free_irq_vectors() calls in the probe error path and remove function are redundant. Drop them and the now-unused error label. Signed-off-by: Felix Gu --- drivers/spi/spi-dw-pci.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-dw-pci.c b/drivers/spi/spi-dw-pci.c index 7f002d5e5b88..bfb874f96a26 100644 --- a/drivers/spi/spi-dw-pci.c +++ b/drivers/spi/spi-dw-pci.c @@ -120,16 +120,15 @@ static int dw_spi_pci_probe(struct pci_dev *pdev, con= st struct pci_device_id *en if (desc->setup) { ret =3D desc->setup(dws); if (ret) - goto err_free_irq_vectors; + return ret; } } else { - ret =3D -ENODEV; - goto err_free_irq_vectors; + return -ENODEV; } =20 ret =3D dw_spi_add_controller(&pdev->dev, dws); if (ret) - goto err_free_irq_vectors; + return ret; =20 /* PCI hook and SPI hook use the same drv data */ pci_set_drvdata(pdev, dws); @@ -143,10 +142,6 @@ static int dw_spi_pci_probe(struct pci_dev *pdev, cons= t struct pci_device_id *en pm_runtime_allow(&pdev->dev); =20 return 0; - -err_free_irq_vectors: - pci_free_irq_vectors(pdev); - return ret; } =20 static void dw_spi_pci_remove(struct pci_dev *pdev) @@ -157,7 +152,6 @@ static void dw_spi_pci_remove(struct pci_dev *pdev) pm_runtime_get_noresume(&pdev->dev); =20 dw_spi_remove_controller(dws); - pci_free_irq_vectors(pdev); } =20 #ifdef CONFIG_PM_SLEEP --- base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad change-id: 20260530-dw-pci-d756a48bf3a2 Best regards, -- =20 Felix Gu