From nobody Mon Jun 8 09:49:58 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AAB734F474; Fri, 29 May 2026 21:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; cv=none; b=kOqibRh+OH4HPzTXZy4lDZMXDwkhKuxJWiRJxWGzfEU+hkdwaysZDtRCnAtYSgVjAzTB+OKI16cCwHk176m31Z/dawro5JQvxHfhWcCGuBHzY7d5nUw8K872U9e3g0R2DiQzaDXRfX+LXcoUZrh3Bq4mai6tkSMbX0MYtht6XuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; c=relaxed/simple; bh=oQ7x4NyHSPJnjBkGhNLc/QnP2bbrI9Ctr2l4qiKM6ow=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BqEMXow/EE3bvdVRDfCu5rZxeNGtmdSeweb9UFR502ljrFq6De7DGINbcsTv1AmSURCRUdJijV+Atim9kwWY/Iuq6mFgM0I4qwKGC/CdNpSpNfF7vICpPHhqhpMwC2sOEU3dbbnlfO/cAsSg646N/1lTh08m0TXjnC9RdJiq2fI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ld0SYG+o; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ld0SYG+o" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=XzNZ2l/2uZ2WpZM+YlAZx0tA9px8hPppIzSOcPIbcTs=; b=ld0SYG+oRntiKmikAa7hhVEPUl E/7P3ISfMsCUeRIcKX/3WANFEjo/Gl7gUkCfiHnSqCt3NQTP+S2QtL++QBQakhNHhORxGSealZFJo 9FIZw0bU7X0Hw6CndCoATlpFByEfSrY2zchkteNNelek8sDaD0emGPSKSVUqy0Aj5uHpH/YoQO+zu 3VMHX9klkDY6CQXM6VM89Atnv90M+gbrff5yUulXIldWXrDcxMfIe2f1znSMMhPJg6pnDySbw5JJC JlyDEiSjM9oiwJLSm9u0uDCuptbVKtax+J+TkvSjPryrA9lTyH014bvXa1qAE1OPqr+VERLd1JHHO aKJhq3Gw==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wT4d0-00000008F6L-3RCt; Fri, 29 May 2026 21:20:26 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH v2 1/5] watchdog: add devm_watchdog_register_device() to watchdog-kernel-api Date: Fri, 29 May 2026 14:20:20 -0700 Message-ID: <20260529212024.2119204-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529212024.2119204-1-rdunlap@infradead.org> References: <20260529212024.2119204-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_watchdog_register_device() is not documented. Add it to the current kernel API documentation. Signed-off-by: Randy Dunlap --- v2: no changes Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org Cc: Jonathan Corbet Cc: Shuah Khan Cc: linux-doc@vger.kernel.org Documentation/watchdog/watchdog-kernel-api.rst | 8 ++++++++ 1 file changed, 8 insertions(+) --- linux-next-20260525.orig/Documentation/watchdog/watchdog-kernel-api.rst +++ linux-next-20260525/Documentation/watchdog/watchdog-kernel-api.rst @@ -42,6 +42,14 @@ The watchdog subsystem includes a regist which allows you to register a watchdog as early as you wish during the boot process. =20 +There is also a resource-managed watchdog_register_device(), +devm_watchdog_register_device(). If you use this to register a watchdog +device, watchdog_unregister_device() is called automatically on driver +detach:: + + int devm_watchdog_register_device(struct device *dev, + struct watchdog_device *wdd); + The watchdog device structure looks like this:: =20 struct watchdog_device { From nobody Mon Jun 8 09:49:58 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB34376A08; Fri, 29 May 2026 21:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089630; cv=none; b=pzh4Gw4NeZMCQ2EVXgVEG+z8X3Qz1AR2sBAYxEoBDITrxwIqihqINMUGoqm2K0J9HcjN+CT+/0jlhbKPOwVPxDenirKzZuWBheGJYX1NmpRNNuDC+MiAs3AdSQ3lVK84yOq9nHLVhU0DLDeb7Bum7Tss+Kkpb4G8/GueF8BNzJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089630; c=relaxed/simple; bh=CqSv9cmPJO/PxD6q49Z67NKiZbXS5jDlvbMSTGZIxCU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bf5Vpox7KDjo55WXAF5ooKaR1US9jLew00IWksueRYm/ViEMetVwQrQDi6I0mUJuKN5EDMJLV5mFLwLedGjLvOAKITXDcyWtw3Xx5QGtvbZ54WX4RJ5HhSjLMEMvtVdShPjo+FtljawcILUriVIDJlTUk6sULqRZLclEf/uIsLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=boqY+kMg; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="boqY+kMg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=saVoIXt3/fcxXLiwGsf1nAuW7aBnL6Qy+Cl1HCXemIs=; b=boqY+kMgkTOmSL+TlAq39Zm7I3 8v1VFy5wyhP7HbLuNQefIq3uL7Cs5dy7WtkqadWQytOXwwINtuetYO1599bMbZUKtnBtuiguRrpP6 0gA582ZscO4lQvCv+/clVAPtfX09OiojlGlTjmuWWqQOOiYJlEyq8PYfQ8TSLqcijhnIHXvaKTiXM 4p42+C6GL4R2jQy4yPBC7xgWuep3L9atLo480MDQbQ7FH2pSGycPY7Q9VtkkiRWK3Oq3Ty31VfWHc YKCPZpZfILTqHJUx0aSpnsaUAq8JfNutVetC1c4Rg+zVbeb2OrQIDhmc2EPcka8HGllph60zmHhNo sAUBrQyw==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wT4d1-00000008F6L-0YMi; Fri, 29 May 2026 21:20:27 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH v2 2/5] watchdog: linux/watchdog.h: repair kernel-doc comments Date: Fri, 29 May 2026 14:20:21 -0700 Message-ID: <20260529212024.2119204-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529212024.2119204-1-rdunlap@infradead.org> References: <20260529212024.2119204-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert struct comments to correct kernel-doc format and add one missing struct member description. Signed-off-by: Randy Dunlap --- v2: no changes Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org include/linux/watchdog.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- linux-next-20260525.orig/include/linux/watchdog.h +++ linux-next-20260525/include/linux/watchdog.h @@ -26,7 +26,8 @@ struct watchdog_device; struct watchdog_core_data; struct watchdog_governor; =20 -/** struct watchdog_ops - The watchdog-devices operations +/** + * struct watchdog_ops - The watchdog-devices operations * * @owner: The module owner. * @start: The routine for starting the watchdog device. @@ -59,7 +60,8 @@ struct watchdog_ops { long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long); }; =20 -/** struct watchdog_device - The structure that defines a watchdog device +/** + * struct watchdog_device - The structure that defines a watchdog device * * @id: The watchdog's ID. (Allocated by watchdog_register_device) * @parent: The parent bus device @@ -83,6 +85,8 @@ struct watchdog_ops { * Replaces max_timeout if specified. * @reboot_nb: The notifier block to stop watchdog on reboot. * @restart_nb: The notifier block to register a restart function. + * @pm_nb: The notifier block to stop watchdog on suspend and restart it + * on resume. * @driver_data:Pointer to the drivers private data. * @wd_data: Pointer to watchdog core internal data. * @status: Field that contains the devices internal status bits. From nobody Mon Jun 8 09:49:58 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABB4376BE2; Fri, 29 May 2026 21:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; cv=none; b=CM0YbtX/Y06HVhV8Pav8IQvBTQUJoXpLx79Hb16Unp7S0t+sv/1jJTe53aZkgkTucgwDuPL/q/JDGAu9AAaJgudXXnZUUH7xlaFzwmXPyREpTJ4NCCouwAsxFEYMWcKfWBshlZQ88YZlchpWH67/TP5vz5tEOnptyq0obMoq/mY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; c=relaxed/simple; bh=Tx4rfkWcgmObg6q+pcOAf1CA3ek4CJeffzJ7yJbqttc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NGEeoPCi3Ko1t8ewAUBGWVwEDRKycEy026X9xaQLoPwIlWhdaYd05vsyJuZck9KiSdtp6lmkp2iMOOl04ynRwEsVW/Mu5wJno4xW1x39SrG1030LbpamHhCPV5B3R8pC5dC9tCoktl/Vwb5VtqlU+uFotLKiCy2F0XenLAJ1Yg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Cu0cGVpg; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Cu0cGVpg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=e0ZbXbd/dw1VsVbUP0kZvfc279kxbpTeXOlDnyM1uAs=; b=Cu0cGVpgd3zgkvDl04AMBgR/UM HiQs/EZGpAxbnSR4rDU0tVoR93NnekQ5H97B8fcDeg0+tBbTtmw+n8tfv/JpLNGXcjUlb5nw4kF+n ZNnHGbqCFC6b/4tEjH7352Z1poVvwk8pAosXkIIu/E/3uiKewlXkZuWv2b+7FSNJG1YNa9ICPg8yd Yl5Zc/rhZs3V683nZsa66T2QSAuZK9Zx11QbRZjtW0yOZaQYRYSoiSDKeChW5NGiOOd8y4vM3UghF 7pAvPddFUakdRtwBwhYK3I3oDqLXxhQzZmsWRqbBNHRx13pIVoL8My0+BAJOSrgx+PVtl+eYn4jlZ QWwbe2nQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wT4d1-00000008F6L-1uXd; Fri, 29 May 2026 21:20:27 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH v2 3/5] watchdog: uapi: add comments for what bit masks apply to Date: Fri, 29 May 2026 14:20:22 -0700 Message-ID: <20260529212024.2119204-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529212024.2119204-1-rdunlap@infradead.org> References: <20260529212024.2119204-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add comments similar to those in include/linux/watchdog.h so that the reader/user doesn't have to dig into the API documentation files for this. Signed-off-by: Randy Dunlap --- v2: s/Bit numbers/Bit masks/ per sashiko review include/uapi/linux/watchdog.h | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20260527.orig/include/uapi/linux/watchdog.h +++ linux-next-20260527/include/uapi/linux/watchdog.h @@ -36,6 +36,7 @@ struct watchdog_info { #define WDIOF_UNKNOWN -1 /* Unknown flag error */ #define WDIOS_UNKNOWN -1 /* Unknown status error */ =20 +/* Bit masks for watchdog_info.options, GETSTATUS and GETBOOTSTATUS ioctls= */ #define WDIOF_OVERHEAT 0x0001 /* Reset due to CPU overheat */ #define WDIOF_FANFAULT 0x0002 /* Fan failed */ #define WDIOF_EXTERN1 0x0004 /* External relay 1 */ @@ -50,6 +51,7 @@ struct watchdog_info { other external alarm not a reboot */ #define WDIOF_KEEPALIVEPING 0x8000 /* Keep alive ping reply */ =20 +/* Bit masks for WDIOC_SETOPTIONS ioctl */ #define WDIOS_DISABLECARD 0x0001 /* Turn off the watchdog timer */ #define WDIOS_ENABLECARD 0x0002 /* Turn on the watchdog timer */ #define WDIOS_TEMPPANIC 0x0004 /* Kernel panic on temperature trip */ From nobody Mon Jun 8 09:49:58 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB4037C906; Fri, 29 May 2026 21:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; cv=none; b=XA2gTtwlts0LrpNi+HvQG5GVUYj6rCR1ppwn6/3ca8S+b+zF6a1nXL2LTnuXUDDqW/m0vcg1PJsl2PDqLdlRrZlDN+xjQ99cW1aIkhsvuHkL1CHCEY5kI+K/bIhKs4SKxURwgA6nM+N4or+zBXMuDYJB+RyBF6s8mYdLId2uDLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089629; c=relaxed/simple; bh=D056dRNoR9oA7TCTf5YDn2YTnuyKSIACzM6iLg9S7lM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bWs+v8Us+RI0xOBXl0n2NdrAfKwc8hAkIC46GnbrRVeAp7O3Sh0B62vb3TIK/fHee9Pb/ZIqEoPaDKQE0SyVbeeDqFznBwzjdp+UItIsRYxJI2waB+82S2PhXx2BFPwYbO+8tT8fyPUv+pOrAPFsGvJ7xplksMacPMbi6Eh3w9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=GYS2mI+e; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GYS2mI+e" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=N7Bca/B5hmAp/fuY2i7qJA/ehRCoNsUB9uBA43cnIqc=; b=GYS2mI+eJ38Ix8cOddsTIip8MO bXE/QYockid7nZNwzCgZmDGkPVrprafdgebLea64wNjt9I/pvpMq12zvoYu5yhB1TWSqd9Caku+Ri z10IK/Nq//mfOOwHAJ7PKFoWwYdhmH/Q2vMjGH6+v0tkMOU+M8n8CC1aIBY9yhZJLSgjt8SHyLOK2 gwVjd2Hjy8JRcBsGG2Hi0qsfh4KQUxLszlCt5iwL+zo86YeuW2jvyDpHpDgG+CCQSvLKJHKl+rA+v bZUfWIR9sdXHUl2Cjb5lwlk+KcBolsuWsPjIMGbyLGkdGrX/++nyBkuC+n/Oy2MjgQSnV5sODPW6r /UFXoVYw==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wT4d1-00000008F6L-3IGe; Fri, 29 May 2026 21:20:27 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH v2 4/5] watchdog: core: clean up some comments Date: Fri, 29 May 2026 14:20:23 -0700 Message-ID: <20260529212024.2119204-5-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529212024.2119204-1-rdunlap@infradead.org> References: <20260529212024.2119204-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix some grammar typos and bulleted kernel-doc comment format. Signed-off-by: Randy Dunlap --- v2: no changes Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org drivers/watchdog/watchdog_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- linux-next-20260525.orig/drivers/watchdog/watchdog_core.c +++ linux-next-20260525/drivers/watchdog/watchdog_core.c @@ -55,9 +55,9 @@ MODULE_PARM_DESC(stop_on_reboot, "Stop w * for example when it's impossible to disable it. To do so, * raising the initcall level of the watchdog driver is a solution. * But in such case, the miscdev is maybe not ready (subsys_initcall), and - * watchdog_core need miscdev to register the watchdog as a char device. + * watchdog_core needs miscdev to register the watchdog as a char device. * - * The deferred registration infrastructure offer a way for the watchdog + * The deferred registration infrastructure offers a way for the watchdog * subsystem to register a watchdog properly, even before miscdev is ready. */ =20 @@ -222,11 +222,11 @@ static int watchdog_pm_notifier(struct n * watchdog_set_restart_priority - Change priority of restart handler * @wdd: watchdog device * @priority: priority of the restart handler, should follow these guideli= nes: - * 0: use watchdog's restart function as last resort, has limited rest= art - * capabilies - * 128: default restart handler, use if no other handler is expected to = be + * * 0: use watchdog's restart function as last resort, has limited rest= art + * capabilities + * * 128: default restart handler, use if no other handler is expected to = be * available and/or if restart is sufficient to restart the entire = system - * 255: preempt all other handlers + * * 255: preempt all other handlers * * If a wdd->ops->restart function is provided when watchdog_register_devi= ce is * called, it will be registered as a restart handler with the priority gi= ven From nobody Mon Jun 8 09:49:58 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E5573812CD; Fri, 29 May 2026 21:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089631; cv=none; b=NVbFTALPp/e7CgWc1ldBmHFlKWj//gHbK7QgkfpKxOql5gWiRDaQeNHU2aEHpHXQOCvL4QTWCT5lbtDArxGWjDOWMciZ7+fKIysFkNiCGHONaYCAd83RHDHhoux7a145dttZ0AD8JQ6MZNS4xwWv5Dcg6tYzMuirN6nfN3Jq8Qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780089631; c=relaxed/simple; bh=Tf0qU8LB8uYD1kHFNSO8MCcwtZ5dg+gLpqoCHJKo/r0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dZ9zyBPyWfgPIcZS7gkaAjhSjjOmELIZJVccPHUdQRLLch3ZKcERGMSZVjNFBDX++cBklXwSJvmhDbWKjuiHj7Fa9/S9wKYWp3AKk5Jz4FHCmiHXAtUdJLDZSNuEMlf9k0Tt8csgVuGMAVPJd0HHmZtXRZk9aXHMidIak1Gv9f0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=oLAjWzBN; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oLAjWzBN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=2wa/8Egzxo2dDMSvue2WkdpmvgoFhsomLNolAW13Grs=; b=oLAjWzBNZscOW1KuUyKbuIyS99 wXoMriz96y6RQFsk9ihC5jGW+lSQ4PqFL19UjqTcy3OOPYZ+BACiBVL06MB3sx3xYtjH0OF+IKwsM 25hMlCoj8urzrXLkibTLLNUxRWhmVz3YG3APMMEA2qyWlqtNjcQDw3gwWta2BOPTlNL18qttv8Rn6 9l/ugDwgPVhRrGLyXJWNtzFEYU7tuYSb//9oMVMHhnQ30h+V1imXJ3xoaFoOSL2Wp9Ucj99TzzGCz vQN9LXleOIv/MfUzD50jioVdY/4QAi1aggtoeMOBo/BANp1llTTPmz1JxVGcGDo/1FETV6bgsK3qO f1CDntaQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wT4d2-00000008F6L-0QwB; Fri, 29 May 2026 21:20:28 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH v2 5/5] watchdog: dev: convert to kernel-doc comments Date: Fri, 29 May 2026 14:20:24 -0700 Message-ID: <20260529212024.2119204-6-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529212024.2119204-1-rdunlap@infradead.org> References: <20260529212024.2119204-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert multiple functions to kernel-doc format. Signed-off-by: Randy Dunlap --- v2: no changes Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org drivers/watchdog/watchdog_dev.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) --- linux-next-20260525.orig/drivers/watchdog/watchdog_dev.c +++ linux-next-20260525/drivers/watchdog/watchdog_dev.c @@ -176,7 +176,7 @@ static int __watchdog_ping(struct watchd return err; } =20 -/* +/** * watchdog_ping - ping the watchdog * @wdd: The watchdog device to ping * @@ -236,7 +236,7 @@ static enum hrtimer_restart watchdog_tim return HRTIMER_NORESTART; } =20 -/* +/** * watchdog_start - wrapper to start the watchdog * @wdd: The watchdog device to start * @@ -279,7 +279,7 @@ static int watchdog_start(struct watchdo return err; } =20 -/* +/** * watchdog_stop - wrapper to stop the watchdog * @wdd: The watchdog device to stop * @@ -319,7 +319,7 @@ static int watchdog_stop(struct watchdog return err; } =20 -/* +/** * watchdog_get_status - wrapper to get the watchdog status * @wdd: The watchdog device to get the status from * @@ -356,7 +356,7 @@ static unsigned int watchdog_get_status( return status; } =20 -/* +/** * watchdog_set_timeout - set the watchdog timer timeout * @wdd: The watchdog device to set the timeout for * @timeout: Timeout to set in seconds @@ -391,7 +391,7 @@ static int watchdog_set_timeout(struct w return err; } =20 -/* +/** * watchdog_set_pretimeout - set the watchdog timer pretimeout * @wdd: The watchdog device to set the timeout for * @timeout: pretimeout to set in seconds @@ -417,7 +417,7 @@ static int watchdog_set_pretimeout(struc return err; } =20 -/* +/** * watchdog_get_timeleft - wrapper to get the time left before a reboot * @wdd: The watchdog device to get the remaining time from * @timeleft: The time that's left @@ -659,7 +659,7 @@ __ATTRIBUTE_GROUPS(wdt); #define wdt_groups NULL #endif =20 -/* +/** * watchdog_ioctl_op - call the watchdog drivers ioctl op if defined * @wdd: The watchdog device to do the ioctl on * @cmd: Watchdog command @@ -678,7 +678,7 @@ static int watchdog_ioctl_op(struct watc return wdd->ops->ioctl(wdd, cmd, arg); } =20 -/* +/** * watchdog_write - writes to the watchdog * @file: File from VFS * @data: User address of data @@ -732,7 +732,7 @@ static ssize_t watchdog_write(struct fil return len; } =20 -/* +/** * watchdog_ioctl - handle the different ioctl's for the watchdog device * @file: File handle to the device * @cmd: Watchdog command @@ -845,7 +845,7 @@ out_ioctl: return err; } =20 -/* +/** * watchdog_open - open the /dev/watchdog* devices * @inode: Inode of device * @file: File handle to device @@ -923,7 +923,7 @@ static void watchdog_core_data_release(s kfree(wd_data); } =20 -/* +/** * watchdog_release - release the watchdog device * @inode: Inode of device * @file: File handle to device @@ -932,7 +932,7 @@ static void watchdog_core_data_release(s * stop the watchdog when we have received the magic char (and nowayout * was not set), else the watchdog will keep running. * - * Always returns 0. + * Returns: Always 0. */ static int watchdog_release(struct inode *inode, struct file *file) { @@ -1004,7 +1004,7 @@ static const struct class watchdog_class .dev_groups =3D wdt_groups, }; =20 -/* +/** * watchdog_cdev_register - register watchdog character device * @wdd: Watchdog device * @@ -1105,7 +1105,7 @@ static int watchdog_cdev_register(struct return 0; } =20 -/* +/** * watchdog_cdev_unregister - unregister watchdog character device * @wdd: Watchdog device *