From nobody Mon Jun 8 09:49:33 2026 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8DB367B70 for ; Fri, 29 May 2026 20:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780086482; cv=none; b=hqVNYolRhqrTf1V566fovDiZgefdEZMBNV7DhF5VAEUA6JwCCe8UyGm/m5uXp9VvdG9t32qF5Epa2W/VjGXzLB6EJaJ6NxXfbsw1he66bCiM8EphAjKHBmBZO6PnCT3kdIbi6tEUJl3Ya4Ca8RAyj3XT9YPEz1luM7ONO/g4AM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780086482; c=relaxed/simple; bh=YDEDkD9JlbufAFCNStS2J0f+IE570tUEHDSSmuDdTX4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=H5hNMfYXTh/S2jSc0Qrr4B0DhIR3SChujCijPALSIGxINx1x+kWCyTdqecmf7XqLUmF9L1J9CUCda1739+518xYHWYvJkCr8ABCsbFllA/wXW0gy+j/hYIzs+4iOfirJcxRmC2r68IEgEfRmnuQDUeEcUYvhhhymXf6LI1YEVGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zzh4AA+i; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zzh4AA+i" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-4855e69a5a4so4348562b6e.2 for ; Fri, 29 May 2026 13:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780086477; x=1780691277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9RzBPZkcHoJztcOY8Ay43RDpkIbpehVBuhl8amny//Y=; b=Zzh4AA+i1FHVazZ3P5PystvsefrGGQ0fXm15pApYpuM50LgS6qrWej8IlLkxaRbDUw Z2+/Rk2CjJMLZqpOhvj0p/hZBqIKuZfxkPXJ1JQHP8/TD5X8PJRRwHH2aN80NitSguMD 0cpd0ccaaeiTT6e+ViQK1qWWt/itVijpbo/Ae8Py2YA3+iaHFMbJGev/a2ltD/Gw9Zwr W/6oFjinkS16D6fexFbOi/ESpuzTmgkkLBBkYPjCWUpSpDsKNXXa/ObLmcpK23sHxzEq bo9jmXuazlaqVhmd99R5o9VyqseLjIPhuaqdoIuP7Q4opvMh5GZT8Ch2LZ+NJ2ZeRWFy 8ftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780086477; x=1780691277; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9RzBPZkcHoJztcOY8Ay43RDpkIbpehVBuhl8amny//Y=; b=sdafKWx+rclJw6oy5nx/y9mGJB1y82wwR02pdwdkR3FNRSOXeFK994C6crCvAdjLsf d8KO+TMcOsQ50i6EoEJWEO6U0MiPkwok55SSSIv4+E/pWq8aSjEiDuoigCXFtQ7voHl5 wbdl8YFEfN69ApkLWG45+cysJmQEvkTUlsF8y4JXrt1ap3YcoFdfdQVSupdE4aw43/gl XhgzT68HUF31/hYmbaW42qqNH8wHAb3XME+RQL6HVlniivz0MP3fYqe8x24eS28PGHvI snKkOQM7jyTCMAiOt+QZvvocKgv7Jp5bVM/WWa8Y2Pgo7u478jgzgpujp/yNYmjqqmd8 S3nQ== X-Forwarded-Encrypted: i=1; AFNElJ8FjVcW8pVWZt6ZER8XfLQizuQViPHAUu2epc6B+DoD9BYJdWZymQrXfkneFI6qVELb++gl2SkvfA437r4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6lhfn4KKRvaBtmEq+6wQR9vAwqo/JaUGVRomhTafoFcXAvciK SSSOpm6MUHuswRehj1CToib6E7NVv6KlUE4X9yjxMMfVpKfFSvNvVY0f X-Gm-Gg: Acq92OE1kQ8REjQcE3Vt9bN1R6m5FdQmjQI/xB2maIRv+iUUUC6dlY7lRbempIyk/5W +kBuUqqLt5q9VYthi+GYAIYABphjWVf5kw4sIDcmKeRYtcncw/PgC5/NI24i8MEBKO3ZLLThN7f V6E7PhaIat61MmxnpzNhTE5tVJ+u1PnSQR9HxvhQZld/+MByK7JR5qfKvt/hFXun9vdLEgnXbYL KndtMVVNM5NPspzTd6VfjaD1GclU4fO5W07L5qzuLoG7kLzq4CSj0NSJNgJtYgD5cDl8i28/k0W a05YtWHJJQGUFoW+Kj5nLQWrdvZ2+Bh+FJpG4ol4Ne/0MmyN8IlN9hmlKoB1ywc9aESa40Zo76y xgpzbXiXZOYwzL2KcN1QuEv1qINsE4Q8F9mF5w5NqRV3avt3PKkJW+4lrJhhAbf+Ec6ksrXUKAr /8y2sGZjpanSwY8QkECMeESJdlYNBkySWJvAmJ7yZBYf4e21XJzyXtCqBhUw4r5AM4 X-Received: by 2002:a05:6808:3092:b0:485:d6e7:9dcb with SMTP id 5614622812f47-485faf4d41cmr620581b6e.0.1780086477061; Fri, 29 May 2026 13:27:57 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:58::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43c93ae5342sm1729030fac.7.2026.05.29.13.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 13:27:56 -0700 (PDT) From: Joshua Hahn To: Yury Norov Cc: Rasmus Villemoes , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: [PATCH] mm/nodemask: Correctly describe nodemask operation return types Date: Fri, 29 May 2026 13:27:54 -0700 Message-ID: <20260529202755.1846800-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 0dfe54071d7c8 ("nodemask: Fix return values to be unsigned") changed a number of nodemask operations that used to return int to returning a bool instead. However, it did not update the comment block that described these functions, leaving the documentation incorrect. Fix the comment block to accurately describe the functions. Also fix a typo (unsigend --> unsigned), and fix a callsite in mempolicy.c that did not get updated during the conversion. No functional changes intended; changes are purely cosmetic. Signed-off-by: Joshua Hahn Reviewed-by: SeongJae Park --- include/linux/nodemask.h | 18 +++++++++--------- mm/mempolicy.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h index 204c92462f3c0..b842aa5255464 100644 --- a/include/linux/nodemask.h +++ b/include/linux/nodemask.h @@ -24,23 +24,23 @@ * void nodes_setall(mask) set all bits * void nodes_clear(mask) clear all bits * int node_isset(node, mask) true iff bit 'node' set in mask - * int node_test_and_set(node, mask) test and set bit 'node' in mask + * bool node_test_and_set(node, mask) test and set bit 'node' in mask * - * void nodes_and(dst, src1, src2) dst =3D src1 & src2 [intersection] + * bool nodes_and(dst, src1, src2) dst =3D src1 & src2 [intersection] * void nodes_or(dst, src1, src2) dst =3D src1 | src2 [union] * void nodes_xor(dst, src1, src2) dst =3D src1 ^ src2 - * void nodes_andnot(dst, src1, src2) dst =3D src1 & ~src2 + * bool nodes_andnot(dst, src1, src2) dst =3D src1 & ~src2 * void nodes_complement(dst, src) dst =3D ~src * - * int nodes_equal(mask1, mask2) Does mask1 =3D=3D mask2? - * int nodes_intersects(mask1, mask2) Do mask1 and mask2 intersect? - * int nodes_subset(mask1, mask2) Is mask1 a subset of mask2? - * int nodes_empty(mask) Is mask empty (no bits sets)? - * int nodes_full(mask) Is mask full (all bits sets)? + * bool nodes_equal(mask1, mask2) Does mask1 =3D=3D mask2? + * bool nodes_intersects(mask1, mask2) Do mask1 and mask2 intersect? + * bool nodes_subset(mask1, mask2) Is mask1 a subset of mask2? + * bool nodes_empty(mask) Is mask empty (no bits sets)? + * bool nodes_full(mask) Is mask full (all bits sets)? * int nodes_weight(mask) Hamming weight - number of set bits * * unsigned int first_node(mask) Number lowest set bit, or MAX_NUMNODES - * unsigend int next_node(node, mask) Next node past 'node', or MAX_NUMNOD= ES + * unsigned int next_node(node, mask) Next node past 'node', or MAX_NUMNOD= ES * unsigned int next_node_in(node, mask) Next node past 'node', or wrap to= first, * or MAX_NUMNODES * unsigned int first_unset_node(mask) First node not set in mask, or diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4e4421b22b59f..36699fabd3c22 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2865,7 +2865,7 @@ bool __mpol_equal(struct mempolicy *a, struct mempoli= cy *b) case MPOL_PREFERRED: case MPOL_PREFERRED_MANY: case MPOL_WEIGHTED_INTERLEAVE: - return !!nodes_equal(a->nodes, b->nodes); + return nodes_equal(a->nodes, b->nodes); case MPOL_LOCAL: return true; default: --=20 2.53.0-Meta