From nobody Mon Jun 8 11:02:05 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010016.outbound.protection.outlook.com [52.101.56.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F9833F210B; Fri, 29 May 2026 16:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073029; cv=fail; b=NrOjCp0memQ/07jiD4/J1ZF4fUBpTceAgFNYMQaLR3wTZGjOFUbI1siQyAPH0HLk38Y1na3aqyJNr84K6EosLpsQS3vR9whEUNP1ChJ7AwjH0VnRjpUk59caGRcs+4vX9aexWASIDeyWK07ocn/+Dh6rsTRQ7ds7VRg360vctpM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073029; c=relaxed/simple; bh=VjDnRfiI2UYHvAXt8BWnFUE5/gkyINHqdGsxy+8aANw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JzKu9Y+6LRVP554oToQ6QBc/7GOnbAWSMxi/jFR85gUpp4fq1jtknSRcI/1nCL1U/JZ55URQsKwo9HXaASl9A+0x0HqPTDiD/7fdoU0COZum/Etto5NX2p1ikvlIcOtCq+/lnp+Is2/hAa5PmPHvIWOVOzo2n3mMq78z6H26XZ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Q4nAKUEQ; arc=fail smtp.client-ip=52.101.56.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Q4nAKUEQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GNdKvSJW0I8o1utd08dF88M8W8pZxBdPj/EkFysdDCbqav2fLTAEuDdN/rvIfB57AGIwisPVVgmT0GtCz/Yh7T3dLJITdgCRh66wSpRVfCzHAQHqhSXFEkuZAeR66u4Ky8oui8drdOVxQdR0oAu4kAa77k0tqWW8+eDkvvnmOc4oQXACFrW46Cpzzd0Z7PnlcFMCZW50pMuTmKS9LYwWfCXz40Pvj7K9AAuvsf64sPJT1n3474mWUBV2iW70ncQBfQzhmBo1wFnspPo3R/THUrbjKaEcZD+7ghyvqNBHTZ5gD/q5SE22E+E+//HLdV+xASswxo1Mv63vrUFnvwT6gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7qzu014ra39MD5fSByTQzBE9+aQ8RuCcIcrlABdHT4=; b=gJLKAT0ACYpGECGAYyWUqAaodp3XUsPS5mGpdLojQ+FEb8ilrm/z8yODOtULnL2GibxVseIbDfksj96puFN1PfAKUgME6f4w5dvZkIVg5oQZ6IH1zMUBiCMZ2zJSRvyTCqnQVmfyTK2aNKdj9yu482Xon+boJk/fteLGX29laA4jTUKygNcNZAoChMSrVQ0tUoh4PHe7tqudpYJv+uvd9CMWew49AjheU1t0jhOa8fMOGyRXfUEZpCFkz5kBOmZEPUEeRpI51nooKFKlr8YsVgGgKRcobNmnL4gDen+K76hl3eCh8lBdwcbdM+vnQ4tkLeQImrbEahGCPXfEiA7quQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7qzu014ra39MD5fSByTQzBE9+aQ8RuCcIcrlABdHT4=; b=Q4nAKUEQP35lxE58WNto5qR/uabnp3yUjw2Xh9XqSb+l0vkQiUZH+KYq/FXnAQ0y9Bl70nniAk9W2uywYbgNPgzBdF7ZBIV3zlqUTN36FHuIvJ3XWUIuP2oviEactuRiT/3DHG7lLcWvsXQDnJvNpinrTNCwch1D3K6Df6ezh+4= Received: from BN9PR03CA0176.namprd03.prod.outlook.com (2603:10b6:408:f4::31) by MW5PR12MB5681.namprd12.prod.outlook.com (2603:10b6:303:19e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.15; Fri, 29 May 2026 16:43:43 +0000 Received: from BL6PEPF00020E62.namprd04.prod.outlook.com (2603:10b6:408:f4:cafe::2d) by BN9PR03CA0176.outlook.office365.com (2603:10b6:408:f4::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.13 via Frontend Transport; Fri, 29 May 2026 16:43:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF00020E62.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 29 May 2026 16:43:42 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 29 May 2026 11:43:42 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 29 May 2026 11:43:41 -0500 From: Tanmay Shah To: , , CC: , , Subject: [PATCH v3 1/4] rpmsg: virtio_rpmsg_bus: rename rbufs and sbufs Date: Fri, 29 May 2026 09:43:25 -0700 Message-ID: <20260529164327.1827121-2-tanmay.shah@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260529164327.1827121-1-tanmay.shah@amd.com> References: <20260529164327.1827121-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E62:EE_|MW5PR12MB5681:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f9990b5-ef4c-4a2e-6da6-08debda17181 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|1800799024|22082099003|18002099003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: U5/QIX9gU2T4bR4AJurKfZarHMuvPl9dhql5YyM3TfnX6eMKMitzsVs6NhiW10DFiRw7Nb9w18VgIDBj/ReO/P/wwfalDfH1IMEIL45dU4B1j/ciy4qpojEferfixPKYCF/rKizltJY6kDDlSt8H/AlZCZJq55BKUQ3r9370SFX/wkfgqlWB+F6o7zREDmPDVsFMJKQ5ynUnZTw9LZ69GmMUonNEgAWOXv2BxT+ujvCTQG1dKqicB29YSnR33v5RTbAtF3p4QeXKsbE3j9pEOgqcr47aY0MdFRYA/h2ByW9X3eOR11TORb7/2BNuScXvTD1Q0d2hiSIkprzbwWSxoV7t66WSG3vj5U9x/ty6hTxcv/2SX0wm7+8oGF5b7l6+b8tBbkPI7PexiMcyOX3TNdCpY2Xr4eWrd7SW+mg/MMO4WQgAzZJO5vx1egV4X35LFZR87CAhHPEbi0Kem/wPzwR9beVhHmeCWxRxoauxAKxHnNJOlD0L+dacoCPuDQGd4mcg06O/BeyQEdmVq2CG0ZkHNLWYVO8H1dUX9TXzPNxy30Tpjczf1L4DhhPYFiyqIPxOyRNSV7kx6qLGjva/dr06VPTq7yfhvoTf/kOHiDSLgzhoE7T2I4/TsUEiHW/+0/9ynSsT9EItrBRkZzB6OPVzTGDz59EsPhryZd6I5vXLlpcxnnx+XkIKkURlUgjnPZYixpKvV1reeR7LzCS9UZ+u1EVtZryaj5UVu8dSZYA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(1800799024)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o7xMvYRw+A+7Gwiclm8k/McddEfHjPlkx3umHBLfW1GX2g/xezv0stE0bY2+YRsEM2Xra6PdgJNPJpF94vPwuM5pEVmkcpv2BwNzaVTy7p2hI3TlNduwl6/xQ1kUFj3ugyFLyT1Sv6OGy9WV/60dLe4aooVKWMAQ78g9+V/MOHeIj4e0XfYkIXc7Esptobyhuul8tDbgV1ZkmCjga68/m2rKc+nWWioVW3nLaVtA5r+6ApzbNrVghoYTNQZgvSI/TVFHQO05srTnySt7G3sIvDi1kXlgG+QeDVyQLuwseGw/F/ubcUfRk9JF6F44cjf2vj7uqTpCU6WvIu9DrutoLznvEqckAWvjdIkQajsbL3+O1BcQro39iePL497s0H5qNOn68oiwp4m1ni27OHrdoudNUDnVGK+HkSNHJfx6ppkKF7TwU8jMxmJWZhMUlfrI X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 16:43:42.4443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f9990b5-ef4c-4a2e-6da6-08debda17181 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5681 Content-Type: text/plain; charset="utf-8" rename variables with clear names. %s/rbufs/rx_bufs/ %s/sbufs/tx_bufs/ %s/last_sbuf/last_tx_buf/ Signed-off-by: Tanmay Shah --- drivers/rpmsg/virtio_rpmsg_bus.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 5ae15111fb4f..773547479d15 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -35,13 +35,13 @@ * @vdev: the virtio device * @rvq: rx virtqueue * @svq: tx virtqueue - * @rbufs: kernel address of rx buffers - * @sbufs: kernel address of tx buffers - * @num_bufs: total number of buffers for rx and tx + * @rx_bufs: kernel address of rx buffers + * @tx_bufs: kernel address of tx buffers + * @num_bufs: total number of buffers for rx and tx * @buf_size: size of one rx or tx buffer - * @last_sbuf: index of last tx buffer used + * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers - * @tx_lock: protects svq and sbufs, to allow concurrent senders. + * @tx_lock: protects svq and tx_bufs, to allow concurrent senders. * sending a message might require waking up a dozing remote * processor, which involves sleeping, hence the mutex. * @endpoints: idr of local endpoints, allows fast retrieval @@ -55,10 +55,10 @@ struct virtproc_info { struct virtio_device *vdev; struct virtqueue *rvq, *svq; - void *rbufs, *sbufs; + void *rx_bufs, *tx_bufs; unsigned int num_bufs; unsigned int buf_size; - int last_sbuf; + int last_tx_buf; dma_addr_t bufs_dma; struct mutex tx_lock; struct idr endpoints; @@ -444,8 +444,8 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) * either pick the next unused tx buffer * (half of our buffers are used for sending messages) */ - if (vrp->last_sbuf < vrp->num_bufs / 2) - ret =3D vrp->sbufs + vrp->buf_size * vrp->last_sbuf++; + if (vrp->last_tx_buf < vrp->num_bufs / 2) + ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else ret =3D virtqueue_get_buf(vrp->svq, &len); @@ -635,7 +635,7 @@ static __poll_t virtio_rpmsg_poll(struct rpmsg_endpoint= *ept, struct file *filp, * allocated buffers are used for transmit, hence num_bufs / 2), or, * - we ask the virtqueue if there's a buffer available */ - if (vrp->last_sbuf < vrp->num_bufs / 2 || + if (vrp->last_tx_buf < vrp->num_bufs / 2 || !virtqueue_enable_cb(vrp->svq)) mask |=3D EPOLLOUT; =20 @@ -873,15 +873,15 @@ static int rpmsg_probe(struct virtio_device *vdev) bufs_va, &vrp->bufs_dma); =20 /* half of the buffers is dedicated for RX */ - vrp->rbufs =3D bufs_va; + vrp->rx_bufs =3D bufs_va; =20 /* and half is dedicated for TX */ - vrp->sbufs =3D bufs_va + total_buf_space / 2; + vrp->tx_bufs =3D bufs_va + total_buf_space / 2; =20 /* set up the receive buffers */ for (i =3D 0; i < vrp->num_bufs / 2; i++) { struct scatterlist sg; - void *cpu_addr =3D vrp->rbufs + i * vrp->buf_size; + void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; =20 rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); =20 @@ -980,7 +980,7 @@ static void rpmsg_remove(struct virtio_device *vdev) vdev->config->del_vqs(vrp->vdev); =20 dma_free_coherent(vdev->dev.parent, total_buf_space, - vrp->rbufs, vrp->bufs_dma); + vrp->rx_bufs, vrp->bufs_dma); =20 kfree(vrp); } --=20 2.34.1 From nobody Mon Jun 8 11:02:05 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010064.outbound.protection.outlook.com [52.101.193.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A30D3F39C8; Fri, 29 May 2026 16:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073030; cv=fail; b=k9S4z1AqLgESYO6SHyLHTnBE+T+zsXvcKaXev+gM6h/PhQ1vL5pQQuNdDZyj/mkzPXw6XmU6ZoUSMOH6PRWvIf0dgxGa3zJwAElnuoGrYMGI1/dfktuPtB+nc3kU3DKRSOavNV9L1Me2Ohl22MFfNzguNsAh/gc7DezD6dKoiDI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073030; c=relaxed/simple; bh=AzuWtuFcKkeGk2SjUXJHCHngk9bXPItDsq0XJrdSmuw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=llEb67s+xSRrl96bL0idOC7c5miDxmnO2VJpAmeQxUGLCsWJrUjY/K1kOcrNVNOWux6V1K6XLWx6TH28ouCL08oT4c/QNbjgEGuTlBs5K16fgxJ0aWezl8hWIaCIxiTiiVCnH5NgfZMiEa6KtVpsu/f9j/eDc8umUyyZfwj3Il8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pxuihFcQ; arc=fail smtp.client-ip=52.101.193.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pxuihFcQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d+4FDpG1bhiAOX+GLAdUsEfAQB8Il/JqVE9r33EDHOxJmBtOslXolBHecmU6J8TlORWqX6syDOjYsaVkiyNHdGUVk/Y3fNZSwIHHtmHNXb8NSOmSml1U8/latp64kbXmnb5IEoftJSVhvaVuadXs0scr8gErY2jANC+Hgz6hqQRXayx+TZslUjCgWhzRQEAur2G/KyVmVeV5VhEeh5Q3csofml9vnmnMux0HhW/A2wbY/sMxeATHZ4UlIknhu4ixuzjJkFkuofUtCdp693wd2YY9GvPjKAJr9d4uhf5BQF2Ml0/WTTTUYS3Eb3MFH5O+vyzMS+MbU3zdp8nxPkqI9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmGRg1LsyE7BCDRjrlDMRiXTh+DGlKxNSF30ZneF4FE=; b=E3bMPaXfqq6d638qBM4evSkMFlSQwBb8GU/e6303t0spQ/JBYYn8n74vhDjw49GnPbT4bnQshhZWh6wSpA7ekKhIuh3gIocx/HifcO7cfJCp79Aq/BpNSaayn9X84u+v9CRXIospi9JdDHHlXecV20wujEDFWQdhz1OaAJV/FW+odfQJcOvEjttZf9m2R45FCTqJZCVeDOK4piKXTvYZ8v4leBjF7+nroK2WbBFfM3QC8wQTNJMF4jMPadPkLLPEiKrY4N1fxR2XdSuoLZJDINl/bmi5ri2shsq7cq6z/Fe+Y8c7vDvl6B5HbkGs5K1nImZLjsJXGj+yTStrzD/dEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TmGRg1LsyE7BCDRjrlDMRiXTh+DGlKxNSF30ZneF4FE=; b=pxuihFcQgSK8j5TQlIpN4/Nqf5RBBiJdPdMuy9vJ9o7ejVYGjql+0/AyE5N0b/wt422/lS6SfFK/aSxqfx5HjMjnByU9GD2B7tWTrgs84g7tkoXRL2E6rwuZHEekAu2x0S91rYqmJKh6AZq+avQKP0Ndv6gfBpHsNxo+do9E4bY= Received: from BN9PR03CA0177.namprd03.prod.outlook.com (2603:10b6:408:f4::32) by LV8PR12MB9134.namprd12.prod.outlook.com (2603:10b6:408:180::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.15; Fri, 29 May 2026 16:43:43 +0000 Received: from BL6PEPF00020E62.namprd04.prod.outlook.com (2603:10b6:408:f4:cafe::e) by BN9PR03CA0177.outlook.office365.com (2603:10b6:408:f4::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.13 via Frontend Transport; Fri, 29 May 2026 16:43:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF00020E62.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 29 May 2026 16:43:43 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 29 May 2026 11:43:42 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 29 May 2026 11:43:42 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 29 May 2026 11:43:42 -0500 From: Tanmay Shah To: , , CC: , , Subject: [PATCH v3 2/4] rpmsg: virtio_rpmsg_bus: allow different size of tx and rx bufs Date: Fri, 29 May 2026 09:43:26 -0700 Message-ID: <20260529164327.1827121-3-tanmay.shah@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260529164327.1827121-1-tanmay.shah@amd.com> References: <20260529164327.1827121-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E62:EE_|LV8PR12MB9134:EE_ X-MS-Office365-Filtering-Correlation-Id: b635a1c4-e88e-4dc8-a9a7-08debda17226 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|82310400026|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: mG7fzzIVv4ZD/gETnC/BPXDD4oyOlyDiakTm0srU0147n4tknQM+vS15EreHQDRNzYdNJeXk7hBxj73jC1ZVi/c7jvfps+SmcfSkBCpZ2sZaXcZ2SZrl8D5eX9HHNP0pPPkzBP8fcjV+8tvzRgvvrwT2WqfJiyNFLdMmm/teThVGm49UlBu6kPrWI3FsRvj4ai1gHaL8RJKLPLAGENtRJa6+63MQj2kMgg5BX/KXmI8JOb6M5/ZkQf5DREkJzYv5axVn0rSZVu9s65fzvvbohTc71UEnK4FaIvGrQhixTa+I/+4vbpq5aHtZy88SQypGTIzNpVuKxcOpH6sP7CRrzr/oXdNNBFhtN8ZWsfQ2MRqx9xemV/2Yw3IdRsKvr//DUinglp6GbPauV14x3rMsXodb4VkeeeiQjVGNtcZ/+hGUcE5FnkgImzvIp91/+mRbrP5ZLnahEdl5G//FhQ4mZJ0SVTehdhZsH0hRK0sMJxEzDNBUCZxzUbFcHKx5QKR1XqR6/6Oh+a8a2Auva5ByaBF/Ko/z5AViY0Je6NzkGthdofiHmpSTbGlsPKLBDIetlhApI32GjhL7Le5owosMALk7EDbiUYPws7OvkVkUbFSC/w6bDRrwbuTbCE5t+REBVXUP8EG32m86C+fjybBybYFq6o+IXDEJajKWvHXzWdZoEqbnejOWrVQ7SCU1crwTKgmiUl+LP5jjRJjCLjOoGw3zVTyDRrmD8VIMJ6JSvjc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DMI2kPXmZ1+7MudfUJw3zgFjWUNsW9yO0l5lnozMMEMSAkFAbJJf3uMSC1oXsFSjeBiaDZIIs3P/Y03bkMKNhHsrWGsJHbspKA0KLtpZveHusuRBKCBJXIErTk5/5lJWzfEvOjCe6jYa5TkOsRWlotcURfqykWg5/Nv9coedBIrwTjsfsXBYQ2PqMHixCCS8e8Ke7YYAj2XiETpwOpESrnem7JPJnZ71bS/c5hwr3ua8588tPw8xnMFPnmPFqpbpA+i3XvI5Ghiu8l4/GWLM3HpesbTyJq/Pzvi9HyqB8t6AgQ/vmmPChcaKOh8u77Oo5VTFC1EG8aasDnXxNL/lBWa3+fDIWOXq9npC8KuHeqjIlRO2NYQn1G1WK3erLSqO4vFxo+9ju0Hp0JroWrYZgWJIj7g/RV3ht/qeLtu7o6/j2xAA7qOnBmJV9gJoyLA8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 16:43:43.5271 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b635a1c4-e88e-4dc8-a9a7-08debda17226 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9134 Content-Type: text/plain; charset="utf-8" Current design allocates memory for tx and rx buffers equally. The throughput can be increased if the user is allowed to configure number of tx and rx buffers as required. Hence, do not split number of tx & rx buffers into half, but decide based on respective vring size. Signed-off-by: Tanmay Shah --- drivers/rpmsg/virtio_rpmsg_bus.c | 50 ++++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 773547479d15..99df1ae07055 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -37,7 +37,8 @@ * @svq: tx virtqueue * @rx_bufs: kernel address of rx buffers * @tx_bufs: kernel address of tx buffers - * @num_bufs: total number of buffers for rx and tx + * @num_rx_buf: total number of rx buffers + * @num_tx_buf: total number of tx buffers * @buf_size: size of one rx or tx buffer * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers @@ -56,7 +57,8 @@ struct virtproc_info { struct virtio_device *vdev; struct virtqueue *rvq, *svq; void *rx_bufs, *tx_bufs; - unsigned int num_bufs; + unsigned int num_rx_buf; + unsigned int num_tx_buf; unsigned int buf_size; int last_tx_buf; dma_addr_t bufs_dma; @@ -110,7 +112,7 @@ struct virtio_rpmsg_channel { /* * We're allocating buffers of 512 bytes each for communications. The * number of buffers will be computed from the number of buffers supported - * by the vring, upto a maximum of 512 buffers (256 in each direction). + * by the vring, up to a maximum of 256 in each direction. * * Each buffer will have 16 bytes for the msg header and 496 bytes for * the payload. @@ -125,7 +127,7 @@ struct virtio_rpmsg_channel { * can change this without changing anything in the firmware of the remote * processor. */ -#define MAX_RPMSG_NUM_BUFS (512) +#define MAX_RPMSG_NUM_BUFS (256) #define MAX_RPMSG_BUF_SIZE (512) =20 /* @@ -440,11 +442,8 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) =20 mutex_lock(&vrp->tx_lock); =20 - /* - * either pick the next unused tx buffer - * (half of our buffers are used for sending messages) - */ - if (vrp->last_tx_buf < vrp->num_bufs / 2) + /* either pick the next unused tx buffer */ + if (vrp->last_tx_buf < vrp->num_tx_buf) ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else @@ -631,11 +630,10 @@ static __poll_t virtio_rpmsg_poll(struct rpmsg_endpoi= nt *ept, struct file *filp, =20 /* * check for a free buffer, either: - * - we haven't used all of the available transmit buffers (half of the - * allocated buffers are used for transmit, hence num_bufs / 2), or, + * - we haven't used all of the available transmit buffers or, * - we ask the virtqueue if there's a buffer available */ - if (vrp->last_tx_buf < vrp->num_bufs / 2 || + if (vrp->last_tx_buf < vrp->num_tx_buf || !virtqueue_enable_cb(vrp->svq)) mask |=3D EPOLLOUT; =20 @@ -846,19 +844,20 @@ static int rpmsg_probe(struct virtio_device *vdev) vrp->rvq =3D vqs[0]; vrp->svq =3D vqs[1]; =20 - /* we expect symmetric tx/rx vrings */ - WARN_ON(virtqueue_get_vring_size(vrp->rvq) !=3D - virtqueue_get_vring_size(vrp->svq)); - /* we need less buffers if vrings are small */ - if (virtqueue_get_vring_size(vrp->rvq) < MAX_RPMSG_NUM_BUFS / 2) - vrp->num_bufs =3D virtqueue_get_vring_size(vrp->rvq) * 2; + if (virtqueue_get_vring_size(vrp->rvq) < MAX_RPMSG_NUM_BUFS) + vrp->num_rx_buf =3D virtqueue_get_vring_size(vrp->rvq); + else + vrp->num_rx_buf =3D MAX_RPMSG_NUM_BUFS; + + if (virtqueue_get_vring_size(vrp->svq) < MAX_RPMSG_NUM_BUFS) + vrp->num_tx_buf =3D virtqueue_get_vring_size(vrp->svq); else - vrp->num_bufs =3D MAX_RPMSG_NUM_BUFS; + vrp->num_tx_buf =3D MAX_RPMSG_NUM_BUFS; =20 vrp->buf_size =3D MAX_RPMSG_BUF_SIZE; =20 - total_buf_space =3D vrp->num_bufs * vrp->buf_size; + total_buf_space =3D (vrp->num_rx_buf + vrp->num_tx_buf) * vrp->buf_size; =20 /* allocate coherent memory for the buffers */ bufs_va =3D dma_alloc_coherent(vdev->dev.parent, @@ -872,14 +871,14 @@ static int rpmsg_probe(struct virtio_device *vdev) dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", bufs_va, &vrp->bufs_dma); =20 - /* half of the buffers is dedicated for RX */ + /* first part of the buffers is dedicated for RX */ vrp->rx_bufs =3D bufs_va; =20 - /* and half is dedicated for TX */ - vrp->tx_bufs =3D bufs_va + total_buf_space / 2; + /* and second part is dedicated for TX */ + vrp->tx_bufs =3D bufs_va + vrp->num_rx_buf * vrp->buf_size; =20 /* set up the receive buffers */ - for (i =3D 0; i < vrp->num_bufs / 2; i++) { + for (i =3D 0; i < vrp->num_rx_buf; i++) { struct scatterlist sg; void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; =20 @@ -966,7 +965,8 @@ static int rpmsg_remove_device(struct device *dev, void= *data) static void rpmsg_remove(struct virtio_device *vdev) { struct virtproc_info *vrp =3D vdev->priv; - size_t total_buf_space =3D vrp->num_bufs * vrp->buf_size; + unsigned int num_bufs =3D vrp->num_rx_buf + vrp->num_tx_buf; + size_t total_buf_space =3D num_bufs * vrp->buf_size; int ret; =20 virtio_reset_device(vdev); --=20 2.34.1 From nobody Mon Jun 8 11:02:05 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012017.outbound.protection.outlook.com [52.101.43.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B297C3F39FC; Fri, 29 May 2026 16:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073032; cv=fail; b=tbLmcVlyhRh4ZMNrLdnK10Kw8tmdNXFBEMb5+uEhLm/qH7Am0OQEiq18IubSrwSaDFWuuBdgS51lb6RUiE68sFtq0wZOne8rOFsZaYCyyp0fthNPzCHijzi4eQrmQe0YuN9bu56xuN4HK4tnbcLcMDqzcUjR8TWU3rSCQlY8k+4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073032; c=relaxed/simple; bh=bpHQ4+fs4OUgmy+fX5aJW+QqcFFlx9fl5ZGlhezBaQ8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZmJRiLjrzzbWXDnmxv6lZzACeIeVHl2amnh06Fue2lOY8ZuxzkwaOYpS80MF+x2jFxagjtLLaLGGP7CHTg9dedTRauQFDeXqGwcaMGpsLzizI8l3pKeRucXmj3o5hmNY//Um/zr04kngE6Sab2+TyDSesUxgM6pxn8ZjpKdzCUU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Afxsv2Mz; arc=fail smtp.client-ip=52.101.43.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Afxsv2Mz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RjrbkPFHiICoMysoz9GsBwtJcZr6u2OP2QzvVJ/050jvJSobc2IRu3YGWFIeUX3xqxsS8WFMV+4yiYkuwCwO/UjtnkK5VfXIoipGX4xCGFMM342nqr+YHbrLs/XfHE5SLW0dnsASToOOwPekbDMoxm8INfLj/JcduTciK1Z3uowd2epf8nLXOUDIULif41PLvo+0hQIVyq1iVNQRfyjH5/w4wUsMO45yTOg/n4bDyKxDwv7FOiwoYUKamOSLMdvsSj7MQ9mGD5reUEiQVmyCR+ZwOxDnAVcQr/2wcbejwerXvtdfsa/wciHf1cr4Cp000FagJLOz53gUY7f5tCxr8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oqnBq/mQtCs7BpGT6iz7C9DG7w18MQpjOM2mKMXuDXw=; b=sINFWr7lyz0pj6LDZ1vgXmldKeXiVcU9vbMycVK2F2pqscOvGXSs4GFQVfhtjr2DXii41if2jsTubmDUBh4jhO0yGhmGBLleBvPDti4C9cQ8eyj0wFP9vsy8ZHfirJ04ERoowsFxlFvX7dN+8y7Ce+o+hwc72r5vH06z51bAl6bO/0fcBtj5hhSCg+Y5mWcyCRYY23Fz4x4noTmoC0rqeLCJIm2yigKMVJEzUfY5aVELnRD9pnK5RYr7+ylZ2+zTl2UCKaef1gKfGsfec55FiH9wD/R4I5RqstTFDiEm0pM9TXz/pxrIBaW/pTVdRHWPMIErGCzuHz7QrrmJ1VQV3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oqnBq/mQtCs7BpGT6iz7C9DG7w18MQpjOM2mKMXuDXw=; b=Afxsv2MzMCWUQq5Zv8NLBmUPlmhA6fosWo5ZnswHHTBYOTKxLKbp6hfVjqJrEJwZ6xIxqK5MJdd+kjnDXJbYZrsL7KteGEpUb5SVA4jxQFfUtBc22AMuV/9DZFKlNuH6NpTWyWDMygT3nfd8/FNIsB5FcS1f7+Ve/F8xE9om9SU= Received: from BN9PR03CA0165.namprd03.prod.outlook.com (2603:10b6:408:f4::20) by SA5PPFAB8DFE4E8.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8db) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.12; Fri, 29 May 2026 16:43:44 +0000 Received: from BL6PEPF00020E62.namprd04.prod.outlook.com (2603:10b6:408:f4:cafe::1d) by BN9PR03CA0165.outlook.office365.com (2603:10b6:408:f4::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.12 via Frontend Transport; Fri, 29 May 2026 16:43:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF00020E62.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 29 May 2026 16:43:43 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 29 May 2026 11:43:43 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 29 May 2026 11:43:42 -0500 From: Tanmay Shah To: , , CC: , , Subject: [PATCH v3 3/4] rpmsg: virtio_rpmsg_bus: get buffer size from config space Date: Fri, 29 May 2026 09:43:27 -0700 Message-ID: <20260529164327.1827121-4-tanmay.shah@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260529164327.1827121-1-tanmay.shah@amd.com> References: <20260529164327.1827121-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E62:EE_|SA5PPFAB8DFE4E8:EE_ X-MS-Office365-Filtering-Correlation-Id: 490fca2a-f2a1-475e-2409-08debda17264 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|82310400026|1800799024|11063799006|18002099003|56012099006|22082099003; X-Microsoft-Antispam-Message-Info: 7V9TbGX2qI8lwZrQjM7t/ossCtUKuM0/s55RJf5QGN0qOGea0g6xft9Gl3yGWJA3MsXU1XFVCowZgV9exhKQ7t9+FCrgarrzJ1FJe3ZgsFh5giseJPEeTTopSEHJWMopShKyFZI3YoZNZ9ubDpPdlpYzPvSmiWcflh1sr/FpUDObCWiWHbfIGR2n4riVQA4UWAX8+4g8RWZx7HXbtqHpAtd35zSZXtHfL+GKgs4D2wmIIGRLgcLLR0bBT4MO24LX67Xkv22N6IrrVWwzlTWFzBj14fGgMG1bRuBZFge/QcrSJ8Bq4tYshMyPModGldjqny360YpRdqC6NF/UerlNvblQ+3uiu3Rb1s71L0425utSyYmUDisLbWyzLMBQvrjq40rItuYPe5tWJWz9QvrKpWEZ/Gs1jCgDcDlChfzbbFMw84Q/Bs7x3pdT57uUB2323OCKN3n1daKO5mp1ZOlrm3KFIm7Yp9yAkfcS7UqAoKd9xwYz8X4gLBWJkQWDtgcOjCRKJH51fCZjAqUb8vgqfp3dPIpt++My/AK4/lS6PxeznSMSVPReKTcKU5m1RK4XMyr0qiofxfGMU27FJ+NVkQmvBMBYvJQwNTN14c1kJ3/irawJRz4NhlhHZs9WfcswlLdZDyBaq1HtCx2hxnsZmE5/C5PVHJqtgEixrvSza11WHKNXFpjgaFTVBMPiClGK9LLMWvcuZWfSz3uTzYVkQHEVeltSq+ry1G67TRANKzU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(11063799006)(18002099003)(56012099006)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: er24q6uhKTcuwhNU7JjAcCCq6Swb/e48sTgqwSJGupTynWU2AN5Rr7VVQCMIhNvmORFfv2l7w+1hp74ZYolQUW30T84fgCbVhMIsqwkGM+0xpGIxv+JGL0CrCeief/aCGe0lnybIj+unWFZejdv1eE7E+Vg4tQ3nZh253FgqEDJR9BFqic9zWuRVIwx2HPCCWk4GEXbPJJyzd05S0uYCJfI2CLHqvrr+H5ngx9D8wUBn0V8hqRuB4qvES0MHjpgsVAJS9nFeTSijJREASZ5kDg12PE5n8M/HY/yLBop1PDLIcxH5iSH6mlGbxzMfqPQIrr6ctWEg7XyLWavmRJvQraa9vwoCIAyKaZ9z0FxMKkZNq444/XlysWkng99pqEqcc4BUK3BNI32C/wV1RI8PTsrBOyZHyVKS0AGkTOaDEyWnzJQ+mzhap+T9OG5FBwOR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 16:43:43.9303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 490fca2a-f2a1-475e-2409-08debda17264 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPFAB8DFE4E8 Content-Type: text/plain; charset="utf-8" 512 bytes isn't always suitable for all case, let firmware maker decide the best value from resource table. enable by VIRTIO_RPMSG_F_BUFSZ feature bit. Signed-off-by: Tanmay Shah --- Changes in v3: - change version field from u16 to u8 - introduce size field in the rpmsg_virtio_config structure - check version field is set to any non-zero value. - check size field is not 0. - Remove field for private config, as not needed for now. - add documentation of rpmsg_virtio_config structure drivers/rpmsg/virtio_rpmsg_bus.c | 90 ++++++++++++++++++++++++------ include/linux/rpmsg/virtio_rpmsg.h | 34 +++++++++++ 2 files changed, 106 insertions(+), 18 deletions(-) create mode 100644 include/linux/rpmsg/virtio_rpmsg.h diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 99df1ae07055..f1ab8e792f3d 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -39,7 +40,8 @@ * @tx_bufs: kernel address of tx buffers * @num_rx_buf: total number of rx buffers * @num_tx_buf: total number of tx buffers - * @buf_size: size of one rx or tx buffer + * @rx_buf_size: size of one rx buffer + * @tx_buf_size: size of one tx buffer * @last_tx_buf: index of last tx buffer used * @bufs_dma: dma base addr of the buffers * @tx_lock: protects svq and tx_bufs, to allow concurrent senders. @@ -59,7 +61,8 @@ struct virtproc_info { void *rx_bufs, *tx_bufs; unsigned int num_rx_buf; unsigned int num_tx_buf; - unsigned int buf_size; + unsigned int rx_buf_size; + unsigned int tx_buf_size; int last_tx_buf; dma_addr_t bufs_dma; struct mutex tx_lock; @@ -68,9 +71,6 @@ struct virtproc_info { wait_queue_head_t sendq; }; =20 -/* The feature bitmap for virtio rpmsg */ -#define VIRTIO_RPMSG_F_NS 0 /* RP supports name service notifications */ - /** * struct rpmsg_hdr - common header for all rpmsg messages * @src: source address @@ -128,7 +128,9 @@ struct virtio_rpmsg_channel { * processor. */ #define MAX_RPMSG_NUM_BUFS (256) -#define MAX_RPMSG_BUF_SIZE (512) +#define DEFAULT_RPMSG_BUF_SIZE (512) + +#define RPMSG_VDEV_CONFIG_VER 1 =20 /* * Local addresses are dynamically allocated on-demand. @@ -444,7 +446,7 @@ static void *get_a_tx_buf(struct virtproc_info *vrp) =20 /* either pick the next unused tx buffer */ if (vrp->last_tx_buf < vrp->num_tx_buf) - ret =3D vrp->tx_bufs + vrp->buf_size * vrp->last_tx_buf++; + ret =3D vrp->tx_bufs + vrp->tx_buf_size * vrp->last_tx_buf++; /* or recycle a used one */ else ret =3D virtqueue_get_buf(vrp->svq, &len); @@ -514,7 +516,7 @@ static int rpmsg_send_offchannel_raw(struct rpmsg_devic= e *rpdev, * messaging), or to improve the buffer allocator, to support * variable-length buffer sizes. */ - if (len > vrp->buf_size - sizeof(struct rpmsg_hdr)) { + if (len > vrp->tx_buf_size - sizeof(struct rpmsg_hdr)) { dev_err(dev, "message is too big (%d)\n", len); return -EMSGSIZE; } @@ -647,7 +649,7 @@ static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoi= nt *ept) struct rpmsg_device *rpdev =3D ept->rpdev; struct virtio_rpmsg_channel *vch =3D to_virtio_rpmsg_channel(rpdev); =20 - return vch->vrp->buf_size - sizeof(struct rpmsg_hdr); + return vch->vrp->tx_buf_size - sizeof(struct rpmsg_hdr); } =20 static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, @@ -673,7 +675,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, * We currently use fixed-sized buffers, so trivially sanitize * the reported payload length. */ - if (len > vrp->buf_size || + if (len > vrp->rx_buf_size || msg_len > (len - sizeof(struct rpmsg_hdr))) { dev_warn(dev, "inbound msg too big: (%d, %d)\n", len, msg_len); return -EINVAL; @@ -706,7 +708,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, dev_warn_ratelimited(dev, "msg received with no recipient\n"); =20 /* publish the real size of the buffer */ - rpmsg_sg_init(&sg, msg, vrp->buf_size); + rpmsg_sg_init(&sg, msg, vrp->rx_buf_size); =20 /* add the buffer back to the remote processor's virtqueue */ err =3D virtqueue_add_inbuf(vrp->rvq, &sg, 1, msg, GFP_KERNEL); @@ -824,6 +826,8 @@ static int rpmsg_probe(struct virtio_device *vdev) int err =3D 0, i; size_t total_buf_space; bool notify; + u8 version; + u16 size; =20 vrp =3D kzalloc_obj(*vrp); if (!vrp) @@ -855,9 +859,58 @@ static int rpmsg_probe(struct virtio_device *vdev) else vrp->num_tx_buf =3D MAX_RPMSG_NUM_BUFS; =20 - vrp->buf_size =3D MAX_RPMSG_BUF_SIZE; + /* + * If VIRTIO_RPMSG_F_BUFSZ feature is supported, then configure buf + * size from virtio device config space from the resource table. + * If the feature is not supported, then assign default buf size. + */ + if (virtio_has_feature(vdev, VIRTIO_RPMSG_F_BUFSZ)) { + virtio_cread(vdev, struct virtio_rpmsg_config, + version, &version); + if (version =3D=3D 0) { + dev_err(&vdev->dev, "invalid version of vdev config\n"); + err =3D -EINVAL; + goto vqs_del; + } + + /* + * The size field is not used for the remoteproc virtio transport, + * but kept for any future transport to use + */ + virtio_cread(vdev, struct virtio_rpmsg_config, + size, &size); + if (size =3D=3D 0) { + dev_err(&vdev->dev, "invalid size of vdev config\n"); + err =3D -EINVAL; + goto vqs_del; + } + + /* note: tx and rx are defined from remote view */ + virtio_cread(vdev, struct virtio_rpmsg_config, + txbuf_size, &vrp->rx_buf_size); + virtio_cread(vdev, struct virtio_rpmsg_config, + rxbuf_size, &vrp->tx_buf_size); + + /* The buffers must hold at least the rpmsg header */ + if (vrp->rx_buf_size < sizeof(struct rpmsg_hdr) || + vrp->tx_buf_size < sizeof(struct rpmsg_hdr)) { + dev_err(&vdev->dev, + "bad vdev config: rx buf sz =3D %u, tx buf sz =3D %u\n", + vrp->rx_buf_size, vrp->tx_buf_size); + err =3D -EINVAL; + goto vqs_del; + } + + dev_dbg(&vdev->dev, + "vdev config: version=3D%d, rx buf sz =3D 0x%x, tx buf sz =3D 0x%x\n", + version, vrp->rx_buf_size, vrp->tx_buf_size); + } else { + vrp->rx_buf_size =3D DEFAULT_RPMSG_BUF_SIZE; + vrp->tx_buf_size =3D DEFAULT_RPMSG_BUF_SIZE; + } =20 - total_buf_space =3D (vrp->num_rx_buf + vrp->num_tx_buf) * vrp->buf_size; + total_buf_space =3D (vrp->num_rx_buf * vrp->rx_buf_size) + + (vrp->num_tx_buf * vrp->tx_buf_size); =20 /* allocate coherent memory for the buffers */ bufs_va =3D dma_alloc_coherent(vdev->dev.parent, @@ -875,14 +928,14 @@ static int rpmsg_probe(struct virtio_device *vdev) vrp->rx_bufs =3D bufs_va; =20 /* and second part is dedicated for TX */ - vrp->tx_bufs =3D bufs_va + vrp->num_rx_buf * vrp->buf_size; + vrp->tx_bufs =3D bufs_va + (vrp->num_rx_buf * vrp->rx_buf_size); =20 /* set up the receive buffers */ for (i =3D 0; i < vrp->num_rx_buf; i++) { struct scatterlist sg; - void *cpu_addr =3D vrp->rx_bufs + i * vrp->buf_size; + void *cpu_addr =3D vrp->rx_bufs + i * vrp->rx_buf_size; =20 - rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); + rpmsg_sg_init(&sg, cpu_addr, vrp->rx_buf_size); =20 err =3D virtqueue_add_inbuf(vrp->rvq, &sg, 1, cpu_addr, GFP_KERNEL); @@ -965,8 +1018,8 @@ static int rpmsg_remove_device(struct device *dev, voi= d *data) static void rpmsg_remove(struct virtio_device *vdev) { struct virtproc_info *vrp =3D vdev->priv; - unsigned int num_bufs =3D vrp->num_rx_buf + vrp->num_tx_buf; - size_t total_buf_space =3D num_bufs * vrp->buf_size; + size_t total_buf_space =3D (vrp->num_rx_buf * vrp->rx_buf_size) + + (vrp->num_tx_buf * vrp->tx_buf_size); int ret; =20 virtio_reset_device(vdev); @@ -992,6 +1045,7 @@ static struct virtio_device_id id_table[] =3D { =20 static unsigned int features[] =3D { VIRTIO_RPMSG_F_NS, + VIRTIO_RPMSG_F_BUFSZ, }; =20 static struct virtio_driver virtio_ipc_driver =3D { diff --git a/include/linux/rpmsg/virtio_rpmsg.h b/include/linux/rpmsg/virti= o_rpmsg.h new file mode 100644 index 000000000000..77a530514d86 --- /dev/null +++ b/include/linux/rpmsg/virtio_rpmsg.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) Pinecone Inc. 2019 + * Copyright (C) Xiang Xiao + * Copyright (C) Advanced Micro Devices, Inc. + */ + +#ifndef _LINUX_VIRTIO_RPMSG_H +#define _LINUX_VIRTIO_RPMSG_H + +#include +#include + +/* The feature bitmap for virtio rpmsg */ +#define VIRTIO_RPMSG_F_NS 0 /* RP supports name service notifications */ +#define VIRTIO_RPMSG_F_BUFSZ 1 /* RP get buffer size from config space */ + +/** + * struct virtio_rpmsg_config - config space for rpmsg virtio device + * + * @version: version of this structure. current version is 1. + * @size: size of this structure. unused for the remoteproc virtio back= end. + * @txbuf_size: Tx buf size from remote's view. For Linux this is rx buf s= ize. + * @rxbuf_size: Rx buf size from remote's view. For Linux this is tx buf s= ize. + */ +struct virtio_rpmsg_config { + u8 version; + __virtio16 size; + /* The tx/rx individual buffer size(if VIRTIO_RPMSG_F_BUFSZ) */ + __virtio32 txbuf_size; + __virtio32 rxbuf_size; +} __packed; + +#endif /* _LINUX_VIRTIO_RPMSG_H */ --=20 2.34.1 From nobody Mon Jun 8 11:02:05 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012050.outbound.protection.outlook.com [52.101.43.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C014A3F7A82; Fri, 29 May 2026 16:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073037; cv=fail; b=Txtmypa/aAJJVkZh7DeCYgPUOAIupdzrbZxyW2U1EBkyi3zqndH926tgUAFg8aUzvvdPMw3JV2596dRPscZ/eXSocBxzpf+QWufMGLmF/7PdB1CdRDoIlk1PdsOGTMU8UWLYWjOMgGgWwRo18iMi39+5yqlnuDEQxDbQLZRAwSw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073037; c=relaxed/simple; bh=CywmKuSBN2/UBdYt7rYK4mTkiPfR5yfuzEVaYbmw3ds=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sLV+mEwKP3eT6kTBRE5eEaNSrjvXqREPuwxK7vVlZUkL43eWzhpbAbEAaf3+PlBO+Xprv20CJ/uTIQFMWIDeOHLUYt1JXOqcPPQ6T2WkCgWvjQRb6p7wwdzE3i4vEYHAIpP24YfLf7TrGUoSp26ygcGniqJWf4M6XD9fbuS6tLk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=X1T22KoJ; arc=fail smtp.client-ip=52.101.43.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="X1T22KoJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VO9Z6Shu9CeyPFNKAmjMozdJwjovbxtMxe/k210UltRQrQeOFG7sZ2A/yPyGGTUAs7dcVhghfSaqymk3ZWst3FYnYbphIZKp9OEV0QKmJ5u7dhBQ2n6e1LdztAKp9ebmjxARC+elcA3YZB7YZCqcuxRdclkyMnTLxCuRcaHP0sWLmeiPdf90rdSDtTS8yH8z/y/BHP1zDzhuJczvpz/5J9ZK36a/4ajn0IAeDHA5QsVHViK0qyWSrnCHYlZ6W8+3MpMKPGl+RL6zjfpJE+fwU/Oo2KoCarJJv7kcoLksOGDTjHGFjk9eCcqN55jglflK0wwZvYcyhtaKsHYOTm5yVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IYDaPjU2LfdPbC/6ZCujTEDVKzmwX5Dul1ysRjZ1Vf8=; b=Rs4LtLWrOjqIZB+kKFGVEFT8p/MNdrb1jms6/mWY2jHKh/NT7k6XRIZVGzXYs0FLahhmMFqtDvaHFpkYD4CDa/CsdgTVnOgqbYTw7X5DmunhBdvzKr0dtczPB5EkCt6g00CgYu+3VErP7V+TRlq7LrQyhXd4a7bHSxB7WCosqLH/SpAITB42ig1q1YaY6UtkBSMibcqcSi9SilHrAPNMcCmSDAOdtjBB1qqk0PzMWUAW8raLYF/OqWQSEeeNlRoP4kH/v30qvnCbTPlv2S12Q7uAmrJI04vXCSbx3N2u9qKYG6wAq3d8CMnpSeYf3xy83JZ/bTnwVyY56chYQlbRwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYDaPjU2LfdPbC/6ZCujTEDVKzmwX5Dul1ysRjZ1Vf8=; b=X1T22KoJV7q/mxfFMIbWYb3LUt4MW8Fc7CK0VQRdxTJdN6NvNdciILcSf1Ir0qA/LQNEkpCGPmuaskuYHtQyEF9C6N7ttSeGrGlSZJpQtYx/aE0m/saFyVuqvay2Z/aO2wq1//UksWmE2HlusaUeq7njpPsklbbPCsHHbJqm6dg= Received: from CH5P223CA0009.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:1f3::7) by LV2PR12MB5799.namprd12.prod.outlook.com (2603:10b6:408:179::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.14; Fri, 29 May 2026 16:43:46 +0000 Received: from DS3PEPF000099DE.namprd04.prod.outlook.com (2603:10b6:610:1f3:cafe::16) by CH5P223CA0009.outlook.office365.com (2603:10b6:610:1f3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.13 via Frontend Transport; Fri, 29 May 2026 16:43:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by DS3PEPF000099DE.mail.protection.outlook.com (10.167.17.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 29 May 2026 16:43:45 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 29 May 2026 11:43:43 -0500 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 29 May 2026 11:43:43 -0500 From: Tanmay Shah To: , , CC: , , Subject: [PATCH v3 4/4] samples: rpmsg: add MTU size info Date: Fri, 29 May 2026 09:43:28 -0700 Message-ID: <20260529164327.1827121-5-tanmay.shah@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260529164327.1827121-1-tanmay.shah@amd.com> References: <20260529164327.1827121-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DE:EE_|LV2PR12MB5799:EE_ X-MS-Office365-Filtering-Correlation-Id: 3019679b-75e8-449e-d199-08debda1738f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700016|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 11z82bDdLKy9VLL01eD+3fVZmM07pSEptsM7fW9itAYWz57Ewg7QVYzl0ZPR6mTJAjedb2zuWlCu3r+SN1jTmdhu8W2Q0i+XlN1Sntu/Iw3WZeiZfy4xCI4zZq5cu/vTaHNPFYnfH0dtbqhYn+LvzoenUKrv+yNsEwzBOPxhENa9/d/tzsIRVv/9vNJt2qh1H75VyH5L0tHpBEKEW788HA2G523sxzzwE+Jhdn0ZLC5VmmfiRH5oy/BKL6KPze2Hkjv+4Tc/M3e9eZ9RZKpAEiC3zMW0Mwjp1BryHe7uPu94RTmIVj8dSDfbLp3myvg/to20SZ8s7sDgGRO/0/1cmjMxeUfBHlepjrAmoAbkCZIQMag6h9VSRucy0J649Za4kaxYZKb5do3E2FaIVsHEVA1ygWYfFNoZUtF5yn3BJcvlXnzc2/tVbIH5o0CSdhbxxUUYt3qaGFHfskxCuf9+erZsKdWY0G8yZuh3/CkL2ewHIFXwPMYxfI7yTsxlISShcGbfR+F0hg+0jgkmk6jAXe/d+uRbr7RQxCGlrydZLSzQVfFBNUBFZWzc7WV07I4UlIjl9jXwrRCOXCvc7dk8nuf69a+fsfIAjFc7QFq3v7Aftl1Nkv2Urw8wzdzsTdfybwy1oSgC6+8ruDQixbMfDTSgmrd3zAecoKpSUnniiIPzrdHfn5weUzhqwLeOWaxFnDdotHIzxAIFGChJIP9jcRySgjt5G1v7ck84wfQFEVA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700016)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iDj/AXqPDJNzSwiO5cIuMh0ZQkVfiK+rD9jau2d6INifpdMY2Vrv/hvi4C7Fw5CGMb2+tQrkXzj3r9y+sH7Fb3huiKFXzmyppuDM8nEvJUMcwLhPDARqZvq1uN6PcQpXtKr4UBWzSwpyxHcpDdbCe/57Gqy24u8YXNSN+XFG7OUG/sv3y9lCuXrNWEqBk9gWbYUXiqnI52h2P9DTfBiV7UKvXKgBXimZEj/Oh19qauUEqhRoBmgYVcriwl+1S6E7oCsUlchlXdOIjXMTAAkbM3UCkT45c+6PsddWiTICCWLyCSkWzWCVsQaUnWANAXIZ39XeSJ5z+XcW/Hi6H6A+7e1qVq5PConRHF15DVQsJEoKKGwUL5Eyvlbu8SCbUtfKExeqVp46PgbHuXcO7diexapdV4PxJ6pPApk2PjnBXkVtiGSYWiIO905+5RFFstQt X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 16:43:45.8632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3019679b-75e8-449e-d199-08debda1738f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DE.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5799 Content-Type: text/plain; charset="utf-8" RPMsg MTU size can be variable now and no longer hardcoded to 512 bytes. Add log to the sample driver that prints current MTU size of the rpmsg buffer. Signed-off-by: Tanmay Shah --- Changes in v3: - Check for error when retrieving MTU size - %s/mtu/MTU/ samples/rpmsg/rpmsg_client_sample.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_clie= nt_sample.c index ae5081662283..55afa53189af 100644 --- a/samples/rpmsg/rpmsg_client_sample.c +++ b/samples/rpmsg/rpmsg_client_sample.c @@ -52,6 +52,7 @@ static int rpmsg_sample_probe(struct rpmsg_device *rpdev) { int ret; struct instance_data *idata; + ssize_t mtu; =20 dev_info(&rpdev->dev, "new channel: 0x%x -> 0x%x!\n", rpdev->src, rpdev->dst); @@ -62,6 +63,14 @@ static int rpmsg_sample_probe(struct rpmsg_device *rpdev) =20 dev_set_drvdata(&rpdev->dev, idata); =20 + mtu =3D rpmsg_get_mtu(rpdev->ept); + if (mtu < 0) { + dev_warn(&rpdev->dev, "invalid rpmsg MTU size =3D %ld\n", mtu); + return mtu; + } + + dev_info(&rpdev->dev, "rpmsg MTU size =3D %ld\n", mtu); + /* send a message to our remote processor */ ret =3D rpmsg_send(rpdev->ept, MSG, strlen(MSG)); if (ret) { --=20 2.34.1