From nobody Mon Jun 8 12:11:55 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E96183BBA0D for ; Fri, 29 May 2026 09:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045918; cv=none; b=kEF94jHOFfUAMfkin/NAAMmyPb2gM2pOMdFEOTDODlwX1AaSsnn8IDA8qH54/6y08eYXdDtHp+8o6QAO4pL4KAyo8zsWScPtyjtFMrAxeGoDebVI3KGBvHR1LzJ9ujjmcdNcBS/db2wrQgD2gk2KrLRlMsOo9HWx4mJEe0K1TmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045918; c=relaxed/simple; bh=kduMQMEuEfr+wqAKGR4y+slgP4W5W7GDFBAeNV/zTKs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=hJIwk213m8KC6L6PNpMlxPO6nYAvr1pPehnp0oWXph4eIIgtsFEUDOwvrBwJbyGbUqfgMFsOscrRpkzPogDufYNT++qoFWHS19PvxDHQjIvHFpMigdLLb+pi2bc0plz318ldSSIgPkgMvbmDDJ9Bhltr2f+BitZvEdCvFCAHp0Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbMpvXTk; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbMpvXTk" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4906238c62eso52112385e9.3 for ; Fri, 29 May 2026 02:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780045915; x=1780650715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=QKMOZZqY8qXuWzcol5aT0Qr0Wy5iVaDJuahhZblfGNo=; b=CbMpvXTkpoBxIiQCn27nehA9/XuOLstuns67Y+zC0ioBIc9vuQg0Gwvme/38UhU+qU ynHSsrcGO4lB3nW9Ri4P2Fp38tzxnVxdsNrg2wVtaI90O4aQP+4AoYvG4c7feudM03Bi UPZoiCHzAl/8O1A6Qj4hGVXb3u8E39zhQUIApooUWDc9UHeL8SLkBys0mOZYbqvWp8fR 591W6cCYFzOhA2L6ztrsp2WuGkI/AYoAh8SwLJX344eT8j5GuBpF8LnpAFjmgCzMf0a0 5hKtkmOUlP3o1WD+u9gFXeUdE+3t032Bn9jefKN2RANPuDV+3QoFfNY0nvS/+XyTCMhe +oHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780045915; x=1780650715; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QKMOZZqY8qXuWzcol5aT0Qr0Wy5iVaDJuahhZblfGNo=; b=gXVYs8Q27IQHJoa4U3gLWxey64vDAltvxQmZ9qINXKFpvqk+tmEGSEhRdZTV+V68aR RlVULaxATJLTUpqyEUpxZ//fY6eslLVZuAvDnXpiDhcZkGIXZzm09QBDBNlcusEraUS1 8hLVpcqGEiSuLhtxQLdrHOFnUvvGFSvbWoMJ5OxdKSjml0ahOwOCOV11UGGgEzn0s7pi Iecwo3Wmz7aBl0M5DCN3reFRlc6r/9wy+EiuOqPf9HmxwsdpCddjog91AOoXAYHWm3kw yieDAq07f9+ktCtp1XPpg+C8WToMMe4pFFKlsKQAtYy56hXMkeKnS3BnotTVdKw5r+On kr0Q== X-Forwarded-Encrypted: i=1; AFNElJ93dfQav563sD1+rHb6aihZzxO5f8+/K3MZEx4HJhlO2Vz6iNbt5i/XxmAs9YqKqzG6gLMK/XzO9X1kpbw=@vger.kernel.org X-Gm-Message-State: AOJu0YyURJ8pDGplnUwiKaHbSdzmg2LdDAEOhNQXc5Qn4W/y7ESseWwr 17aJrg5bg4Rv4EY2LAJbhU4uINe6n0o8KLieYpVVLsWKaENTwt9/eP7F X-Gm-Gg: Acq92OFIbFk0367EGF2mMDvD2oant/E2IxVL8SRdiJrEdjmnFO3HelhaqRR8xwe08yS Fc2qBWt4y7mcq36rE7ADHTJIBxZSyMapE0os0aiWF8ArgLvDRxFuFhPkwW7fwKZ++WIa5EQmRqI oomMc7OsRpUA5VjvkKtaj291HF8TPSMLobozAHctx1SPCCFL6DTztmKvMcZqg232CHrP8kw9F6a VS+pRCf5ZAiUQC4cMN6fShv50QgvFGisv8sPxBbHPUkcnMaO4H+32hbLTPo9MUybZNZk5yAEZ84 VO/0QtymZqjYHel6rkBgjsHUQu52dfcpk105yx7r8y4A2UCtF3hJNHqdqMRsO74WryP9yQhbpnw 2x3JNV0LWxjAX5ks0nfZ/+ZE617J7DRDRWrVvTh1yE48RwiPFt+RUn+08M2nK+KD78T0WP27ED/ qK+z+55wyZ6UPX27IbDezJsjT/HMF7dy6y/dZmjEkdB8Zxyw== X-Received: by 2002:a05:600c:818f:b0:48f:d5a0:284e with SMTP id 5b1f17b1804b1-4909c0b9344mr37332445e9.28.1780045915380; Fri, 29 May 2026 02:11:55 -0700 (PDT) Received: from foxbook (bfe246.neoplus.adsl.tpnet.pl. [83.28.42.246]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c123406sm12603625e9.5.2026.05.29.02.11.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 29 May 2026 02:11:55 -0700 (PDT) Date: Fri, 29 May 2026 11:11:51 +0200 From: Michal Pecio To: Mathias Nyman , Greg Kroah-Hartman Cc: Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: xhci: Remove isochronous URB_SHORT_NOT_OK handling Message-ID: <20260529111151.17375c5d.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This URB flag was never supposed to have any effect on isoc endpoints. No kernel code uses the flag except usb_sg_init(), on non-isoc only. USBFS can't use it on isoc because proc_do_submiturb() rejects it. Signed-off-by: Michal Pecio --- drivers/usb/host/xhci-ring.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index a6c2f2373849..54fe0fc3dd8f 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -2400,7 +2400,6 @@ static void process_isoc_td(struct xhci_hcd *xhci, st= ruct xhci_virt_ep *ep, u32 trb_comp_code; bool sum_trbs_for_length =3D false; u32 remaining, requested, ep_trb_len; - int short_framestatus; =20 trb_comp_code =3D GET_COMP_CODE(le32_to_cpu(event->transfer_len)); urb_priv =3D td->urb->hcpriv; @@ -2409,8 +2408,6 @@ static void process_isoc_td(struct xhci_hcd *xhci, st= ruct xhci_virt_ep *ep, requested =3D frame->length; remaining =3D EVENT_TRB_LEN(le32_to_cpu(event->transfer_len)); ep_trb_len =3D TRB_LEN(le32_to_cpu(ep_trb->generic.field[2])); - short_framestatus =3D td->urb->transfer_flags & URB_SHORT_NOT_OK ? - -EREMOTEIO : 0; =20 /* handle completion code */ switch (trb_comp_code) { @@ -2418,15 +2415,12 @@ static void process_isoc_td(struct xhci_hcd *xhci, = struct xhci_virt_ep *ep, /* Don't overwrite status if TD had an error, see xHCI 4.9.1 */ if (td->error_mid_td) break; - if (remaining) { - frame->status =3D short_framestatus; + if (remaining) sum_trbs_for_length =3D true; - break; - } frame->status =3D 0; break; case COMP_SHORT_PACKET: - frame->status =3D short_framestatus; + frame->status =3D 0; sum_trbs_for_length =3D true; break; case COMP_BANDWIDTH_OVERRUN_ERROR: @@ -2461,7 +2455,7 @@ static void process_isoc_td(struct xhci_hcd *xhci, st= ruct xhci_virt_ep *ep, break; case COMP_STOPPED_SHORT_PACKET: /* field normally containing residue now contains transferred */ - frame->status =3D short_framestatus; + frame->status =3D 0; requested =3D remaining; break; case COMP_STOPPED_LENGTH_INVALID: --=20 2.48.1