From nobody Mon Jun 8 13:29:54 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB2A348C51 for ; Fri, 29 May 2026 07:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780039178; cv=none; b=uvaIFH4+PuKEJGR/Q5wuwcq9LoQ+Q5k7gWmn7E6DHNb481sXOjuohIhiPSQxOWtimJMo7ySFOKwtaAoqhBjSSgyS0n3NUHK7ch2LYBsKv6BJqiw/HX6/ciL1KICVt6f5AoXBMExTWuhA18EDv7jTOM7cBC0BjDzfDYlEcui+PTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780039178; c=relaxed/simple; bh=lvBzjbjwsHSamzgVJuzljlh4xQh6VT+oxbFJ8mT/Hxs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lPyeKkPMkuktvfEWO7tXZLGKwZGx9DKwwENtqjNkosyArkOoihEZ4XCESovioW6pcx2PfMGjjQg+DHkSA8KBimFQOhJ/Wssc+zqCgxuxvAzzwijKnTbsHnWnxOVg/ab9FpyBySmSlNyDiGnJvb/MsTWzvk34txN5xBDAungNUOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=okIJ7jlU; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="okIJ7jlU" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4906869f0cbso57862935e9.1 for ; Fri, 29 May 2026 00:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780039174; x=1780643974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QUPoKgsqf9IYvngriOSrkcKb9UgwJs35aRy/89k4iTs=; b=okIJ7jlUKfW5sZnnGznruIenfW31sXofygIixXJDqPcmOfCgu3SmmoVAm8dRUqWpu8 r5opeZ5KDerJC/E6fJMOlfA1fwxjO0f8pVp76bOWCHKR1AFMbkZC5H3hpEQqbSmPmokz OyC8970+UZ8FmjvvKSuVAX+6P5YjZzwlnANcunIz6Cf757K3vUn9E71uGBmrL1ZiWZnT RhASMYX5Zgu1dhr8CFLGJ1POHy3hN47Wzq15HAWlmTAN+2K4rogtxm2ma+5EW95uhT4D LbhFscJLfs5I+ab+Chj0EAHFGMZKRqUyN7CsyZQz8DdTObvEvicrN1Rg65FzksWUl9HS gylQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780039174; x=1780643974; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QUPoKgsqf9IYvngriOSrkcKb9UgwJs35aRy/89k4iTs=; b=dlIofMhBsITzjo2qwodtYfEggOZ8TaST/Q1JV/8XdADDLOmJerQTej3WAWbpZeqVv7 AdNdXTWj3yRBW9KZ8Gh6DzQfyzPLM9b/VkHnB2o067Q9WndRCA93XHFGDYmN7aqMdIzM FecjKRq4kQJYzmSPDPTALv+xEDw4g7qkWHPiIQkfPLcRtF+d+73biVXmV4rxqzHfUKzr EJwFFsCBEhvJQAjrygeIsf6ieCkksKZcW69vKhza7rIqrkvGeZi6KdR+KHoC9hAOeUYh RgA3pF5tWL+Q5iuYgKtSJzxq7g/03ijSw+w0Fos1Sve6r2FLOLvyJnG3XM018ly80jj7 J7QA== X-Forwarded-Encrypted: i=1; AFNElJ/5Iojqm4z8XBWdVp5uoGd34jJdWKoq6KWkwnxQa5uZvUXj13N+RRAryQ5jWIfDoY13xyHj0KUDel+5dn4=@vger.kernel.org X-Gm-Message-State: AOJu0YyaMV1qHCz4U9FxhJksK1c6pQy4LTVKWKJUMWcOY5T3MQuG5+dW +V1bQGteB3NfpaCsNwwc+o46tMU+iuzxjQExkNwi4/yMHwTMIVBZDHR6c/C9mkax X-Gm-Gg: Acq92OEAjUTYbWXOR5EhJtxCo5CBS80GeSm9M43ErNoPXJ6Zi+ehEVcs874dBznZyak oeGB8JL7FVhRN7bhus6vtwoWdh2PF0lMpr8A/64QQ1mdOKgHZRY0BkeC/47VFfljFicYVTvYy13 sF61x2RqYkfNcaibFIrWFuZ35r9VgPbIN5V2eHx0OotQtkfkAXCEiDLCUxKKwtV5WBOVM8Zty7b 0WfjXYqL9fFIa+LJV7YIQEB4CX8T7DBmGHRySeCbwXASZ6Hn0dzl64EiZSVF8H/hkXCZtI/Xq4b ROEpRUhUrINPLKqzwYs6L6CkBN3PWteOODyvmHK2EOqCcmfYuCkfN5sJZB7rwAg1JeElbbdG9l9 kFWW6rkUDHr/X7huoTxhhbausVdDIu+Fk4NP28cT6pcYpWdzgpfrifv5PxQrVoGzODzdi63ZImy 7bOGmuf9bvBKiD6WFXSnSGT89STS6wyOlFD1hc2MUcT5t9E7OJlGPeX+Q2vRegfmkkMI4JkcCUE iO94T9VITPK4jsPsvgbcNuPZKgmqA7rQYA8EXiN4Dl3f+U6AfTcBmwgDftObAat8+NcsprhP7M6 qg== X-Received: by 2002:a05:600c:c3cf:20b0:490:5466:8591 with SMTP id 5b1f17b1804b1-4909c07f2b1mr20575105e9.12.1780039174418; Fri, 29 May 2026 00:19:34 -0700 (PDT) Received: from localhost.localdomain (host-217-59-207-212.business.telecomitalia.it. [217.59.207.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c114e99sm8610615e9.25.2026.05.29.00.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 00:19:34 -0700 (PDT) From: Alessandro Schino <7991aleschino@gmail.com> To: netdev@vger.kernel.org Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, pabeni@redhat.com, linux-kernel@vger.kernel.org, Alessandro Schino <7991aleschino@gmail.com> Subject: [PATCH ipsec] esp: fix uninitialised req->src dereference in esp_ssg_unref Date: Fri, 29 May 2026 09:18:46 +0200 Message-ID: <20260529071847.1301-1-7991aleschino@gmail.com> X-Mailer: git-send-email 2.41.0.windows.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When esp_ssg_unref() is called with already_unref=3Dtrue, req->src has not been initialised yet because aead_request_set_crypt() has not been called at that point. Use esp_req_sg() to obtain the source scatterlist directly from the tmp buffer layout instead. Fixes: 2982e599fff6 ("esp: fix page frag reference leak on skb_to_sgvec fai= lure") Signed-off-by: Alessandro Schino <7991aleschino@gmail.com> --- net/ipv4/esp4.c | 2 +- net/ipv6/esp6.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 5d3a8656687e..2429c7845984 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -114,7 +114,7 @@ static void esp_ssg_unref(struct xfrm_state *x, void *t= mp, struct sk_buff *skb, * Skip the first sg which comes from skb->data. */ if (already_unref || req->src !=3D req->dst) - for (sg =3D sg_next(req->src); sg; sg =3D sg_next(sg)) + for (sg =3D sg_next(already_unref ? esp_req_sg(aead, req) : req->src); s= g; sg =3D sg_next(sg)) skb_page_unref(page_to_netmem(sg_page(sg)), skb->pp_recycle); } diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c index b963b8e72604..50af6ab9b8fc 100644 --- a/net/ipv6/esp6.c +++ b/net/ipv6/esp6.c @@ -131,7 +131,7 @@ static void esp_ssg_unref(struct xfrm_state *x, void *t= mp, struct sk_buff *skb, * Skip the first sg which comes from skb->data. */ if (already_unref || req->src !=3D req->dst) - for (sg =3D sg_next(req->src); sg; sg =3D sg_next(sg)) + for (sg =3D sg_next(already_unref ? esp_req_sg(aead, req) : req->src); s= g; sg =3D sg_next(sg)) skb_page_unref(page_to_netmem(sg_page(sg)), skb->pp_recycle); } --=20 2.41.0.windows.3