From nobody Mon Jun 8 13:29:42 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE062EC09F for ; Fri, 29 May 2026 03:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780025670; cv=none; b=FI3BuSoRmIT429PmWsR0IYcgJXYfnxJhgZZbTczOzVYb0RzOb8HuWDIohVBKw/uyX/s+Iyj4ZKHbbV6VmQecQjTXf9mrUD+EmNpbIQ2zEPcHH/ge8je11QlniEaXxwuqaYPcCRkUDwsJbKlvncnEyrcyrOdTkqITYkSCggcR/mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780025670; c=relaxed/simple; bh=/X9Gx9nrlqqYvQNamVBrEU//0++TS8PHZQfk3nvxaZQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=p8vJaolQyD/LjaeqaVvHeaUquoATmyPU8M6qmxtQrr9MxY6YcSy8x7qRH97++ewB95d/k4nQ5JxkdAd49f6+FSKxtFwzFP/pybkRcu8mqNjRmcTS5X6frFxOBQkVmMnkGW1wtYd/hEk7cXcUWziwEhSpE9hz9SOp0lt+U6ghljo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=khzVJKIy; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="khzVJKIy" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c8027e876fcso5564593a12.1 for ; Thu, 28 May 2026 20:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780025669; x=1780630469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3sgklvG/C53PAwo2/sITXhbGcqoDKxJ+Vu3aUEy7pgU=; b=khzVJKIyzoldyqXjx0vtdgTgVinGQXl+ICHzf/maHvnabr/BCEJRjSMdvIW0FboD6L PysVk3ByfyB5OK8viJ4yUvE+jeN8b5aWR5GBV1d/FbU0bL9NvC0+HVeMr4YYY04KwKOw UXpKvGNDavxIRffcKjR1unIrKcB632gFyRcXGnRuM0PlzFR31wsJ9pdXt7o1cit7/4Q8 eCJZp1okJdc925AdpEWGNcuoo1aAS+voGAhPNqwtjzEmtzzEOXVhH7EQFFgFcHj961rG UPkqPbbTxswj5GKFmchNN1qPUGR1dxuj9G3COzQZBFJoXoEnypNd4F0fqVttlAw5ufu6 E61A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780025669; x=1780630469; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3sgklvG/C53PAwo2/sITXhbGcqoDKxJ+Vu3aUEy7pgU=; b=Uf9jzqX2fUw/SremCjyKmwSIJaTwiu3lBXvg9mTh2J30eurFfhDJTVTzrZ0ScMfz6D GcfdlammK/MNjw+O5Rc9EL59EHvGer/gT8HTCbBWoABa8m1kfPj8tUrqTuTU+aJJWDS+ S6c2+bjD8L7ookPtQA7xBKdeZNPZunAO80wbGfD5IWPuznKtuptWep3M5+8Wpdz6VvpV 8pHSzvQjJWgsFBrO5BmzzdDyDK33LP1eXnUkG3IZxZnejRyF1A1KURyT2zo/8YtSnJaG B8CQuPlcWbljS7cxNIN+mNRdg8VJFHj0vB1bYEtSOuWJDLo/m5SDN6KOYTemVSdDlxCw 5pFQ== X-Forwarded-Encrypted: i=1; AFNElJ8Q68D9+l4VO9Ky2T/41xFM+NVXumbwJJvuO9sWUGVyvXeFQCSh3g4SEJudVpm8giXSkG/sjGrMCGaDsJw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi64rD1Uc0CH/2ETQOg8FQDA5TFJraIrYjzJnuXBLw3SDUOiHY +319UYEHSr9u0q4JXIHJ2dajh0RLLBl5TvGvqZiKjcKdm0Zs4x5jM3Nb X-Gm-Gg: Acq92OGEAVAuOGmNr6IGSAo+l/jKWE8e7PC7+Yzu1gLkGXLW+UDvzLqSIpWowkQEyXP x3wcRMVXs6Yr98+AxFe8JTMppYHJTz1Vuh+yyzRd51G+ibjy2AZ6/r+Pc1/Dr214mkrZ+XQVZRQ 6/H8ftMdtlUz7jOStGPSLz6wVLCV5zCK5TzlO1TogmX4X9OOorp4MwWhz4lcDCTcmvGs7WcErmP 9MtYwJMZRW4JzaOQrqhB4NO+p/Ho4Ydd6u+EfYRsahKpZPeym3LH0nB2O+NQNhF00hN+bB7X6Un QVMaBzRAmZwmbUTQd6/4WkAnJ0HEt26G4GOiiHiUVHSl14FpQsURgluFaogjTFNciExq+o1JNBU GoRqEEC7Mu3bZT4KySm01BB9IDeRC66BuagxZpSsTKNNmTtCIoTqzCE86BP93b7ttsAZ3FhtBiE Q6Ea87oR0lYBDz/6nvsLaG8AFIPWhoeYdL7wl5Xm62ksJvKcdsatu5nrb6A+mAJTjj2y+WOc3uj 2wa44S0sUeuRHceuiHQI38GtsBpPtdxVi11+xDi6onSuGncwr51x0PJw0Nv+ULnBoM/qI3hBXjY X-Received: by 2002:a05:6a21:1519:b0:3a2:d79c:4149 with SMTP id adf61e73a8af0-3b412314c2fmr1086635637.28.1780025668501; Thu, 28 May 2026 20:34:28 -0700 (PDT) Received: from bass-virtual-machine.. ([163.61.198.39]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85771a7c04sm306821a12.1.2026.05.28.20.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 20:34:28 -0700 (PDT) From: Gui-Dong Han To: keyrings@vger.kernel.org, dhowells@redhat.com, jarkko@kernel.org Cc: ebiggers@google.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Gui-Dong Han Subject: [PATCH] KEYS: Use acquire when reading state in keyring search Date: Fri, 29 May 2026 11:34:06 +0800 Message-Id: <20260529033406.20673-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The negative-key race fix added release/acquire ordering for key use. Publish payload before state; read state before payload. keyring_search_iterator() still uses READ_ONCE() before match callbacks. An asymmetric match callback calls asymmetric_key_ids(), which reads key->payload.data[asym_key_ids]. Use key_read_state() there to complete that ordering. Fixes: 363b02dab09b ("KEYS: Fix race between updating and finding a negativ= e key") Signed-off-by: Gui-Dong Han Reviewed-by: Jarkko Sakkinen --- Found by auditing READ_ONCE() used for synchronization. A similar fix can be found in 8df672bfe3ec. --- security/keys/keyring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/keyring.c b/security/keys/keyring.c index b39038f7dd31..243fb1636f10 100644 --- a/security/keys/keyring.c +++ b/security/keys/keyring.c @@ -576,7 +576,7 @@ static int keyring_search_iterator(const void *object, = void *iterator_data) struct keyring_search_context *ctx =3D iterator_data; const struct key *key =3D keyring_ptr_to_key(object); unsigned long kflags =3D READ_ONCE(key->flags); - short state =3D READ_ONCE(key->state); + short state =3D key_read_state(key); =20 kenter("{%d}", key->serial); =20 --=20 2.34.1