From nobody Mon Jun 8 12:16:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9676149C7B for ; Fri, 29 May 2026 08:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780042159; cv=none; b=KMrdzFAlh7W1jRXLsvjkqIJQi2Nodzo+UUDBTalgdcN5KCiudcWcsTfSLkeGX941MpAaHMnikov4ndUmqsCyRNREzlFK1YuGUjn/liQ+1KUiSJgAExuySdZ9CLDEeSaiWH3GL2lLgiNInI/+2VDF0ANDywYU1CEuQo5fLWkC8rA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780042159; c=relaxed/simple; bh=N8hfsxpSiKl22KeegE3vYAhGOHOFOR0ac/DSaLY3BoM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iqSVHQBPqlel4H//PLEXlmhnRfddy2z1+7zf+QzOwmYh3N96Hk59dayow0+9CfF0ERiywF8ooSOR2hb0n4W+qH7pgZosIWTUCpgSMiWlpP1qVQYO3PNr9pAQ0Ww2nxDoNaxPUpbplTV0OESJxQCd861Y4Uj/qD2TZV82tFfuSEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q81xpEDK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZBWZQ/Jx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q81xpEDK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZBWZQ/Jx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64T6HkrL1370525 for ; Fri, 29 May 2026 08:09:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=C1Jxgj5bloGFbb+wxjgm56 VvWTxc0wnItMHSSsAedd4=; b=Q81xpEDKH1LulZJnw9B9wvFS3aK55ts7DlIakj cIHISARP8ZYj7jaI3fwhc2OpSrJsIZhFYR8It370KHtFHNsbiwWDByRDgHQtkP2Z WPedeXykxYR7fAvJqOROo8ldcwUmtoGajKI05PgaJYDA4+yjKzdTJv/jujLcE8vl lx9Wa23jhHW7nQeYsdUmf2nbLdL/Ss3TJ2IxS1aiXP9kwun62z/R7TnwnxvP/6Rt OefXYLhqRifUD7MfV95x02DVMU+rE4xER5sO4bCyLKKej2oFwYbQ7fO/ZV2/k15F JU+Qw6NFS0Tay7L3B51zUu/jyMcU5WtzpGy6woNRTXalQIjA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eety5u3s8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 08:09:16 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36b7c55406bso1447575a91.2 for ; Fri, 29 May 2026 01:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780042156; x=1780646956; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=C1Jxgj5bloGFbb+wxjgm56VvWTxc0wnItMHSSsAedd4=; b=ZBWZQ/Jx/YaD+7QezjmWHvBkiNQBigL/EIk1il4hvAYfxMLQTrqtsXqWryMPQKyrz5 q7xVb0+8qrY0g509NM/oJkU4pPXZPxYJO2iG5+VCchWcsEReMlzvWi+z7t1niI9HeUAS j/G+94APWofW4y+Tylo8fEjS3EXu3PZlikEHiUVRu+VQqg1MFpESeW+fgpWRZNPPYYUA P3GzFN2Nf+6+v2hl2nT5shXfWcaGapcPi6nmyE1W3njDQshoqW2ikrvqJ7uPAxvVnMme qh72HQ5Xj/iHFbJKCZIqjgHi3Yd2Ltqg6Bg0aRAOCqWadgSPDCrmg7L1YcIf50M+aiZ6 5aPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780042156; x=1780646956; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1Jxgj5bloGFbb+wxjgm56VvWTxc0wnItMHSSsAedd4=; b=XSE03YBp8Vzlp3fq/QDhkECGqCe1N1ec48ThcR3scEQ6Z5XC6O06OJVYJhaIY3uqB2 axDR6xgcpDi28jqJbTaRtynJYKSkubWQ3p5qmP0KqBytkJdp1xqFevlsrU2utmd2Cq/S K4pIuGg35dst32fWnW0KB7+DuySaW14NGFF29QHJSrA0jiLpf5XSHeQUt8VKFotlkW3c xQvkZznjR0A38u+MLOmMri7sJFgpnifz2ci25usm3tH1HUs5eJg7B+unQGMca/Nb7ZGm ORYbnGdol2zqZu6grqxhIkMsFyoMm6Zq1Hd38t89WZu47M+xwRwY90jTrhuRsTlzFR+S eaUQ== X-Forwarded-Encrypted: i=1; AFNElJ/uAEI9fkXLBUM37Kx82H1FPMvgNmqzWUBnFU8QU4IlbIMpl7IiSDQr+KzloHPFMK+Uzhfwd67Ch9dUVoE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpwt5H+FPC1krZ+7UqhPpcSCQeB3gCyYyOjGfidJYWFCZUItRS VpY2X7OD1b7dC9jgTg/RvzRlkoQ8EFCVOBSnz66fhZo1svx48yC8iU9Ym2zY3F/6mW791jQ/4eM ctKRo2A7XrtA0evxu8Uy81AIfQ9HCG0Iwd0cZo9rIRx6qKvGo05S/2+E6sS4QJ4zTO30= X-Gm-Gg: Acq92OG1JMsA0m7d0ZiaW8uRJPyruSrAdsH37MPLTVz4XNR1iEB45I3reZFRPg52SeN QxL4vf4uUMk1t8nTDo0LTfL6k5Lbh98NrBP0KA2AD4WiTxm9LcpE/Yy8ae6aov67ZCxTy87ToyE nRCcFbCjasv4Rs/kjPO19F3qjf6wN/Yx16DJxXgUwVKKt+liPfjM7HdD4XzdFpxQEVSf3zYigwH rNXNbVPcGYwKQcYsMrUIGRurgrz6UysnQZpAIQl/bqche0hWWtV5YN28BVMaxLbioX0lXqvssbc 7sLMjB8UmUCCLKraaZ9RYAf9L4Uw+wOox4LVoLYY8cpbOqNbWj7SexBXc0J4NUNbOIwHSum7cLM IBjdoVUctDd71ui0aiRODIbh1oSnt4I+rPvHaGEHFsaIfOMAT2afRAsHwwMgV X-Received: by 2002:a17:90b:3d50:b0:368:1064:62f7 with SMTP id 98e67ed59e1d1-36bbcc14a21mr2439419a91.6.1780042155716; Fri, 29 May 2026 01:09:15 -0700 (PDT) X-Received: by 2002:a17:90b:3d50:b0:368:1064:62f7 with SMTP id 98e67ed59e1d1-36bbcc14a21mr2439390a91.6.1780042155207; Fri, 29 May 2026 01:09:15 -0700 (PDT) Received: from hu-mkshah-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bbdcf7a0fsm702794a91.2.2026.05.29.01.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 01:09:14 -0700 (PDT) From: Maulik Shah Date: Fri, 29 May 2026 13:39:11 +0530 Subject: [PATCH v2] pinctrl: qcom: Replace open coded eoi call with irq_chip_eoi_parent() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260529-pinctrl_msm_irq_eoi-v2-1-7edd050a46f6@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAKZJGWoC/32NwQ6CMBBEf4X0bAlbAdGT/2EIgbLIGkqhC0RD+ HcL3r1M8pKZeatgdIQsbsEqHC7EZHsP6hQI3Zb9EyXVnoWKVBolEMuBej25rjBsCnJjgZZkWV3 OKUJaxwDCLweHDb2P10f+Y56rF+ppv9obLfFk3efQLrD3/hsWkCBVDYlqsvSaNNndMofjXHbaG hP6EPm2bV+eUUotzwAAAA== X-Change-ID: 20260514-pinctrl_msm_irq_eoi-ab736e16d411 To: Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780042152; l=2146; i=maulik.shah@oss.qualcomm.com; s=20240109; h=from:subject:message-id; bh=N8hfsxpSiKl22KeegE3vYAhGOHOFOR0ac/DSaLY3BoM=; b=8mWeXKQtk8VYyR7BWMLoMFizRryJGjE6TcFCCreDzd8GP9T1huW3i/K5hgm9lNix7QYr68DY2 iBJAKNmDvHjCIortxszWbRJp3lxPQ4ua0ks3Tvy7XhvQ7/csg3IX7yR X-Developer-Key: i=maulik.shah@oss.qualcomm.com; a=ed25519; pk=bd9h5FIIliUddIk8p3BlQWBlzKEQ/YW5V+fe759hTWQ= X-Proofpoint-ORIG-GUID: ZOw5ASBLziDXwOLXzJUBRsKIbMR8x5iF X-Authority-Analysis: v=2.4 cv=TeqmcxQh c=1 sm=1 tr=0 ts=6a1949ac cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=-nbtqxR-dX0XXlXkv4YA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: ZOw5ASBLziDXwOLXzJUBRsKIbMR8x5iF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDA3OCBTYWx0ZWRfX9s/mMraVoUxh EQ527TRtxciElaBuYz+LRvemXkES+PC85wGKBdwzONRjUjmu5JxgnM5Z5b4Qy0oV3ziK56JUu1e zLgm+CaEStfBZMFUz+w7anCzTG4DbaGfKcU0iunCP2L11kacHihZAZizj7kjk7HMtAKgL1n8jXI 09WYiytTH/FvNYzcfNrwwwbrpWcaF4ScARYMAUzPaHXovVZYEJhNs9xMWkGU0Iv9xBaQSw3QJY2 uNALA8S+0zaaF0nciwbGs2+k6yXiR+4gsFLmJ7u96lF32KZMTXvM67rAeJ3eO+0XKG/U/hpK/lb cmYidKlSxYWog2vPOOg6YGioONXxc69v5qTv4i2pTbYzntTJyJk1EUNUwkCZecInxTL9WKQyGS0 HyoF9orX2KFk0zM4vI8j7v7YPaqkfPBEZ1y954XnHlF8S5j1HHA8JCV+3QUlaPcIIRLShFqb1/B PVOks93S9i4Q6qZlOEg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-29_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290078 Before commit 14dbe186b9d4 ("pinctrl: msmgpio: Make the irqchip immutable") msm gpio irqchip conditionally initialized pctrl->irq_chip.irq_eoi to irq_chip_eoi_parent() only for the GPIO irqs having a wakeup capable irq. In order to make gpio irqchip immutable pctrl->irq_chip.irq_eoi is initialized to msm_gpio_irq_eoi() which now gets invoked for both wake up and non-wakeup capable GPIO IRQs. Replace open coded eoi call to parent irqchip with irq_chip_eoi_parent(). Since the irq_chip_*_parent() APIs internally do not check the valid parent data is present to ensure irq_chip_eoi_parent() is only invoked for wakeup capable GPIOs validate d->parent_data within msm_gpio_irq_eoi(). For non wakeup capable GPIOs d->parent_data will be NULL since parent irqchip diconnects hierarchy using irq_domain_disconnect_hierarchy() and later irq framework trims hierarchy using irq_domain_trim_hierarchy() which makes d->parent_data as NULL. No functional impact. Reviewed-by: Bjorn Andersson Signed-off-by: Maulik Shah Reviewed-by: Dmitry Baryshkov --- Changes in v2: - Update commit log with the reasoning - With the reasoning added keep reviewed by tag from Bjorn - Link to v1: https://patch.msgid.link/20260514-pinctrl_msm_irq_eoi-v1-1-2d= 152f8695f8@oss.qualcomm.com --- drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinc= trl-msm.c index 45b3a2763eb8..6771f5eb29e4 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -1012,10 +1012,8 @@ static void msm_gpio_irq_ack(struct irq_data *d) =20 static void msm_gpio_irq_eoi(struct irq_data *d) { - d =3D d->parent_data; - - if (d) - d->chip->irq_eoi(d); + if (d->parent_data) + irq_chip_eoi_parent(d); } =20 static bool msm_gpio_needs_dual_edge_parent_workaround(struct irq_data *d, --- base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 change-id: 20260514-pinctrl_msm_irq_eoi-ab736e16d411 Best regards, -- =20 Maulik Shah