From nobody Mon Jun 8 14:35:33 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22A0352C3C for ; Thu, 28 May 2026 20:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780000572; cv=none; b=g9R5CSAZlOT7U2piaoVvbvJ57ZsgfYO0DzncxUk0rlURLB5lIdnlnjEotK9RqdhEtcre5Z98Opu21T5u9SdUyfYBZlbOZg2wZMfPEbPMKVAeD4YPsK6fLR0oe4RJt0T1m67ItnA+/HfjFRjNmjD9K3mqsZ96IFkrvp2FLm7wx4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780000572; c=relaxed/simple; bh=x6oGcWWWDQfDqcCU7PkoHIAD74jyO7vWkfckEQCPXvM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UQ9MTWqfhj//JvPCy8NvW86/l7M/CcC1koTympiHYYN96+oTSJ0juivZoNhCSdMdLE9B7gfwpTAKLIcMobadf4lbm0L2e6GLKcd4A0Bwn3KjyrEaz0RW6k4gtHRe+po74uIXutoOKUlHpF1AfSk4VgIgrJQT91pd8pOi1y1G0fg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qACQo+rq; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qACQo+rq" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba6485d219so102197425ad.3 for ; Thu, 28 May 2026 13:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780000571; x=1780605371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8ql2aRaaprs6WrGu8tmGWv8UQcUIzHaXz46Uq9P4wzk=; b=qACQo+rqaNjX3IDEUhvolkl/Lrajil04iTM55vaqtQGEbvDb1BIW1PpyEEzoEyjIDn Doaf6RvQCI51insdXXLtiyofm41WWVJU1zZdIxVvtkoc/6pzirS/4+Y9GiLifMRQmPaZ oSxR87IaCZ+Ki2Y52AgdZZesK4rnnmpu7CqH0wqoVdVleuWJx8LHeso0Kh1nsjk9Sc1S +qyp29pvyNplehKmzMKBhSauoQutDHvyy9AgtOWfjvtNZYEnKogAXyxXF1Md06Ui0DEm ZzZLTQOPkGhiRukJwMygOYGetJWaVWaO8zx40VwNubS08BhFfnpR4BlOfjQr7tR5zE3I F/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780000571; x=1780605371; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8ql2aRaaprs6WrGu8tmGWv8UQcUIzHaXz46Uq9P4wzk=; b=rN9ouQOBXlid3qdKh+Ok6xRk5fxnKzzK39Ungw2MkkzCAW4CaYPAnNbvntCieXs++X yMfmmnNczIVkrloVbv4LNpWdkaG277iiC3eFUWDWP6AyUHYhu94WeuICmRqWf6GMcWNU yyjLQtV1ulyp/R+fMbh+d9taIP+k3H7Iov3sSXY6HtsuxdFJhDeYUcs9MkpKSfSWtIua F9xPxuFDnbrFc0Gi+nPwc2Dv1iMtbqnCNIK6unXFzbqkW9Q7Z6bDo5rhUH9RHGd+nThc YJyDB6mzPioXK55mjUcd5Kuq2RQVu0Su5IrLhP+b/gF3q3we8cx7Zmz8a3n3AdHYenZ8 BBHA== X-Forwarded-Encrypted: i=1; AFNElJ9hnXnaq+2MeX46nyvJuJ4JgtoAvD01pHg6rfFkKv6elLJ85mjhgTO1F0ECPPoUv2c3B44XCB+fywtjhis=@vger.kernel.org X-Gm-Message-State: AOJu0YyXBS0Ov/ViwPUP2tkoLqNhdpd1bhbQ7SXp3aC1KfKGm3q23x8m KFCp54Z9cDw/daeGPXE2rNNq4oK9mQnrhrXSnC4ewk/5qjcFMx+kzOL9 X-Gm-Gg: Acq92OHp1lwn5CWjSmPEr26Ro5PNOFanw0tyVNm/oXhmMlA/da1zSh5jpsQ60fexb0S k/j0cPMVV6wCZnQJ/n6LncQABt/zrx3OrvidMoUYPGvNJp3zD44eCf+o8IYHAJjVU2oy0Ilmyx5 oHeIBKn5dyiGZeKievIDypl5LpV3OZsp+50cf9npJzx8+Vbh2JaPtYcupxryCoTe3ZXuDdk/4JM tx4JZnSKh2OQcA7uDo/G48NNXRM3Nmn40vC/VCSYBnrh9noCoQm2jbvtaQljLYRT7pxPQK28wDl wSmC8ilgqMp5954toiZNDBe6mcI+gJ9lYhSA1oK+q6Z7xrrO+nrsyHQ1F/M6OiUz48YJcaqSZz6 uLQ+GPMtJyVMlCFz/GINRAtUPOU0Vr3P3D0F9SYf7j9R++aG6lcE6AvnR4CJcdkYpPUurrMxxo1 jZjnPw24BYNbFEggwOzpkqhxVi53DUPUor4jAiyEzUWaaiWF2T3XyfgklSJUfQEwqcgZXxKQ== X-Received: by 2002:a17:903:18c:b0:2bd:8dbd:17e6 with SMTP id d9443c01a7336-2bf1ed4d997mr3553615ad.35.1780000571010; Thu, 28 May 2026 13:36:11 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:d30::4cf:38]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf1e5ca55dsm1870645ad.7.2026.05.28.13.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 13:36:10 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Vladimir Oltean , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: dsa: sja1105: flower: reject cross-chip redirect Date: Fri, 29 May 2026 04:35:44 +0800 Message-ID: <20260528203549.1918040-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver silently accepts a destination port on a different switch chip, then programs its index (on another chip) into the local hardware, which redirects to the wrong port or possibly crashes if the port index is out of bound locally. Add a check for it and adjust the extack message. Signed-off-by: David Yang Reviewed-by: Vladimir Oltean --- drivers/net/dsa/sja1105/sja1105_flower.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/sja1105/sja1105_flower.c b/drivers/net/dsa/sja= 1105/sja1105_flower.c index fba926f85b47..7547999a113f 100644 --- a/drivers/net/dsa/sja1105/sja1105_flower.c +++ b/drivers/net/dsa/sja1105/sja1105_flower.c @@ -391,9 +391,9 @@ int sja1105_cls_flower_add(struct dsa_switch *ds, int p= ort, struct dsa_port *to_dp; =20 to_dp =3D dsa_port_from_netdev(act->dev); - if (IS_ERR(to_dp)) { + if (IS_ERR(to_dp) || to_dp->ds !=3D ds) { NL_SET_ERR_MSG_MOD(extack, - "Destination not a switch port"); + "Destination not a local switch port"); return -EOPNOTSUPP; } =20 --=20 2.53.0