From nobody Mon Jun 8 14:35:28 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A5530C15B for ; Thu, 28 May 2026 20:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999730; cv=none; b=J4VDPB0/SWwZpM5ISr8Xrt6PWEd5pX2ILOFuUEWiaCmOkYRqztq+y8Rviv0U5YqCWHY8mhtlBAQsWvgXFqX3WiHAXwwH0XuZzLrGYhhQeZgge+U1G/KWjYV7DeyOYC0zdaO+0PEjUaOUl5PdAwzoMkMXa3ifs5OXrRFVN4MEg/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999730; c=relaxed/simple; bh=8r3Njt8panVzaDyqKXn/pvgpQoA+kH4AbvtZB3YhhYU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SQqZEPuGodHeq8POdsCAq+eEFqk+YCwHFnl35gGJ5VN4gRho7ONqmuU4yh/1xY2T1iLWki/GUMTuIUty9QC2wlfKaijsRcJPs2tOEU30oMO1aL4XRnpSFj0GM9mFhhLr6b9IABjHafXWTAXQhCC11ei9KcEId+Q2zdFEoilWYfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=haWb59rv; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="haWb59rv" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-368f25ff4c4so7636988a91.2 for ; Thu, 28 May 2026 13:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779999729; x=1780604529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BvVT0II3dEilSbYrBZE5Ytb4041NB7ZsFn14SAB4u14=; b=haWb59rvJjBrnh/KE1CyLwsmwK7M4ximKxm1/arnsKrv709NK+S8XTL0r9sPVIR2bK yUGa0ngl5dy4TUeNIWL+PF5vugF+NYq12ehSZoOdS/VWMgutbyylUzvh5DNnbu+GCRwH sRLGdgpNodocXvDF/QJLhulhA0c+G+rx1/L26xTdJV74W2j3fOF1vhkDWo/39uUjNqhn QczCmBxty9LJ1Bm8XE0n2y/ANxcl/AgoSWj8jY7uefdTIAsudkvLNm8pDUY95Vwti5Yk i1ZMbm8VJFopXstkl5XGnJVZ5c3yycJpr/ddYj49lzXIMIx1xA3jTWxxawi9C69CwuLL J5+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779999729; x=1780604529; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BvVT0II3dEilSbYrBZE5Ytb4041NB7ZsFn14SAB4u14=; b=jRvzzwdHzVBbva443gybTTrte3TlwOd2P+n+wBKv2/LhMQ2fPkMbUpD8v2Vh882WhW c2Gs72Z+uH1qlih/7ZW+VBM3ou22FfiC6ojXGpCjCtctdrf9sbPc8uvMZlkTTXiF+af5 YGH1gRUa7PqT+zh/MpuG8zwF0dayPYnRqNtNX0WmChUw/bvM6n5rFc3bU1X45QhtwVzX WkdcFV4qpr+Fy1zKRiQHVf8OVtdKYGAOa6quS+pLAoWVS+BIh/lco0503oZ01jlSSzej M4a+aWNF9/z0/iyYXPDsVK1/fBCkIm4kZ3tlHo7vS58lFuTgjV5104wC7jc/QBFCQQse 0uIw== X-Forwarded-Encrypted: i=1; AFNElJ+LuAtQouZSllxVX7/UXV3PTh47e8siR+f2ENQ2G6/WRylhXU6MBHvlNBEYCfNfMA70Q/izzJO72yCIIkU=@vger.kernel.org X-Gm-Message-State: AOJu0YxlbvwHHuyUvA98T3Jm92p358Ngbc+oEyJCfoQbPXRBlSg65kgQ jk6n0ji+MV9mgS/sMtIhaY9DRJor9i8MU01d5wamOkn8BC0bUGlCGXPy X-Gm-Gg: Acq92OHvIOdJYgfTXs9he9szwlG5NlP74TzZYvf5r2YZuYz/foCKRkvZdH+/7TWPzb7 kZbUU77wL80lxgcj/LlcRosaD0sO/J+H6qrlzf3MPdZnIXOGuzvV/qNau2e+IFzv34VuaBISTqa vqv4TjIFC3x22rP3VQtrRFxTAQsNSOL5eBesstyFBVp8FRIrgcs9NoxptJFGNVqt6Uwb8ocNogC HNOpxrBV+0IzlBe/UUruFtMSrQEwgFJuS8NeXxlrDIggmXy+Gpt8HF8F6WSnb5jStTwqD/KOCI6 gzQ1h8sIsDTe1iHQ3eXV0AOs3VyyTBxum2dlM3wvre/4tHL2J4HYK0wM2A0j8uSguvnBp4w1u7Y /jimnOtqjImN8ziNmgWqbVqHncaN+fkKUH7qrHwoKx+yjiN+pQmKsuuaXZEQmzHAOBP3U7sUMaA mEsiaQWU+8iOObTDDjqqypiffDFpvGOJbLkl/mCEZwKAnwHoWX9ocgJMM/W0rbHZQKIOvUXewbp JPF8tLQXTgYJFyqfu66Vy0UdGA46OQGy3acmkVtOYZNJg== X-Received: by 2002:a17:90a:dfcf:b0:35d:a3b4:2f0d with SMTP id 98e67ed59e1d1-36bbcc146f3mr122373a91.6.1779999729076; Thu, 28 May 2026 13:22:09 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36b908da770sm2334406a91.2.2026.05.28.13.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 13:22:08 -0700 (PDT) From: Rosen Penev To: linux-block@vger.kernel.org Cc: Ilya Dryomov , Dongsheng Yang , Jens Axboe , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , ceph-devel@vger.kernel.org (open list:RADOS BLOCK DEVICE (RBD)), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] rbd: cast snap_count to size_t to avoid tautological comparison warning Date: Thu, 28 May 2026 13:21:51 -0700 Message-ID: <20260528202151.136274-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snap_count is u32 but the comparison is against a SIZE_MAX-derived value (~2^61 on 64-bit), which clang flags as always false with -Wtautological-constant-out-of-range-compare. Cast to size_t so the comparison is done in the correct width. Assisted-by: Opencode:Big-pickle Signed-off-by: Rosen Penev Reviewed-by provided earlier). Reviewed-by: Alex Elder --- drivers/block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 94709466ad19..b4ba51db9a28 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -6079,7 +6079,7 @@ static int rbd_dev_v2_snap_context(struct rbd_device = *rbd_dev, * make sure the computed size of the snapshot context we * allocate is representable in a size_t. */ - if (snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) + if ((size_t)snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) / sizeof (u64)) { ret =3D -EINVAL; goto out; --=20 2.54.0