From nobody Mon Jun 8 15:33:47 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7832BDC1C for ; Thu, 28 May 2026 13:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976367; cv=none; b=G+tLdWpBlOSJ5irnreV81wVL0CloxtKTlWdHieih2U04ON5CwJDJrUQMhJBfw4Nv4FB+xKL0aAvBexq4Vbf3i5jd26lbImiGcfuLKuY/sh+ZqX7pEhxTQIjA2HlglE9rToKOAe4thT8EPQinBJ4NisiwwH4UT7VZcH4u6hQRWeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976367; c=relaxed/simple; bh=/lCjwMCwIUN6ufAh37kRzYX8caEh602jwuVmDhShp9U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rGaoGpKuBjRPORCvjenDVyRbZt0aNAOB/omwYTRlFr1QsoMDQh2oA3uSQKJRMKDJEXCfo2fb1n/UusRhZwJcu/Vm8GPmBPYk7UoOLAUF6Z0hlS1QlCbwz9UnbjoV8T8X4B5JX/Okl/1uod98uRNxVvBOO/rBYq421X4CvxI1fkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TT/8Jo/+; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TT/8Jo/+" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2bd80b3aa13so86206805ad.0 for ; Thu, 28 May 2026 06:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779976365; x=1780581165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=A71OUHyyRe1M+VCs+XKSSgTKfIfoE57tMLNWnn+zSKk=; b=TT/8Jo/+76HBU45pRAKwZbGCAwLhpPEI2TrkcCNwtRi47bXbmxYtVFKdaybOpF0ovm wF+5YRoD7c0aRLFdIGwEy0k5p3mf3msVA5bw8C7n/gETYbFp4FCQSqQPmT4FFgQmdbBy E3AnfmoJo2eJjiGy0KtZb+7Y+3IjKINrLLPJS2w55LhMPaBjk480H7YC0USV3QJ7MWC1 udwU4mM2pzQMa/aJFwktKoo4tEhAa3OWpQEu2WMGA2k0cN5hK7tzbclyrdu8Fyjo8A99 Hg4za31i7a06IhGtWBjBy3HNblMkG9/ICkcoUoP110Fx9NAT2ymIh/BegGNTALgOdXdj 5H6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779976365; x=1780581165; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A71OUHyyRe1M+VCs+XKSSgTKfIfoE57tMLNWnn+zSKk=; b=DhspkXZxnwZJ4KgzTgmnQ8d4dlQISG2Vhp0BZ9/vy/iazU1H/hMMPDwYHC0MCEInb5 xUWiPilHMd1FBTLv2afM37C6mzOOi6SANnZ+T7AgCdZAFifegyflmCYMMMzzZjGzOMQW iBADU0aIaYoOtCqxzyA/hn8GPpv1cbMtL2fLE3sLUVFmVhwRxwGjJNfb89g0bDJhduw0 ukcwpExeWDmbAVPfwmpZTPjDnB3FMVia/lfvIDbOnxzWOZnKfFTHMZVvWvK6Z3HwJzbF 6dFcNniVP0wihhUpd3WmWvG2kM0bGBuOnTm8J+UseEUBoFmJDYuZ/Blx2sGzjxCjtZmV fA1Q== X-Forwarded-Encrypted: i=1; AFNElJ/46wXebddj7D4PN0iVGlXsZVHUy2ZVnYKJKJuRuTWRPfBtblni14uktL5wDzCgmdb1rpJJweduhkRwnfU=@vger.kernel.org X-Gm-Message-State: AOJu0YzXxTOmvLz9V727qhiUhzBGwK7oV5mlDUTF66EXo80S5EyiOYob YI0mepmwppcKecMa1gMVWYidfuHpgfJvQg9I2xVL6NuERr2KiHYZOezi X-Gm-Gg: Acq92OHH3szqc3SYl/oiJMTStpXx2c38R0vyKVX/0fcnTj0z05IQHRvJNyiCepTxRj0 lJrg5eC5vkFoOy7xFGyWdhUpdyRk2QoMXmtEcTZJcP4Q5xeTxpNPd5anwLesV3QWwPn2ZQZrPvq JsfDajpOmklnqQKaBuFcvRLxMp2wN+3+/x077C5TvDz0oaa/QBSw8Dy3bePsKz947yGVWUElFwH k7LcD0TjuuelPOzvyXS4q63RF4Bs9sZobNNagjvSnvvT1gKoFdmixyfkqKbtmp1JrSW6tR3313X jArNegcm1lL2T7RdObwE5AjcUdzV2IQONrWpCMARTH0+vTof0COFAfEJnEyAwaUCUzTNe1+2nPp q29eI4kk4wRWIRfpTiA4vW1wQVCOfYVM2GmIwqrN9iQ/lAJWT7P7ENIdrbozyr2kKAbGdl4ZU1V vhhzcBZV2bYej3VIgnrcp2qOlrtVdjYZgLcd6/1eXPmWuUxFb5OA7nnjaJHGv4oqZR7fLJ3LoHo STtGv/STmCw55TMUrXUpPIhKwkDZrh17Fz6hRtsfsBGhHxrrsMd X-Received: by 2002:a17:903:4405:b0:2b2:b117:1e1b with SMTP id d9443c01a7336-2beb0758814mr299325935ad.17.1779976365551; Thu, 28 May 2026 06:52:45 -0700 (PDT) Received: from localhost ([1.39.75.74]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bed2061c59sm127792595ad.2.2026.05.28.06.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 06:52:45 -0700 (PDT) From: Alfie Varghese To: Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alfie Varghese Subject: [PATCH] staging: greybus: vibrator: return device_create() errors Date: Thu, 28 May 2026 13:52:21 +0000 Message-ID: <20260528135229.2816-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gb_vibrator_probe() maps any device_create() failure to -EINVAL. This loses the real errno returned by the driver core, such as -ENOMEM, and makes probe failures harder to diagnose correctly. Return PTR_ERR(dev) instead so callers receive the actual failure reason while preserving the existing cleanup path. Signed-off-by: Alfie Varghese --- drivers/staging/greybus/vibrator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/v= ibrator.c index 0ec4d317c..763c234fb 100644 --- a/drivers/staging/greybus/vibrator.c +++ b/drivers/staging/greybus/vibrator.c @@ -161,7 +161,7 @@ static int gb_vibrator_probe(struct gb_bundle *bundle, dev =3D device_create(&vibrator_class, &bundle->dev, MKDEV(0, 0), vib, "vibrator%d", vib->minor); if (IS_ERR(dev)) { - retval =3D -EINVAL; + retval =3D PTR_ERR(dev); goto err_ida_remove; } vib->dev =3D dev; --=20 2.54.0.windows.1