From nobody Mon Jun 8 15:33:47 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA1E4239567 for ; Thu, 28 May 2026 13:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976280; cv=none; b=ZlVEz2bieQBYl8lgY7Pkz2HXgf4FAwayGUSXN5NFrKOJx3b/LbhwQw6A5xkp+4QwFWkh4zTo8Br3V3AIkZIS4eyBIrQQYF4XUWN48rBnkrVwRMyPjhPMfd42Mp6pyCJiRfO33//uSGKHuGSkxkyJ288RSs7u1Eg/hvnHZPLNs4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976280; c=relaxed/simple; bh=/lCjwMCwIUN6ufAh37kRzYX8caEh602jwuVmDhShp9U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pL3d6McYbuJe2BN1aaiv9AWauXonUItrHjUXAh7Q8fds/RrMH+oj1FJnn8NL1xK+mO4mS58wPpch+EEfzO3eZsWx0B1+lcUbM+ZXm0AQ2kjVE4T8C8ybSQ6f3LHMbqNd2TzxIkeBv1c1cKeLMeeaeXcsStUQx+ANUg/2IsxVud8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iPsS/azg; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iPsS/azg" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c801d732058so5723377a12.1 for ; Thu, 28 May 2026 06:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779976279; x=1780581079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=A71OUHyyRe1M+VCs+XKSSgTKfIfoE57tMLNWnn+zSKk=; b=iPsS/azgov9s9qbTAIJtsNlJ94ozHlBtH29aSmNLIXe5QGrTSGSUZcSvYm071oK526 UUK5lz4EokSfnByu71OWQVBdvgRmGqnOXxLdHBu2nsB6fbquGxtzSonKkwr58q1bNEHk 6uEfiZVhyl1L9Rhjvz1QHhd+pwqME6fYTvjsXjZqRyj8AmbJLHq4ZUpW5lFzlCfZ+b3+ CPmHitIk8KnJw+3mf8B63RPINMrghLEgg9f95bPKFbnXIoKK/P+o6aLjOmlwB6O2wSbq EdSHmGZfksIZd/XWEInxLW8BQz63Vyae3CT+gRsWhjLcWuSfHeSTSu2i1zoElM013h3j j2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779976279; x=1780581079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A71OUHyyRe1M+VCs+XKSSgTKfIfoE57tMLNWnn+zSKk=; b=JhWBcTvRkqVXwfN2MOu4I+/Sggkwq7kTHu8AN3ky5mXmqsqnoXif8vaXs4i84ZboEA cFDd0pAJ5+ciAD6qG+4zBOZrmWgHYS1kMvFb7Acdo0QF8LVCCQ+nsnKzjx4qYx6Zqp5o txTDkpzcFSu7y0RXyzrLsGDny7BFJMDwgVSENmPC/M486RBq9XSW+ntHFUvZL17KZeR9 ljDDIymttYiri5jwnzBFWNlVWXSiUlaoXb0mcnDF6igu5WgLw6ylwVBSGQN7Ti1s7r2T +3tDMygoUPnjpqmOBg7FifO7JOYkUveW3j9Fim8+fKdQ5Vp7iNENNUiMPxi/sXtXko50 G3Ww== X-Forwarded-Encrypted: i=1; AFNElJ9RCWSSULrGCjZ5ujLwNjpOr+rTMfGXOFSQWO16BZlJs3g4j/+VMSWHa4VS0pV3pgydsNJhO8Yk3AYA0Gg=@vger.kernel.org X-Gm-Message-State: AOJu0YzPLbQSxeXNDzgTRSnFnf5AM7oUf404JPtBKTPU9W+ai6poNL3J geV18GtCF99p1fbdCDh0sSfxczTpvZox4F/3nnyINUXklyLC9soqMt2F X-Gm-Gg: Acq92OEgGhh9x80OF+ywvKjpm2szPlfBYZeB2vuVa7YjQRHPegeYSdEXRegWihPUyJ7 ai3ja1S4EloKSSV806vL5n+zrV2ELnr+S/XBQsWWoo/nOYXMG+UMIED2sLjL6ZY9v67MmeD76EI KzddVMh/DQg4efCnGH8M4IHjB0EHIQtJbVZeohp99NG/BrCIE8AYgnncTtWcNl87lPVexgIZKnU gpXUoxQFUzR0cKezKRUm6L+rfS4jGvXvuH3KDfAkmIawrXUw0bwxJoxEMPrMM9qV3fawNpO1iQ1 TN6eRyAoLzx/VgHinOhj/SqiSvJqbyn6rp7JE8auyCWgmsoe/R9QG0bfix08UOQtJcdYDpYEmBy uwcsm/hEw4ZzEgWtuLcBQgGo4w5hVLJSrYR8ylw6kkc5698IS3ql1yGyTcywAtUh5HQO4M5iZuI 4WkHWM0eeLB8rBYf2YJqiBEyroXT4+EGLqH+i5ictTNkR119vjxHKn+2Fj+Qy3lSlvvJPPbrxwr PgT5Vf5IdOa4AXYHnPE/zj1KopJkE4drE3abs2LxpkeBTj52Non X-Received: by 2002:a05:6a21:4c13:b0:39c:2d2a:632e with SMTP id adf61e73a8af0-3b3fed32fd4mr1697534637.11.1779976278988; Thu, 28 May 2026 06:51:18 -0700 (PDT) Received: from localhost ([1.39.75.74]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85202a337fsm15256769a12.8.2026.05.28.06.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 06:51:18 -0700 (PDT) From: Alfie Varghese To: Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alfie Varghese Subject: [PATCH] staging: greybus: vibrator: return device_create() errors Date: Thu, 28 May 2026 13:51:09 +0000 Message-ID: <20260528135111.2791-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gb_vibrator_probe() maps any device_create() failure to -EINVAL. This loses the real errno returned by the driver core, such as -ENOMEM, and makes probe failures harder to diagnose correctly. Return PTR_ERR(dev) instead so callers receive the actual failure reason while preserving the existing cleanup path. Signed-off-by: Alfie Varghese --- drivers/staging/greybus/vibrator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/v= ibrator.c index 0ec4d317c..763c234fb 100644 --- a/drivers/staging/greybus/vibrator.c +++ b/drivers/staging/greybus/vibrator.c @@ -161,7 +161,7 @@ static int gb_vibrator_probe(struct gb_bundle *bundle, dev =3D device_create(&vibrator_class, &bundle->dev, MKDEV(0, 0), vib, "vibrator%d", vib->minor); if (IS_ERR(dev)) { - retval =3D -EINVAL; + retval =3D PTR_ERR(dev); goto err_ida_remove; } vib->dev =3D dev; --=20 2.54.0.windows.1