From nobody Mon Jun 8 15:33:20 2026 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D658358D3D for ; Thu, 28 May 2026 13:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975496; cv=none; b=aOYg4bT/W9/OAZL+TT9IK5A9hTuuOgxpv2DROLfrkUi4xQiSZdAPEPmv6FpBjJn9w0GrA/fNfWjJ1ddZV306mV03uP9sZAaDsllOEgNxYSHN+gFpdpqX6RnnWgFRIbse2wzaKr+HUrf3Bp4it/VASi22WnX7W3jaieJWVIj0b6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975496; c=relaxed/simple; bh=1f9GNGnxqHYMYTUVEWPshCybn7EU+s4/PHdaM2twDos=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MOMHKFBDg4+wzWx3Tgj6+Pkr+JRTo8YfApmq6FAoOz9vCsxc1UtWE+DWwsLmIQLBiXAjQgWZi9d4Ro+4FPnev+lQuZVW9gPOJr4xezny7+KEWG2FlN1zXPnakG5b0Ympw+71Pt9QA2lzsqWn9r3iyxnFYvvLHdNBebhh963Omq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=he/bhHKb; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="he/bhHKb" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-914ae4101b4so885560485a.2 for ; Thu, 28 May 2026 06:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779975494; x=1780580294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lf5y1emthCXYhd+dZebItKHK8eGGD+WMbJr9hkUNC5Q=; b=he/bhHKb52dlzIKSS/qoQnMCp+bIV/P6Kfd/DutyqA2qCtkbfOdelWxywSey4I70nq b8GbujTw0L3s3z0qvJxw8qrEQz6IckPW3DqtR7y2IKVob23NzvmpH+MYwZYFCC9i36TA FchpjhonFch6XtKzByNNhgfdv0yOIWKoUA7N2qqJK+5sCblF6heRmQXaNLXL/6UvBFlJ DClGsS2X9E1vgEkl60drotkh+Y+CcDTNtHGhovlrkA/01kSzvx1/T/xCh9rr3rDMPThO 2Q/alQPRprvJFdDK30/y3YfsD1rpWffBn8k94H7cvON73ijtDEwJUHvZxZfHbqX5EZ1z qbrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779975494; x=1780580294; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lf5y1emthCXYhd+dZebItKHK8eGGD+WMbJr9hkUNC5Q=; b=OjeuBzLgMPRK+W1J5NYrQ42Cuxly4c0uoBxxy2ur6eImhXoiwf02CkgkSI2kJ6bWA/ Aqt+auaEWXdYdDQO2wpS3/TlxRPIBUZvBaLobyQZ5nVMZqTpRR6XV9KiQ47bnuv1EBcB KkWy1iYZpOKaJTtu0c5x3xpp2JQlHnmDAbfpULJgLq9dWXjhgUolPs0aotWNtjvln3QG pmCFcayMKJNvjkRVa8FTqaRjcrYo/6+r7JDbULP/7goWpTlO1XdoO2ZrWoPlkTfLYo1W STEl+FgAa9G4+Mo8zlp3he+ZvKmu+d4/nQ3TmIOqBZB0IkS7YAcVmHil6WAAcZdLb2OU 5gog== X-Forwarded-Encrypted: i=1; AFNElJ997VTlA9AuQ2BEAQDujuv7yi51mDH4oCwip3IvF56rB1myBsb79K2tkp7/mQkwvOZiEkmWzWcPGWlGjQs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo/ikrHv75FGDR5omxQ4xGQohyQ7t3WHzqr4YkQb2PSRUQEJY8 +hoMgGJK5kTAzui7kJjgGsShoWxH353dBZ97E2MtxOJw/eV8b9+Yem25lQVTXAAZcRw= X-Gm-Gg: Acq92OGNc7gG+t4R7dyQL8ChL935TnokJzLxhM9TvABe3OqQ6PvPO/9zC+V+o3V6re0 ZjegkoDVubMx9Lj+pRMD6Wq1KgaIUzExRJF+tkOfGe+GAkKm4t73n6xKeacJ9Sl5td5u2BSMc3w hddNTP3dLJt/xuPjg14nnGqfJdUJ9kycRf9dfI2bniDaI9nz/6oldtJDyEtx4EGxDdi5fYNLgh7 XceFG0m3LkOpeZ3O5xt1hbeKmpIY52VyUSHNl9vnXre7RgZ7Kz6A8pxcnmMF+oIkRM9GZsN4T3z 2zXTlBW5U5qYnW7XDNZA5RkoS2Hc6AY+7TE7+QzsvqrBSjXYcimTjd6Tvrnqgv9tR8Q+fJRNpm6 Vzwr3wmMG+cL8/BdTkedOYoupVfbdzabKiFEeejdTdbLbr0QzTpL0QWWtFd85gH1R4+tn24Ohym gE0Q0cD2b6oZGqMuLWfIphmqp7vHWE6BagQzzGH8MgtLkwvPryqO4xnRpPptoDCfCmBF6/geLpm Iy94TFhHnU29TEJWvya9A3hCFNbAFWKMZowSv61rg== X-Received: by 2002:a05:620a:4151:b0:908:8470:4e98 with SMTP id af79cd13be357-914b496b6ffmr3627640685a.30.1779975494312; Thu, 28 May 2026 06:38:14 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f87d1a90sm877659585a.27.2026.05.28.06.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 06:38:13 -0700 (PDT) From: Michael Bommarito To: Haakon Bugge , Mark Haywood Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ibacm: Check for source space in resolve requests Date: Thu, 28 May 2026 09:37:53 -0400 Message-ID: <20260528133753.3952087-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If a resolve request omits the source address, acm_svr_verify_resolve() uses the next endpoint slot as a scratch source address. A full request can already contain all eight endpoint slots. In that case there is no scratch slot, and the current code writes past the fixed message buffer. Reject a source-less request when there is no endpoint slot left for the selected source address. Fixes: 5cf79fbad67a ("ibacm: resolve source address if not given") Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito --- ibacm/src/acm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c index f13617c40..125b660e0 100644 --- a/ibacm/src/acm.c +++ b/ibacm/src/acm.c @@ -1044,6 +1044,10 @@ static uint8_t acm_svr_verify_resolve(struct acm_msg= *msg) } =20 if (msg->hdr.src_out) { + if (i >=3D ACM_MSG_DATA_LENGTH / ACM_MSG_EP_LENGTH) { + acm_log(0, "ERROR - no room for source address\n"); + return ACM_STATUS_EINVAL; + } msg->hdr.src_index =3D i; memset(&msg->resolve_data[i], 0, sizeof(struct acm_ep_addr_data)); } --=20 2.53.0