From nobody Mon Jun 8 16:28:12 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E807E2FE579 for ; Thu, 28 May 2026 06:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779950514; cv=none; b=Vk23oEvgoofYoTHIWnzSCWdr/QMDoVV4kP3y0cwxf3YyZGtItkGGUnyrmWOa78su5/PghD/H3hy0FvPPz3U8yqyCPicnOiFP5bD6Jg+y4zksiSp2geLG/X6QUt/P/bjXFP4VkgxTkLl1BRuTWIAFb4xv8IhjHefeSmvJ7ciUMag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779950514; c=relaxed/simple; bh=qKlJOVQ8CeguRlCMIV6TL5JFjOuni3FW2zUBP4TnhuE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MKprgTh19S+fdEWr6A/SZF1k5P57dEUuor8w+I2oAksGyG9hXd7ihzZ3vIWJuR6IwGut4jU8uaTq5dI3PbFoYedNMv7sDOf6xtpnSDp2ILo47GGFaeqS0LIV4WLrTKx/EoR9zNl+IoB5ErfUNOAH4hxnSwWWvpKQY5P6+fVZKeg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VfH9qze1; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VfH9qze1" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c802803ac17so5190358a12.1 for ; Wed, 27 May 2026 23:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779950512; x=1780555312; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eyGymNqbhiXLlzQIXinZjQ2T/+xHy6TN3+8MZhwVUx4=; b=VfH9qze1UMaQlmwBWAQjxIPBZ8clMOgWZ35Yhz8pabY411Ak89d8IACWxlk22Bjdoj rZTn9xJiFmnobRhjQwgZDWjQ6Iz/GPZN4YsN6NWMjnYC6s4k4NlG4gxSKM8c7OpEJdI7 iKFN902UgS5ZAcWAKqrRKKUqSDxwOg071DS5aiqQN3OemzZPy+0Sx8bCoWRRuMDeSugH WGSdJtM/q6UJcslaaZ6LEMfw+fM67sPl5EE3vgkX7yCM9TRpqQPJV3NwsudblGfe9Wc9 2XxSi3nSaTmIgrnwa37c+ozJ3cmb+xxKABPX5XatnRBGLVJxikxIwcKK6G5LiMThQRPq D5BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779950512; x=1780555312; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eyGymNqbhiXLlzQIXinZjQ2T/+xHy6TN3+8MZhwVUx4=; b=UwR+OsQWB6gyxEhyLuctLsmk4mtbYsvbWsrY+y3rx9eVMkFT6A7QUkdy9iHmqxYFfu jsmfi9bF4ayIGkH5gqzVHod8fX3mlI+T70FKEeIM8pLZMyj1GFx9lbMhJ9y8dtdH/u2+ oXsvtgiKnICydzEF+vvl6OrHfYTpFtwI0pyM3ugRVb9UrpmfswONDYUye0712i5lx0e6 6JZsgdr/Pef2d9I9xGl9MtTVoV9e0dCw2NZ3MiEE/DiJiuK8Ah2s/Uz0aUr7FV8jPsZ5 ZoyGsYdsm2o0XZgYP3NnJjpOYariw4XYDMJs0ncgPv8TrSrCZdZJzNa45UwxnvA/vPm6 hHoQ== X-Forwarded-Encrypted: i=1; AFNElJ8Oj7foUXqq/gOsgalKOo5G32NcX7db1AuonDmlkCXVcQoAb0TFt/YFKZk35/UTanEuuIWrsQpiKPKXtp4=@vger.kernel.org X-Gm-Message-State: AOJu0YwSV/ROX/mx1kvpcx1bqV/i4liiB0zeOjsASxN0U5z9NF4pZl9A zj3umfNL/YUnKRutiNo9fduooyQPkKGx4BOAXLcJSBfiHf8gevbj8kC8 X-Gm-Gg: Acq92OEYh8v1iGLcs6UI7xZtKca4+r1PtlqBGSfPEfKlWaaCzK6DPqrlhSYF4pkZYWB 1taadlWcPL6vxN5963ZVOMK0vBp5C9a2CE75jmiUHOCEPnWmuOji2KVIksLLOs7FB8nRbWdLkaG LAU0dg4ZzpxmaZkJGNlNE6KCaHUKpdPg4rLCEN5z9KxQ+621kp93Dr8ntAw0e5W3g89icvFd5/Y t17XC6pY7BbljktlTJdkkTn/o4B6KRxCqYWxl1NZYMruB55VnBz+8yFs1kb51MLcxjD5mgcdySF xO4s6yzxONhJYk5V+933q7wDcrrUIi65GbtU4H3K8o/LsdfAPGhdLzrqmLyaFTAwizO2W08/Wjz COedwqDLzm1OXQpAcQvh8skBl+bF2buRuu282W+Xri0PBzsxARs3XsjsGgboYDYXtWoR+qQNGgZ LBKNzr5pSDlZnM9E0M4OnoMYkZc+vi+vnyNeJ9rsNjNCw9h/RdyEWoSyb3srwYehg5pQ== X-Received: by 2002:a05:6a21:9d91:b0:39f:9eb3:1d09 with SMTP id adf61e73a8af0-3b328ee2e52mr27362688637.37.1779950512300; Wed, 27 May 2026 23:41:52 -0700 (PDT) Received: from oslab.. (n058152075021.netvigator.com. [58.152.75.21]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852056db34sm14417515a12.27.2026.05.27.23.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 23:41:51 -0700 (PDT) From: Tuo Li To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, kuninori.morimoto.gx@renesas.com, ckeepax@opensource.cirrus.com, vulab@iscas.ac.cn Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tuo Li Subject: [PATCH] ASoC: mediatek: mt8365-afe-pcm: fix possible NULL-pointer dereferences in mt8365_afe_suspend() Date: Thu, 28 May 2026 14:41:06 +0800 Message-ID: <20260528064107.470824-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mt8365_afe_suspend() allocates the register backup buffer with devm_kcalloc(), but does not check for allocation failure before using the returned pointer. This may lead to a NULL pointer dereference when accessing afe->reg_back_up[i]. Add the missing NULL check and return -ENOMEM on allocation failure after disabling the main clock. Also propagate the return value of mt8365_afe_suspend() in mt8365_afe_dev_runtime_suspend() so that the suspended state is not updated when suspend fails. Signed-off-by: Tuo Li --- sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediate= k/mt8365/mt8365-afe-pcm.c index d01793394f22..5966ca18c7c9 100644 --- a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c +++ b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c @@ -1974,10 +1974,15 @@ static int mt8365_afe_suspend(struct device *dev) =20 mt8365_afe_enable_main_clk(afe); =20 - if (!afe->reg_back_up) + if (!afe->reg_back_up) { afe->reg_back_up =3D devm_kcalloc(dev, afe->reg_back_up_list_num, sizeof(unsigned int), GFP_KERNEL); + if (!afe->reg_back_up) { + mt8365_afe_disable_main_clk(afe); + return -ENOMEM; + } + } =20 for (i =3D 0; i < afe->reg_back_up_list_num; i++) regmap_read(regmap, afe->reg_back_up_list[i], @@ -2011,11 +2016,15 @@ static int mt8365_afe_resume(struct device *dev) static int mt8365_afe_dev_runtime_suspend(struct device *dev) { struct mtk_base_afe *afe =3D dev_get_drvdata(dev); + int ret; =20 if (pm_runtime_status_suspended(dev) || afe->suspended) return 0; =20 - mt8365_afe_suspend(dev); + ret =3D mt8365_afe_suspend(dev); + if (ret) + return ret; + afe->suspended =3D true; return 0; } --=20 2.43.0