From nobody Mon Jun 8 16:28:55 2026 Received: from mail-106113.protonmail.ch (mail-106113.protonmail.ch [79.135.106.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0371331222; Thu, 28 May 2026 06:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.113 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949705; cv=none; b=n+1nFsMr00FGFf03fyi4i5/ykYnVxJmGaWcjpka1ieW6B5KDw76Ct9UCTUKycxe4jVqRe6UiQC04HSKgVKm4tsNYNJ4ob3HOQnS7eZ89BBQ/pj0SsFzrYQ9ateCCnwHlMLWwycXSavAZpcSekQG3VNKUiH6R/wxOiA+Kk2u8PJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949705; c=relaxed/simple; bh=BJGCuTwKXnb7xtObAQRjjs/n0+cYOdiYTtYroZHcwEE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bzpn02Tke38FZgxXoBYy9DNOS80ZDUsbatXt0ZUuhxQ4NfFiWJ8rv1Kq9SeYt/H0lpfsSUYoEa+jWlCVuk2S6/GaR1wmNQBtw7HNHdkdhXCMIhXX+84cVQ0M9FGyiJaf3+C8etqL+w29Ty0EdWoze2msWYuL+erobnPvxYZSl7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=nes94oZI; arc=none smtp.client-ip=79.135.106.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="nes94oZI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=protonmail; t=1779949698; x=1780208898; bh=JFj8bpASKdO/Q6l1EDIhoBmA4UrdA23CFVdITf9usiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=nes94oZIHmE0wxBXW7AyOlmGRw3fEL2uX5ZUZ0KVorStmhwZ1E7G7mDBV2/1LPt8S vpCa29hNy7ABaZCo9b6IZZ1wK9vXvPEAU18yeYKUG6NKqyq7eOuFI4NsgNNqKnGaBO iIZK/3gbgB2xlbqzuotdIyYhdjJeAchii5hOc3LITCRdki4CcG//2aKXFH8GdLzRxs cYcc8Z9pyfmkwS/oqFVRAH37bbhxPSJ0BmBxHptsxbeE1INpaIrCshtM2GH5bwtbcQ XzasH74zAqqEgLk6/ARAB4rakVb+8jZkZRfPmXKWi1WaPpk/+Hpb5HXsOQ52SlEmNB D8miATct38AFw== X-Pm-Submission-Id: 4gQxPq0Sf1z2ScXC From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rcu@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, peterz@infradead.org, fujita.tomonori@gmail.com, tamird@kernel.org, jiangshanlai@gmail.com, paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v7 1/4] rust: helpers: add SRCU helpers Date: Thu, 28 May 2026 09:27:33 +0300 Message-ID: <20260528062810.256212-2-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260528062810.256212-1-work@onurozkan.dev> References: <20260528062810.256212-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add helper wrappers for SRCU functions that are exposed to Rust through generated bindings. Signed-off-by: Onur =C3=96zkan Reviewed-by: Paul E. McKenney --- include/linux/srcu.h | 5 +++++ rust/helpers/helpers.c | 1 + rust/helpers/srcu.c | 30 ++++++++++++++++++++++++++++++ 3 files changed, 36 insertions(+) create mode 100644 rust/helpers/srcu.c diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 81b1938512d5..790a4ef713c0 100644 --- a/include/linux/srcu.h +++ b/include/linux/srcu.h @@ -57,6 +57,11 @@ int __init_srcu_struct_fast_updown(struct srcu_struct *s= sp, const char *name, #else /* #ifdef CONFIG_DEBUG_LOCK_ALLOC */ =20 int init_srcu_struct(struct srcu_struct *ssp); +static inline int __init_srcu_struct(struct srcu_struct *ssp, const char *= name, + struct lock_class_key *key) +{ + return init_srcu_struct(ssp); +} #ifndef CONFIG_TINY_SRCU int init_srcu_struct_fast(struct srcu_struct *ssp); int init_srcu_struct_fast_updown(struct srcu_struct *ssp); diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c index 625921e27dfb..f3562d3b3888 100644 --- a/rust/helpers/helpers.c +++ b/rust/helpers/helpers.c @@ -88,6 +88,7 @@ #include "signal.c" #include "slab.c" #include "spinlock.c" +#include "srcu.c" #include "sync.c" #include "task.c" #include "time.c" diff --git a/rust/helpers/srcu.c b/rust/helpers/srcu.c new file mode 100644 index 000000000000..225b3bf9334a --- /dev/null +++ b/rust/helpers/srcu.c @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include + +__rust_helper int rust_helper_init_srcu_struct_with_key(struct srcu_struct= *ssp, + const char *name, + struct lock_class_key *key) +{ + return __init_srcu_struct(ssp, name, key); +} + +__rust_helper int rust_helper_srcu_read_lock(struct srcu_struct *ssp) +{ + return srcu_read_lock(ssp); +} + +__rust_helper void rust_helper_srcu_read_unlock(struct srcu_struct *ssp, i= nt idx) +{ + srcu_read_unlock(ssp, idx); +} + +__rust_helper void rust_helper_srcu_barrier(struct srcu_struct *ssp) +{ + srcu_barrier(ssp); +} + +__rust_helper void rust_helper_synchronize_srcu_expedited(struct srcu_stru= ct *ssp) +{ + synchronize_srcu_expedited(ssp); +} --=20 2.51.2 From nobody Mon Jun 8 16:28:55 2026 Received: from mail-244108.protonmail.ch (mail-244108.protonmail.ch [109.224.244.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF93330676 for ; Thu, 28 May 2026 06:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949709; cv=none; b=O9L302g0cE9n5ll8Ol4csYcwcNs+CvCRAXHKw/fi5/ZwehweQ5mBV5VKV66ActVxwLlygdgqaguUytlsGeXxrH+KQDbNCGddblbKgQ3Mq+XlhtPcLwIE2aIzfhQpfEl5C0Bk2GmafWfzaW1fLuBuIfYHKb+6qhMPBIPCrjMgGgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949709; c=relaxed/simple; bh=Cph4dXyUFtaIRhYtuZAcg75IYZZfyBZFccAjo5vxo+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a6rwuyL2ZNSisL5cTNjYYt2Em6Rmpc2ZbrfyyHZVfFpg1tdqQLuM6c5qzcnU0ZMY1p1DhgZYZEtobGrf4MRVCGyImMCFQ7h2f6yAC1xioLPziZjlNeMn8DdHq0xw35E1+DEV0HqFGMfLPoJZ8Q/FWc6awJ0D8PLyotwwPwyyTIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=sqi3YDm6; arc=none smtp.client-ip=109.224.244.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="sqi3YDm6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=protonmail; t=1779949703; x=1780208903; bh=6Y43LTgZywEkysAuCinLIc4XYSbGTte742wmYzuT/wU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=sqi3YDm6csxQUFRInc9oMCvp8UlK+K6NFnw/ijHDj4q6JAc165J5B/y+Eh1qKaAHH VymxJbVPIjGOBhwL7rLn/3ZuB+knsi4srDjAo87yDxr9NULzuwFWg2vPwU1ggF3O1m w3K+afVCT+i98pRlxOtCe5t+G1iUny1Mf0o8BFGY+brsQ35Y4UxPykqPg4inUNCHbx wiO6BZd2bMBC4lA31Gykqt487CDtPq8ji9eKh61QmclrQ1QV6YandIkxTppQ6Jgkhi HCIkRUgAR33oMQLMtZVII6joZo4NvAD39fZmhGMsLy+Vo54xrvGE0V3Si8YD8etemo FivHfAWEA+LWQ== X-Pm-Submission-Id: 4gQxPt0dY3z2Scq2 From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rcu@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, peterz@infradead.org, fujita.tomonori@gmail.com, tamird@kernel.org, jiangshanlai@gmail.com, paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v7 2/4] srcu: expose srcu_readers_active() Date: Thu, 28 May 2026 09:27:34 +0300 Message-ID: <20260528062810.256212-3-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260528062810.256212-1-work@onurozkan.dev> References: <20260528062810.256212-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This is needed by rust/helpers/srcu.c which now adds rust_helper_srcu_readers_active() as a wrapper around the SRCU helper for Rust callers. To achive this: 1- Move the srcu_readers_active() implementation from "kernel/rcu/srcutree.c" to "include/linux/srcutree.h". 2- Implement a matching srcu_readers_active() in "include/linux/srcutiny.h" and use it on the existing open-coded WARN_ON() check in cleanup_srcu_struct(). Signed-off-by: Onur =C3=96zkan Reviewed-by: Paul E. McKenney --- include/linux/srcutiny.h | 13 +++++++++++++ include/linux/srcutree.h | 24 ++++++++++++++++++++++++ kernel/rcu/srcutiny.c | 2 +- kernel/rcu/srcutree.c | 25 ------------------------- rust/helpers/srcu.c | 5 +++++ 5 files changed, 43 insertions(+), 26 deletions(-) diff --git a/include/linux/srcutiny.h b/include/linux/srcutiny.h index 905b629e8fa3..fbcf13bc12d1 100644 --- a/include/linux/srcutiny.h +++ b/include/linux/srcutiny.h @@ -154,4 +154,17 @@ static inline void srcu_torture_stats_print(struct src= u_struct *ssp, data_race(READ_ONCE(ssp->srcu_idx_max))); } =20 +/** + * srcu_readers_active - returns true if there are readers. and false othe= rwise. + * @ssp: which srcu_struct to count active readers (holding srcu_read_lock= ). + * + * Note that this is not an atomic primitive, and can therefore suffer + * severe errors when invoked on an active srcu_struct. That said, it + * can be useful as an error check at cleanup time. + */ +static inline bool srcu_readers_active(struct srcu_struct *ssp) +{ + return READ_ONCE(ssp->srcu_lock_nesting[0]) || READ_ONCE(ssp->srcu_lock_n= esting[1]); +} + #endif diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h index fd1a9270cb9a..75e54e4f963f 100644 --- a/include/linux/srcutree.h +++ b/include/linux/srcutree.h @@ -374,4 +374,28 @@ static inline void srcu_check_read_flavor(struct srcu_= struct *ssp, int read_flav __srcu_check_read_flavor(ssp, read_flavor); } =20 +/** + * srcu_readers_active - returns true if there are readers. and false othe= rwise. + * @ssp: which srcu_struct to count active readers (holding srcu_read_lock= ). + * + * Note that this is not an atomic primitive, and can therefore suffer + * severe errors when invoked on an active srcu_struct. That said, it + * can be useful as an error check at cleanup time. + */ +static inline bool srcu_readers_active(struct srcu_struct *ssp) +{ + int cpu; + unsigned long sum =3D 0; + + for_each_possible_cpu(cpu) { + struct srcu_data *sdp =3D per_cpu_ptr(ssp->sda, cpu); + + sum +=3D atomic_long_read(&sdp->srcu_ctrs[0].srcu_locks); + sum +=3D atomic_long_read(&sdp->srcu_ctrs[1].srcu_locks); + sum -=3D atomic_long_read(&sdp->srcu_ctrs[0].srcu_unlocks); + sum -=3D atomic_long_read(&sdp->srcu_ctrs[1].srcu_unlocks); + } + return sum; +} + #endif diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c index a2e2d516e51b..5dc26af604bf 100644 --- a/kernel/rcu/srcutiny.c +++ b/kernel/rcu/srcutiny.c @@ -85,7 +85,7 @@ EXPORT_SYMBOL_GPL(init_srcu_struct); */ void cleanup_srcu_struct(struct srcu_struct *ssp) { - WARN_ON(ssp->srcu_lock_nesting[0] || ssp->srcu_lock_nesting[1]); + WARN_ON(srcu_readers_active(ssp)); irq_work_sync(&ssp->srcu_irq_work); flush_work(&ssp->srcu_work); WARN_ON(ssp->srcu_gp_running); diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 0d01cd8c4b4a..b1e97ba2e53f 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -598,31 +598,6 @@ static bool srcu_readers_active_idx_check(struct srcu_= struct *ssp, int idx) return srcu_readers_lock_idx(ssp, idx, did_gp, unlocks); } =20 -/** - * srcu_readers_active - returns true if there are readers. and false - * otherwise - * @ssp: which srcu_struct to count active readers (holding srcu_read_lock= ). - * - * Note that this is not an atomic primitive, and can therefore suffer - * severe errors when invoked on an active srcu_struct. That said, it - * can be useful as an error check at cleanup time. - */ -static bool srcu_readers_active(struct srcu_struct *ssp) -{ - int cpu; - unsigned long sum =3D 0; - - for_each_possible_cpu(cpu) { - struct srcu_data *sdp =3D per_cpu_ptr(ssp->sda, cpu); - - sum +=3D atomic_long_read(&sdp->srcu_ctrs[0].srcu_locks); - sum +=3D atomic_long_read(&sdp->srcu_ctrs[1].srcu_locks); - sum -=3D atomic_long_read(&sdp->srcu_ctrs[0].srcu_unlocks); - sum -=3D atomic_long_read(&sdp->srcu_ctrs[1].srcu_unlocks); - } - return sum; -} - /* * We use an adaptive strategy for synchronize_srcu() and especially for * synchronize_srcu_expedited(). We spin for a fixed time period diff --git a/rust/helpers/srcu.c b/rust/helpers/srcu.c index 225b3bf9334a..1a2f563640e0 100644 --- a/rust/helpers/srcu.c +++ b/rust/helpers/srcu.c @@ -9,6 +9,11 @@ __rust_helper int rust_helper_init_srcu_struct_with_key(st= ruct srcu_struct *ssp, return __init_srcu_struct(ssp, name, key); } =20 +__rust_helper bool rust_helper_srcu_readers_active(struct srcu_struct *ssp) +{ + return srcu_readers_active(ssp); +} + __rust_helper int rust_helper_srcu_read_lock(struct srcu_struct *ssp) { return srcu_read_lock(ssp); --=20 2.51.2 From nobody Mon Jun 8 16:28:55 2026 Received: from mail-106111.protonmail.ch (mail-106111.protonmail.ch [79.135.106.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610D73314D2; Thu, 28 May 2026 06:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949712; cv=none; b=nWVNy7M7zeZ97EMdlmMlhurYo62i3WKIo6bjXnYwAhAg17eqruIDTGEvdqGO9vJqVn6MyjTvpQzK3NPS5VCrBofsbd+B9LLVY5SbmR2cbqurU03mO7h1LIfgyHK6Z1AEPhoH3qWfEKDmyiLUcbItXj6kXMPHZCpnMwzQbO0KpaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949712; c=relaxed/simple; bh=nwto9TSN5DwcrkY38NX1+Y3ppUDOvXkhEPgbZdMEZeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t0n/nd7Oqp4+aF0LggrgsvM+mRMva63zT5WJCmj3kIuyUGGl9JonGFYzso/a8+XqODkb7tExJ2lHZdv8Mt/iapxs8cmVwxajixuClyfdQ/BKKV9Bbk0P7/0nW+aR9COuYAY0XYAy8bnd39fMx5emyjaBNH6dTu8ZUJDB+ZXmjTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=Aq2UTG7Q; arc=none smtp.client-ip=79.135.106.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="Aq2UTG7Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=protonmail; t=1779949704; x=1780208904; bh=hucoFCxR6ZRmPQZBC0IZgPLRY3PhP3652ZNo3G0VcFc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Aq2UTG7Q5Im+0tV8KLLx2G9sIjMGk/Ud9vgA0x86Yc27KmeQSNv3Qc0j78tfEp74P iGcIXxPKZlTGwTOASQlxdX7D+7cw8vDTkUzOU7+nmus883ZGVqBGmRXtFTsWiuMz5y tXUx4N2yzYVRFqO7wy3iO4BqPklSolYIGfgBdo8Ygd1EGBAip1mPdcc1+zLKgyyMLY 1SlIVoZ+vO0slgYh2VDQPRYcJ5q9i3A1+6p8Esu+nvDiVUQvVZkTznA25OxtAnnb1N UCngCoYhB+ysDviGP1TahbU29qpevwfKRueoChj7bTf/QGhxbDHKl8h8AqqWcgLc0A +ZuUTafAGQJUQ== X-Pm-Submission-Id: 4gQxPx6lBqz2ScXC From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rcu@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, peterz@infradead.org, fujita.tomonori@gmail.com, tamird@kernel.org, jiangshanlai@gmail.com, paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v7 3/4] rust: sync: add SRCU abstraction Date: Thu, 28 May 2026 09:27:35 +0300 Message-ID: <20260528062810.256212-4-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260528062810.256212-1-work@onurozkan.dev> References: <20260528062810.256212-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add a Rust abstraction for sleepable RCU (SRCU), backed by C srcu_struct. Provide FFI helpers and a safe wrapper with a guard-based API for read-side critical sections. Cleanup is handled via `PinnedDrop`, which explicitly drains pending grace periods and callbacks via `synchronize_srcu` and `srcu_barrier` before executing `cleanup_srcu_struct` to guarantee memory safety e.g. when there are leaked guards (via `mem::forget($guard)`). Signed-off-by: Onur =C3=96zkan Reviewed-by: Paul E. McKenney --- rust/kernel/sync.rs | 2 + rust/kernel/sync/srcu.rs | 166 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 168 insertions(+) create mode 100644 rust/kernel/sync/srcu.rs diff --git a/rust/kernel/sync.rs b/rust/kernel/sync.rs index 993dbf2caa0e..0d6a5f1300c3 100644 --- a/rust/kernel/sync.rs +++ b/rust/kernel/sync.rs @@ -21,6 +21,7 @@ pub mod rcu; mod refcount; mod set_once; +pub mod srcu; =20 pub use arc::{Arc, ArcBorrow, UniqueArc}; pub use completion::Completion; @@ -31,6 +32,7 @@ pub use locked_by::LockedBy; pub use refcount::Refcount; pub use set_once::SetOnce; +pub use srcu::Srcu; =20 /// Represents a lockdep class. /// diff --git a/rust/kernel/sync/srcu.rs b/rust/kernel/sync/srcu.rs new file mode 100644 index 000000000000..343f00d070c7 --- /dev/null +++ b/rust/kernel/sync/srcu.rs @@ -0,0 +1,166 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Sleepable read-copy update (SRCU) support. +//! +//! C header: [`include/linux/srcu.h`](srctree/include/linux/srcu.h) + +use crate::{ + bindings, + error::to_result, + prelude::*, + sync::LockClassKey, + types::{ + NotThreadSafe, + Opaque, // + }, +}; + +use pin_init::pin_data; + +/// Creates an [`Srcu`] initialiser with the given name and a newly-create= d lock class. +#[doc(hidden)] +#[macro_export] +macro_rules! new_srcu { + ($($name:literal)?) =3D> { + $crate::sync::Srcu::new($crate::optional_name!($($name)?), $crate:= :static_lock_class!()) + }; +} +pub use new_srcu; + +/// Sleepable read-copy update primitive. +/// +/// SRCU readers may sleep while holding the read-side guard. +/// +/// The destructor waits for active readers and callbacks, so it may sleep. +/// If a read-side guard has been leaked, dropping an [`Srcu`] may never r= eturn. +/// +/// # Invariants +/// +/// This represents a valid `struct srcu_struct` initialized by the C SRCU= API +/// and it remains pinned and valid until the pinned destructor runs. +#[repr(transparent)] +#[pin_data(PinnedDrop)] +pub struct Srcu { + #[pin] + inner: Opaque, +} + +impl Srcu { + /// Creates a new SRCU instance. + #[inline] + pub fn new(name: &'static CStr, key: Pin<&'static LockClassKey>) -> im= pl PinInit { + try_pin_init!(Self { + // INVARIANT: On success, the C initializer creates a valid `s= rcu_struct` and + // it remains pinned until `PinnedDrop` runs. + inner <- Opaque::try_ffi_init(|ptr: *mut bindings::srcu_struct= | { + // SAFETY: `ptr` points to valid uninitialised memory for = a `srcu_struct`. + to_result(unsafe { + bindings::init_srcu_struct_with_key(ptr, name.as_char_= ptr(), key.as_ptr()) + }) + }), + }) + } + + /// Enters an SRCU read-side critical section. + /// + /// Leaking the returned [`Guard`] leaves the SRCU read-side critical + /// section active and makes `drop` sleep forever. + #[inline] + pub fn read_lock(&self) -> Guard<'_> { + // SAFETY: By the type invariants, `self` contains a valid `struct= srcu_struct`. + let idx =3D unsafe { bindings::srcu_read_lock(self.inner.get()) }; + + // INVARIANT: `idx` was returned by `srcu_read_lock()` for this `S= rcu`. + Guard { + srcu: self, + idx, + _not_send: NotThreadSafe, + } + } + + /// Waits until all pre-existing SRCU readers have completed. + #[inline] + pub fn synchronize(&self) { + // SAFETY: By the type invariants, `self` contains a valid `struct= srcu_struct`. + unsafe { bindings::synchronize_srcu(self.inner.get()) }; + } + + /// Waits until all pre-existing SRCU readers have completed, expedite= d. + /// + /// This requests a lower-latency grace period than [`Srcu::synchroniz= e`] typically + /// at the cost of higher system-wide overhead. Prefer [`Srcu::synchro= nize`] by default + /// and use this variant only when reducing reset or teardown latency = is more important + /// than the extra cost. + #[inline] + pub fn synchronize_expedited(&self) { + // SAFETY: By the type invariants, `self` contains a valid `struct= srcu_struct`. + unsafe { bindings::synchronize_srcu_expedited(self.inner.get()) }; + } +} + +#[pinned_drop] +impl PinnedDrop for Srcu { + fn drop(self: Pin<&mut Self>) { + let ptr =3D self.inner.get(); + + // SAFETY: By the type invariants, `self` contains a valid and pin= ned `struct srcu_struct` + // and `srcu_readers_active()` only checks the active reader count. + if unsafe { bindings::srcu_readers_active(ptr) } { + crate::pr_warn!( + "Leaked `Guard` detected while dropping SRCU; drop will bl= ock forever.\n" + ); + } + + // `cleanup_srcu_struct()` may return early if readers are still a= ctive. Because `Srcu` + // owns the embedded `srcu_struct`, returning from `drop` in that = state could free memory + // that is still referenced by the C side. + // + // Wait for all readers to complete first. If any `Guard` was leak= ed, `synchronize_srcu()` + // will sleep forever. + // + // SAFETY: By the type invariants, `self` contains a valid and pin= ned `struct srcu_struct`. + unsafe { bindings::synchronize_srcu(ptr) }; + + // Ensure all SRCU callbacks have been finished before freeing. + // SAFETY: By the type invariants, `self` contains a valid and pin= ned `struct srcu_struct`. + unsafe { bindings::srcu_barrier(ptr) }; + + // SAFETY: By the type invariants, `self` contains a valid and pin= ned `struct srcu_struct`. + unsafe { bindings::cleanup_srcu_struct(ptr) }; + } +} + +// SAFETY: `srcu_struct` may be shared and used across threads. +unsafe impl Send for Srcu {} +// SAFETY: `srcu_struct` may be shared and used concurrently. +unsafe impl Sync for Srcu {} + +/// Guard for an active SRCU read-side critical section on a particular [`= Srcu`]. +/// +/// Leaking this guard with [`core::mem::forget`] leaves the SRCU read-side +/// critical section active and makes dropping the associated [`Srcu`] sle= ep forever. +/// +/// # Invariants +/// +/// `idx` is the index returned by `srcu_read_lock()` for `srcu`. +#[must_use =3D "if unused, the lock will be immediately unlocked"] +pub struct Guard<'a> { + srcu: &'a Srcu, + idx: i32, + _not_send: NotThreadSafe, +} + +impl Guard<'_> { + /// Explicitly releases the SRCU read-side critical section. + #[inline] + pub fn unlock(self) {} +} + +impl Drop for Guard<'_> { + #[inline] + fn drop(&mut self) { + // SAFETY: `Guard` is only constructible through `Srcu::read_lock(= )`, + // which returns a valid index for the SRCU instance. + unsafe { bindings::srcu_read_unlock(self.srcu.inner.get(), self.id= x) }; + } +} --=20 2.51.2 From nobody Mon Jun 8 16:28:55 2026 Received: from mail-244108.protonmail.ch (mail-244108.protonmail.ch [109.224.244.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37535336EDA; Thu, 28 May 2026 06:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949714; cv=none; b=jLWDt7pTakHginUjSGvSctYPPYEuu+jc/sx2edxFeFjuLKhNyMfJ9dL8nY48krtuW6kq9RbmdRo19wn9uB5rkzEh5By9KEw64J7+8dZGdRrSpogyr7fkvUw4F/dXmPRAgY18JvBaGsAu9ACVi3Pe0pTWGK+JZobFvtZ/N1K91Ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949714; c=relaxed/simple; bh=iNIea3X1u5UlLSCKpcd9EjyAvSlc5TEnDXzmsvHUUBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gSsl4NH9bkbAjtGlb+Bf3ZjziYx9/pAQytH67hgkF2jDfSPtaGqRCK2ERI9lG33B/dIcOx96owUbeUqLSGuCJegtQJdDtjL5+5GYxBb/1NjDRyWynJIPhXc3vA3SFaQMbDCboj0Euenxey4L7GBWI++cqr3iKK4cBHQKGd3GJr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=CVRw1pE5; arc=none smtp.client-ip=109.224.244.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="CVRw1pE5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=protonmail; t=1779949708; x=1780208908; bh=JkD+A35aA68GLUHdDWX6WjTBKf+CG0Z+zqkNuKRO2O8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=CVRw1pE58Y0iMS5n8iZdWmhn7Hknf/+IjJDVF5nhEmrVu5Q9riWpByX49owN140+O 9yGjY3LIXUCA4Jwgx6Ax0Q2FtC0CcGeMKexWGHlVbDSICNEoWp7AyANz2HXhqnV78f E0cwySEjNEVlrWcI+L9iGKUqI5llZMAl7cjOPNQwVVW+PDoVMNWYs6k0Yom4FZ9bgq H18XSTzCH1a4VZYdpiYDEah6RblIYEUX6TJlJea2Yki8sl3dKVfv3pdJxb3oqJXf52 FHRxcnNrpVhlZGRV0YsGabYSgz+LlJBZKyaeMwFlYFRnyWPehjYAzzKuuW7cDRjeG1 +7HzhDlmCMkkw== X-Pm-Submission-Id: 4gQxQ04Jp9z2ScpZ From: =?UTF-8?q?Onur=20=C3=96zkan?= To: rcu@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, peterz@infradead.org, fujita.tomonori@gmail.com, tamird@kernel.org, jiangshanlai@gmail.com, paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v7 4/4] MAINTAINERS: add Rust SRCU files to SRCU entry Date: Thu, 28 May 2026 09:27:36 +0300 Message-ID: <20260528062810.256212-5-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260528062810.256212-1-work@onurozkan.dev> References: <20260528062810.256212-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Include Rust side implementation files to the SRCU maintainer entry. Reviewed-by: Paul E. McKenney Signed-off-by: Onur =C3=96zkan --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e0b307b2108c..7739a435f258 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24624,6 +24624,7 @@ SLEEPABLE READ-COPY UPDATE (SRCU) M: Lai Jiangshan M: "Paul E. McKenney" M: Josh Triplett +M: Onur =C3=96zkan (RUST) R: Steven Rostedt R: Mathieu Desnoyers L: rcu@vger.kernel.org @@ -24632,6 +24633,8 @@ W: http://www.rdrop.com/users/paulmck/RCU/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git rcu/dev F: include/linux/srcu*.h F: kernel/rcu/srcu*.c +F: rust/helpers/srcu.c +F: rust/kernel/sync/srcu.rs =20 SMACK SECURITY MODULE M: Casey Schaufler --=20 2.51.2