From nobody Mon Jun 8 16:28:13 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F32978F26 for ; Thu, 28 May 2026 05:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946341; cv=none; b=qMZV/oH4KQZtvlLEUHJl3RAS3NA7+47BP7g43a73jQqJUybVndzsKE7qSQLqIsggknTJHgdwbn87uWbxKkNv45vwZxzMT/nXX3y9j3TCRLPNEPZhZolKqifTsFoXMGkE9QL3qJjnWZiKL1m2NGB89ID4kq8QsoP+tmqDJzDGTIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946341; c=relaxed/simple; bh=5QXLvT5Qaze0XfDinDuIPEU6u8HNpeMVVd/w/JHQ/90=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V8NXSSgEshn5bKH51iWScrZTsAGflrbYUP9GlVRDm9+flaOtyHIXSCFNiuOyA/0eZK2FJvmpRuq+Dzi1Z1cHT7/ywcrM+ZOC2Ioc3Rncmw1QwvmGETeLDzErpEvDLJ02qnz/4pM3x94g/8tpEGI/a3FqdLdnHF0qP+fJownJflA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q0v8E6vj; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q0v8E6vj" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c80291e6237so8467658a12.0 for ; Wed, 27 May 2026 22:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946340; x=1780551140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QTFk96WD/mDvsuOxsaQzMcg9DBpgS3bUxpPfnb/QrVA=; b=Q0v8E6vjZQIACcLYITDytblAXJLgXNQRwke0G97ax1uKGxiBhQPgisjmQ3PILZrSaU YZGAMXVL/eZ6a5s6sM30cAJmV8SVpzXSj/ZwwdAsxGG9CKYgmnh7i5S4t/k5T2wShHFB WQ3kzRmJ/bc2r0emE3kWItFHWTVDNJDhprh8KDThnPn6oOOcv5pxKcZnoPvmYk3PrLkL 4gpxj8K4BEhar+TULPWon5yJyuyEVbPdtc1TSweZDSCW7gmUvXvrS5+Ip2MSyjXOzNRS T1TxYR8pAtR3sI9PS5YHKCOyCuni8CrTs84LOmjuc4zMwYUTihUGXq7Pk3sC1IOd4vjz 0R2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946340; x=1780551140; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QTFk96WD/mDvsuOxsaQzMcg9DBpgS3bUxpPfnb/QrVA=; b=U6PJdBe75Dfr/qLZx/SN7aT17SQreJFMospX9PtfuStyoAjn026myrjqODH2DEyqt9 F8F3gHK6o8cAjhkKcWG3swqe4HEEjB10eEhvvFuQ00uwqhAhUk6hWzTWK3IoCKFwMhjK EGVUOrPDMmcJWxhTABlSx68K8n89f5I5fchcerBMhlGgwiLpMwn7oO2UnKfJgEdgM408 z8D8XCUyewymumdSQtoMXmFrWa6T73+p37AAjC34SyuyV/qCOFfuYYQibc0n7geRUczw X3sy1VHE7OGOBo7snoILJPS62WU//glc/iRFfw5MOW6xC9LZgytixr4BwUgazItsDiPm GYSQ== X-Forwarded-Encrypted: i=1; AFNElJ/ZiBkDQviwpwLgxXOvyDFRre3asGorPl7ycB4g0P1dlUCvTgqElJ7/Y0Dkgv6g7SfeNnB3F4ZHfCdaRc8=@vger.kernel.org X-Gm-Message-State: AOJu0YxRDrQwTzHboeZY0KijcCi/jkkx6EbXCzZ75oPEKI+STweWr1Nw +H3mL41Kff35HdMU7uZ3dWR2HCp0EreXX/5yUv2o17HYpqGv9Agxz89Q X-Gm-Gg: Acq92OEICVIMFPiwply5/Gkidtk2k2Ao7R4MTi/UeQWxAotH370oH8cOquFBNgsvJ9X 3TEwSR1BeHdG5PgX0P4sGXgE9tqUs+L7++77lcdlGlFr8KXyOFz2XfSHQdoEa7kjK7wEfCjPkts E4I932yEliENM4wsf1f1Nsh5XAQRR6u3Ln2zr9frCriWx8brieImwNcSmktE0YbQy3MCpj1zd0U UK5fG16NW/kvVx77lhtQTuRAQRjISvYuz3T4WChQNfFkaFps1dIhTilL3uySHcf/TsAaaXgT2Ja Bgx/yUZxtGmQszIoC3vjIts75cjlgJSP2/smoBdENFfBzn1ka8mFZIBBt/Ro2VIq1SGHgzmqsvE hZWPsNpAMwwFa50D0o/Vb+RWmqkUuM0N/ZFCiuUVwPrhC6Fs0n8FDFSspnCuZ8Rmik2MkmyFcKi 7pO7PKk4O2yN1CnaPcmUOwBudw9sXd8hriyGUboL9WmI0AQJhUbO2CWc2zbjmrmQR3NAqa X-Received: by 2002:a05:6a20:9396:b0:39e:f994:f697 with SMTP id adf61e73a8af0-3b328d15e01mr27437264637.17.1779946339907; Wed, 27 May 2026 22:32:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85202b91c6sm13929495a12.14.2026.05.27.22.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:19 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Greg Kroah-Hartman Cc: "Rafael J . Wysocki" , Danilo Krummrich , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] regmap: reject volatile update_bits() in cache-only mode Date: Thu, 28 May 2026 12:32:04 +0700 Message-ID: <20260528053204.46783-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Prevent _regmap_update_bits() from accessing hardware when the register map is in cache-only mode. Unlike regmap_raw_read() and _regmap_read(), the volatile _regmap_update_bits() fast path bypasses the cache_only check. This can result in unexpected hardware accesses while the device is suspended. Return -EBUSY to ensure behavior is consistent with other cache-only access paths. Signed-off-by: bui duc phuc --- Compile-tested only. drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index b2b26f07f4e3..e6e022b02637 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -3257,6 +3257,9 @@ static int _regmap_update_bits(struct regmap *map, un= signed int reg, *change =3D false; =20 if (regmap_volatile(map, reg) && map->reg_update_bits) { + if (map->cache_only) + return -EBUSY; + reg =3D regmap_reg_addr(map, reg); ret =3D map->reg_update_bits(map->bus_context, reg, mask, val); if (ret =3D=3D 0 && change) --=20 2.43.0