From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99D2315D33 for ; Thu, 28 May 2026 05:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946353; cv=none; b=qTF4Wt80Bn6lEixJ9HAdcRXn8P8brTozOq1Vkciu6uU00UzhQsF3EVWvxKrsnsw+jKVaRHrk7y5PcMWcEaFPYv6PB3/QCfYvzft8dg4IMLr75CRDKSG7fnUj6G/q/Mt8mfIdrldEi2+B1M7KEQXPJcub3aVSCW/r3ngKhnzHRFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946353; c=relaxed/simple; bh=or+EJ07SOsHtoyrRm94X5M8kiBqJd626zfaT/m/MjG0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HyVpwnHYXFDxxrg7s0KbRBwiz7epB5Dgr0Xyxz6HeXjFPboG5n0OSSRyF37zT1ufV0HLXMJ/O/m2Olcs3j0VsbPsjutNnCaBhYtKPTiio51ZQE/T28dDg8FcGQ2m7rR0CKRyPQmeEljh/FYQbDzgaMacVYS/QbgzDhrVlddJHOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VuQN5ltW; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VuQN5ltW" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6886be3d39bso9992760a12.3 for ; Wed, 27 May 2026 22:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946350; x=1780551150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CuxBA1Jnwii0AQo0AYAcpS9dZCQZKs+YbA2PPOQhDTM=; b=VuQN5ltWkC3k9ikvHRMRn5mkhcc434VY8Oel+BDUNoYr7CMaqMWu/GlU/MWWZUrlH8 5DUPIc2xQ2+khJIWyXS+p3Xma8S1uZ0dbiO8BYNh0RGr9uuO7uVPgZFbMiZfpLvTURxV m3uZImWMUQiZBJ+FTvqI8IkSpXUHaFC7xxP2KO5NxngeJGsPkSvHuqtepwUIt3vDXXjl qqGo8bAMsJBscsjObnKv/uulevFqotmRz6Xxrge9ZuU5E8ai7A0DU77H0p+96XJKd69f 8dc32hl/4AiJdtZmCZyoJ+zklnMIipZGv1CviB+2b4du5/G3i/hJwgaAVT+j803+iHoX DANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946350; x=1780551150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CuxBA1Jnwii0AQo0AYAcpS9dZCQZKs+YbA2PPOQhDTM=; b=UT+DyhuVK6zcxgfIUFOtIaI6TL0fTF+ChvIVxsMNlVvmf7peJs+P0SGkOkPzZrSWjh 3/bpXojg9Zz1qWAkGGbHZxn8uAaVfk1rEcxxqAulbe09er2BRsOeFBzPL+wjdZXFUU5h d41eTeIe79rAjy+nbGaRdvX0/1s7pQtbNEUrnkDhCy7akk3YRystHaU8lYKLmPK4srgF O67Ak+tjHlyWnbs77LBd6XwKSY1Y2q+L8L6nAzdfXNuEsMF7jy13o64PovWUAXI278ZZ xqyE2yXzc2k16zrr2NAvXVrpqwLfLZfC8arXdgGtRGcc+ZAV3/vWmSsYPZr7az5J/j3U e95w== X-Forwarded-Encrypted: i=1; AFNElJ8jm8+r/a3edJX6eqLKG5HXOAL+QY9Oz+A5w/arCrH8kIR/67fs4r/+26mwMDuA7JoTb924qrYAynYwVWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+IYwRlA4aAtJB4Ncg+KKdOZmxx5dFri+3HK0RqNtYyAjNN3x4 b3DSFttAhBzDNQ5sB3U5Zr6BGm/HqkBrnnl7EgzbAKrmS8v1Fiv4vJW8 X-Gm-Gg: Acq92OHEdQvxRLV/c/NXoW49Npzdnrn0HUSL2NWUt3XerdtLIEhfO2T2cZIZMC/aW70 uIHn3/eXmpHEWSwfR357W6D9QXcqqZfQyPCydE6394FptUMamuzBJ9zYMov0YhEdOFc3U7xZXyZ ODaoPNwujR9DBgCgzG2d948PfkVuy4zwzG91uvaMXB3V0gnTw2YzREEks3AfTLMwA4ZyUqSJbiv h2E1yWR731cnYTSYlebtZSzFOuCRslqvhvevB4lxXPe2bEzrkBOeU1sPlvkFBKz1eYWPNEEVcfM h/3cT6zTkth6Y7nTzSugsEB2szPUxQWPNMOyQg4NQ1PxymCazjgTL4GRaMp4juFla42IwxRGaQQ FEbBlDBR4BspOyxr4oFAfzaWvyYuNjF4Zc/850CiI94OPe2vsJe4OJU1UN9ewcqOP79HQ8UfrAi F4uta5IgSLH3wKDSm/DqI4PGw= X-Received: by 2002:a17:907:c003:b0:bd5:7a3:a593 with SMTP id a640c23a62f3a-bdd2b0d6a45mr1714780166b.46.1779946349814; Wed, 27 May 2026 22:32:29 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:29 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC Date: Thu, 28 May 2026 08:31:57 +0300 Message-ID: <20260528053203.9339-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document embedded controller used in ASUS Transformer device series. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Rob Herring (Arm) --- .../asus,tf201-ec-pad.yaml | 119 ++++++++++++++++++ 1 file changed, 119 insertions(+) create mode 100644 Documentation/devicetree/bindings/embedded-controller/a= sus,tf201-ec-pad.yaml diff --git a/Documentation/devicetree/bindings/embedded-controller/asus,tf2= 01-ec-pad.yaml b/Documentation/devicetree/bindings/embedded-controller/asus= ,tf201-ec-pad.yaml new file mode 100644 index 000000000000..60b6375864aa --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/asus,tf201-ec-p= ad.yaml @@ -0,0 +1,119 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/asus,tf201-ec-pad.y= aml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASUS Transformer's Embedded Controller + +description: + Several Nuvoton based Embedded Controllers attached to an I2C bus, + running a custom ASUS firmware, specific to the ASUS Transformer + device series. + +maintainers: + - Svyatoslav Ryhel + +properties: + compatible: + description: + The 'pad' suffix is used for the controller within the tablet, while + the 'dock' suffix refers to the controller in the mobile dock keyboa= rd. + oneOf: + - enum: + - asus,sl101-ec-dock + - asus,tf101-ec-dock + - asus,tf201-ec-pad + - asus,tf600t-ec-dock + - asus,tf600t-ec-pad + + - items: + - enum: + - asus,tf101g-ec-dock + - asus,tf201-ec-dock + - asus,tf300t-ec-dock + - asus,tf300tg-ec-dock + - asus,tf300tl-ec-dock + - asus,tf700t-ec-dock + - const: asus,tf101-ec-dock + + - items: + - enum: + - asus,tf300t-ec-pad + - asus,tf300tg-ec-pad + - asus,tf300tl-ec-pad + - asus,tf700t-ec-pad + - const: asus,tf201-ec-pad + + - items: + - enum: + - asus,tf701t-ec-dock + - const: asus,tf600t-ec-dock + + - items: + - enum: + - asus,p1801-t-ec-pad + - asus,tf701t-ec-pad + - const: asus,tf600t-ec-pad + + reg: + description: + The ASUS Transformer EC has a main I2C address and an associated + DockRAM device, which provides power-related functions for the + embedded controller. Both addresses are required for operation. + minItems: 2 + + reg-names: + items: + - const: ec + - const: dockram + + interrupts: + maxItems: 1 + + request-gpios: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + +allOf: + - $ref: /schemas/power/supply/power-supply.yaml + - if: + properties: + compatible: + not: + contains: + const: asus,tf600t-ec-dock + then: + required: + - interrupts + - request-gpios + +unevaluatedProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@19 { + compatible =3D "asus,tf201-ec-dock", "asus,tf101-ec-dock"; + reg =3D <0x19>, <0x1b>; + reg-names =3D "ec", "dockram"; + + interrupt-parent =3D <&gpio>; + interrupts =3D <151 IRQ_TYPE_LEVEL_LOW>; + + request-gpios =3D <&gpio 134 GPIO_ACTIVE_LOW>; + + monitored-battery =3D <&dock_battery>; + }; + }; +... --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DF86322A2E for ; Thu, 28 May 2026 05:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946356; cv=none; b=gVg4eiEOLptqFFilkWb5+tEVb9bFyWJkRNUBOqf5dglmYtS8YqVgCELrdk1wpWvh9GBuMcxIsgRSTIUfiv4p7LphGIGKNJ0kFXShhL+CWfeSUuDGHkFNfJu/ORfYRFlpzeREheIeUHSCeIpOTDF0mxYrLsdvNKQQkS4akRpSoiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946356; c=relaxed/simple; bh=H/y1f7DazsFlIRIQMfF7Qoix86AnNw/z/F0ENegi+us=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KdUYAsj9wib+NR721Jv59++nc/DK3HYryV+9JWs3f1wFwoi+M1oTZW5GS4cOOPEsaC8fTULVk67uNRtq1RZL00RdzS+dMUggvVvNRYnHxxexMyTJ+wnE6bKVl9BTmPlcNBxNn7FqUwVf2W65XeelshOzfcfLlJHuTldpHUsbbn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mD8mdwJY; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mD8mdwJY" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-bd2087858c4so2221783966b.0 for ; Wed, 27 May 2026 22:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946352; x=1780551152; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PGtZBbLq8O3U7f1eScgufghNfBKENTz6Fbwki6rD/iI=; b=mD8mdwJYTwmr8fWOYPhy4L46b3tWnNgaPJ7R3GvGoahkaMWLWGJ6ZJZj4tqGqC+J08 yVUjl45UIPQwpy76CG2EnS7idljZAIvKByRB//ZcXPopeERwuAOhPJOfNlpsWQko5u02 bECGDWDGfyavHZTijITMIv7asmixVdqBlBskrSwOB1WWlVtNSXM+ErOCjHaZ+R3PnQvU +6v5BcJs/l/o8+dEzb2IJG5eupq5tRuwS5b4PwPea2Cu/kgKtevK38ImdaNd7hGHMwBn 0UXuxy0+M6f5DbjZBAb+bCG7qnNyCwF5qdYD6rlWlnxKxEyQTMBueuZ+MzJs3RT4DU8i kr4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946352; x=1780551152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PGtZBbLq8O3U7f1eScgufghNfBKENTz6Fbwki6rD/iI=; b=kYyNsrtWUwdTbLZVdCI5748wEkZSgjdqtW83PecNyOkF8kNDWnl7Z2kJogxijW18u+ yaRvyHAlfPwcMb4OKuoWsY6zeQ2Qa4FU57ZySzHFwo61Zv8anuBZVWXdHTgrAcwwb5X+ xolhGnYnrOw7if4FmuDUVmVK7LbSoILYoLSpY2IV8wsO39WjkzxXWtcF+U/r5MaiLdPe wbKciJdKNEISbw26O8wIoeaD5Nqz4XaalJYy/L4a+MXkGelqObcRYHTnK7ApGHLLMWUl g8S1ph379QpobWOM7j5eEXbcqNIaqZsiOZhU73yTQ1ukiHXuYKwjzAyP4eZDrt37p/v2 Nz9Q== X-Forwarded-Encrypted: i=1; AFNElJ/NYIgWVEMUgZIoKHccAyXljLGtlUH6WRTX8+nc2/bGuByP7soJzH9Dul9JPmNvcgoDkoeI9fM8X4MZdcQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyRGwhooKRCen2S/E8s23nwucYeQm4F0/taWLmi8xY1K0WMHmPA i3ErWgu6QKMtzBwp+XQeSP8ndA/cqYSM0vr88VAIY0waTtA9lAmPUbNH X-Gm-Gg: Acq92OHj2nHhxPL4tbvwucC4fV9rWn9aloG1gdBSNPsoGKynttuvf0XNODE8AKDEUYZ CY1jftgWxuz0I+1YQAFdoYfB+GHnvlex3Ym89GO7STqmWl5M5bwdKWF3+Nbd4jCg2Uyuvf/Py3y X0fZjyAlQzHEe0Y3pMbagotQWnmBSNsFCkGRBN1n8IiRSZDcU+9u3BCcrAKPWf0tGU17UkCcxL0 emURvmafIOtZEeSTmg4fULX86sbF6XDq05T4Xy6lkItm4ClypggCMrJdX9OHsBLOhIyzE5813+p nh5AO1NGDJR9mYLsGNECkEG+zOzyzXW/nyQSW0C3/4NK0QeTiMYhTPYL9gQ1kmKvn39tjdVtjKT WCOpaYTRIZU9ZtO24ep32mC31WifSVpJvtJ26oFooYF23ImdTNB/7NIZcpWr8BI8zjrFODf+7py flXBofnn4bpmsLRF83V/8T69oEqkbmRB3ZzA== X-Received: by 2002:a17:907:501f:b0:bdd:f2c9:80cc with SMTP id a640c23a62f3a-bddf2c98604mr986948366b.21.1779946351428; Wed, 27 May 2026 22:32:31 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:30 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 2/7] mfd: Add driver for ASUS Transformer embedded controller Date: Thu, 28 May 2026 08:31:58 +0300 Message-ID: <20260528053203.9339-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201, TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock and TF600T, P1801-T and TF701T pad. This is a glue driver handling detection and common operations for EC's functions. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/mfd/Kconfig | 16 + drivers/mfd/Makefile | 1 + drivers/mfd/asus-transformer-ec.c | 542 ++++++++++++++++++++++++ include/linux/mfd/asus-transformer-ec.h | 92 ++++ 4 files changed, 651 insertions(+) create mode 100644 drivers/mfd/asus-transformer-ec.c create mode 100644 include/linux/mfd/asus-transformer-ec.h diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 7192c9d1d268..e1c32505b97a 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -137,6 +137,22 @@ config MFD_AAT2870_CORE additional drivers must be enabled in order to use the functionality of the device. =20 +config MFD_ASUS_TRANSFORMER_EC + tristate "ASUS Transformer's embedded controller" + select MFD_CORE + depends on I2C && OF + help + Select this to enable support for the Embedded Controller (EC) + found in Tegra based ASUS Transformer series tablets and mobile + docks. + + This driver handles the core I2C communication with the EC and + provides support for its sub-devices, including battery management, + charger detection, LEDs and keyboard dock functions support. + + This driver can also be built as a module. If so, the module + will be called asus-transformer-ec. + config MFD_AT91_USART tristate "AT91 USART Driver" select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index e75e8045c28a..fd80088d8a9a 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_MFD_88PM805) +=3D 88pm805.o 88pm80x.o obj-$(CONFIG_MFD_88PM886_PMIC) +=3D 88pm886.o obj-$(CONFIG_MFD_ACT8945A) +=3D act8945a.o obj-$(CONFIG_MFD_SM501) +=3D sm501.o +obj-$(CONFIG_MFD_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec.o obj-$(CONFIG_ARCH_BCM2835) +=3D bcm2835-pm.o obj-$(CONFIG_MFD_BCM590XX) +=3D bcm590xx.o obj-$(CONFIG_MFD_BD9571MWV) +=3D bd9571mwv.o diff --git a/drivers/mfd/asus-transformer-ec.c b/drivers/mfd/asus-transform= er-ec.c new file mode 100644 index 000000000000..1f5900d0fdc9 --- /dev/null +++ b/drivers/mfd/asus-transformer-ec.c @@ -0,0 +1,542 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_RSP_BUFFER_SIZE (ASUSEC_ENTRIES / ASUSEC_ENTRY_SIZE) + +#define ASUSEC_RESET 0 +#define ASUSEC_RETRY_MAX 3 +#define ASUSEC_ACCESS_TIMEOUT 300 + +enum asusec_variant { + ASUSEC_SL101_DOCK =3D 1, + ASUSEC_TF101_DOCK, + ASUSEC_TF201_PAD, + ASUSEC_TF600T_PAD, + ASUSEC_MAX +}; + +enum asusec_mode { + ASUSEC_MODE_NONE, + ASUSEC_MODE_NORMAL, + ASUSEC_MODE_FACTORY, + ASUSEC_MODE_MAX +}; + +/** + * struct asus_ec_chip_info + * + * @name: prefix associated with the EC + * @variant: id of programming model of EC + * @mode: state of Factory Mode bit in EC control register + */ +struct asus_ec_chip_info { + const char *name; + enum asusec_variant variant; + enum asusec_mode fmode; +}; + +/** + * struct asus_ec_data + * + * @ec: public part shared with all cells (must be first) + * @ecreq_lock: prevents simultaneous access to EC + * @ecreq_gpio: EC request GPIO + * @client: pointer to EC's i2c_client + * @info: pointer to EC's version description + * @ec_buf: buffer for EC read + * @logging_disabled: flag disabling logging on reset events + */ +struct asus_ec_data { + struct asusec_core ec; + struct mutex ecreq_lock; + struct gpio_desc *ecreq_gpio; + struct i2c_client *client; + const struct asus_ec_chip_info *info; + u8 ec_buf[ASUSEC_ENTRY_BUFSIZE]; + bool logging_disabled; +}; + +/** + * struct dockram_ec_data + * + * @ctl_lock: prevent simultaneous access to Dockram + * @ctl_buf: buffer for Dockram read + */ +struct dockram_ec_data { + struct mutex ctl_lock; + u8 ctl_buf[ASUSEC_ENTRY_BUFSIZE]; +}; + +/** + * asus_dockram_access_ctl - Read from or write to the DockRAM control reg= ister. + * @client: Handle to the DockRAM device. + * @out: Pointer to a variable where the register value will be stored. + * @mask: Bitmask of bits to be cleared. + * @xor: Bitmask of bits to be set (via XOR). + * + * This performs a control register read if @out is provided and both @mask + * and @xor are zero. Otherwise, it performs a control register update if + * @mask and @xor are provided. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_access_ctl(struct i2c_client *client, u64 *out, u64 mask, + u64 xor) +{ + struct dockram_ec_data *ddata =3D i2c_get_clientdata(client); + u8 *buf =3D ddata->ctl_buf; + u64 val; + int ret =3D 0; + + guard(mutex)(&ddata->ctl_lock); + + memset(buf, 0, ASUSEC_ENTRY_BUFSIZE); + ret =3D i2c_smbus_read_i2c_block_data(client, ASUSEC_DOCKRAM_CONTROL, + ASUSEC_ENTRY_SIZE, buf); + if (ret < ASUSEC_ENTRY_SIZE) { + dev_err(&client->dev, "failed to access control buffer: %d\n", + ret); + return ret; + } + + if (buf[0] !=3D ASUSEC_CTL_SIZE) { + dev_err(&client->dev, "buffer size exceeds %d: %d\n", + ASUSEC_CTL_SIZE, buf[0]); + return -EPROTO; + } + + val =3D get_unaligned_le64(buf + 1); + + if (out) + *out =3D val; + + if (mask || xor) { + put_unaligned_le64((val & ~mask) ^ xor, buf + 1); + ret =3D i2c_smbus_write_i2c_block_data(client, + ASUSEC_DOCKRAM_CONTROL, + ASUSEC_ENTRY_SIZE, buf); + if (ret) + return ret; + } + + return 0; +} +EXPORT_SYMBOL_GPL(asus_dockram_access_ctl); + +static int asus_ec_signal_request(struct asus_ec_data *ddata) +{ + guard(mutex)(&ddata->ecreq_lock); + + gpiod_set_value_cansleep(ddata->ecreq_gpio, 1); + msleep(50); + + gpiod_set_value_cansleep(ddata->ecreq_gpio, 0); + msleep(200); + + return 0; +} + +static void asus_ec_clear_buffer(struct asus_ec_data *ddata) +{ + int ret, retry =3D ASUSEC_RSP_BUFFER_SIZE; + + /* + * Read the buffer till we get valid data by checking ASUSEC_OBF_MASK + * of the status byte or till we reach end of the 256 byte buffer. + */ + while (retry--) { + ret =3D i2c_smbus_read_i2c_block_data(ddata->client, ASUSEC_READ_BUF, + ASUSEC_ENTRY_SIZE, + ddata->ec_buf); + if (ret < ASUSEC_ENTRY_SIZE) + continue; + + if (ddata->ec_buf[ASUSEC_IRQ_STATUS] & ASUSEC_OBF_MASK) + continue; + + break; + } +} + +static int asus_ec_log_info(struct asus_ec_data *ddata, unsigned int reg, + const char *name, const char **out) +{ + struct device *dev =3D &ddata->client->dev; + u8 buf[ASUSEC_ENTRY_BUFSIZE]; + int ret; + + memset(buf, 0, ASUSEC_ENTRY_BUFSIZE); + ret =3D i2c_smbus_read_i2c_block_data(ddata->ec.dockram, reg, + ASUSEC_ENTRY_SIZE, buf); + if (ret < ASUSEC_ENTRY_SIZE) + return ret; + + if (buf[0] > ASUSEC_ENTRY_SIZE) { + dev_err(dev, "bad data len; buffer: %*ph; ret: %d\n", + ASUSEC_ENTRY_BUFSIZE, buf, ret); + return -EPROTO; + } + + if (!ddata->logging_disabled) { + dev_info(dev, "%-14s: %.*s\n", name, buf[0], buf + 1); + + if (out) { + *out =3D devm_kasprintf(dev, GFP_KERNEL, "%.*s", + buf[0], buf + 1); + if (!*out) + return -ENOMEM; + } + } + + return 0; +} + +static int asus_ec_reset(struct asus_ec_data *ddata) +{ + int retry, ret; + + guard(mutex)(&ddata->ecreq_lock); + + for (retry =3D 0; retry < ASUSEC_RETRY_MAX; retry++) { + ret =3D i2c_smbus_write_word_data(ddata->client, ASUSEC_WRITE_BUF, + ASUSEC_RESET); + if (!ret) + return 0; + + msleep(ASUSEC_ACCESS_TIMEOUT); + } + + return ret; +} + +static int asus_ec_susb_on_status(struct asus_ec_data *ddata) +{ + u64 flag; + int ret; + + ret =3D asus_dockram_access_ctl(ddata->ec.dockram, &flag, 0, 0); + if (ret) + return ret; + + flag &=3D ASUSEC_CTL_SUSB_MODE; + dev_info(&ddata->client->dev, "EC FW behaviour: %s\n", + flag ? "susb on when receive ec_req" : + "susb on when system wakeup"); + + return 0; +} + +static int asus_ec_set_factory_mode(struct asus_ec_data *ddata, + enum asusec_mode fmode) +{ + dev_info(&ddata->client->dev, "Entering %s mode.\n", + fmode =3D=3D ASUSEC_MODE_FACTORY ? "factory" : "normal"); + + return asus_dockram_access_ctl(ddata->ec.dockram, NULL, + ASUSEC_CTL_FACTORY_MODE, + fmode =3D=3D ASUSEC_MODE_FACTORY ? + ASUSEC_CTL_FACTORY_MODE : 0); +} + +static int asus_ec_detect(struct asus_ec_data *ddata) +{ + int ret; + + ret =3D asus_ec_reset(ddata); + if (ret) + goto err_exit; + + asus_ec_clear_buffer(ddata); + + ret =3D asus_ec_log_info(ddata, ASUSEC_DOCKRAM_INFO_MODEL, "Model", + &ddata->ec.model); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(ddata, ASUSEC_DOCKRAM_INFO_FW, "FW version", + NULL); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(ddata, ASUSEC_DOCKRAM_INFO_CFGFMT, "Config forma= t", + NULL); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(ddata, ASUSEC_DOCKRAM_INFO_HW, "HW version", + NULL); + if (ret) + goto err_exit; + + /* Disable logging on next EC request */ + ddata->logging_disabled =3D true; + + /* Check and inform about EC firmware behavior */ + ret =3D asus_ec_susb_on_status(ddata); + if (ret) + goto err_exit; + + ddata->ec.name =3D ddata->info->name; + + /* Some EC require factory mode to be set normal on each request */ + if (ddata->info->fmode) + ret =3D asus_ec_set_factory_mode(ddata, ddata->info->fmode); + +err_exit: + if (ret) + dev_err(&ddata->client->dev, "failed to access EC: %d\n", ret); + + return ret; +} + +static void asus_ec_handle_smi(struct asus_ec_data *ddata, unsigned int co= de) +{ + switch (code) { + case ASUSEC_SMI_HANDSHAKE: + case ASUSEC_SMI_RESET: + asus_ec_detect(ddata); + break; + } +} + +static irqreturn_t asus_ec_interrupt(int irq, void *dev_id) +{ + struct asus_ec_data *ddata =3D dev_id; + unsigned long notify_action; + int ret; + + ret =3D i2c_smbus_read_i2c_block_data(ddata->client, ASUSEC_READ_BUF, + ASUSEC_ENTRY_SIZE, ddata->ec_buf); + if (ret < ASUSEC_ENTRY_SIZE || + !(ddata->ec_buf[ASUSEC_IRQ_STATUS] & ASUSEC_OBF_MASK)) + return IRQ_NONE; + + notify_action =3D ddata->ec_buf[ASUSEC_IRQ_STATUS]; + if (notify_action & ASUSEC_SMI_MASK) { + unsigned int code =3D ddata->ec_buf[ASUSEC_SMI_CODE]; + + asus_ec_handle_smi(ddata, code); + + notify_action |=3D code << 8; + } + + blocking_notifier_call_chain(&ddata->ec.notify_list, + notify_action, ddata->ec_buf); + + return IRQ_HANDLED; +} + +static void asus_ec_release_dockram_dev(void *client) +{ + i2c_unregister_device(client); +} + +static struct i2c_client *devm_asus_dockram_get(struct device *dev) +{ + struct i2c_client *parent =3D to_i2c_client(dev); + struct i2c_client *dockram; + struct dockram_ec_data *ddata; + int ret; + + dockram =3D i2c_new_ancillary_device(parent, "dockram", + parent->addr + 2); + if (IS_ERR(dockram)) + return dockram; + + ret =3D devm_add_action_or_reset(dev, asus_ec_release_dockram_dev, + dockram); + if (ret) + return ERR_PTR(ret); + + ddata =3D devm_kzalloc(&dockram->dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return ERR_PTR(-ENOMEM); + + i2c_set_clientdata(dockram, ddata); + mutex_init(&ddata->ctl_lock); + + return dockram; +} + +static const struct mfd_cell asus_ec_sl101_dock_mfd_devices[] =3D { + MFD_CELL_NAME("asus-transformer-ec-kbc"), +}; + +static const struct mfd_cell asus_ec_tf101_dock_mfd_devices[] =3D { + MFD_CELL_BASIC("asus-transformer-ec-battery", NULL, NULL, 0, 1), + MFD_CELL_BASIC("asus-transformer-ec-charger", NULL, NULL, 0, 1), + MFD_CELL_BASIC("asus-transformer-ec-led", NULL, NULL, 0, 1), + MFD_CELL_NAME("asus-transformer-ec-keys"), + MFD_CELL_NAME("asus-transformer-ec-kbc"), +}; + +static const struct mfd_cell asus_ec_tf201_pad_mfd_devices[] =3D { + MFD_CELL_NAME("asus-transformer-ec-battery"), + MFD_CELL_NAME("asus-transformer-ec-led"), +}; + +static const struct mfd_cell asus_ec_tf600t_pad_mfd_devices[] =3D { + MFD_CELL_NAME("asus-transformer-ec-battery"), + MFD_CELL_NAME("asus-transformer-ec-charger"), + MFD_CELL_NAME("asus-transformer-ec-led"), +}; + +static int asus_ec_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct asus_ec_data *ddata; + const struct mfd_cell *cells; + unsigned int num_cells; + unsigned long irqflags; + int ret; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) + return dev_err_probe(dev, -ENXIO, + "I2C bus is missing required SMBus block mode support\n"); + + ddata =3D devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + ddata->info =3D device_get_match_data(dev); + if (!ddata->info) + return -ENODEV; + + switch (ddata->info->variant) { + case ASUSEC_SL101_DOCK: + cells =3D asus_ec_sl101_dock_mfd_devices; + num_cells =3D ARRAY_SIZE(asus_ec_sl101_dock_mfd_devices); + break; + case ASUSEC_TF101_DOCK: + cells =3D asus_ec_tf101_dock_mfd_devices; + num_cells =3D ARRAY_SIZE(asus_ec_tf101_dock_mfd_devices); + break; + case ASUSEC_TF201_PAD: + cells =3D asus_ec_tf201_pad_mfd_devices; + num_cells =3D ARRAY_SIZE(asus_ec_tf201_pad_mfd_devices); + break; + case ASUSEC_TF600T_PAD: + cells =3D asus_ec_tf600t_pad_mfd_devices; + num_cells =3D ARRAY_SIZE(asus_ec_tf600t_pad_mfd_devices); + break; + default: + return dev_err_probe(dev, -EINVAL, + "unknown device variant %d\n", + ddata->info->variant); + } + + i2c_set_clientdata(client, ddata); + ddata->client =3D client; + + ddata->ec.dockram =3D devm_asus_dockram_get(dev); + if (IS_ERR(ddata->ec.dockram)) + return dev_err_probe(dev, PTR_ERR(ddata->ec.dockram), + "failed to get dockram\n"); + + ddata->ecreq_gpio =3D devm_gpiod_get(dev, "request", GPIOD_OUT_LOW); + if (IS_ERR(ddata->ecreq_gpio)) + return dev_err_probe(dev, PTR_ERR(ddata->ecreq_gpio), + "failed to get EC request GPIO\n"); + + BLOCKING_INIT_NOTIFIER_HEAD(&ddata->ec.notify_list); + mutex_init(&ddata->ecreq_lock); + + asus_ec_signal_request(ddata); + + ret =3D asus_ec_detect(ddata); + if (ret) + return dev_err_probe(dev, ret, "failed to detect EC version\n"); + + /* + * Systems using device tree should set up interrupt via DTS, + * the rest will use the default low interrupt. + */ + irqflags =3D dev->of_node ? 0 : IRQF_TRIGGER_LOW; + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + &asus_ec_interrupt, + IRQF_ONESHOT | irqflags, + client->name, ddata); + if (ret) + return dev_err_probe(dev, ret, "failed to register IRQ\n"); + + /* Parent I2C controller uses DMA, ASUS EC and child devices do not */ + client->dev.coherent_dma_mask =3D 0; + client->dev.dma_mask =3D &client->dev.coherent_dma_mask; + + return devm_mfd_add_devices(dev, 0, cells, num_cells, NULL, 0, NULL); +} + +static const struct asus_ec_chip_info asus_ec_sl101_dock_data =3D { + .name =3D "dock", + .variant =3D ASUSEC_SL101_DOCK, + .fmode =3D ASUSEC_MODE_NONE, +}; + +static const struct asus_ec_chip_info asus_ec_tf101_dock_data =3D { + .name =3D "dock", + .variant =3D ASUSEC_TF101_DOCK, + .fmode =3D ASUSEC_MODE_NONE, +}; + +static const struct asus_ec_chip_info asus_ec_tf201_pad_data =3D { + .name =3D "pad", + .variant =3D ASUSEC_TF201_PAD, + .fmode =3D ASUSEC_MODE_NORMAL, +}; + +static const struct asus_ec_chip_info asus_ec_tf600t_pad_data =3D { + .name =3D "pad", + .variant =3D ASUSEC_TF600T_PAD, + .fmode =3D ASUSEC_MODE_NORMAL, +}; + +static const struct of_device_id asus_ec_match[] =3D { + { + .compatible =3D "asus,sl101-ec-dock", + .data =3D &asus_ec_sl101_dock_data + }, { + .compatible =3D "asus,tf101-ec-dock", + .data =3D &asus_ec_tf101_dock_data + }, { + .compatible =3D "asus,tf201-ec-pad", + .data =3D &asus_ec_tf201_pad_data + }, { + .compatible =3D "asus,tf600t-ec-pad", + .data =3D &asus_ec_tf600t_pad_data + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, asus_ec_match); + +static struct i2c_driver asus_ec_driver =3D { + .driver =3D { + .name =3D "asus-transformer-ec", + .of_match_table =3D asus_ec_match, + }, + .probe =3D asus_ec_probe, +}; +module_i2c_driver(asus_ec_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's EC driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/asus-transformer-ec.h b/include/linux/mfd/as= us-transformer-ec.h new file mode 100644 index 000000000000..f085eea2193e --- /dev/null +++ b/include/linux/mfd/asus-transformer-ec.h @@ -0,0 +1,92 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MFD_ASUS_TRANSFORMER_EC_H +#define __MFD_ASUS_TRANSFORMER_EC_H + +#include +#include + +struct i2c_client; + +/** + * struct asusec_core - public part shared with all cells + * + * @model: firmware version running on the EC + * @name: prefix associated with the EC + * @dockram: pointer to Dockram's i2c_client + * @notify_list: notify list used by cells + */ +struct asusec_core { + const char *model; + const char *name; + struct i2c_client *dockram; + struct blocking_notifier_head notify_list; +}; + +#define ASUSEC_ENTRIES 0x100 +#define ASUSEC_ENTRY_SIZE 32 +#define ASUSEC_ENTRY_BUFSIZE (ASUSEC_ENTRY_SIZE + 1) + +/* interrupt sources */ +#define ASUSEC_IRQ_STATUS 1 +#define ASUSEC_OBF_MASK BIT(0) +#define ASUSEC_KEY_MASK BIT(2) +#define ASUSEC_KBC_MASK BIT(3) +#define ASUSEC_AUX_MASK BIT(5) +#define ASUSEC_SCI_MASK BIT(6) +#define ASUSEC_SMI_MASK BIT(7) + +/* SMI notification codes */ +#define ASUSEC_SMI_CODE 2 +#define ASUSEC_SMI_POWER_NOTIFY 0x31 /* USB cable plug event */ +#define ASUSEC_SMI_HANDSHAKE 0x50 /* response to ec_req edge */ +#define ASUSEC_SMI_WAKE 0x53 +#define ASUSEC_SMI_RESET 0x5f +#define ASUSEC_SMI_ADAPTER_EVENT 0x60 /* charger to dock plug event */ +#define ASUSEC_SMI_BACKLIGHT_ON 0x63 +#define ASUSEC_SMI_AUDIO_DOCK_IN 0x70 + +#define ASUSEC_SMI_ACTION(code) (ASUSEC_SMI_MASK | ASUSEC_OBF_MASK | \ + (ASUSEC_SMI_##code << 8)) + +/* control register [0x0a] layout */ +#define ASUSEC_CTL_SIZE 8 + +/* + * EC reports power from 40-pin connector in the LSB of the control + * register. The following values have been observed (xor 0x02): + * + * PAD-ec no-plug 0x40 / PAD-ec DOCK 0x20 / DOCK-ec no-plug 0x40 + * PAD-ec AC 0x25 / PAD-ec DOCK+AC 0x24 / DOCK-ec AC 0x25 + * PAD-ec USB 0x45 / PAD-ec DOCK+USB 0x24 / DOCK-ec USB 0x41 + */ + +#define ASUSEC_CTL_DIRECT_POWER_SOURCE BIT_ULL(0) +#define ASUSEC_STAT_CHARGING BIT_ULL(2) +#define ASUSEC_CTL_FULL_POWER_SOURCE BIT_ULL(5) +#define ASUSEC_CTL_SUSB_MODE BIT_ULL(9) +#define ASUSEC_CMD_SUSPEND_S3 BIT_ULL(33) +#define ASUSEC_CTL_TEST_DISCHARGE BIT_ULL(35) +#define ASUSEC_CMD_SUSPEND_INHIBIT BIT_ULL(37) +#define ASUSEC_CTL_FACTORY_MODE BIT_ULL(38) +#define ASUSEC_CTL_KEEP_AWAKE BIT_ULL(39) +#define ASUSEC_CTL_USB_CHARGE BIT_ULL(40) +#define ASUSEC_CTL_LED_BLINK BIT_ULL(40) +#define ASUSEC_CTL_LED_AMBER BIT_ULL(41) +#define ASUSEC_CTL_LED_GREEN BIT_ULL(42) +#define ASUSEC_CMD_SWITCH_HDMI BIT_ULL(56) +#define ASUSEC_CMD_WIN_SHUTDOWN BIT_ULL(62) + +#define ASUSEC_DOCKRAM_INFO_MODEL 0x01 +#define ASUSEC_DOCKRAM_INFO_FW 0x02 +#define ASUSEC_DOCKRAM_INFO_CFGFMT 0x03 +#define ASUSEC_DOCKRAM_INFO_HW 0x04 +#define ASUSEC_DOCKRAM_CONTROL 0x0a +#define ASUSEC_DOCKRAM_BATT_CTL 0x14 + +#define ASUSEC_WRITE_BUF 0x64 +#define ASUSEC_READ_BUF 0x6a + +int asus_dockram_access_ctl(struct i2c_client *client, + u64 *out, u64 mask, u64 xor); + +#endif /* __MFD_ASUS_TRANSFORMER_EC_H */ --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B926232143D for ; Thu, 28 May 2026 05:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946357; cv=none; b=N57fX/3e46ygm0IfV2xfJbcRgM92gIJ7wxVd7E4mwJvpr2IdX0k8yfJxAjRXi+7iO+uEbli108h9fl/VppJlntluugYfZKuKaU+iypKIqbfOkDHcsAnzw1bMMMeyXT8+0+v4hcB0D/k5wyhvZCS8e32fxtY51zOHOE5lq2bGCHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946357; c=relaxed/simple; bh=hK+dWBAA+DEcDok8uugHzVY5yaaIHZxlJhl90Etmrh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a9xNvkL1rqVPeLgxjdaVjihCYNb/McJ7F7Y2gly2/Ny17tmM31KqKNZbRpkc9WLNAD1xCZNVZsfkfc80g+9LrvYnKMtpgA8A0GDy6Hmd/KWUKoKJ3AwltWLRvk8fnzZD4NnMUhpjkaRFdReRH9sP4eRaOtprilRHOthWgSjfRcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hE6QDA9v; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hE6QDA9v" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-bdbac72ac1fso1357370766b.3 for ; Wed, 27 May 2026 22:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946353; x=1780551153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JJKsTc6hq+ggH0YRoZKQwr0T1aAAX7cAjmxTIIxV7ck=; b=hE6QDA9v+jbzzjLzo20zCiZNUj13uICepUmoAwVflfku4xrCR+2MbdLS9NWJzDVIou wekwO7fo4IFxXlm3bR/Vi1onpa+8F8HCHfrNcPW/tko5+0W92Jl3d7jAcZtjEN+4s30R jVIc326SWa/Gh6aPlUulPdrgMfHiqQpUdZOWwCIRd766LglN2LGCxjkglZtJqE/eUhwc V44ZSDzhklgP92Ok5uqxK8jGQFOXvSPeNBpswipuGZAXv+fEbGnEtrJXgzv0wcr72/e+ X/Vl3SxTzdEb3JHtBqcqabKHyVBz/Yhwk8tqaxtv3fwd5o76XnriYYB4yFZH6Ugcf31b yyqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946353; x=1780551153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JJKsTc6hq+ggH0YRoZKQwr0T1aAAX7cAjmxTIIxV7ck=; b=SHt12aM/DJV8E3Ty+ZBCdGV8ZFRjdkbfOM3KMYJ/3ZspLOCLzFyLVNI2dJPEFw+eQo t9p3pIICUUrvWnie5L8fCugkWILfMyOcqbA8fHuDfzXCkdgIzsBiZAw4Et0A5H36GDON JTLu5TLWVGR6iFG/JyOe9Id2k9PeYwpq0pNXqA4+M4N88rn6KrU2LTnl/qE8SG7LsW2z VBgvxMdACXU9/wPnRgXJmCv1+y7HncGZPx8hO1IF1BxDUlVAyp3JVAF6QAzO8jVbL41I 51S90bJsKeY2XCd64/fUAflikb1oU06kkanJpQ0fmo5PY3MsF/rSIr9M3klC66dpOUTW d72Q== X-Forwarded-Encrypted: i=1; AFNElJ/YqfX4yj8iQpMcRRJBQ8mhRcUmfy08ZwrMfxLJ7j1giEtyT2RwTXwYyGZcvuQXEpTIXnQc0LsPoQFieTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyKtMvUA0L5lsTSEMpGuQRWuDN8Qu4grQRHfPu38xAwy+GsVW5j Ee6XqJaenbLnZFvicrdIWIARuXnesQn5aP0yRUqc3uzH7Es18nadEwxt X-Gm-Gg: Acq92OG9QqPj7ZJj2p+7PNAZMYT/2i1wcggr4nI4mGeMr3rp5WOagw+iMLWLCTo3j7s bOE1tRBhui82NXc0BqNCDW+E3GsYrIzvNBaOBX372EDe6304sj79LfGgMZDjaGY6qe9BOwstB3V tNQ8W+NAdEJECK7RpFZNsNE9NNfG2G2eM2zrYf0n4Z1IO7lUStW2scqKzoi4OFHn+b6s2sZ/4VO 3VVbQmlECqNt21gde8kvbiOx53j0fRyw/ro+3HiiLsvi9PZtmZv/M0b/Cw+iogvcYQADSOAG1VI UUR0LZwTYvQYeXhtXVCMh58DErd5gBXKGfoCkbrf4pmdKJwtd7HkVvbKyfRCwzdcOAjnXYaKwn6 FN/+Mkl1+QphxGDK0SMGEa/ntWYYixvmVNDsVdy2Zncs+WwA+xImLH+h07rBWGrTyglJajDMM+P 86n/Kr8OM/YW5YPe/Lu4xAhts= X-Received: by 2002:a17:907:d113:b0:bd8:f771:ea9a with SMTP id a640c23a62f3a-bdd264c895dmr1593311366b.41.1779946352946; Wed, 27 May 2026 22:32:32 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:32 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Date: Thu, 28 May 2026 08:31:59 +0300 Message-ID: <20260528053203.9339-4-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add input driver for ASUS Transformer dock keyboard and touchpad. Some keys in ASUS Dock report keycodes that don't make sense according to their position, this patch modifies the incoming data that is sent to serio to send proper scancodes. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/serio/Kconfig | 15 ++ drivers/input/serio/Makefile | 1 + drivers/input/serio/asus-transformer-ec-kbc.c | 158 ++++++++++++++++++ 3 files changed, 174 insertions(+) create mode 100644 drivers/input/serio/asus-transformer-ec-kbc.c diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index 5f15a6462056..fad29b950309 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -84,6 +84,21 @@ config SERIO_RPCKBD To compile this driver as a module, choose M here: the module will be called rpckbd. =20 +config SERIO_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Dock keyboard and touchpad controller" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use the keyboard and/or touchpad on + Asus Transformed's Mobile Dock. + + For keyboard support you also need atkbd driver. + + For touchpad support you also need psmouse driver with Elantech + touchpad option enabled. + + To compile this driver as a module, choose M here: the module will + be called asus-transformer-ec-kbc. + config SERIO_AMBAKMI tristate "AMBA KMI keyboard controller" depends on ARM_AMBA diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile index 8ab98f4aa28d..fedc37ee102b 100644 --- a/drivers/input/serio/Makefile +++ b/drivers/input/serio/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_SERIO_SERPORT) +=3D serport.o obj-$(CONFIG_SERIO_RPCKBD) +=3D rpckbd.o obj-$(CONFIG_SERIO_SA1111) +=3D sa1111ps2.o obj-$(CONFIG_SERIO_AMBAKMI) +=3D ambakmi.o +obj-$(CONFIG_SERIO_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-kbc.o obj-$(CONFIG_SERIO_Q40KBD) +=3D q40kbd.o obj-$(CONFIG_SERIO_GSCPS2) +=3D gscps2.o obj-$(CONFIG_HP_SDC) +=3D hp_sdc.o diff --git a/drivers/input/serio/asus-transformer-ec-kbc.c b/drivers/input/= serio/asus-transformer-ec-kbc.c new file mode 100644 index 000000000000..6f10b7f1baae --- /dev/null +++ b/drivers/input/serio/asus-transformer-ec-kbc.c @@ -0,0 +1,158 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_kbc_data { + struct notifier_block nb; + struct asusec_core *ec; + struct i2c_client *parent; + struct serio *sdev[2]; +}; + +static int asus_ec_kbc_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_kbc_data *priv =3D container_of(nb, struct asus_ec_kbc_dat= a, nb); + unsigned int port_idx, n; + u8 *data =3D data_; + + if (action & (ASUSEC_SMI_MASK | ASUSEC_SCI_MASK)) + return NOTIFY_DONE; + else if (action & ASUSEC_AUX_MASK) + port_idx =3D 1; + else if (action & (ASUSEC_KBC_MASK | ASUSEC_KEY_MASK)) + port_idx =3D 0; + else + return NOTIFY_DONE; + + /* + * The data[0] is the length of the packet including itself. The data[] + * buffer has to be at least 3 bytes (length + ctrl + 1 data byte) and + * must not exceed the EC buffer size. + */ + if (data[0] < 2 || data[0] > ASUSEC_ENTRY_BUFSIZE) + return NOTIFY_BAD; + + n =3D data[0] - 1; + data +=3D 2; + + if (port_idx =3D=3D 0) { + /* + * Remap keyboard key codes to match AT layout: + * SEARCH: RIGHT-META [E0 27] -> LEFT-ALT [11] + * MENU: COMPOSE [E0 2F] -> RIGHT-META [E0 27] + */ + if ((n =3D=3D 2 || (n =3D=3D 3 && data[1] =3D=3D 0xF0)) && data[0] =3D= =3D 0xE0) { + u8 *keycode =3D &data[n - 1]; + + switch (*keycode) { + case 0x27: + *keycode =3D 0x11; + ++data; + --n; + break; + case 0x2F: + *keycode =3D 0x27; + break; + } + } + } + + while (n--) + serio_interrupt(priv->sdev[port_idx], *data++, 0); + + return NOTIFY_OK; +} + +static int asus_ec_serio_write(struct serio *port, unsigned char data) +{ + struct asus_ec_kbc_data *priv =3D port->port_data; + + return i2c_smbus_write_word_data(priv->parent, ASUSEC_WRITE_BUF, + (data << 8) | port->id.extra); +} + +static void asus_ec_serio_remove(void *data) +{ + serio_unregister_port(data); +} + +static int asus_ec_register_serio(struct platform_device *pdev, int idx, + const char *name, int cmd) +{ + struct asus_ec_kbc_data *priv =3D platform_get_drvdata(pdev); + struct i2c_client *parent =3D priv->parent; + struct serio *port =3D kzalloc_obj(*port); + + if (!port) + return -ENOMEM; + + priv->sdev[idx] =3D port; + port->dev.parent =3D &pdev->dev; + port->id.type =3D SERIO_8042; + port->id.extra =3D cmd & 0xFF; + port->write =3D asus_ec_serio_write; + port->port_data =3D (void *)priv; + snprintf(port->name, sizeof(port->name), "%s %s", + priv->ec->model, name); + snprintf(port->phys, sizeof(port->phys), "i2c-%u-%04x/serio%d", + i2c_adapter_id(parent->adapter), parent->addr, idx); + + serio_register_port(port); + + return devm_add_action_or_reset(&pdev->dev, asus_ec_serio_remove, port); +} + +static int asus_ec_kbc_probe(struct platform_device *pdev) +{ + struct asusec_core *ec =3D dev_get_drvdata(pdev->dev.parent); + struct asus_ec_kbc_data *priv; + int error; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + priv->ec =3D ec; + priv->parent =3D to_i2c_client(pdev->dev.parent); + + error =3D asus_ec_register_serio(pdev, 0, "Keyboard", 0); + if (error) + return error; + + error =3D asus_ec_register_serio(pdev, 1, "Touchpad", I8042_CMD_AUX_SEND); + if (error) + return error; + + priv->nb.notifier_call =3D asus_ec_kbc_notify; + + return blocking_notifier_chain_register(&ec->notify_list, &priv->nb); +} + +static void asus_ec_kbc_remove(struct platform_device *pdev) +{ + struct asus_ec_kbc_data *priv =3D platform_get_drvdata(pdev); + struct asusec_core *ec =3D priv->ec; + + blocking_notifier_chain_unregister(&ec->notify_list, &priv->nb); +} + +static struct platform_driver asus_ec_kbc_driver =3D { + .driver.name =3D "asus-transformer-ec-kbc", + .probe =3D asus_ec_kbc_probe, + .remove =3D asus_ec_kbc_remove, +}; +module_platform_driver(asus_ec_kbc_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-kbc"); +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's Dock keyboard and touchpad driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66802319847 for ; Thu, 28 May 2026 05:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946359; cv=none; b=Pa5pwpxM2QbEjtffWWHw/Utr2mHqW1G+7IudRGcBQc7Bvr4rbSMzRQmMXcn9M/nNaqKL8QYwelUdV6tySUbFH/GVpbpOjil9BSgCOOExDVOJlOIxD9icHWTJFbIHCOHb39XP0mQh21MiaGucws7C12z4eU2n4hmHgUx1UfvIHQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946359; c=relaxed/simple; bh=V9K5YRxjQ7revTeyfXMEW++zDS+PxHSdOgZ9EDk8vGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dqVqR5zzDhjS8h9NEOiGDjN/rlbNJLzILub3ZNGumEf5LMH1kNSa4LT+UdTGbd88sYNOb8tOvusSji4N2i4MGEX00qyWor207NMC276BaVbtTqn/yZ4qudWVOYkgaWYeBk1rJ6RWxwdv4vM7s1EUvfw1jvE6YJnEe6I8k6Y8cmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qOF1tGX2; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qOF1tGX2" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-bd22b2abaa4so1973028166b.0 for ; Wed, 27 May 2026 22:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946356; x=1780551156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1utQQ3PbeR0Q0s8gXOi9tsH4hbwGLO7eHRtqx4+b1nI=; b=qOF1tGX2oFXSRNGNfjVorOoNvaR6M9K2+x0ZpxLWHBDktBYtRVD1sdJiamQDB+xhal OSgvN4xHLwamXru7ZGzqSlgXOP48QkZreS1zaVwsEgav8apYh18M051Lc1aA9UOtuFJq Jzk4lZwxk0rENxUcIvgDYqokevvsqG9aTVwXToBapcbpnV/0m8CXUv7xeqbvguylftSV VRoFKtoZuEfP+H4SGKYoz1TSgt+psUN+v2Fs+bpvOsrEXOyaTcVJnzhC/McjEsjb3FiH 5pQLhHk5y9c8bOZFuZp10Vq3gOFoizOwnMlV5OW/bGLkzxDr4ZnfcDJxQkXrNkkA/nvh TDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946356; x=1780551156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1utQQ3PbeR0Q0s8gXOi9tsH4hbwGLO7eHRtqx4+b1nI=; b=Z0Dvp/lftpXtJBSd7vYFLz3bTCY9SmNSMHGw2OpG5vZl34bbOG+TZSezrBQVXHdqnY +F4zWCzTupUrfi19tNU/85Kkn099JMqpNV1j4tpqcWibJHsuriMj6+4cxtdMRKg0Iu7K mVUpyEn2KkQqHWcYHihuFsd8mtQus+bWbK5w5YeDTJzTnP6Lr7/Rowa++HMh6EBcTMJP +0uhD7sHqmuYmXEX9Fb2v7LJ4oW1HQaDSri8fgDJfSnZMWe3l4TLj4d2EY8rkfe/D8BI M6JI/XwNiVqF4jvlSjQZg2L5sShFkI1wS4eNTo1+BZcih13ny3WDkfB4LfaNGNZIUr/d 2rUQ== X-Forwarded-Encrypted: i=1; AFNElJ8/9WOqBUyigi/w7ZlLcjHUxJcYcIGuX2eIzdkxcNqwixuvkZcPcJ5sFofvM3q+0MmeOCDYIEWJW4FVh9w=@vger.kernel.org X-Gm-Message-State: AOJu0YyIvsjM6tH9ogEfBuVbN3XbrG7+7ReVYSv76WFtmCP1HoM9QZTw OhDwi4rXKv+CZc8nE57/D+orJGzCvn59PK6s0Rfax4OZzPZk7jhGZX+U X-Gm-Gg: Acq92OHhM2dKG66xjamtVjinp6gN9ym/+2B9qXtxZKEhxAATbVsMwNkhLsOEJKWXsb3 7/mO7CDNiv0MBYdsgD+m8RF5e21v02CK8XC+MX00vXjGx3eNj/B3GFsnRxgHC4dWJiKJt1WUQyS 1sgqR2fNt0oOGT5SJ+omcmL1oW3xKRI8hOsFSMm/eUrJTfO2DE4phjtsEkIOUFxXufXyfgkUBMp XO6sl06/TxX79S8bQogExKdv6xMzOSY7bNXtfscI1vM1Kk/vxrhkNWvr2LyqJgqwDhcOUTG0vqw 0tnzf8nuKtaFoFX5aGTG+ToyVIZnW8VP7kFV3uz8gz3kqs3Y/ugoIbDLeIs6SiOkrJ/sulWPD7h OJT8641IZiRJ7Vgr1Ruy2bDgBWOmruSsgXSvQZYznAwrAN3z1qhArCf5wW2CRF8OiLmhrnsF8Cs Lajkd7jTiWruAnTfrphHcvF6M= X-Received: by 2002:a17:907:3e87:b0:be2:36d7:573b with SMTP id a640c23a62f3a-be236d757b1mr781282166b.12.1779946355535; Wed, 27 May 2026 22:32:35 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:34 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Date: Thu, 28 May 2026 08:32:00 +0300 Message-ID: <20260528053203.9339-5-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for multimedia top button row of ASUS Transformer's Mobile Dock keyboard. Driver is made that function keys (F1-F12) are used by default which suits average Linux use better and with pressing ScreenLock + AltGr function keys layout is switched to multimedia keys. Since this only modifies codes sent by asus-ec-keys it doesn't affect normal keyboards at all. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + .../input/keyboard/asus-transformer-ec-keys.c | 286 ++++++++++++++++++ 3 files changed, 297 insertions(+) create mode 100644 drivers/input/keyboard/asus-transformer-ec-keys.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 9d1019ba0245..913cb4900565 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -89,6 +89,16 @@ config KEYBOARD_APPLESPI To compile this driver as a module, choose M here: the module will be called applespi. =20 +config KEYBOARD_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Mobile Dock multimedia keys" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use multimedia keys present on Asus + Transformer's Mobile Dock. + + To compile this driver as a module, choose M here: the + module will be called asus-transformer-ec-keys. + config KEYBOARD_ATARI tristate "Atari keyboard" depends on ATARI diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makef= ile index 60bb7baf802f..0d81096887ad 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ADP5585) +=3D adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) +=3D adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) +=3D amikbd.o obj-$(CONFIG_KEYBOARD_APPLESPI) +=3D applespi.o +obj-$(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-keys.o obj-$(CONFIG_KEYBOARD_ATARI) +=3D atakbd.o obj-$(CONFIG_KEYBOARD_ATKBD) +=3D atkbd.o obj-$(CONFIG_KEYBOARD_BCM) +=3D bcm-keypad.o diff --git a/drivers/input/keyboard/asus-transformer-ec-keys.c b/drivers/in= put/keyboard/asus-transformer-ec-keys.c new file mode 100644 index 000000000000..bf6db002a853 --- /dev/null +++ b/drivers/input/keyboard/asus-transformer-ec-keys.c @@ -0,0 +1,286 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_EXT_KEY_CODES 0x20 + +struct asus_ec_keys_data { + struct notifier_block nb; + struct asusec_core *ec; + struct input_dev *xidev; + struct input_handler input_handler; + bool special_key_pressed; + bool special_key_mode; + unsigned short keymap[ASUSEC_EXT_KEY_CODES * 2]; +}; + +static void asus_ec_input_event(struct input_handle *handle, + unsigned int event_type, + unsigned int event_code, int value) +{ + struct asus_ec_keys_data *priv =3D handle->handler->private; + + /* Store special key state */ + if (event_type =3D=3D EV_KEY && event_code =3D=3D KEY_RIGHTALT) + priv->special_key_pressed =3D !!value; +} + +static int asus_ec_input_connect(struct input_handler *handler, + struct input_dev *dev, + const struct input_device_id *id) +{ + struct input_handle *handle; + int error; + + handle =3D kzalloc_obj(*handle); + if (!handle) + return -ENOMEM; + + handle->dev =3D dev; + handle->handler =3D handler; + handle->name =3D handler->name; + + error =3D input_register_handle(handle); + if (error) + goto err_free_handle; + + error =3D input_open_device(handle); + if (error) + goto err_unregister_handle; + + return 0; + + err_unregister_handle: + input_unregister_handle(handle); + err_free_handle: + kfree(handle); + + return error; +} + +static void asus_ec_input_disconnect(struct input_handle *handle) +{ + input_close_device(handle); + input_unregister_handle(handle); + kfree(handle); +} + +static const struct input_device_id asus_ec_input_ids[] =3D { + { + .flags =3D INPUT_DEVICE_ID_MATCH_EVBIT, + .evbit =3D { BIT_MASK(EV_KEY) }, + }, + { } +}; + +static const unsigned short asus_ec_dock_ext_keys[] =3D { + /* Function keys [0x00 - 0x19] */ + [0x01] =3D KEY_DELETE, + [0x02] =3D KEY_F1, + [0x03] =3D KEY_F2, + [0x04] =3D KEY_F3, + [0x05] =3D KEY_F4, + [0x06] =3D KEY_F5, + [0x07] =3D KEY_F6, + [0x08] =3D KEY_F7, + [0x10] =3D KEY_F8, + [0x11] =3D KEY_F9, + [0x12] =3D KEY_F10, + [0x13] =3D KEY_F11, + [0x14] =3D KEY_F12, + [0x15] =3D KEY_MUTE, + [0x16] =3D KEY_VOLUMEDOWN, + [0x17] =3D KEY_VOLUMEUP, + /* Multimedia keys [0x20 - 0x39] */ + [0x21] =3D KEY_SCREENLOCK, + [0x22] =3D KEY_WLAN, + [0x23] =3D KEY_BLUETOOTH, + [0x24] =3D KEY_TOUCHPAD_TOGGLE, + [0x25] =3D KEY_BRIGHTNESSDOWN, + [0x26] =3D KEY_BRIGHTNESSUP, + [0x27] =3D KEY_BRIGHTNESS_AUTO, + [0x28] =3D KEY_PRINT, + [0x30] =3D KEY_WWW, + [0x31] =3D KEY_CONFIG, + [0x32] =3D KEY_PREVIOUSSONG, + [0x33] =3D KEY_PLAYPAUSE, + [0x34] =3D KEY_NEXTSONG, + [0x35] =3D KEY_MUTE, + [0x36] =3D KEY_VOLUMEDOWN, + [0x37] =3D KEY_VOLUMEUP, +}; + +static void asus_ec_keys_report_key(struct input_dev *dev, unsigned int co= de, + unsigned int key, bool value) +{ + input_event(dev, EV_MSC, MSC_SCAN, code); + input_report_key(dev, key, value); + input_sync(dev); +} + +static int asus_ec_keys_process_key(struct input_dev *dev, u8 code) +{ + struct asus_ec_keys_data *priv =3D dev_get_drvdata(dev->dev.parent); + unsigned int key =3D 0; + + if (code =3D=3D 0) + return NOTIFY_DONE; + + /* Flip special key mode state when pressing SCREEN LOCK + R ALT */ + if (priv->special_key_pressed && code =3D=3D 1) { + priv->special_key_mode =3D !priv->special_key_mode; + return NOTIFY_DONE; + } + + /* + * Relocate code to second "page" if pressed state XOR's mode state + * This way special key will invert the current mode + */ + if (priv->special_key_mode ^ priv->special_key_pressed) + code +=3D ASUSEC_EXT_KEY_CODES; + + if (code < dev->keycodemax) { + unsigned short *map =3D dev->keycode; + + key =3D map[code]; + } + + if (!key) + key =3D KEY_UNKNOWN; + + asus_ec_keys_report_key(dev, code, key, 1); + asus_ec_keys_report_key(dev, code, key, 0); + + return NOTIFY_OK; +} + +static int asus_ec_keys_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_keys_data *priv =3D + container_of(nb, struct asus_ec_keys_data, nb); + u8 *data =3D data_; + + if (action & ASUSEC_SMI_MASK) + return NOTIFY_DONE; + + if (action & ASUSEC_SCI_MASK) + return asus_ec_keys_process_key(priv->xidev, data[2]); + + return NOTIFY_DONE; +} + +static void asus_ec_keys_setup_keymap(struct asus_ec_keys_data *priv) +{ + struct input_dev *dev =3D priv->xidev; + unsigned int i; + + BUILD_BUG_ON(ARRAY_SIZE(priv->keymap) < ARRAY_SIZE(asus_ec_dock_ext_keys)= ); + + dev->keycode =3D priv->keymap; + dev->keycodesize =3D sizeof(*priv->keymap); + dev->keycodemax =3D ARRAY_SIZE(priv->keymap); + + input_set_capability(dev, EV_MSC, MSC_SCAN); + input_set_capability(dev, EV_KEY, KEY_UNKNOWN); + + for (i =3D 0; i < ARRAY_SIZE(asus_ec_dock_ext_keys); i++) { + unsigned int code =3D asus_ec_dock_ext_keys[i]; + + if (!code) + continue; + + __set_bit(code, dev->keybit); + priv->keymap[i] =3D code; + } +} + +static int asus_ec_keys_probe(struct platform_device *pdev) +{ + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct asusec_core *ec =3D dev_get_drvdata(pdev->dev.parent); + struct device *dev =3D &pdev->dev; + struct asus_ec_keys_data *priv; + int error; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + priv->xidev =3D devm_input_allocate_device(dev); + if (!priv->xidev) + return -ENOMEM; + + priv->xidev->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s Keyboard Ext", + ec->model); + priv->xidev->phys =3D devm_kasprintf(dev, GFP_KERNEL, "i2c-%u-%04x", + i2c_adapter_id(parent->adapter), + parent->addr); + + if (!priv->xidev->name || !priv->xidev->phys) + return -ENOMEM; + + asus_ec_keys_setup_keymap(priv); + + error =3D input_register_device(priv->xidev); + if (error) + return dev_err_probe(dev, error, + "failed to register extension keys\n"); + + priv->input_handler.event =3D asus_ec_input_event; + priv->input_handler.connect =3D asus_ec_input_connect; + priv->input_handler.disconnect =3D asus_ec_input_disconnect; + priv->input_handler.id_table =3D asus_ec_input_ids; + priv->input_handler.passive_observer =3D true; + priv->input_handler.private =3D priv; + priv->input_handler.name =3D devm_kasprintf(dev, GFP_KERNEL, + "%s-media-handler", + ec->name); + if (!priv->input_handler.name) + return -ENOMEM; + + error =3D input_register_handler(&priv->input_handler); + if (error) + return error; + + priv->nb.notifier_call =3D asus_ec_keys_notify; + + error =3D blocking_notifier_chain_register(&ec->notify_list, &priv->nb); + if (error) { + input_unregister_handler(&priv->input_handler); + return error; + } + + return 0; +} + +static void asus_ec_keys_remove(struct platform_device *pdev) +{ + struct asus_ec_keys_data *priv =3D platform_get_drvdata(pdev); + struct asusec_core *ec =3D priv->ec; + + input_unregister_handler(&priv->input_handler); + blocking_notifier_chain_unregister(&ec->notify_list, &priv->nb); +} + +static struct platform_driver asus_ec_keys_driver =3D { + .driver.name =3D "asus-transformer-ec-keys", + .probe =3D asus_ec_keys_probe, + .remove =3D asus_ec_keys_remove, +}; +module_platform_driver(asus_ec_keys_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-keys"); +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's multimedia keys driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D50D329E79 for ; Thu, 28 May 2026 05:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946361; cv=none; b=eD5gux82+fXtsXhJcylhAJgCNgzBBHoC5im1gqTcU6UO0AQvclgwhIBJzOKa2WzY8fTYh4mjnqZdCY787VeD6UCP7jOB06q2byYpV5l3HigMt2O12PVoukfsuYdhMOUPBJHbpqgs4P3qgM9AlRSMhwHrJNav6u6g4arw/7m3UgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946361; c=relaxed/simple; bh=N5Bs7jrwAWana/GHhO8hVdgu7yjQxJ+wg3hxQlL/s2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ct0diJ0BEbWJdKDff5Rqz1saD/9Mw+UZ6jW+iZVvuRn4hcbDqpNG+syWTFStNCGVHZ4oZvjeH1tx1BLN5esW4DDR/EYotGJB2R6XqCzKyKT32hLBb+i/QkISsS1fM7GnNQw4hWDT/54PHA4SCS5qXnj8hhDJPIA/sVLkVojUcrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p/XYnQ30; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p/XYnQ30" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-bd8f9889a8cso1489608666b.1 for ; Wed, 27 May 2026 22:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946357; x=1780551157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EMAGW8nfdxjsjGAkIOyueBisELm9uNOe9lSbirQK6Uo=; b=p/XYnQ30t8cvETQscMSjPNzWUPNxTBZEfFsXm+pU9eomeQFolL+dmcGB2v7RFcrKvw DOqPKyzC0CBZt9iuNnGQsqg0CA5JnrcM/pDYplOdxzCEK0nsaCiBy2/x9p/fLH/MS7kV naltG+62DSf4JCNILrprTQpPT9wGmCXvpJAAdkcSA3Af17XF0NWkA2XBamgKpMP9Ybe1 c/IcajJ9TbbCA4jcsJ9qE2TO2cV4nqdN230RXBtBnwVrr3OTpB4LtHFpzmIg2o9u0RY3 AE9hl0B7x46PCJOCp9yjmdl5PEN2yhiSYwLxgFQ2FjqNyzbMspc2MYtrXnnvu0Afo+Gh Y9og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946357; x=1780551157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EMAGW8nfdxjsjGAkIOyueBisELm9uNOe9lSbirQK6Uo=; b=ZlNfgA1hB7IEe0i2zBS4DU9J7rZdASsGa671G2cVGiUtwcBh0hB+Da1XbBtPmqUG1Z 08+y9/OFQHK8TnLxzzOaqLPxFsvvw7/CdXo63Utjuo91KIidGxW3acLmI+neUXIknhYz LD1zLtYksVAwbvIhKuhkyxCwzp17lEJf3s3pIZWKtKNgsSD+wlQToJYP7qyBhWC2HuIz XEqKUXF+QdGzanptm+R9cOx4SNTCQRU5BJ88HWRTSkAN+zuoRF6vbw/Hns7iVEQZoe+O UbgEds/Jl+GSAlnvOTKQRpTRd0u2zKNz9yyQZooZ7LCGkb/RAghz86+HQbzsfcQGjml8 V4gg== X-Forwarded-Encrypted: i=1; AFNElJ/xO7xw3/YZVOcrWLtQpQN0a4y4j/YX/hrJ/iVS79uSAE+jsIq0LNzvrnSoV7NVZ0nSzn5y/31x1aJb8n4=@vger.kernel.org X-Gm-Message-State: AOJu0YxLz97c8OqzApv63ueo+9vMJ2moV/3WCRDTzYSVfEnO89Dx2mx9 9dttgYbfwJBZY8oTh6HcpHiJu04lAAMC9HVOVcmR5VkkyGdM7VJIo3SH X-Gm-Gg: Acq92OFrxT0A104D/1JZZPPD/0XlASrY4gCjjffpuBMiYKGcoafnT7zARMxQlbDDDbh rFbFwieN57pebtfOBlzgRsfzE7dnFnYuTIfhj8lK9+Mfir7qKFHlHpme3uz7urTYPUCutIhoydN pwa2q0p8sQKYDC9BVAqimWZI/P7N3RDkYvavLSnZcavflH1QJ3uin+zzVfY5kT7M2ySwo+jC5H4 YzLUnC9YPaJ/UkruKAaXQXpZZ43Rxx3+ymbXWw7RYngM6V0QBMHqiC4eKwBIhNPdwcrTnqNEeTI Ilqu5c40Bj5hm6/tCCwMI245ejBheoQ17j4t85kTLwMfug0QAV4IdtedOfl8LOmNhd9HfkYYGrO 0dv94yO6+w9Zj3/2KkayBEB1iXN0lav4AEf69R7j/5vIUQSmir+/RS0MFzyEMcRUrqJc4FMOVC/ /MCU9zpOfWNakJzMmXoABmBcp6Xss3MyvYVg== X-Received: by 2002:a17:907:60cb:b0:bda:e47:70c6 with SMTP id a640c23a62f3a-bdd22944feamr1637047666b.1.1779946357072; Wed, 27 May 2026 22:32:37 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:36 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 5/7] leds: Add driver for ASUS Transformer LEDs Date: Thu, 28 May 2026 08:32:01 +0300 Message-ID: <20260528053203.9339-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw ASUS Transformer tablets have a green and an amber LED on both the Pad and the Dock. If both LEDs are enabled simultaneously, the emitted light will be yellow. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/leds/Kconfig | 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-asus-transformer-ec.c | 125 ++++++++++++++++++++++++ 3 files changed, 137 insertions(+) create mode 100644 drivers/leds/leds-asus-transformer-ec.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index f4a0a3c8c870..f637d23400a8 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -120,6 +120,17 @@ config LEDS_OSRAM_AMS_AS3668 To compile this driver as a module, choose M here: the module will be called leds-as3668. =20 +config LEDS_ASUS_TRANSFORMER_EC + tristate "LED Support for Asus Transformer charging LED" + depends on LEDS_CLASS + depends on MFD_ASUS_TRANSFORMER_EC + help + This option enables support for charging indicator on + Asus Transformer's Pad and it's Dock. + + To compile this driver as a module, choose M here: the module + will be called leds-asus-transformer-ec. + config LEDS_AW200XX tristate "LED support for Awinic AW20036/AW20054/AW20072/AW20108" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 8fdb45d5b439..d5395c3f1124 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_LEDS_AN30259A) +=3D leds-an30259a.o obj-$(CONFIG_LEDS_APU) +=3D leds-apu.o obj-$(CONFIG_LEDS_ARIEL) +=3D leds-ariel.o obj-$(CONFIG_LEDS_AS3668) +=3D leds-as3668.o +obj-$(CONFIG_LEDS_ASUS_TRANSFORMER_EC) +=3D leds-asus-transformer-ec.o obj-$(CONFIG_LEDS_AW200XX) +=3D leds-aw200xx.o obj-$(CONFIG_LEDS_AW2013) +=3D leds-aw2013.o obj-$(CONFIG_LEDS_BCM6328) +=3D leds-bcm6328.o diff --git a/drivers/leds/leds-asus-transformer-ec.c b/drivers/leds/leds-as= us-transformer-ec.c new file mode 100644 index 000000000000..09503e76331c --- /dev/null +++ b/drivers/leds/leds-asus-transformer-ec.c @@ -0,0 +1,125 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include + +enum { + ASUSEC_LED_AMBER, + ASUSEC_LED_GREEN, + ASUSEC_LED_MAX +}; + +struct asus_ec_led_config { + const char *name; + unsigned int color; + unsigned long long ctrl_bit; +}; + +struct asus_ec_led { + struct asus_ec_leds_data *ddata; + struct led_classdev cdev; + unsigned long long ctrl_bit; +}; + +struct asus_ec_leds_data { + const struct asusec_core *ec; + struct asus_ec_led leds[ASUSEC_LED_MAX]; +}; + +static const struct asus_ec_led_config asus_ec_leds[] =3D { + [ASUSEC_LED_AMBER] =3D { + .name =3D "amber", + .color =3D LED_COLOR_ID_AMBER, + .ctrl_bit =3D ASUSEC_CTL_LED_AMBER, + }, + [ASUSEC_LED_GREEN] =3D { + .name =3D "green", + .color =3D LED_COLOR_ID_GREEN, + .ctrl_bit =3D ASUSEC_CTL_LED_GREEN, + }, +}; + +static enum led_brightness asus_ec_led_get_brightness(struct led_classdev = *cdev) +{ + struct asus_ec_led *led =3D container_of(cdev, struct asus_ec_led, cdev); + const struct asusec_core *ec =3D led->ddata->ec; + u64 ctl; + int ret; + + ret =3D asus_dockram_access_ctl(ec->dockram, &ctl, 0, 0); + if (ret) + return LED_OFF; + + return ctl & led->ctrl_bit ? LED_ON : LED_OFF; +} + +static int asus_ec_led_set_brightness(struct led_classdev *cdev, + enum led_brightness brightness) +{ + struct asus_ec_led *led =3D container_of(cdev, struct asus_ec_led, cdev); + const struct asusec_core *ec =3D led->ddata->ec; + + if (brightness) + return asus_dockram_access_ctl(ec->dockram, NULL, + led->ctrl_bit, led->ctrl_bit); + + return asus_dockram_access_ctl(ec->dockram, NULL, led->ctrl_bit, 0); +} + +static int asus_ec_led_probe(struct platform_device *pdev) +{ + const struct asusec_core *ec =3D dev_get_drvdata(pdev->dev.parent); + struct asus_ec_leds_data *ddata; + struct device *dev =3D &pdev->dev; + int i, ret; + + ddata =3D devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + platform_set_drvdata(pdev, ddata); + ddata->ec =3D ec; + + for (i =3D 0; i < ASUSEC_LED_MAX; i++) { + const struct asus_ec_led_config *cfg =3D &asus_ec_leds[i]; + struct asus_ec_led *led =3D &ddata->leds[i]; + + led->cdev.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s::%s", + ddata->ec->name, cfg->name); + if (!led->cdev.name) + return -ENOMEM; + + led->cdev.max_brightness =3D 1; + led->cdev.color =3D cfg->color; + led->cdev.flags =3D LED_CORE_SUSPENDRESUME | LED_RETAIN_AT_SHUTDOWN; + led->cdev.brightness_get =3D asus_ec_led_get_brightness; + led->cdev.brightness_set_blocking =3D asus_ec_led_set_brightness; + + led->ddata =3D ddata; + led->ctrl_bit =3D cfg->ctrl_bit; + + ret =3D devm_led_classdev_register(dev, &led->cdev); + if (ret) + return dev_err_probe(dev, ret, + "failed to register %s LED\n", + cfg->name); + } + + return 0; +} + +static struct platform_driver asus_ec_led_driver =3D { + .driver.name =3D "asus-transformer-ec-led", + .probe =3D asus_ec_led_probe, +}; +module_platform_driver(asus_ec_led_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-led"); +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's charging LED driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B96232B11E for ; Thu, 28 May 2026 05:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946363; cv=none; b=rbZDgDObaTY/CNP5HnB2FouhwIVovQlAyIVPZoOb6wWIm9grKmqNFteQiVzUIDpLE598VeLO2x3Sn92Va1XYdIkMd6aQmYKxpeQ/vBXUAEETZQ4w4xPTKRuPgWfo2Ig4L1O9fwdT9wvuvqfSCyffw/Qqh5DL7Nbm8rzKBhjferg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946363; c=relaxed/simple; bh=FCPhbsAMyJyYImp7zXGL6cmwqGbP0SQR2MuPEoI7Hwc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PhxdrAaEnRhGaRfK2fbywNQqhFp/qNXdc+aRDNoT2jw2+Q7QwYXfz06cOz+AKpU3QRqDtltxout3VHEOE2bxzwF5GWmDKLiodTQYBrcYuseGqV8Z2yQtJDoaHeUc83100vUMY8iKeFu8QwYM3YqRlquL3u5nwIapBSr9/rvzmkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R7P150FH; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R7P150FH" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-bd8d0e4e341so1778853966b.0 for ; Wed, 27 May 2026 22:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946359; x=1780551159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T8QEc08A6CmRP52KGvrh5FaqE/RdFYGEh4SppUK/ed8=; b=R7P150FH9+1+53l3FfccM5foV1pXAmdaLnK0Z6fpRQkepR5ZP8KMWhgw5B0CH082cO 7swghd5j1F3teSPP9hVO18chl2dys/+lyIZNr3PYiWxADH5fXhtchiHt1aiAow57qv39 6x37axxFTEmSjYXwphh+MXJ14gkC1F7EfN1bdvr1l4NCZx6pzGyXasYFZaNuAv3TC7Dn LP6VH/RWwpNtaCu1l3VTs/VYzDba9biT93iEu9Lj08Bm1n16ZqN4UkXeWBcsc1fK57YB 0w577kYhtvVOp1Y0XpnvRpxOHVrDnSusAgxu27BGDxqR8OhKlD97hYOxOvTaLqsyN+Gj QiPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946359; x=1780551159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T8QEc08A6CmRP52KGvrh5FaqE/RdFYGEh4SppUK/ed8=; b=cg8n3h3ZxrIbp9aoHhCaEo05QWrpWp+m6cnbMO3R05jG3LVKK0wwxDjmV8GG9jGbjc xaubTL3xXqWG+A9etacgL+5sOQfaXJHMGC1vhnOyAjwZDHu1MQZEtlahOENhoU1D/AR6 TKA6SZLYq1aB2aTOvJPD+o6jVBmIVX9iu7POi5sIvb9GiVCB3jzwP7TnRnJVBXbBPbQ3 QiyeOf8iEqVeFdhpPnogXShCLoywBEqvyrSZmUA08Wv4kDlyDTCrt7iWaT68AiGwDPHm tfp7YwIpYC9NLWY+6iaxSP+amtEZKBTp0J7W72y5dDyehASyegeGozZAsufzmvNx/Q8I oIfA== X-Forwarded-Encrypted: i=1; AFNElJ8YpAEFc2aO4GSqsHmvjIijK0N2LgLEbJOaxU3KHV48hJxhoA/siWIBQbJGmsBjx74BRJbZ67slasNxi7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxJuyMRsHu8p9nZqwIlmb+uO6PzBZyw4WrTl78vhx9KM+1vmYjY BDlTCuAdVcKH+7nlXZgDZpM0PnZixgIgwOWV6SruXk3G3Ae6exweuFuf X-Gm-Gg: Acq92OGSKG7VM6VKPchTYHza21mDZNky/AFOmuYxGSgshXua+vNctc7+0pR2LEAptdE HkUgn/wNG66TK2+NPaNtq4waa4E95cT3PQKtYtnmAA/Qo4yc/PcnTt68RWKT3HfB/g8RwPmPoQT MkgqaRUv19//vyADqcIIEy0iIyYr+s/26u0sb3zGtflo3utLfj6T1AlbS26NqKDEjsRa8FpSVkH +aFEzL/rO76bOW36uO0MlSMTrl+9Pcm0a5fdtdOqFBDRlXfm2AJJUmo0hNFxa1Y6JVRpt4BUekn r2Dwf8SoKGGQONy5VuGiZfyNQr4ZYnq/108p6CnyBV6Al0TqcKaozccMYdIqrMu3Ec6QDhRVdh9 z6bJeOE81jqcNXJfl9JUkGEPdHqhme5KFxPKP1T0PuJ3lWQb3HDqgA3F1yPQ48LTcZgkgQYWE2l Vg2oZDmQtm10Ry8jTJedy3Wlg= X-Received: by 2002:a17:907:3e23:b0:bd0:8e74:85a3 with SMTP id a640c23a62f3a-bdd25ce8df4mr1736671366b.26.1779946358615; Wed, 27 May 2026 22:32:38 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:38 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 6/7] power: supply: Add driver for ASUS Transformer battery Date: Thu, 28 May 2026 08:32:02 +0300 Message-ID: <20260528053203.9339-7-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Driver implements one battery cell per EC controller and supports reading of battery status for ASUS Transformer's pad and mobile dock. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-battery.c | 289 ++++++++++++++++++ 3 files changed, 301 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-battery.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 83392ed6a8da..1dc3d0b2e021 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -122,6 +122,17 @@ config BATTERY_CHAGALL This driver can also be built as a module. If so, the module will be called chagall-battery. =20 +config BATTERY_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's battery driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y to enable support for battery status access on Tegra based + ASUS Transformer devices. + + This sub-driver supports battery cells found in Asus Transformer + tablets and mobile docks and controlled by a special embedded + controller. + config BATTERY_CPCAP tristate "Motorola CPCAP PMIC battery driver" depends on MFD_CPCAP && IIO diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 7ee839dca7f3..1313f367715c 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TEST_POWER) +=3D test_power.o obj-$(CONFIG_BATTERY_88PM860X) +=3D 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) +=3D adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) +=3D act8945a_charger.o +obj-$(CONFIG_BATTERY_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-battery= .o obj-$(CONFIG_BATTERY_AXP20X) +=3D axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) +=3D axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) +=3D chagall-battery.o diff --git a/drivers/power/supply/asus-transformer-ec-battery.c b/drivers/p= ower/supply/asus-transformer-ec-battery.c new file mode 100644 index 000000000000..db6331352f7d --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-battery.c @@ -0,0 +1,289 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_BATTERY_DATA_FRESH_MSEC 5000 + +#define ASUSEC_BATTERY_DISCHARGING BIT(6) +#define ASUSEC_BATTERY_FULL_CHARGED BIT(5) +#define ASUSEC_BATTERY_NOT_CHARGING BIT(4) + +#define TEMP_CELSIUS_OFFSET 2731 + +struct asus_ec_battery_data { + struct asusec_core *ec; + struct power_supply *battery; + struct power_supply_desc psy_desc; + struct delayed_work poll_work; + struct mutex battery_lock; /* for data refresh */ + unsigned long batt_data_ts; + int last_state; + u8 batt_data[ASUSEC_ENTRY_BUFSIZE]; +}; + +static int asus_ec_battery_refresh(struct asus_ec_battery_data *priv) +{ + struct i2c_client *client =3D priv->ec->dockram; + struct device *dev =3D &client->dev; + int ret =3D 0; + + if (time_before(jiffies, priv->batt_data_ts)) + return ret; + + memset(priv->batt_data, 0, ASUSEC_ENTRY_BUFSIZE); + ret =3D i2c_smbus_read_i2c_block_data(client, ASUSEC_DOCKRAM_BATT_CTL, + ASUSEC_ENTRY_SIZE, priv->batt_data); + if (ret < ASUSEC_ENTRY_SIZE) + return ret; + + if (priv->batt_data[0] > ASUSEC_ENTRY_SIZE) { + dev_err(dev, "bad data len; buffer: %*ph; ret: %d\n", + ASUSEC_ENTRY_BUFSIZE, priv->batt_data, ret); + return -EPROTO; + } + + priv->batt_data_ts =3D jiffies + + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC); + + return ret; +} + +static enum power_supply_property asus_ec_battery_properties[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_MAX, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, + POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const unsigned int asus_ec_battery_prop_offs[] =3D { + [POWER_SUPPLY_PROP_STATUS] =3D 1, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] =3D 3, + [POWER_SUPPLY_PROP_CURRENT_MAX] =3D 5, + [POWER_SUPPLY_PROP_TEMP] =3D 7, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] =3D 9, + [POWER_SUPPLY_PROP_CURRENT_NOW] =3D 11, + [POWER_SUPPLY_PROP_CAPACITY] =3D 13, + [POWER_SUPPLY_PROP_CHARGE_NOW] =3D 15, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW] =3D 17, + [POWER_SUPPLY_PROP_TIME_TO_FULL_NOW] =3D 19, +}; + +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv, + enum power_supply_property psp) +{ + int ret, offs; + + guard(mutex)(&priv->battery_lock); + + if (psp >=3D ARRAY_SIZE(asus_ec_battery_prop_offs)) + return -EINVAL; + + offs =3D asus_ec_battery_prop_offs[psp]; + if (!offs) + return -EINVAL; + + ret =3D asus_ec_battery_refresh(priv); + if (ret < 0) + return ret; + + if (offs >=3D priv->batt_data[0]) + return -ENODATA; + + return get_unaligned_le16(priv->batt_data + offs); +} + +static int asus_ec_battery_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_battery_data *priv =3D power_supply_get_drvdata(psy); + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + + default: + ret =3D asus_ec_battery_get_value(priv, psp); + if (ret < 0) + return ret; + + val->intval =3D (s16)ret; + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (ret & ASUSEC_BATTERY_FULL_CHARGED) + val->intval =3D POWER_SUPPLY_STATUS_FULL; + else if (ret & ASUSEC_BATTERY_NOT_CHARGING) + val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (ret & ASUSEC_BATTERY_DISCHARGING) + val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval =3D POWER_SUPPLY_STATUS_CHARGING; + break; + + case POWER_SUPPLY_PROP_TEMP: + val->intval -=3D TEMP_CELSIUS_OFFSET; + break; + + case POWER_SUPPLY_PROP_CHARGE_NOW: + case POWER_SUPPLY_PROP_CURRENT_NOW: + case POWER_SUPPLY_PROP_CURRENT_MAX: + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + case POWER_SUPPLY_PROP_VOLTAGE_MAX: + val->intval *=3D 1000; + break; + + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: + val->intval *=3D 60; + break; + + default: + break; + } + + break; + } + + return 0; +} + +static void asus_ec_battery_poll_work(struct work_struct *work) +{ + struct asus_ec_battery_data *priv =3D + container_of(work, struct asus_ec_battery_data, poll_work.work); + int state; + + state =3D asus_ec_battery_get_value(priv, POWER_SUPPLY_PROP_STATUS); + if (state < 0) + goto reschedule; + + if (state & ASUSEC_BATTERY_FULL_CHARGED) + state =3D POWER_SUPPLY_STATUS_FULL; + else if (state & ASUSEC_BATTERY_NOT_CHARGING) + state =3D POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (state & ASUSEC_BATTERY_DISCHARGING) + state =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + state =3D POWER_SUPPLY_STATUS_CHARGING; + + if (priv->last_state !=3D state) { + priv->last_state =3D state; + power_supply_changed(priv->battery); + } + +reschedule: + /* continuously send uevent notification */ + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); +} + +static const struct power_supply_desc asus_ec_battery_desc =3D { + .name =3D "asus-ec-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D asus_ec_battery_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_battery_properties), + .get_property =3D asus_ec_battery_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static int asus_ec_battery_probe(struct platform_device *pdev) +{ + struct asusec_core *ec =3D dev_get_drvdata(pdev->dev.parent); + struct asus_ec_battery_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + mutex_init(&priv->battery_lock); + + priv->ec =3D ec; + priv->batt_data_ts =3D jiffies - 1; + priv->last_state =3D POWER_SUPPLY_STATUS_UNKNOWN; + + cfg.fwnode =3D dev_fwnode(dev->parent); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_battery_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-battery", + priv->ec->name); + if (!priv->psy_desc.name) + return -ENOMEM; + + priv->battery =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->battery)) + return dev_err_probe(dev, PTR_ERR(priv->battery), + "Failed to register power supply\n"); + + ret =3D devm_delayed_work_autocancel(dev, &priv->poll_work, + asus_ec_battery_poll_work); + if (ret) + return ret; + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static int __maybe_unused asus_ec_battery_suspend(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&priv->poll_work); + + return 0; +} + +static int __maybe_unused asus_ec_battery_resume(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(asus_ec_battery_pm_ops, + asus_ec_battery_suspend, asus_ec_battery_resume); + +static struct platform_driver asus_ec_battery_driver =3D { + .driver =3D { + .name =3D "asus-transformer-ec-battery", + .pm =3D &asus_ec_battery_pm_ops, + }, + .probe =3D asus_ec_battery_probe, +}; +module_platform_driver(asus_ec_battery_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-battery"); +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's battery driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Jun 8 16:49:05 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0548732143D for ; Thu, 28 May 2026 05:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946365; cv=none; b=Yo1WMa11N7T9m4whFbP3XcgIiZR+Hz3Sjb2gST1JmsZ42XA3fqRJnTo0LBAc6lHSMGJOb7COvWc/387tdVQJOSZgUndfUZkKp3fBidltrqvzCCoGU5MOQRMYBfkpSG0Yb03X541fHKxcYlc0HLr+nA4G40ZrLyvufMwDZ9Gfwek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946365; c=relaxed/simple; bh=DmksfHT6MlGqSqjmYOxJfXx9JPeKsGh8gzABDeJ0S3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AC8gdw7fPVgGc6yPmDFbdGeLate8k39Q+3B/KyX2WY0WS8QSmzV8qcdsacu1uSV7rf0FDQphjzNNcF2N+4ABeRBX+EvvacUWl8RGps7zRTgIYBWHpMFzsR/JDrnDDs7bDiRwzSmLpg6HgicBdM2N84dDN/ZIgXpZk3wc2Pmbpjk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QBGNy66L; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QBGNy66L" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-68ad1e513d3so931473a12.0 for ; Wed, 27 May 2026 22:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946361; x=1780551161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KSastJv1yeLOMBYWqlsnzJjkboYGfgrWByJH8uwQayw=; b=QBGNy66LJOIZQA3PdtUDyDsmsEojlUrTHbZDKqOPpG7AZcEIfAlC0Ae7fJcBgoUpoI 1xXYcjcohzkV0yLAQXkf/axIvwqy/YvIfZ4PpOd5kkc4kwTXBEmDpHqijKp3PprVaViu prRKFcO8n8VXUyvouur3OkbnhO8XRMNpBqKHlTbbCWP6BvdkMqQkGBhDLajOYQ+0XXdn OlLLouW+FsYTluhSsnOTv39ZpKSzPAb27HGT/1BBjZiuyf+Jm3zsrl3dCGxGBmHGiLrW wohTrLf1vaKV8cJbKjifbiTTzGDMxvUrlzNkEm7/8k+BQebxPqQRmixked2FnSPbIpi4 SVpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946361; x=1780551161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KSastJv1yeLOMBYWqlsnzJjkboYGfgrWByJH8uwQayw=; b=p/zvIhJ/OYUWz0pJXHHX6GNBPBNfPZ6y0vkQwnNOco6dED/8gYMFMKjWa8p37GZdUZ a9qW85VyrcLQj0ezcFyqoz4uDm3NAYpBeQ3aBNlLjMsh4MWyRFipe73vZ6BePAmRr0ZJ YPSEYTDB1AyrKYW0vf6wKXZbPo+lGCT67BEeCIyeHcGsrybxUL956J9VyzR4J3/95Qj9 cbsu4bCk1DGLTWt5IHQQTIDb5QQAb4wi4ffuNvk/QlhFFgDlP2DeqMQYc6dv4sC3+QxJ SmI29Y9gHdayuZ/rz+NiIz37SO3V/N2GQeQzEcpc68XgHz/3vb2VZMy7OxbdohCa9QLN Wh/g== X-Forwarded-Encrypted: i=1; AFNElJ8aBLw7Z5RCAiDJ+AmUhqUcgGbiTUHKD6I9V1XvOgw28UnNEVn6aMg+lGl7BPVjubvct4Igg1VzbggXYEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwkQCmcet1yPb4wSE0xfz4L1UhF/a3uJh/Oy0EypuUoC/N+8WWy 9CM2yVmziTrwt+707PhDHj4kyMWZyQzAo+zygl5xWOyaUFAxAs99+VYz X-Gm-Gg: Acq92OFV0U0LYeMzApMr63lsSO2pXBUAqMqZ4RB/OWJkpCNP/beE/jUXer1rrKC81UR QH5Xr6AZD7BFAPl4o6JcHJEQDi9jre7L/2l/tfMmRtQGFKZsLqK+SPRqgwLKW+yceepFCUsuagE B6dYd6ff83LC1C5nsWJ8Qg52OdYgWNooby5ZenZuPjUzZth/zF3sWgiJGNAt+J7oHuy1z7f/o8v hRErtJX71FIUzuFQ3aZlxTER6A7ElLvlgnzq4X8lf1yEk+mLC6NLEToBSCWUsTVggIerrvyv06M WkUd20z8Z+vhR0Nm/lno34mAC73x9oJy9mTYnKvC7HaDZfp1MBvMDGFddd51q6bPo0Mr/GxELhm LzLwG9SwdLxwHXrKKGYODBNRoUJ/T1QpIRfyC7YlIKH97lBifR3Q6LAdsZNx+M37VhXhrzaxJOy MZM0eUcR5irvo1Ru8gMBmwFAVgD/xR2lb/OA== X-Received: by 2002:a17:907:a394:b0:bda:254d:4761 with SMTP id a640c23a62f3a-bdd277c8310mr1684820766b.31.1779946361155; Wed, 27 May 2026 22:32:41 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eca616sm693427966b.30.2026.05.27.22.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:32:39 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v8 7/7] power: supply: Add charger driver for Asus Transformers Date: Thu, 28 May 2026 08:32:03 +0300 Message-ID: <20260528053203.9339-8-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260528053203.9339-1-clamor95@gmail.com> References: <20260528053203.9339-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for charger detection capabilities found in the embedded controller of ASUS Transformer devices. Suggested-by: Maxim Schwalm Suggested-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-charger.c | 208 ++++++++++++++++++ 3 files changed, 220 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-charger.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 1dc3d0b2e021..ebc6d5c01330 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -508,6 +508,17 @@ config CHARGER_88PM860X help Say Y here to enable charger for Marvell 88PM860x chip. =20 +config CHARGER_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's charger driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here to enable support AC plug detection on Asus Transformer + Dock. + + This sub-driver supports charger detection mechanism found in Asus + Transformer tablets and mobile docks and controlled by special + embedded controller. + config CHARGER_PF1550 tristate "NXP PF1550 battery charger driver" depends on MFD_PF1550 diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 1313f367715c..93d17d28081e 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -69,6 +69,7 @@ obj-$(CONFIG_CHARGER_RT9471) +=3D rt9471.o obj-$(CONFIG_CHARGER_RT9756) +=3D rt9756.o obj-$(CONFIG_BATTERY_TWL4030_MADC) +=3D twl4030_madc_battery.o obj-$(CONFIG_CHARGER_88PM860X) +=3D 88pm860x_charger.o +obj-$(CONFIG_CHARGER_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-charger= .o obj-$(CONFIG_CHARGER_PF1550) +=3D pf1550-charger.o obj-$(CONFIG_BATTERY_RX51) +=3D rx51_battery.o obj-$(CONFIG_AB8500_BM) +=3D ab8500_bmdata.o ab8500_charger.o ab8500_fg.o= ab8500_btemp.o ab8500_chargalg.o diff --git a/drivers/power/supply/asus-transformer-ec-charger.c b/drivers/p= ower/supply/asus-transformer-ec-charger.c new file mode 100644 index 000000000000..c7a6bd2ba533 --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-charger.c @@ -0,0 +1,208 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include + +struct asus_ec_charger_data { + struct notifier_block nb; + struct asusec_core *ec; + struct power_supply *psy; + struct power_supply_desc psy_desc; +}; + +static enum power_supply_property asus_ec_charger_properties[] =3D { + POWER_SUPPLY_PROP_USB_TYPE, + POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR, + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_MODEL_NAME, +}; + +static int asus_ec_charger_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + enum power_supply_usb_type psu; + int ret; + u64 ctl; + + /* Check if model name is requested first since it needs no hw access */ + if (psp =3D=3D POWER_SUPPLY_PROP_MODEL_NAME) { + val->strval =3D priv->ec->model; + return 0; + } + + ret =3D asus_dockram_access_ctl(priv->ec->dockram, &ctl, 0, 0); + if (ret) + return ret; + + switch (ctl & (ASUSEC_CTL_FULL_POWER_SOURCE | ASUSEC_CTL_DIRECT_POWER_SOU= RCE)) { + case ASUSEC_CTL_FULL_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_CDP; /* DOCK */ + break; + case ASUSEC_CTL_DIRECT_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_SDP; /* USB */ + break; + case 0: + psu =3D POWER_SUPPLY_USB_TYPE_UNKNOWN; /* no power source connected */ + break; + default: + psu =3D POWER_SUPPLY_USB_TYPE_ACA; /* power adapter */ + break; + } + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + val->intval =3D psu !=3D POWER_SUPPLY_USB_TYPE_UNKNOWN; + return 0; + + case POWER_SUPPLY_PROP_USB_TYPE: + val->intval =3D psu; + return 0; + + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + if (ctl & ASUSEC_CTL_TEST_DISCHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE; + else if (ctl & ASUSEC_CTL_USB_CHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO; + else + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE; + return 0; + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + switch ((enum power_supply_charge_behaviour)val->intval) { + case POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO: + return asus_dockram_access_ctl(priv->ec->dockram, NULL, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_USB_CHARGE); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE: + return asus_dockram_access_ctl(priv->ec->dockram, NULL, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, 0); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE: + return asus_dockram_access_ctl(priv->ec->dockram, NULL, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_TEST_DISCHARGE); + default: + return -EINVAL; + } + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_property_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + return true; + default: + return false; + } +} + +static const struct power_supply_desc asus_ec_charger_desc =3D { + .name =3D "asus-ec-charger", + .type =3D POWER_SUPPLY_TYPE_USB, + .charge_behaviours =3D BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE), + .usb_types =3D BIT(POWER_SUPPLY_USB_TYPE_UNKNOWN) | + BIT(POWER_SUPPLY_USB_TYPE_SDP) | + BIT(POWER_SUPPLY_USB_TYPE_CDP) | + BIT(POWER_SUPPLY_USB_TYPE_ACA), + .properties =3D asus_ec_charger_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_charger_properties), + .get_property =3D asus_ec_charger_get_property, + .set_property =3D asus_ec_charger_set_property, + .property_is_writeable =3D asus_ec_charger_property_is_writeable, + .no_thermal =3D true, +}; + +static int asus_ec_charger_notify(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct asus_ec_charger_data *priv =3D + container_of(nb, struct asus_ec_charger_data, nb); + + switch (action) { + case ASUSEC_SMI_ACTION(POWER_NOTIFY): + case ASUSEC_SMI_ACTION(ADAPTER_EVENT): + power_supply_changed(priv->psy); + break; + } + + return NOTIFY_DONE; +} + +static int asus_ec_charger_probe(struct platform_device *pdev) +{ + struct asusec_core *ec =3D dev_get_drvdata(pdev->dev.parent); + struct asus_ec_charger_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + cfg.fwnode =3D dev_fwnode(dev->parent); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_charger_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-charger", + priv->ec->name); + if (!priv->psy_desc.name) + return -ENOMEM; + + priv->psy =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->psy)) + return dev_err_probe(dev, PTR_ERR(priv->psy), + "Failed to register power supply\n"); + + priv->nb.notifier_call =3D asus_ec_charger_notify; + + return blocking_notifier_chain_register(&ec->notify_list, &priv->nb); +} + +static void asus_ec_charger_remove(struct platform_device *pdev) +{ + struct asus_ec_charger_data *priv =3D platform_get_drvdata(pdev); + struct asusec_core *ec =3D priv->ec; + + blocking_notifier_chain_unregister(&ec->notify_list, &priv->nb); +} + +static struct platform_driver asus_ec_charger_driver =3D { + .driver.name =3D "asus-transformer-ec-charger", + .probe =3D asus_ec_charger_probe, + .remove =3D asus_ec_charger_remove, +}; +module_platform_driver(asus_ec_charger_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-charger"); +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer Pad battery charger driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0