From nobody Mon Jun 8 16:50:02 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671FD2D060C for ; Thu, 28 May 2026 04:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779942556; cv=none; b=np9e6LOxK0ayw3kIJlcrX/sGYq04+gIeE+RoQOwfhxXmAEhUVP632wqvz+nRMV4/BXsO89/CEG4lmrEwXgGmG5IRVUmsjuYSZ1jvuIrOQIXNa7t8EGKnnu0b/5vemg1GM305f9EnV2V+KmUHBVrKU5sXkOXrjs8aLDMqj9g9WhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779942556; c=relaxed/simple; bh=cY2a5W/nIKwHBly6hYcs7h3YMk2FJ4n2UXhDqpuNXGk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ps3J/aIIC1h63a6yzcb8YU2APPunvvOZ68HW6kXtlWoD8s4frIbRzaTrAHkKVDhGOj/4juWndqouzNnxm1H/Z5/I2pPTh1X61A+P9snKAQR2rhAFoyUXFX+uc/PuZyTKKdnPFXmo/NFlCqcV80EpxW2yNN+dMTdz6Cl1IB7GBNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mMaCQqUD; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mMaCQqUD" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c8561fcb680so134529a12.3 for ; Wed, 27 May 2026 21:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779942554; x=1780547354; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EhiW+uhYb7yOkQVsq9tZ39UUfuEazA56TlzvJ4Ekon0=; b=mMaCQqUDV+0qLDvKG0FrJ8s77aiCs9DXhJU2ZHcab/TURPoLWNkXriCYNlgKa0oOCK fetzswzOXKVy6cA9fJzryrDZFLIJvMALDwGVRgkZW4qS2SN5OYyC6EVHMufzaeqo0Buk IPXIWN1gbUO2+FunQV80Gn9MSRETs+jnwlznpMyaRaDGEg3iwGAkgskgeTVNABHgXfcx oTQO0HCyndJPB0dkeqQpKR4qnGhFBLsxhFi5ZhIiehi5rHG2FEsFYgDqHjh+yKHR+3uH lTLHj1FNN02yPPg62NVmqbtt1s1hNkN6GYbVj0EXaJjFqdbfKx2V5lj0q5Dcd7klz/FI ICMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779942554; x=1780547354; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EhiW+uhYb7yOkQVsq9tZ39UUfuEazA56TlzvJ4Ekon0=; b=IFhJcXgvJlIek3E8erk+uj/9VoJ7ft53SzrjK9L0udoYbPQKNnFU0RjGQkUwtudHX1 cuRcl3na6K0gw0NdmwolGf7X3AJx22Mhl/2P7Kfbk/ZOoiQzqwi7oZcv++rBGDqIEv2z isdXZbD2XgJ8jAxLxDKeE2zQYa3PJU+oo4fNtgB3jaIkM0IvOdBQQkEFYEwcOmDD8t3M 0kbln4ZigTnLf4mYy6D0YxRT7iNY830QkssmvIkrG/mgWn4ER8cX2FB6WW3gArcjq/sG WA0NnpKag0ojHch4o3MSuBDhKZ4youvVBBh3zjpR3psbOljtPS1LEE4uQF3ChTl5gWWd rFLw== X-Forwarded-Encrypted: i=1; AFNElJ+UOWQs85ftG3bJ8vj6OCB09J78x4qeJul/j5UgkfiQr/cMyoae+KhatNc5LzSBB7st73CVIwUkEy1ni9c=@vger.kernel.org X-Gm-Message-State: AOJu0YyDLjYF+zKJ+TRc7qVrKXJzGEHXEXPvlzFzaYgUqBHu7ulcmmZx S8jJ7NiToqQVWWBdQAMZVk9ahRD8vvuwMMmBphv5lwCUxpfVchxmYLwj/0ltYuVrtDr/k0Ca9Ko = X-Gm-Gg: Acq92OEOszUA6881aOaORY2JKbTUcp4wvAzG+k0t7MVRborVuBL1/ZztspNeP9poZTR BXW0mIgAIWJRJbnDdPOePc2lpg5flpGXu5+IwZl5SRs+sf4xCnI8BCl4ueX9+jD09p1DxP9Y3jI HdT2jZirrOVwpBpW1lITsU5Q6DYbqYDdw9/V6aSQzVKC54jfuAeCk8zPfMQy/9H4QYIS9Fywvx6 ukA8+9FLEpRtuyy3ZTEqRVtfirFwT7jcp9NGs1G+lhzfjanskPnLNIureM4TKaXVT5U43CRDfLh Kmty8OI1o4n+alQT9MYZGyQ+GN9mwrIpBRL5oKN57ivlokl6vms5c7UUQVNwZZKeOPyg1Gxil8v 4uXBWbISf2hQZAnIOPRL6iiGZCLUUR+1wCpMvCjCWkOzF18g86d+1HyW4+0v90crgz+ink5pZBs Gw0HHLeRy3kToK22kvt177rR26r3TX60jY0zPM7+fyyvcLv/JVcQ== X-Received: by 2002:a05:6a00:140e:b0:83a:4846:90b0 with SMTP id d2e1a72fcca58-8415f3c6635mr25622392b3a.46.1779942554488; Wed, 27 May 2026 21:29:14 -0700 (PDT) Received: from elysia090-Inspiron-7790-AIO ([2400:2411:d120:da00:480:dca6:feb8:54eb]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d6eb3aa5sm3808022b3a.22.2026.05.27.21.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 21:29:14 -0700 (PDT) From: Ren Tamura To: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Ren Tamura Subject: [PATCH] cgroup: pair max limit READ_ONCE() with WRITE_ONCE() Date: Thu, 28 May 2026 13:28:39 +0900 Message-ID: <20260528042839.28472-1-ren.tamura.oss@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cgroup.max.descendants and cgroup.max.depth are shown through seq_file. Their show callbacks read cgrp->max_descendants and cgrp->max_depth with READ_ONCE(), respectively. The corresponding write callbacks update the same scalar fields while holding the cgroup lock, but the seq_file show path does not serialize against those stores. This leaves the lockless show-side loads annotated with READ_ONCE(), while the corresponding stores remain plain stores. Use WRITE_ONCE() for the updates so the intended lockless access is marked consistently on both sides. This does not change locking, ordering, or user-visible semantics. Assisted-by: OpenAI-Codex:gpt-5.5 Signed-off-by: Ren Tamura --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 6152add0c..daddfc2b9 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -3726,7 +3726,7 @@ static ssize_t cgroup_max_descendants_write(struct ke= rnfs_open_file *of, if (!cgrp) return -ENOENT; =20 - cgrp->max_descendants =3D descendants; + WRITE_ONCE(cgrp->max_descendants, descendants); =20 cgroup_kn_unlock(of->kn); =20 @@ -3769,7 +3769,7 @@ static ssize_t cgroup_max_depth_write(struct kernfs_o= pen_file *of, if (!cgrp) return -ENOENT; =20 - cgrp->max_depth =3D depth; + WRITE_ONCE(cgrp->max_depth, depth); =20 cgroup_kn_unlock(of->kn); =20 base-commit: eb3f4b7426cfd2b79d65b7d37155480b32259a11 --=20 2.53.0