From nobody Mon Jun 8 16:30:31 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E29C186284; Thu, 28 May 2026 00:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; cv=none; b=X3wArFp2qlu/aVsF/0Z2u/Hf2nxLrHO9m4qx3sJ4rE5O2oF5rgmsfzeAGQFLvfQaecvME/xIdyw/8pbRGgwQwAsh8QMVN1qx9WJaKsJ5DV94knNG6hliAOIsH3jBORKyB/TqIwqHWUjOsItvAFgE5QDtYxE5Nn6ZvsQEQZy8z94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; c=relaxed/simple; bh=VzCCG2WY9lp/Ig+ftT7XCOYa3KAVTvV+8yWaQKuCg24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EpT96OAYCYU3iX7IzyOoShVNW6UgStD4w8DNhAU+zYjeKFKjM8t7RK7HXmroBpBpRIjuG/h6lu36YK1iyzwauvixeoskdaIFEVW0GdanmWsov+EG2NvvlyWSLxgNhyvJyAl6y9Ml1jlWCttTwHkQurM0Kl+q74k5CXB4LP1YQZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=RhdOcE4H; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RhdOcE4H" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=NpxOKjsfnDebULmYkiyGcMGkmFp7bR2xF1D+86616qg=; b=RhdOcE4HedAwdTo8jgjOUGNqod N/MfIwhs2SmXkFxo6tudlchN0aZl7TSiqbMid4OZRUndqaKLR5Av147tX8LoE2ykz/F2ML7X16vtW MK0d8wbLF8/YcgtoWk6hGZM6kDX79rNHoSjcTNJV3qFsRPvRkKcH5gaXEgx781a6oJ8DrEpGYvRKg dcT+GiUnBT09H02E+HCg7i02+5RwuGutrljvxrOM59eNf7DuM/EdAVRLFHi5Uejqjrf7Fkg7UhrKn U1k5Qyj6DCqf2yNDiLYx/UYlpyh9YJZDwWT5UGQyuHFEHyjIn/yIYGSG2uSrs76dQ30emdyjiPtBR q8rdpdzw==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSObV-00000004rZ7-1qPG; Thu, 28 May 2026 00:28:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH 1/5] watchdog: add devm_watchdog_register_device() to watchdog-kernel-api Date: Wed, 27 May 2026 17:27:59 -0700 Message-ID: <20260528002803.1260126-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528002803.1260126-1-rdunlap@infradead.org> References: <20260528002803.1260126-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_watchdog_register_device() is not documented. Add it to the current kernel API documentation. Signed-off-by: Randy Dunlap --- Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org Cc: Jonathan Corbet Cc: Shuah Khan Cc: linux-doc@vger.kernel.org Documentation/watchdog/watchdog-kernel-api.rst | 8 ++++++++ 1 file changed, 8 insertions(+) --- linux-next-20260525.orig/Documentation/watchdog/watchdog-kernel-api.rst +++ linux-next-20260525/Documentation/watchdog/watchdog-kernel-api.rst @@ -42,6 +42,14 @@ The watchdog subsystem includes a regist which allows you to register a watchdog as early as you wish during the boot process. =20 +There is also a resource-managed watchdog_register_device(), +devm_watchdog_register_device(). If you use this to register a watchdog +device, watchdog_unregister_device() is called automatically on driver +detach:: + + int devm_watchdog_register_device(struct device *dev, + struct watchdog_device *wdd); + The watchdog device structure looks like this:: =20 struct watchdog_device { From nobody Mon Jun 8 16:30:31 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E2EB18FC80; Thu, 28 May 2026 00:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928090; cv=none; b=Oxu1l61dGRzY/RUAwt+bFl7bMcnASUPbWJ6lI3rmVqji/h9x6B7LNmfuQO824DGYHxp6nGxvaOfeM74heYpq6cRI15JwygUwmprbFahEiYcJjGdDeNaWOtKGQiafIwiQKa52silJ6SIoidUsVxJcVqVb0XtP6IN3p4GePI5VCq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928090; c=relaxed/simple; bh=vwm3ZNRCzNEkNrji1GlfC6deS7Y4C3lKdD2jDFtC0Sk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JrepWCsklbW4vFHf1mK8vzAaRxjrX6Q/U5pT8vfv4tJD3ZhrN2p6vuNfsIdx2hRPTuf+HL1CbAOKAdfSWlhvCX0KIZE+m1+/ugezCG+Nn15x22TRA6BR8k4ruFR8rbuxVhnAw0W/KrTptBMguvUter4NCmG+cQ2Bpe3ULnF7Hro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=YbQPS73C; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YbQPS73C" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=YUbwXC7zGeZUbyZDSGIHXcRoenrR+B/707Xvi52W8jE=; b=YbQPS73Cl9CIgvsr1bYeHF2AKW WzKJkEcC7LX8BOcNiZPVllLahAYKHql4mC17C9TWxHWj7MsIMI3XSS7MgWS/cuvamGJCPkuKdHy2e bhovLbmzpBfCwR8tpTVzb7UMGTc3aoRCvAPFXDw5Gdh9zERKNrbva7X+tBOUHxO9E63L6GaWnWz83 MCrSDTQDwGNjBpBz618yF9Bm05uqmnX6CU8WsgS0TNukktwBj8huiBV6iD3ia9noJrva1cJ9bSAA2 wi9fWk7Qi+WeGXdXc3GSZWPqJcQnI69SwAjLGJSi1TEPEWuFuz+6Sd9+bXEIRx0gQ2x4Ff1y9K4UU NUlyl4vQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSObV-00000004rZ7-3JS4; Thu, 28 May 2026 00:28:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH 2/5] watchdog: linux/watchdog.h: repair kernel-doc comments Date: Wed, 27 May 2026 17:28:00 -0700 Message-ID: <20260528002803.1260126-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528002803.1260126-1-rdunlap@infradead.org> References: <20260528002803.1260126-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert struct comments to correct kernel-doc format and add one missing struct member description. Signed-off-by: Randy Dunlap --- Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org include/linux/watchdog.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- linux-next-20260525.orig/include/linux/watchdog.h +++ linux-next-20260525/include/linux/watchdog.h @@ -26,7 +26,8 @@ struct watchdog_device; struct watchdog_core_data; struct watchdog_governor; =20 -/** struct watchdog_ops - The watchdog-devices operations +/** + * struct watchdog_ops - The watchdog-devices operations * * @owner: The module owner. * @start: The routine for starting the watchdog device. @@ -59,7 +60,8 @@ struct watchdog_ops { long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long); }; =20 -/** struct watchdog_device - The structure that defines a watchdog device +/** + * struct watchdog_device - The structure that defines a watchdog device * * @id: The watchdog's ID. (Allocated by watchdog_register_device) * @parent: The parent bus device @@ -83,6 +85,8 @@ struct watchdog_ops { * Replaces max_timeout if specified. * @reboot_nb: The notifier block to stop watchdog on reboot. * @restart_nb: The notifier block to register a restart function. + * @pm_nb: The notifier block to stop watchdog on suspend and restart it + * on resume. * @driver_data:Pointer to the drivers private data. * @wd_data: Pointer to watchdog core internal data. * @status: Field that contains the devices internal status bits. From nobody Mon Jun 8 16:30:31 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E24434389F; Thu, 28 May 2026 00:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; cv=none; b=X3u0SOS2Bye4IATNsAbwu4xIB++tUtTIlq0eZbpZYp6Kv3ZwLU9PiKwpt0rMCuAi3Us+3AiFAKfZuAknC0ZPaSmN+7VrLMGorUz2jSp/pHPZjGzun7zi/BN52fIl/03kA5Uj3upCz7cbF14JImnR1YDXkqCA8pdYIfXEPzZ9yTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; c=relaxed/simple; bh=EdW20xVGsmA/NiUd4NEN5b53XesQ3mEfxdtpHwA71x0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jcmMlB/IrBK6w8BjBs1fLJF25eOTR5iB1Uba2sSAbwGAugfwDn0mI/+tVZBLmDsjIXjDUDcnlgVFhNjngQZlio6ds7tIMFe16TJOZzWadatIWbf1kHFnCORSkwwZZcuDD1NphaFkPS3xIc6jJVBb64J0dlzi9QXnupMhikvBUDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=I9Hhpwlj; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I9Hhpwlj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=nOgR2lLiLc1VSZ5Ry2yGfoAtEh8GVCXHBx9G9lUrrQM=; b=I9HhpwljT3U5ojDlENsY7n+YMJ Yp1MCj2YOAQWlEvAVgrgc7gghfbsn706cPVp9w+VZoyrZfs3t2WewYTv+pyVxe1Qch73sOj9qtxiG GmtYo/quI0AD33kJub8LLKWN/hLAAnCGurGIJSLvxBM9ty9LD0GASWjC1dOOnmQ+9KJ9CkW0q04S7 NgCqIyHZV5nu6cPk6tvHK7Oz/JHFKwgLdq3rb8BDV4vLu5MYq6k93NLXXfHbIE+Lwcy0s6SNv1Bzk xH/cVK0djJ7fVvUon0fd94WNIfGO1QNKAqPYdXzyOezGwRNJ8dZhJKIPxsBrBfw6SGtBMXmSnlxzo AP7kEgjQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSObW-00000004rZ7-0Voh; Thu, 28 May 2026 00:28:06 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH 3/5] watchdog: uapi: add comments for what bit masks apply to Date: Wed, 27 May 2026 17:28:01 -0700 Message-ID: <20260528002803.1260126-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528002803.1260126-1-rdunlap@infradead.org> References: <20260528002803.1260126-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add comments similar to those in include/linux/watchdog.h so that the reader/user doesn't have to dig into the API documentation files for this. Signed-off-by: Randy Dunlap --- include/uapi/linux/watchdog.h | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20260525.orig/include/uapi/linux/watchdog.h +++ linux-next-20260525/include/uapi/linux/watchdog.h @@ -36,6 +36,7 @@ struct watchdog_info { #define WDIOF_UNKNOWN -1 /* Unknown flag error */ #define WDIOS_UNKNOWN -1 /* Unknown status error */ =20 +/* Bit numbers for watchdog_info.options, GETSTATUS and GETBOOTSTATUS ioct= ls */ #define WDIOF_OVERHEAT 0x0001 /* Reset due to CPU overheat */ #define WDIOF_FANFAULT 0x0002 /* Fan failed */ #define WDIOF_EXTERN1 0x0004 /* External relay 1 */ @@ -50,6 +51,7 @@ struct watchdog_info { other external alarm not a reboot */ #define WDIOF_KEEPALIVEPING 0x8000 /* Keep alive ping reply */ =20 +/* Bit numbers for WDIOC_SETOPTIONS ioctl */ #define WDIOS_DISABLECARD 0x0001 /* Turn off the watchdog timer */ #define WDIOS_ENABLECARD 0x0002 /* Turn on the watchdog timer */ #define WDIOS_TEMPPANIC 0x0004 /* Kernel panic on temperature trip */ From nobody Mon Jun 8 16:30:31 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E39519CD0A; Thu, 28 May 2026 00:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928090; cv=none; b=IUSyCnnEMxn6Yzg93Pk2PUTGIQEjk5n65u9T50WgBsiby2M3xxCG4pbf1uMdfiJpkfKwUJcw6xvC+QI/k1GhSk4nzpDaZH+s8flwUnAb3Umz4+06DGJVBonGwoXKgPXpWAP9ykX3MlHKrNyhifz1fOL/UcIujwfxswqwTWAEih8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928090; c=relaxed/simple; bh=KKugxGyftPu51DYy5+LukcSckuJ5KkPf2yTprwVyTGE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dB+4HQ3XXmj/b1OR8pNyisopiJ7cvOzWYHNNDKV9FXXJrBxUZsvZrvulF43w/1coK3zkzBM84gYKhLBue7uZpwXD8pIpTB6MaWC8I8Y6LF/CdFSQl+LBnaGlqfqBxQK3pDNn1c/Hx3s4K294wcZPuoCX+0dKhd139J0t+Ciy7E0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=fFIBQLVa; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fFIBQLVa" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=yWgUw/Fqw/FuRLerzJJk1tlIM0Vz1CFx2RpkBzTIonY=; b=fFIBQLVadUk7RVYTc4qiQ4fJ9R uM1lfDA7mUZ2Kvv0CWDyanhr1XHKsldlKeZ4fm4dC7ODPrDriE6/IlOhJoqBR2kb88IrSha69BYyM x6b5ZVhijfaxj91BIP3sd/JORsnzl2ZhlHFUiRovSlu8FSqOOG3TnuHFyyjW3dzgsNne3LAL5nfAv iefTw97t3KD3cdsoyFZwgYoByY7y8WG2NfKwTabFIT/I1O8bqxqPXtd9XShDtYPBIcJ1BdF7oh2TR gmVzwmnyw9ZRl5Ol8lfpMhNhfsE1if3QyYMnQoPkoHHiXak+WQOZNLK7ggwucu4M5MtUfu7vFM09u Kga6aqeg==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSObW-00000004rZ7-21ic; Thu, 28 May 2026 00:28:06 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH 4/5] watchdog: core: clean up some comments Date: Wed, 27 May 2026 17:28:02 -0700 Message-ID: <20260528002803.1260126-5-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528002803.1260126-1-rdunlap@infradead.org> References: <20260528002803.1260126-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix some grammar typos and bulleted kernel-doc comment format. Signed-off-by: Randy Dunlap --- Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org drivers/watchdog/watchdog_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- linux-next-20260525.orig/drivers/watchdog/watchdog_core.c +++ linux-next-20260525/drivers/watchdog/watchdog_core.c @@ -55,9 +55,9 @@ MODULE_PARM_DESC(stop_on_reboot, "Stop w * for example when it's impossible to disable it. To do so, * raising the initcall level of the watchdog driver is a solution. * But in such case, the miscdev is maybe not ready (subsys_initcall), and - * watchdog_core need miscdev to register the watchdog as a char device. + * watchdog_core needs miscdev to register the watchdog as a char device. * - * The deferred registration infrastructure offer a way for the watchdog + * The deferred registration infrastructure offers a way for the watchdog * subsystem to register a watchdog properly, even before miscdev is ready. */ =20 @@ -222,11 +222,11 @@ static int watchdog_pm_notifier(struct n * watchdog_set_restart_priority - Change priority of restart handler * @wdd: watchdog device * @priority: priority of the restart handler, should follow these guideli= nes: - * 0: use watchdog's restart function as last resort, has limited rest= art - * capabilies - * 128: default restart handler, use if no other handler is expected to = be + * * 0: use watchdog's restart function as last resort, has limited rest= art + * capabilities + * * 128: default restart handler, use if no other handler is expected to = be * available and/or if restart is sufficient to restart the entire = system - * 255: preempt all other handlers + * * 255: preempt all other handlers * * If a wdd->ops->restart function is provided when watchdog_register_devi= ce is * called, it will be registered as a restart handler with the priority gi= ven From nobody Mon Jun 8 16:30:31 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1FA34389A; Thu, 28 May 2026 00:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; cv=none; b=l7L/ZqwgXLyGcFfQYOo3RYq8Dz2fko7no7KMsjn/FJ2AsuYh89UXzylM7BZMEw2liDsx79TFYVpofn51L4chsf0RMkNQvcjTtB9I3fBzX4rihHvgfaNOqgNig7ll+wO5nQVoJZKdTOp2lA0EiL26uG19R7eaOhubRNFutvDIxCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928089; c=relaxed/simple; bh=GOXMm9quu6x7oDg6Jk1CTz4hx5XZqlwDa61SOPezt2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rrw6ELP1/o61iXJitQmNhiBW1KTPy76f0yOe2upNrmk9COaDams+ypASe6Kr0Z+PgLOXiFlY+EI2rLAt3JuNYfUUTwaIUp8X3hbr3z2UpniZ79tttXIB1W269oTeyl627i3dQJW9Vt7rqGR1y+QP417E2FhoeXCdHGEHx8smEhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=CtP+oO82; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CtP+oO82" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=VkrsBFKQKyxb92yofN7Exvmo5N+YI7gvv8pjiOGMeWw=; b=CtP+oO82xckCMaCkd9qFGXYyif yQgbCFcTENXaouSH8OheNKnKZ7jP5OJ/PvERSB0kYtLH8mp5xHSKsFoxd0cYGW2JYIfoP6Kka9acC kpj4FG7S8arqHIQsnq7W/YTlA9QQn0vlqyzjwnTl/xVg3zgGsr9OCniF9DLXfrcb7xsg1HDhSHoMj DIsThJFw/4FBlmedsfc6KUTmRCGHyykiTtAuZnW4N/vdu27aaM8yjdmBm1uUCIuR/K2L9byc3O4kO h63pHNjsuA/4yq0xoN4ct1Pf6giqOluruQPxVUuDR+Xo6g/55tMxo+Qr3f1re48l8IBPIuSUKyO1U BciDX9GA==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSObW-00000004rZ7-3Qbp; Thu, 28 May 2026 00:28:06 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org Subject: [PATCH 5/5] watchdog: dev: convert to kernel-doc comments Date: Wed, 27 May 2026 17:28:03 -0700 Message-ID: <20260528002803.1260126-6-rdunlap@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528002803.1260126-1-rdunlap@infradead.org> References: <20260528002803.1260126-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert multiple functions to kernel-doc format. Signed-off-by: Randy Dunlap --- Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-watchdog@vger.kernel.org drivers/watchdog/watchdog_dev.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) --- linux-next-20260525.orig/drivers/watchdog/watchdog_dev.c +++ linux-next-20260525/drivers/watchdog/watchdog_dev.c @@ -176,7 +176,7 @@ static int __watchdog_ping(struct watchd return err; } =20 -/* +/** * watchdog_ping - ping the watchdog * @wdd: The watchdog device to ping * @@ -236,7 +236,7 @@ static enum hrtimer_restart watchdog_tim return HRTIMER_NORESTART; } =20 -/* +/** * watchdog_start - wrapper to start the watchdog * @wdd: The watchdog device to start * @@ -279,7 +279,7 @@ static int watchdog_start(struct watchdo return err; } =20 -/* +/** * watchdog_stop - wrapper to stop the watchdog * @wdd: The watchdog device to stop * @@ -319,7 +319,7 @@ static int watchdog_stop(struct watchdog return err; } =20 -/* +/** * watchdog_get_status - wrapper to get the watchdog status * @wdd: The watchdog device to get the status from * @@ -356,7 +356,7 @@ static unsigned int watchdog_get_status( return status; } =20 -/* +/** * watchdog_set_timeout - set the watchdog timer timeout * @wdd: The watchdog device to set the timeout for * @timeout: Timeout to set in seconds @@ -391,7 +391,7 @@ static int watchdog_set_timeout(struct w return err; } =20 -/* +/** * watchdog_set_pretimeout - set the watchdog timer pretimeout * @wdd: The watchdog device to set the timeout for * @timeout: pretimeout to set in seconds @@ -417,7 +417,7 @@ static int watchdog_set_pretimeout(struc return err; } =20 -/* +/** * watchdog_get_timeleft - wrapper to get the time left before a reboot * @wdd: The watchdog device to get the remaining time from * @timeleft: The time that's left @@ -659,7 +659,7 @@ __ATTRIBUTE_GROUPS(wdt); #define wdt_groups NULL #endif =20 -/* +/** * watchdog_ioctl_op - call the watchdog drivers ioctl op if defined * @wdd: The watchdog device to do the ioctl on * @cmd: Watchdog command @@ -678,7 +678,7 @@ static int watchdog_ioctl_op(struct watc return wdd->ops->ioctl(wdd, cmd, arg); } =20 -/* +/** * watchdog_write - writes to the watchdog * @file: File from VFS * @data: User address of data @@ -732,7 +732,7 @@ static ssize_t watchdog_write(struct fil return len; } =20 -/* +/** * watchdog_ioctl - handle the different ioctl's for the watchdog device * @file: File handle to the device * @cmd: Watchdog command @@ -845,7 +845,7 @@ out_ioctl: return err; } =20 -/* +/** * watchdog_open - open the /dev/watchdog* devices * @inode: Inode of device * @file: File handle to device @@ -923,7 +923,7 @@ static void watchdog_core_data_release(s kfree(wd_data); } =20 -/* +/** * watchdog_release - release the watchdog device * @inode: Inode of device * @file: File handle to device @@ -932,7 +932,7 @@ static void watchdog_core_data_release(s * stop the watchdog when we have received the magic char (and nowayout * was not set), else the watchdog will keep running. * - * Always returns 0. + * Returns: Always 0. */ static int watchdog_release(struct inode *inode, struct file *file) { @@ -1004,7 +1004,7 @@ static const struct class watchdog_class .dev_groups =3D wdt_groups, }; =20 -/* +/** * watchdog_cdev_register - register watchdog character device * @wdd: Watchdog device * @@ -1105,7 +1105,7 @@ static int watchdog_cdev_register(struct return 0; } =20 -/* +/** * watchdog_cdev_unregister - unregister watchdog character device * @wdd: Watchdog device *