From nobody Mon Jun 8 16:28:55 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6933019A6 for ; Thu, 28 May 2026 02:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779936538; cv=none; b=kvK9fZbI0vM+t6Q7y2/6qAdAktVrCDpHRPSWI/UlGv2cCj7aYGKMgWVe9TtYkthCTUi/pC5eOvEfumPR2w6PfkIEN+HNDCq43keukOERVG316Y4Fap0V6rg+s1SPZLfjB/7eS//+xG3Nu9pA4ePmmA28AGNhpTFP2dR+neszbak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779936538; c=relaxed/simple; bh=4ILmcE2UVRvUA5w/bCMsuoZ6029LYusklIg66JvviMc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DUY0+IISAPQ6eonJ53k3y8h10smJKv6QkkPlQ7qdJcdUV/oxu7CIbZ6n6HHBKWG5zGC2fTJZYWuvTry83OUiQg5eH/88bacaHvLnfDvcR79DYNuTngnviORBGLgEPXPlhjrsuvlzFu4fz9Cbv36J5QTfyGcKaA4S48E6tBZmpAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T5U7ChHy; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T5U7ChHy" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c8173b2af32so9468296a12.0 for ; Wed, 27 May 2026 19:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779936536; x=1780541336; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UdZHIVC8VqdiF0LxnTx3Ka4A/RjNztw5bpRG2RMXPPI=; b=T5U7ChHyEZhxolxb0MDGheEdL2EnsmL94QT1nbR4/jfJv3CfiyzggSxIVzszeOVtdw IL9/fhUf1pHx2ZfARCbIRcw1fYW/smBXRp/1hqvNZ/2YbrDSjjXi2r1O+OYfsX3iE+lj Q7FdHlLkao4e6kEHZ9kKBrQzHXZMtu2BH3jJAWFgv+OzeSBY/PP1UZTJYNRJq1gMtxhk pNFk7Ytfe0lZMoI1RdZ+HUWf1PBFDDDwCdcjrsS1xGNo6XFbH82ZiGH7kpm/ri1wPUmY 25TWRxYM3Csw+e/YrVkc2UYMmH7NTNiKCkpHbQbrDUHfsmwIohUb1lomLhje3CgO4pP3 hIgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779936536; x=1780541336; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UdZHIVC8VqdiF0LxnTx3Ka4A/RjNztw5bpRG2RMXPPI=; b=CBYRh6r/487c5aKjAEK4KgmTXqqbwuzCfM4LgNf2oyUaHhQRyxFtk72mNuZaWdYYZ+ 9U1f7X8sDa1DkOfeSbi+YArgI/0spfE2StKdX1ej7eDpTpjuyRk2brzLb9dmD96xhB8f dwse4UyqLXavYVaa4zxhskNL9lw0iVt7qIYtKFn5rZzhGHmqNCaC8DvJA6c5pCSuygGF lERCU1aA9Jocwq8Ae6CRaeutRwqJTApS38F0INPcspC23BR+YsL/dnjw1WBGHyqEHJd1 +qs9MDbzofE0DhaxkVSboxnC5iedZ6r60IIxL1xWsxUhi+QroTEc8/KrbVJX2+NtrYjR guHA== X-Forwarded-Encrypted: i=1; AFNElJ9BPpUTxRvcBPZXXJMcgs4rCgZv5y1TNkFIm3yPwWI7ogOTPhu4IrD3WmKhQpSrifS4J7AHri5yrzIva7s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl91j0V1ooQvLZ9wKcI6j7UTb65aIzZruzlGyQXwgmRll8z399 HX/dd+YJw8sKbRBdeFCQSPDr2AN2Q4c/UoEIwKw/fciQodg+vtxmRMeS X-Gm-Gg: Acq92OFWo0S2WZFSIizHjY+/JQIMQmJXQC3Jpn1RjJAU1GhypItl5kzTZYbsHCtCIrO 4CYmNgnk/pDT688t+r73imEwKarNQxgThBJQbBpnvYf43v0CD0hUD7t5oc6XVF6Qj5v2gJ/ptOJ UfWR6XlNM9FZQXcYwJ2k4fXfTTl/YaWQ5EiVfc+CP3MBCYe2sUJya6pMal2fJ7jRboEOGKkS89l hTbcJMcSh8M7IuwDhfSHVknYS/iyOf9RVZUHLqStmpbdxpUsHAoMzFzJzXwXe821VVKGJ+PFJPI RsIhQ7JaVm4pmPYnPlOJ4snf95feV5rt7ml/cz8+BM4rmEh5/dckNCFnjkIkN6IzwS7iE7JK+M2 Q/kJVUSAhOjpWmKsKK0VTuGwryeIykMW55uX0MBG7QbCSiwaktVWQrBsJghWZxsYjArEswPE2mu tncNBcApkfNcyKdT77JEAOMAPC+3OQviwHWw== X-Received: by 2002:a05:6a00:238b:b0:835:5aa3:2dab with SMTP id d2e1a72fcca58-8415f1236aemr26567785b3a.6.1779936536313; Wed, 27 May 2026 19:48:56 -0700 (PDT) Received: from [127.0.0.1] ([116.80.91.208]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841f3cbcddbsm366877b3a.4.2026.05.27.19.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 19:48:56 -0700 (PDT) From: Cunlong Li Date: Thu, 28 May 2026 10:48:44 +0800 Subject: [PATCH v3 1/2] zram: fix use-after-free in zram_bvec_write_partial() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260528-zram-v3-1-cab86eef8764@gmail.com> References: <20260528-zram-v3-0-cab86eef8764@gmail.com> In-Reply-To: <20260528-zram-v3-0-cab86eef8764@gmail.com> To: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Andrew Morton , Yisheng Xie Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cunlong Li , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779936530; l=1542; i=shenxiaogll@gmail.com; s=20260517; h=from:subject:message-id; bh=4ILmcE2UVRvUA5w/bCMsuoZ6029LYusklIg66JvviMc=; b=KynYLGaGfZewjfo8RGU3mhyIy/vlwWxgy9oFeOCxoXHK2kYgK2sfLrwnBPEM449prqRHxV4Ff gobRxeZpMNpCc9MhH6mBms/BlpM1EFCtEHdF4CNUFQvLFVvO0SNxIr4 X-Developer-Key: i=shenxiaogll@gmail.com; a=ed25519; pk=SKFifnqPdsvsjuhUiq+Y9vtCdhyZ/LrRcfYn8eRq6AE= zram_read_page() picks the sync or async backing device read path based on whether the parent bio is NULL. zram_bvec_write_partial() passes its parent bio down, so for ZRAM_WB slots the read is dispatched asynchronously and zram_read_page() returns 0 while the bio is still in flight. The caller then runs memcpy_from_bvec(), zram_write_page() and __free_page() on the buffer, leaving the async read to write into a freed page. zram_bvec_read_partial() was switched to NULL in commit 4e3c87b9421d ("zram: fix synchronous reads") for the same reason; the write_partial counterpart was missed. Fixes: 8e654f8fbff5 ("zram: read page from backing device") Cc: Christoph Hellwig Cc: stable@vger.kernel.org Reviewed-by: Christoph Hellwig Reviewed-by: Sergey Senozhatsky Signed-off-by: Cunlong Li --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index aebc710f0d6a..b23a8bbb687c 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -2333,7 +2333,7 @@ static int zram_bvec_write_partial(struct zram *zram,= struct bio_vec *bvec, if (!page) return -ENOMEM; =20 - ret =3D zram_read_page(zram, page, index, bio); + ret =3D zram_read_page(zram, page, index, NULL); if (!ret) { memcpy_from_bvec(page_address(page) + offset, bvec); ret =3D zram_write_page(zram, page, index); --=20 2.30.2 From nobody Mon Jun 8 16:28:55 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5878C1C5D7D for ; Thu, 28 May 2026 02:48:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779936540; cv=none; b=snRz6fCkFcD7M8Azp0ofpDwRTvjgxPXDRRLidWkDN/1Ei5u9qD5DazZhuifaZRhen3GQjL7z2fYLn07Nv70J4K0F4X/z8GD9n90gGFFsS2jP8IKnIVB0xDdbPPxxaJGnNnbnLfJl1JWMJuTpv2Oh5KTPlejlyrZCvhGH95aWIA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779936540; c=relaxed/simple; bh=tYP7A1cG5Idkt7RgPNKfx9ASoxRRbHTZbBSShzPi2BY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Sl6munB27DHZRZjuD0N8MIWr8rvGqgiF4IPuthUYrsbCAOVzCK/3NHXAj0GVCP5v/v6sf8pnQZJF3k908ynuiBzBfrKNnxJDu+ms9kmi3FY4ShPahkVvlZglCjZ+zijUGjchLF9ayj7Vx4OPBFwiaHPvWNlEIClZ0TNZ5rEdKn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jFPR7jhB; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jFPR7jhB" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-841882f8f4bso1920058b3a.0 for ; Wed, 27 May 2026 19:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779936539; x=1780541339; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eRCtt7LbB+SSV6LJlNZfwK4a+gaxuGAqxV4IOSE6198=; b=jFPR7jhBAHuPCZJsw+290vszneqIPW1G8aQ6UcIaYwxqHg2PulHlbXECahcJ1p8vLI hwEoyED9Czqu/nJMLAP/JU4hn1NWx7ut9roltZRHzPaa5DdpeC1H98u1yxjhtafA83Kr jt6H3f2ys8KR+2H3b3AbQH20cjhwM+N8Lzvu+rJCiIvZ3eG2+m1yACHUBDdb0w4uMA8e obPT6ACNPu8IDXVNHMqq9efTHXi2f8aqNhDRjh2m6KfIpYyDg/yS0Uv+IbmEe/+DrNJS YbovK0yOMFoJg6o6HIpYr1fIDvCdV13Wl1e9+qXYj0UDfAsSfQDNnntF+KRTIoG/8ZYp tD3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779936539; x=1780541339; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eRCtt7LbB+SSV6LJlNZfwK4a+gaxuGAqxV4IOSE6198=; b=U4UX5XBxJIijUBw5cvf4Baq21Au/HSJhfqJq3GtuwXU3isaofFtiSgi+HrxHlGy8GV cy8ludrueMNIJ7sYMaTiFdUnvefD4U9b3p/L2vctVHCIxNK5WrmLMWuJyj8qFs4m32z/ Rvu5R+7yZu75Ll+3iYsYhAg/y6xwjsqbJLG0yluA0q1oKQxMEsBVTeRTw/+hYEoCcamC vC7kNiwqqjguC7Gt/tLFgNBCHPRmBb1+d+8fhiVlOBTXcpkIH/6dqbnfpFDnup0DidJI c4rbw3FX9xZS5Wf1NEo74phD9lVlI7jjbalCkvLNhsb9wK0Mz+tmQ3QCxoviqm4Ymrih Umcg== X-Forwarded-Encrypted: i=1; AFNElJ9YkI6Pgy6JfoYvjrJzi5x2pkgGqYthwS2kieSuhUK8QVQ9nkgoDq0rGwQKd79x442Bh0VoG7f4pA3S63o=@vger.kernel.org X-Gm-Message-State: AOJu0YyvpyPt93KlEeBi4kYJp76NBruvGHjCN8viMZ0gb0FwMYj6lJ+V drWpBWLZWlXSJdqTHcFZer7inwHRkSrLOl7Gqp6bGnRBslqpYD9Npw/i X-Gm-Gg: Acq92OHLc7RFuLK/ZxATUNoA+ZiqPPGQM5nhn5fMy3fw4zT+08INHG7tGFW+ZPc1pcu +M2/8lIooXrOJ03yGP+xVw0zep5eeBZDzNH07PhlJa0OlSy4vDCSbHPdGybdntynNm7A9Nt23t5 R+6wB5TYyyBUirHRAWsVnR5cxP1IHMoW0IJquIjLMIgifqilwSpi/4lQFKMg93M7+cGws5LuAYb YNha5NqUZPhGfNGM/R2OUarFS15nLb0pGHaETWRqaFRo6+oYAoqhTJt2w4UPMB+bEdjN7gAC+Na +Hi54/mV9/2lcDUCC33pZr43PABOmwSVsbzfARZsZqlKk4vgjw+qOb7RA0wm5VJ60laQ6a3D+Dw 0Xvjq8BOSSaSUdvvHXuiS/TeIVJA4JAfh1pd/mNA2H7i434E6RGlrP9Y43t/pS2sh3CoD6oSFx4 YH5EsjUqit1xFibYgUOepg0y2C1JFnLNUjqX5nY1rgRfvz X-Received: by 2002:a05:6a00:cc3:b0:82f:8696:5a75 with SMTP id d2e1a72fcca58-8415f66d98bmr25732951b3a.28.1779936538776; Wed, 27 May 2026 19:48:58 -0700 (PDT) Received: from [127.0.0.1] ([116.80.91.208]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841f3cbcddbsm366877b3a.4.2026.05.27.19.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 19:48:58 -0700 (PDT) From: Cunlong Li Date: Thu, 28 May 2026 10:48:45 +0800 Subject: [PATCH v3 2/2] zram: drop unused bio parameter from write helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260528-zram-v3-2-cab86eef8764@gmail.com> References: <20260528-zram-v3-0-cab86eef8764@gmail.com> In-Reply-To: <20260528-zram-v3-0-cab86eef8764@gmail.com> To: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Andrew Morton , Yisheng Xie Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cunlong Li X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779936530; l=2072; i=shenxiaogll@gmail.com; s=20260517; h=from:subject:message-id; bh=tYP7A1cG5Idkt7RgPNKfx9ASoxRRbHTZbBSShzPi2BY=; b=WvOxxhTWOQZ0Yi6BKmdrNNVLoeyNrSBLlOQFAQZmliPst4oSeJu5PmPvbZkCbV22dwIAslJsy 19Hz8Yf/4tjCiI+KF2iqOv5oC/O2lF3YZmkbnllf0Fq2fhIawrNP7PU X-Developer-Key: i=shenxiaogll@gmail.com; a=ed25519; pk=SKFifnqPdsvsjuhUiq+Y9vtCdhyZ/LrRcfYn8eRq6AE= After the previous fix, zram_bvec_write_partial() always passes NULL to zram_read_page() and no longer needs the parent bio. Mirror the read side (zram_bvec_read_partial() has not taken a bio since commit 4e3c87b9421d ("zram: fix synchronous reads")) and drop the parameter from zram_bvec_write_partial() and zram_bvec_write(). No functional change. Reviewed-by: Christoph Hellwig Reviewed-by: Sergey Senozhatsky Signed-off-by: Cunlong Li --- drivers/block/zram/zram_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index b23a8bbb687c..66347915a2cc 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -2325,7 +2325,7 @@ static int zram_write_page(struct zram *zram, struct = page *page, u32 index) * This is a partial IO. Read the full page before writing the changes. */ static int zram_bvec_write_partial(struct zram *zram, struct bio_vec *bvec, - u32 index, int offset, struct bio *bio) + u32 index, int offset) { struct page *page =3D alloc_page(GFP_NOIO); int ret; @@ -2343,10 +2343,10 @@ static int zram_bvec_write_partial(struct zram *zra= m, struct bio_vec *bvec, } =20 static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, - u32 index, int offset, struct bio *bio) + u32 index, int offset) { if (is_partial_io(bvec)) - return zram_bvec_write_partial(zram, bvec, index, offset, bio); + return zram_bvec_write_partial(zram, bvec, index, offset); return zram_write_page(zram, bvec->bv_page, index); } =20 @@ -2743,7 +2743,7 @@ static void zram_bio_write(struct zram *zram, struct = bio *bio) =20 bv.bv_len =3D min_t(u32, bv.bv_len, PAGE_SIZE - offset); =20 - if (zram_bvec_write(zram, &bv, index, offset, bio) < 0) { + if (zram_bvec_write(zram, &bv, index, offset) < 0) { atomic64_inc(&zram->stats.failed_writes); bio->bi_status =3D BLK_STS_IOERR; break; --=20 2.30.2