From nobody Mon Jun 8 16:29:07 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF123126D0; Thu, 28 May 2026 03:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940019; cv=none; b=WEfp0Iawb/G7W0UUN1m/yKH6xGbKOXF15TTmfF4PEzKZmx2dSO315yEnssieY3AR3j5W5QpRs1Ru7Yiyxl/0mMko5c7mIHU52Qpoi7mMKtlaxjhQgouPAKlHj3ikOBDQ9O4qfAhf/Qgk8nCGfuV/fxCTGGD2tS+OgwEYA0CBFYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940019; c=relaxed/simple; bh=XAYwosETQlgTdWFDYwvk1cIdE1sPk2gmVdWmA3M7CUE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=K6/58qOMc144IPt0T232IxF1eGhP0aKsZxuwtVMdUm3pMS7bv498At+ze1cylvnHjdafc/VEW51sV+zmesS/Iqq6oJoGrWX4N1CPjjOCctN143H2eDqAJe+hr7mTWDe9ewqkT6Lb+BzPhQ3lMk02TyZJpsGyeiefqbuDOgkv1GM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=ecgDFNMl; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="ecgDFNMl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1779940019; x=1811476019; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=XAYwosETQlgTdWFDYwvk1cIdE1sPk2gmVdWmA3M7CUE=; b=ecgDFNMlkHFr3ANqsIGGUZaIdEQdJiGAeBY0d9vVKHNDyeJVdns90vtM lH9RWILLETqevdXcluEEmGr0FqIFYtgjkiWlZRB0ikc/osdiO5o76rWXZ 0v9ADRBQAjG4NnGMd7EX+b87mcRy1gjrXYisNmdxG1VhzM7isITR2a7xR PDFBWhP4XHZSDsYu2r2f5gWLOl2Tca9eZQAllpIoGjFRgKzVQesUiR3je gCCd2Rz9avkuIvJcult14HkRnv/hb+XVbfpj5aiULCsfVVV7I4IzUHLZ4 xng6ugUGd6mxvMKhVA2HP4woXw3v2NDuAUv6Tm+tdM9g7F6ihtryv8fiu Q==; X-CSE-ConnectionGUID: QqRB4jt9Rnec6qn95pzP2g== X-CSE-MsgGUID: mEsV2YGsQn2Iq6l9+eToTQ== X-IronPort-AV: E=Sophos;i="6.24,172,1774335600"; d="scan'208";a="289548683" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 May 2026 20:46:53 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Wed, 27 May 2026 20:46:51 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 27 May 2026 20:46:48 -0700 From: Balakrishnan Sambath Date: Thu, 28 May 2026 09:16:44 +0530 Subject: [PATCH 1/4] rtc: palmas: convert to dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-1-29dc9cb6c3f0@microchip.com> References: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> To: Alexandre Belloni , Baolin Wang , Chunyan Zhang , "Orson Zhai" CC: , , "Balakrishnan Sambath" X-Mailer: b4 0.14.3 Use dev_err_probe() in place of dev_err() and return, which communicates the error type and helps debugging hardware issues. No functional change. Signed-off-by: Balakrishnan Sambath --- drivers/rtc/rtc-palmas.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index aecada6bcf8..25fe7a8b73a 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -242,10 +242,8 @@ static int palmas_rtc_probe(struct platform_device *pd= ev) =20 /* Clear pending interrupts */ ret =3D palmas_clear_interrupts(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "clear RTC int failed, err =3D %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "clear RTC int failed\n"); =20 palmas_rtc->dev =3D &pdev->dev; platform_set_drvdata(pdev, palmas_rtc); @@ -280,10 +278,8 @@ static int palmas_rtc_probe(struct platform_device *pd= ev) ret =3D palmas_update_bits(palmas, PALMAS_RTC_BASE, PALMAS_RTC_CTRL_REG, PALMAS_RTC_CTRL_REG_STOP_RTC, PALMAS_RTC_CTRL_REG_STOP_RTC); - if (ret < 0) { - dev_err(&pdev->dev, "RTC_CTRL write failed, err =3D %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "RTC_CTRL write failed\n"); =20 palmas_rtc->irq =3D platform_get_irq(pdev, 0); =20 @@ -292,18 +288,15 @@ static int palmas_rtc_probe(struct platform_device *p= dev) &palmas_rtc_ops, THIS_MODULE); if (IS_ERR(palmas_rtc->rtc)) { ret =3D PTR_ERR(palmas_rtc->rtc); - dev_err(&pdev->dev, "RTC register failed, err =3D %d\n", ret); - return ret; + return dev_err_probe(&pdev->dev, ret, "RTC register failed\n"); } =20 ret =3D devm_request_threaded_irq(&pdev->dev, palmas_rtc->irq, NULL, palmas_rtc_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT, dev_name(&pdev->dev), palmas_rtc); - if (ret < 0) { - dev_err(&pdev->dev, "IRQ request failed, err =3D %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "IRQ request failed\n"); =20 return 0; } --=20 2.34.1 From nobody Mon Jun 8 16:29:07 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83316301472; Thu, 28 May 2026 03:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940022; cv=none; b=OYlBm0g1rB0bvEgPt/VWwlW4VUtzmQkqBiuTgi5ZI6iU0VIjBwhZom0osUJt5T2MNyZy8sosBd9rpJ1MPyYNWvk5TrGeMS6Jh+PnITocer+d18/n2QlvTObWSZfRU6ALvMsohGQ2iHynnD5hHH20Ub0AxSM4WbAYEPWj9RJTzSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940022; c=relaxed/simple; bh=qYgQsEk3n99i/U85hwk5jhpAZurLiXSldhvkeh96t6Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=r4lu+sS1kJtszRCPqCALdY8R8yBya+BmsQz5ra+VgYmqSPIaA/e9KOhEtUl+1sQUJlBIfOEnG63CtUNYCB+7pDynF2USnux1S6Pe8zi9TMHhFomuqf0jj4yG3MMjZoLEKZiUUxLA9yL3ATM3qACJACFGgowu/1SJkr+W2825jdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=wxOvI3kd; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="wxOvI3kd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1779940021; x=1811476021; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=qYgQsEk3n99i/U85hwk5jhpAZurLiXSldhvkeh96t6Q=; b=wxOvI3kda/p0gpzhyVKIciUZ7Rmvge/ElM4E7aUmTrjVa1wQWOQqJU4f U+YQTCoAm+ZFLCg3eCEUtVYD1gOkJ83oetDV/Gr1KzmWtNoZm3Kk6XTfv INj+uMXj9Gp4TBOXE75dfcU3FhfYXD52yteNDU7MDFVfD5Lv4zidT6jLL k3SaEnWfCIdP1UidXxgfAfeZvQUB2wVrggLs2nJKOF+/LtgrDdbVuo1NU aMKrgCWhLKYWXPV5JlFpUjxAnz23OSRvO5hNUjUNioEn6yFkgcl0zxrjL /G0Pwo/9y4y/ZtW16AayPKJSUyEmbAcxfgJL+hyBdEx1Iv7yRDPEsAkyp w==; X-CSE-ConnectionGUID: zqfwHDKVSeu+1EmyMnmlVg== X-CSE-MsgGUID: snKCs0atRe+0gv5L7W+OXQ== X-IronPort-AV: E=Sophos;i="6.24,172,1774335600"; d="scan'208";a="225400142" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2026 20:46:54 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.87.71) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.41; Wed, 27 May 2026 20:46:54 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 27 May 2026 20:46:51 -0700 From: Balakrishnan Sambath Date: Thu, 28 May 2026 09:16:45 +0530 Subject: [PATCH 2/4] rtc: moxart: convert to dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-2-29dc9cb6c3f0@microchip.com> References: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> To: Alexandre Belloni , Baolin Wang , Chunyan Zhang , "Orson Zhai" CC: , , "Balakrishnan Sambath" X-Mailer: b4 0.14.3 Use dev_err_probe() in place of dev_err() and return, which communicates the error type and helps debugging hardware issues. No functional change. Signed-off-by: Balakrishnan Sambath --- drivers/rtc/rtc-moxart.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-moxart.c b/drivers/rtc/rtc-moxart.c index 2247dd39ee4..e1766f03d73 100644 --- a/drivers/rtc/rtc-moxart.c +++ b/drivers/rtc/rtc-moxart.c @@ -253,26 +253,20 @@ static int moxart_rtc_probe(struct platform_device *p= dev) moxart_rtc->gpio_data =3D devm_gpiod_get(&pdev->dev, "rtc-data", GPIOD_IN); ret =3D PTR_ERR_OR_ZERO(moxart_rtc->gpio_data); - if (ret) { - dev_err(&pdev->dev, "can't get rtc data gpio: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "can't get rtc data gpio\n"); =20 moxart_rtc->gpio_sclk =3D devm_gpiod_get(&pdev->dev, "rtc-sclk", GPIOD_ASIS); ret =3D PTR_ERR_OR_ZERO(moxart_rtc->gpio_sclk); - if (ret) { - dev_err(&pdev->dev, "can't get rtc sclk gpio: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "can't get rtc sclk gpio\n"); =20 moxart_rtc->gpio_reset =3D devm_gpiod_get(&pdev->dev, "rtc-reset", GPIOD_ASIS); ret =3D PTR_ERR_OR_ZERO(moxart_rtc->gpio_reset); - if (ret) { - dev_err(&pdev->dev, "can't get rtc reset gpio: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "can't get rtc reset gpio\n"); =20 spin_lock_init(&moxart_rtc->rtc_lock); platform_set_drvdata(pdev, moxart_rtc); @@ -280,10 +274,9 @@ static int moxart_rtc_probe(struct platform_device *pd= ev) moxart_rtc->rtc =3D devm_rtc_device_register(&pdev->dev, pdev->name, &moxart_rtc_ops, THIS_MODULE); - if (IS_ERR(moxart_rtc->rtc)) { - dev_err(&pdev->dev, "devm_rtc_device_register failed\n"); - return PTR_ERR(moxart_rtc->rtc); - } + if (IS_ERR(moxart_rtc->rtc)) + return dev_err_probe(&pdev->dev, PTR_ERR(moxart_rtc->rtc), + "devm_rtc_device_register failed\n"); =20 return 0; } --=20 2.34.1 From nobody Mon Jun 8 16:29:07 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED41D2DF12F; Thu, 28 May 2026 03:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940024; cv=none; b=ScdEwsI7VQxbJpMCcnD5SSDAAZNfDDO1Y4BUYyDg2yK9FkUV1+v1TG0TzZqTxa/kt6YiHZMgc3SbJ/C3RJoomoWEvc24n/hZlFGpP+/c6SfpXBR7Crz0FtEhZGZcPEKu/CE/h0xQZP3ezln2+Rsatr44TeBILZCHTY/rUGm5Xis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940024; c=relaxed/simple; bh=N/+7UgqP3hDoMpdcWGIoFqQQDTgfq+jlToGKPISYtQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=GCzeqecQZvu4B2fT5K6DwH4DIclkixp4SJbhkw5ipuEVAu+yFGPhf3FYp4RETusDpigjJgNbvu1nAvy55sFTqw5ow1P+YWGBRXlq/swmgy4smDOX7SSTG5un4cw5vQC1JJABUtls9USMRZio/5NbC7lGdtwoVO4SRW0mpI8+5uQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=S8wUAJds; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="S8wUAJds" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1779940022; x=1811476022; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=N/+7UgqP3hDoMpdcWGIoFqQQDTgfq+jlToGKPISYtQw=; b=S8wUAJds8oBe7J8cpusYX6x0yyj/+6NgvMjmR3lVmQsRHtn800BUfO1C xxzbHzK/fioS2mJG+diY4BNfYTkDTQqi11pm7NP3xAEwaoKvrMv2AQSVt /MuOrdEXWB1PUDUUqigVl6SxyfDzZUNTzO1JFc2kFR20EEVS3lPe00xDX 0GexkodtnnNNtoyLHvwu5moBG17ok0uOT1tPuwBa5Y49qRw2vdIdphIpV yRYyL+Edkzg0wa9fnXJ5qhC+CPOo8KA/WxayWl/8GC7kZGvlU1f8u+0UH reZZ1isa8oL1EZVS2GyfDz33POEMjqjJ038Wpzvj+gOvM6VwVvlz1TmnR w==; X-CSE-ConnectionGUID: g5WiT7AxRUSGqWE/rya/Jg== X-CSE-MsgGUID: jGORMBdnRS6eUJhIYGtpGQ== X-IronPort-AV: E=Sophos;i="6.24,172,1774335600"; d="scan'208";a="225400144" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2026 20:47:00 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.87.71) by chn-vm-ex2.mchp-main.com (10.10.87.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.41; Wed, 27 May 2026 20:46:58 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 27 May 2026 20:46:55 -0700 From: Balakrishnan Sambath Date: Thu, 28 May 2026 09:16:46 +0530 Subject: [PATCH 3/4] rtc: sc27xx: convert to dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-3-29dc9cb6c3f0@microchip.com> References: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> To: Alexandre Belloni , Baolin Wang , Chunyan Zhang , "Orson Zhai" CC: , , "Balakrishnan Sambath" X-Mailer: b4 0.14.3 Use dev_err_probe() in place of dev_err() and return, which communicates the error type and helps debugging hardware issues. No functional change. Signed-off-by: Balakrishnan Sambath --- drivers/rtc/rtc-sc27xx.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c index 2b83561d4d2..2c6d4565389 100644 --- a/drivers/rtc/rtc-sc27xx.c +++ b/drivers/rtc/rtc-sc27xx.c @@ -574,10 +574,8 @@ static int sprd_rtc_probe(struct platform_device *pdev) return -ENODEV; =20 ret =3D of_property_read_u32(node, "reg", &rtc->base); - if (ret) { - dev_err(&pdev->dev, "failed to get RTC base address\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to get RTC base address\n"= ); =20 rtc->irq =3D platform_get_irq(pdev, 0); if (rtc->irq < 0) @@ -592,26 +590,20 @@ static int sprd_rtc_probe(struct platform_device *pde= v) =20 /* check if we need set the alarm interrupt */ ret =3D sprd_rtc_check_alarm_int(rtc); - if (ret) { - dev_err(&pdev->dev, "failed to check RTC alarm interrupt\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to check RTC alarm interru= pt\n"); =20 /* check if RTC time values are valid */ ret =3D sprd_rtc_check_power_down(rtc); - if (ret) { - dev_err(&pdev->dev, "failed to check RTC time values\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to check RTC time values\n= "); =20 ret =3D devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, sprd_rtc_handler, IRQF_ONESHOT | IRQF_EARLY_RESUME, pdev->name, rtc); - if (ret < 0) { - dev_err(&pdev->dev, "failed to request RTC irq\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "failed to request RTC irq\n"); =20 device_init_wakeup(&pdev->dev, true); =20 --=20 2.34.1 From nobody Mon Jun 8 16:29:07 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 836993101B0; Thu, 28 May 2026 03:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940024; cv=none; b=d6gJ+WV+jGZJ0Z0t1+R0IwXqA1nIEWjDOdR3RnaesifagVkR82zFvBrSDUear3dxlUweeQY4fsQIg5nQq0mxukmRtYr7MH9Ljj70e2FYNo0D7XjoHUKu0qH06ELPZNIrDzXgR3nSlP1yX/RGnHe7bUxROdV7Yh3dyycuT70dVs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940024; c=relaxed/simple; bh=YOdoUxfSBsws3SKNn9de0Uhyko5jGF5YH0WJr5ohLrA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=WjxsDDYVrZR8QEL9VLCtlTH4Ovdv91L3abmZ9uVrQs/clgx9VNY+x8GuLudrfUpi2KxQ4bt8/fpTknulhG9q02ZuJEjfLI/In/qUTVheW7PE4N0Fsrp3hDqoOWFBcpJlYia2Tu/rYuDNEeVZFirLUv50gNvBPkZGcIp1bwklvCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=sMXU3dbF; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="sMXU3dbF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1779940023; x=1811476023; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=YOdoUxfSBsws3SKNn9de0Uhyko5jGF5YH0WJr5ohLrA=; b=sMXU3dbFxQynHHjgxeVqR8c0L6Is80lPTZ0a7gvKMR8MPacF1Nn/qwW+ HAbRDXplURsLRXOlSeanLUWHNKwOPGZ8bbb4FwNUif67rYUZuAZuz0MyB x1htTC9vp3MEizCTl9P2ZRODo959qBers/ES0YQCVUm5msRW7CVHweZX9 98AYrSuvrfgl1K3Yl9ERahQ1yNp8zvNveGXeixymjHVcOQROiixKdRULm 6gyu17143De3V5qO/k9xkhgWAVYOCbePq0NZ0nHFdUaaB35PUuOoee6Dc xicV0oVFYtmUTZFndHEUARTJQIyHh6OQhSGdAmEe0fFhh4U+GGXRuXO3e A==; X-CSE-ConnectionGUID: vXzvNFDVSBG0BleE8SWlBQ== X-CSE-MsgGUID: k2aDQVdFQrG0glp5rs4w2w== X-IronPort-AV: E=Sophos;i="6.24,172,1774335600"; d="scan'208";a="58160225" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 May 2026 20:47:03 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Wed, 27 May 2026 20:47:02 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 27 May 2026 20:46:59 -0700 From: Balakrishnan Sambath Date: Thu, 28 May 2026 09:16:47 +0530 Subject: [PATCH 4/4] rtc: s35390a: convert to dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-4-29dc9cb6c3f0@microchip.com> References: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> To: Alexandre Belloni , Baolin Wang , Chunyan Zhang , "Orson Zhai" CC: , , "Balakrishnan Sambath" X-Mailer: b4 0.14.3 Use dev_err_probe() in place of dev_err() and return, which communicates the error type and helps debugging hardware issues. No functional change. Signed-off-by: Balakrishnan Sambath --- drivers/rtc/rtc-s35390a.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index a4678d7c6cf..342fd2b568a 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -479,10 +479,8 @@ static int s35390a_probe(struct i2c_client *client) return PTR_ERR(rtc); =20 err_read =3D s35390a_read_status(s35390a, &status1); - if (err_read < 0) { - dev_err(dev, "error resetting chip\n"); - return err_read; - } + if (err_read < 0) + return dev_err_probe(dev, err_read, "error resetting chip\n"); =20 if (status1 & S35390A_FLAG_24H) s35390a->twentyfourhour =3D 1; @@ -493,16 +491,12 @@ static int s35390a_probe(struct i2c_client *client) /* disable alarm (and maybe test mode) */ buf =3D 0; err =3D s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, &buf, 1); - if (err < 0) { - dev_err(dev, "error disabling alarm"); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, "error disabling alarm"); } else { err =3D s35390a_disable_test_mode(s35390a); - if (err < 0) { - dev_err(dev, "error disabling test mode\n"); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, "error disabling test mode\n"); } =20 device_set_wakeup_capable(dev, 1); --=20 2.34.1