From nobody Mon Jun 8 17:39:44 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADD0E2F8EA8 for ; Wed, 27 May 2026 20:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779914961; cv=none; b=srN/cqb7iQdZqT1a11iSXeLWNDZzCLGeaEMP2zoXpehGYCVqVMDI5ZXHnSv3Zf2Nl7kviWXsjjUqTDT7ZZKEsOR4uC8xHst39VatdfdCW0kR56zez/971z/wrTwnBn7F0VatSbmZX8Fl6o48HdMNkoXpACEHHJoYSkHlehuEmns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779914961; c=relaxed/simple; bh=VsdewHrfyM1OB5PbLkZoKTT4C0UoQIFfqmJtDMEkuPs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UunCkhZD3hdS44XLUGKgrFOtgh4LYlAgVeH6W31omRYLUHVT2PDXaMDszdspMuNc5Ib/ywMrtQAdFI466nkLkUrZslB55Nyqx2l+B8Zsopzol6E59kghchZIWe38amQ3p3vZS4VO8EjaXbWoTpfjpgbiff5G6qiDHKzjICpug6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vf9gKutT; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vf9gKutT" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-304cd7d4083so910806eec.0 for ; Wed, 27 May 2026 13:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779914960; x=1780519760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fwNtECTzFRXLQthh6lLs9kTrIJ5zoyeP+dHYl7xj4JY=; b=Vf9gKutTHo/e6A32JL99mluboh/bXj3OrGDo4NdcMOpZEGbVOr4XD9ocSpak8VibqU zQtfpViAebfnrszHyxdqpyDLQrW+ri+fU8ZENkD2lgJNuuNYQfHfut8OyiK5nc2A6y7v XYtDv6ndHH2sB/agqY1cggCBCNNYSz/z6vT+882PCHBZkzhWqu6UrxKLZtuqEOmn+Rcq ++mEj2obPPBwZA5nnn/16oWdVpcYjLTzKzTll+fEFmXENBmsAyjbqLLvpaJqOsNae6ZC GOWq0nv7Y3Q5xnsk1QcX2vlPnSSetHDCbiWknszLmHJZwTmyMn3MU+UX0wZkJ6uYVN5O SwxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779914960; x=1780519760; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fwNtECTzFRXLQthh6lLs9kTrIJ5zoyeP+dHYl7xj4JY=; b=E03uu2RbxuCr1NIhA71J9R6QnCxASHeVcgM7yfJo0CwVGMC4BumSMQMAh3nFw7C4/k GhzIjQkhYIB8+QTowq4YFn1BjzmFG2QayKSriVg175ZnRsyLKX48Xs2voMozo1r2BejS xLmV6axiNzwKYai3nptDYMghaOwSw0SkMhoSE0WjloRnACNhXbOmAHbi4py1TZ/L2AtD s5DgLxVL+nz0aP9a4FQvPhc9gJD6U9XTgaWpaBZqaqV1Z4firSwwzl/o+qjIJGv2hTZ5 4P7Ih/UIGglVYoCWD9fz3WnP7x5z6vqvtY/06zC8pZepmWibifDe05frWYBECm/tjc9T n6SQ== X-Forwarded-Encrypted: i=1; AFNElJ83TG4UiEGlrFrTgFufcm2b5vy0eZLMr0Gc2cH7obRq7CllefLcIKDyBBDUDujiR2nHlpYPLgiiyKjPCe4=@vger.kernel.org X-Gm-Message-State: AOJu0YzdSJMojIe2/lCpq+0Fkrh24myt3iXUvJ/zU7gzZoaAPH6A8OYQ kzS5sqy/sFYFTNUdHMmlwyaTCMma8IizouVHbr51L86SAzd19Xt2ETNP X-Gm-Gg: Acq92OHp+uvgZ7XDuGnVgDH6/76QbVQtLPpZQ+BJJTAvYaX8bO2LlrvERiWy/Tu1rUV gjdyVXOrG/843lwu2OjOjd4m4IDIXDAPlETqgnpcYKMK+wKrQ5DyFFdNCaS1HKrYASrU16cveWM 0hAB0whVo48HlaVko11nNAiEciaJcFJoeGcyiaXHjyHrHBZ+yevfV8HPJiIRDaf0OkMytdvhHVl K473lLH3M9mKfTAKIzeHipiyfhmjPV8qMUqLqZ0qSd1sHNtlEadxDmIaJTqIACaBs1SKVzxD9xv TQYdDfd3prUcAkpJO9Gr6YJzf+xwkDcxWhszvZGETeHwIyYuDYK/6IWrEPUP2uAnraume4DlzP4 BkP557D50swdRhvTMZuTHSqQ/+FLccOIZgpuYKBQ+MePHRnGp6gkiYUz+3XkreSHqdHjMl6rM5x 5BBn/HMG43jhb/j1OOWjrF0v2b0br//qxVqR5N X-Received: by 2002:a05:7300:cb86:b0:2ed:e16:6b4a with SMTP id 5a478bee46e88-304491ebd02mr12205186eec.32.1779914959603; Wed, 27 May 2026 13:49:19 -0700 (PDT) Received: from arch-btw.lan ([76.174.70.235]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30452230f1bsm13515105eec.14.2026.05.27.13.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 13:49:19 -0700 (PDT) From: tonybanters To: Dave Penkler Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter , stable Subject: [PATCH] gpib: ines: fix I/O region leak in ines_isa_attach() error path Date: Wed, 27 May 2026 13:46:37 -0700 Message-ID: <20260527204637.1315591-1-tonybanters@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If request_irq() fails after request_region() has succeeded, ines_isa_attach() returns without releasing the I/O region. This leaks the region and prevents a subsequent attach attempt from acquiring it. Release the region on the failure path. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202605271229.d8wGTffx-lkp@intel.com/ Fixes: e6ab504633e4 ("staging: gpib: Destage gpib") Cc: stable Signed-off-by: tonybanters --- drivers/gpib/ines/ines_gpib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c index c000f647fbb..cb6ee6882a0 100644 --- a/drivers/gpib/ines/ines_gpib.c +++ b/drivers/gpib/ines/ines_gpib.c @@ -911,6 +911,7 @@ static int ines_isa_attach(struct gpib_board *board, co= nst struct gpib_board_con nec7210_board_reset(nec_priv, board); if (request_irq(config->ibirq, ines_pci_interrupt, isr_flags, DRV_NAME, b= oard)) { dev_err(board->gpib_dev, "failed to allocate IRQ %d\n", config->ibirq); + release_region(config->ibbase, ines_isa_iosize); return -1; } ines_priv->irq =3D config->ibirq; --=20 2.54.0