From nobody Mon Jun 8 17:38:56 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF7839B498 for ; Wed, 27 May 2026 17:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779902162; cv=none; b=LCfW+O6hdmtEGj4HxTBNSCsm567F0+mIGgh3KvjQhD+Ru+lesDRgY8ozvwGGl5mdrR+vkTJ39d5oFsO2QnWsIumWsSpS/eWS7TnmZIwjJr8yCvwWMRz49mFwuPJyzP3VBHCMo0RDnvlYBQL3FDjBqzfZG8Zp+3n6WDxzkauHTxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779902162; c=relaxed/simple; bh=2JQZxwBIF2ov8gE3PJoRyVQfnmmKpInSArWNiCRiODw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UjpnJ2H3NO7Jk0MCWewAiZANXvUDkovavVE6U9Ka7yof1zjnV55RID4+kJ/3dwRHcYUknw4ibY5+aAau4DcTz0nxAzxl7evbyY2fBeKN6S7+TR1ZKA4yz3d3zkOcV7SscXds+mVBPVYt8pmWLV0xEcvXD2PYciqMPMpY0cD9Ae4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AI7Va69F; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AI7Va69F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779902160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sVR4w/bJZ+gLns5rGEscxsF0pfUh38oD7KsVlfT+LAc=; b=AI7Va69F4E/RtCrz51KypbZAP+OpCh9tPwJMr3yYvxib3UZGjPuwOcju8i/7PI92SkBHWQ qeR4J/S5Yz7quf8yl8CxfVpfOSerQwrvuyS6bBpOjgcv1UbQHMxY0uhmhyT3xYdGyqmnxh DZIWR/PNf/QWfFceqqPfQ6isfHIt2Uw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-e4mBIj0yMaafX_Wq_lFkRw-1; Wed, 27 May 2026 13:15:55 -0400 X-MC-Unique: e4mBIj0yMaafX_Wq_lFkRw-1 X-Mimecast-MFC-AGG-ID: e4mBIj0yMaafX_Wq_lFkRw_1779902153 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B778180060D; Wed, 27 May 2026 17:15:53 +0000 (UTC) Received: from GoldenWind.lan (unknown [10.22.81.166]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EC2EC180034E; Wed, 27 May 2026 17:15:51 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nova-gpu@lists.linux.dev Cc: "Alexandre Courbot" , linux-kernel@vger.kernel.org, "Simona Vetter" , "Alice Ryhl" , "David Airlie" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH] gpu: nova-core: vbios: Fix clippy error in Vbios::new() Date: Wed, 27 May 2026 13:15:21 -0400 Message-ID: <20260527171521.2406456-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" From clippy: error: this `if` can be collapsed into the outer `match` --> drivers/gpu/nova-core/vbios.rs:328:21 | 328 | / if pci_at_image.is_none() { 329 | | pci_at_image =3D Some(PciAtBiosImage::try= _from(image)?); 330 | | } | |_____________________^ | There should be no functional changes in this patch. Signed-off-by: Lyude Paul --- drivers/gpu/nova-core/vbios.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs index c0bc1008ed752..d38d7f138b49d 100644 --- a/drivers/gpu/nova-core/vbios.rs +++ b/drivers/gpu/nova-core/vbios.rs @@ -323,11 +323,9 @@ pub(crate) fn new(dev: &device::Device, bar0: &Bar0) -= > Result { =20 // Convert to a specific image type match BiosImageType::try_from(image.pcir.code_type) { - Ok(BiosImageType::PciAt) =3D> { + Ok(BiosImageType::PciAt) if pci_at_image.is_none() =3D> { // Silently ignore any extra PCI-AT images. - if pci_at_image.is_none() { - pci_at_image =3D Some(PciAtBiosImage::try_from(ima= ge)?); - } + pci_at_image =3D Some(PciAtBiosImage::try_from(image)?= ); } Ok(BiosImageType::FwSec) =3D> fwsec_section =3D Some(image= .data), _ =3D> { base-commit: 2cf1840b0fa7637b6731fd554529f8d57ea34c04 --=20 2.54.0