From nobody Mon Jun 8 18:57:49 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368073E3D86; Wed, 27 May 2026 10:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779878328; cv=none; b=dpcNRcuXxFAR+ppkFpqUIJxoYr43a8cAb7Lt4XdPiKm5yqfM6m9VKili0p8D6tBA6MSUE0mym7Jsn4ym/pkKN/a+79yZkFHJfw8e7NF1NSMklXZv40eOj3dI/t1kSNdUTsFdk3HRMBmSxCRMtjZ+KpFArr6AeUw3fciyk6K4sKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779878328; c=relaxed/simple; bh=xvVfFGqu0pRxJc8OdISO4s9Ig358JwKumzrKecXeUX8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=In/EFu0zB4zoeYKf8I3kGU+EMSRJEAKp48pb9Opo72XCRpdSn7bUxG13HusUf4DMQu5eKt7XCvaFMjytatWzr4kFtcj8UbjiPYm1G/w+MY2tnOkdVbn1nL9VCqcrajLUlgxCbOqu6rNmtoiBCByGcyYtpnGawyDSTER8ujrywkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.3]) by APP-05 (Coremail) with SMTP id zQCowAD3fACuyRZq6N+LEQ--.1041S2; Wed, 27 May 2026 18:38:38 +0800 (CST) From: Wentao Liang To: "Martin K . Petersen" Cc: Kees Cook , Wentao Liang , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] target: iscsi: cxgbit: fix cnp kref leak in __cxgbit_free_cdev_np() Date: Wed, 27 May 2026 10:38:23 +0000 Message-Id: <20260527103823.869792-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAD3fACuyRZq6N+LEQ--.1041S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tF47Wr1xZr4kZr1UArWfuFg_yoW8Gw4rpF 40kFyUJr1UJ3y3Kr18Jw4I9FyxZanIyrW3C348CwsY9w4Y9ryDKFyayw42qay5Crykur43 Xan8AryUGryqy37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkl14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjJ73PUUUU U== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwwAA2oWirr+lwAAst Content-Type: text/plain; charset="utf-8" __cxgbit_free_cdev_np() calls cxgbit_get_cnp() which takes a kref reference on the cnp structure. This reference is only released on the immediate error path after cxgbit_get_cnp(). On the timeout path and the normal completion path that successfully processes the NP, the reference is never released via cxgbit_put_cnp(), leaking the kref. Add cxgbit_put_cnp(cnp) on the timeout and success paths to properly release the kref reference. Cc: stable@vger.kernel.org Fixes: 9730ffcb8957 ("cxgbit: add files for cxgbit.ko") Signed-off-by: Wentao Liang --- drivers/target/iscsi/cxgbit/cxgbit_cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi= /cxgbit/cxgbit_cm.c index 146705845fa3..11149d73c844 100644 --- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c +++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c @@ -545,6 +545,7 @@ __cxgbit_free_cdev_np(struct cxgbit_device *cdev, struc= t cxgbit_np *cnp) ret =3D cxgbit_wait_for_reply(cdev, &cnp->com.wr_wait, 0, 10, __func__); if (ret =3D=3D -ETIMEDOUT) + cxgbit_put_cnp(cnp); return ret; =20 if (ipv6 && cnp->com.cdev) { @@ -558,6 +559,7 @@ __cxgbit_free_cdev_np(struct cxgbit_device *cdev, struc= t cxgbit_np *cnp) =20 cxgb4_free_stid(cdev->lldi.tids, stid, cnp->com.local_addr.ss_family); + cxgbit_put_cnp(cnp); return 0; } =20 --=20 2.34.1