From nobody Mon Jun 8 18:57:48 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5079F3ED131 for ; Wed, 27 May 2026 09:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874743; cv=none; b=IW7CrOCe0avv2F4fMXd0qc7dNPz7wJaxj8xaAOtLqeTVCfxx4V3BXnAC8RxgTP5CjsVCwakeGYO9aeEhS6EzOTlIaeZdY7Oz8JhBAZXfjy/DV4MMAXA1zkYUGIIGkV2rcHAPhdryZWFYt0KVy+JhwUIT25zfLDro1mDUNWboDcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874743; c=relaxed/simple; bh=A1N9Y52zTiSYc1bbNxrS6CLuUh+j9rBK6m1Zr4M48iw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jReU6ICAdJCleKkOhwMT4TZrjw023+sLN1Y4RoQ8dEApnFdCVRDxFZ+IPQo/SfskXfSpcjNL8D05h636T2L06c+ipto3MHqBwVgxBzTg0ophboS20TM6oHw3t9kxBbuksOcM9jEjXzL79MDARoAcIFqfjQsyqWjIwpItbAjWR1g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AWVHpNae; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AWVHpNae" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-83ec36a13e9so5777258b3a.0 for ; Wed, 27 May 2026 02:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779874737; x=1780479537; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HS4tjMUUPzdQI9FfsCJLiT+3MeEnWLUL65FPiz1EwZI=; b=AWVHpNae1ITJ7CwMThcm3tjVsIo7ULyTTtBSgQb2US8lFVWA/4LSXFNicZFauV5Eed OPJ+OOMEtPJJTb714dcw6Bosig0ryXU1GLyQ+muuorMnNJqccHzIKe1uRg0PahbldsFN 3OlnyW7dx1yCArozkIxm4h5lUAkttVn/zJasbFajIiMs8jKjqmom2ZHwE/U6xUvyFTAM bwKyI9b/zw1N/al/tvqC95ISlRGfozP2tsIr5wUpUwfRkVZLyLu1ISapNVJZLvjUgbQe O2/KHo4hH7tv8U0mSY4oiFQ+heGsJ4UDc7QrqyTq+MXItHy7HCyHcplqO0hjFWwSGIDx Ge5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779874737; x=1780479537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HS4tjMUUPzdQI9FfsCJLiT+3MeEnWLUL65FPiz1EwZI=; b=KvwmERNoc3oT4rDHQGI7bQB+wv2BQIsGXi9WqbpVW5+Lp7/AUhxshYiY3iM7jqzn81 no5r1RYl5rJu8aCbU3Nrd5Bj8V0tD/jXcyBwbPIdCpVGR4fTA6uMvb8xu4G/RvTNU/9z ZG89wWhXXofcq7AvrwucamdGZlEktyvtj1Z6cOGsST+iMeFu8qgA+QDXLL1wawwHz/Oc SguZCiStFYeiQxbsAK2bD1jdqWSpP2eaCqmEHCek4YGth1oZTzB4LPT36lqrz4y/Fi1d ubVmW6VRJ9ptsNbeOfRZRoasZOZE6e1Z1RVvzraZ3+5BI81PjDORuiWdDXH/NxvhRcoQ Mvwg== X-Forwarded-Encrypted: i=1; AFNElJ+l6u0J9yu+ZZzFzU9JqlggN+shFTpzQyUwIsohYooKsfTvQLJCP/8376v4AKQV0kAI4sWpTd8O+nBx/H8=@vger.kernel.org X-Gm-Message-State: AOJu0YxQUvmWDtN+JpFpH9xzrsSsXnWQUdeMMEgS7Bm65rIO6FGd9oRb Q9n0YIdcQyu4PSes6uhTCftZDZZPJV1pEaZ5s2AKJrDjKSN1me3jaZKN X-Gm-Gg: Acq92OGFu/sEhM+4e//LLQmOkBE4YSIlggKD8rBclfpGn03tO3clPHbSiN8FZI6ID4W 83IIipD47lJGXSflYr+teMb6tDN23tl50co1nMWEldZjJ4n1bwcUQdl9gIaXye1yITTyBGq/G51 K2CwCaiKDcq5kyqzrdoPh6B/oxqT0I4iPktVQR065aQSe/W1yo31vkAM0LvSnXMow66PPEL3MOh +HOTta5QpTdW36GxTZj01/J3oJSQ2eb1oxI+XXAvMUsRgIBtRDeKZwO3imrC1+uOYMtv73SbCFx 2a9QJW6zN/mxa/z9/QJArPcRyrUWS5BkXCoDKy3cY3PI/yz+dN+GC7gAnVgBpwgqK/CPX9sSbcx 0eWd/NNruBBHEUuJergcE8KaQjBRWKLZZR3ZoBmPv/ErXLO9N17rwuEmMQkc7Nqvpcbuk0pq+6h Nh/AZOLjuyBCmRQPYz35q1Raw15PblvJhMOrYONrBox47L/WvZEQTHMg== X-Received: by 2002:a05:6a00:2ea7:b0:82a:6852:559e with SMTP id d2e1a72fcca58-8415f3264femr21602701b3a.12.1779874736864; Wed, 27 May 2026 02:38:56 -0700 (PDT) Received: from VM-0-14-ubuntu.. ([124.156.198.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d72f6dc1sm1900974b3a.51.2026.05.27.02.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 02:38:56 -0700 (PDT) From: quzicheng315@gmail.com To: arighi@nvidia.com Cc: changwoo@igalia.com, emil@etsalapatis.com, enjuk@amazon.com, linux-kernel@vger.kernel.org, quzicheng315@gmail.com, quzicheng@huawei.com, sched-ext@lists.linux.dev, tanghui20@huawei.com, tj@kernel.org, void@manifault.com, zhangqiao22@huawei.com Subject: [PATCH v2] tools/sched_ext: Fix scx_show_state per-scheduler state reads Date: Wed, 27 May 2026 17:38:50 +0800 Message-ID: <20260527093850.3493647-1-quzicheng315@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zicheng Qu scx_show_state.py still reads scx_aborting and scx_bypass_depth as global symbols. Those symbols no longer exist after the state was moved into struct scx_sched, so the drgn script fails when it reaches either field. Read aborting and bypass_depth from scx_root instead. This preserves the script's current root-scheduler view: with sub-scheduler support, the reported values are for the root scheduler and sub-schedulers are not enumerated. Fixes: 5c8d98a1b4de ("sched_ext: Move bypass state into scx_sched") Fixes: c1743da43cf5 ("sched_ext: Move aborting flag to per-scheduler field") Signed-off-by: Zicheng Qu Reviewed-by: Andrea Righi --- v2: - Clarify that aborting and bypass_depth are reported for scx_root only, as Andrea pointed out. - Add Reviewed-by from Andrea. tools/sched_ext/scx_show_state.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/sched_ext/scx_show_state.py b/tools/sched_ext/scx_show_s= tate.py index 02e43c184d43..446d82807f90 100644 --- a/tools/sched_ext/scx_show_state.py +++ b/tools/sched_ext/scx_show_state.py @@ -27,18 +27,25 @@ def read_static_key(name): def state_str(state): return prog['scx_enable_state_str'][state].string_().decode() =20 +def read_root_ops_name(): + if root: + return root.ops.name.string_().decode() + return '' + +def read_root_field(name, default): + if root: + return getattr(root, name).value_() + return default + root =3D prog['scx_root'] enable_state =3D read_atomic("scx_enable_state_var") =20 -if root: - print(f'ops : {root.ops.name.string_().decode()}') -else: - print('ops : ') +print(f'ops : {read_root_ops_name()}') print(f'enabled : {read_static_key("__scx_enabled")}') print(f'switching_all : {read_int("scx_switching_all")}') print(f'switched_all : {read_static_key("__scx_switched_all")}') print(f'enable_state : {state_str(enable_state)} ({enable_state})') -print(f'aborting : {prog["scx_aborting"].value_()}') -print(f'bypass_depth : {prog["scx_bypass_depth"].value_()}') +print(f'aborting : {read_root_field("aborting", False)}') +print(f'bypass_depth : {read_root_field("bypass_depth", 0)}') print(f'nr_rejected : {read_atomic("scx_nr_rejected")}') print(f'enable_seq : {read_atomic("scx_enable_seq")}') --=20 2.43.0