From nobody Mon Jun 8 18:55:56 2026 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0935A3FC5DA for ; Wed, 27 May 2026 13:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779889288; cv=none; b=sBllHqu5742gzpjQOPRpgsHFEJOQopRnGIJOoS9qatty+25ycl1h6fk1N+tynjZ93S5BFbTvJ5F2K6igXpjCeJVJN9pOkzr/2drg90BVXe7i0jIzF8J5CDnrIBoapPexeR/mau8MuK604CNoYDjV7YftBEEI4zNKqQdSjDhfP44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779889288; c=relaxed/simple; bh=LeUS4h0dAZFMR118R/wSEgBwYTGlXM0bV41TWFIWpWU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=NLWS7VX7P4pH9FxxPePNrGdctnGqeClR1lCmrammv0KW/qUVv/ndmxECDMG70TR3VPhYbvQ6GYOvm4rcdwuOpX51fBlnxqiHOSuFNIbGWnwYBtfPRMClmbUSrtpFAZxZgPBzVd/o1dBiqwzsQYoHjiEJjtRm+/CGyp1y2JDFxuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QPzUUUfX; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QPzUUUfX" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-44a71109b94so7946691f8f.3 for ; Wed, 27 May 2026 06:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779889285; x=1780494085; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=EcF/LO4YfqSS2ARnboxZ+flFU1P58FX+oV9Y6yXSPGM=; b=QPzUUUfXNA75XB2cKHJro7FlP4gjZO2bWI6bFyFMkajWbV5sVWJGdV6/3T3s4lO06P ugAWMMMfdVopiZ81stH6mhrwFAmcu65vl4xP0c5dPSUDu7xa4DGEA/zaG9/ULGjzHbGa IbaPiBrOrRL7xJ/2G5xfibmn10AihfZCy0Ax3Rs5iYPiopmThfiD+fuDV87CPUIwp3DA VRu/iKvpDmD7T37w91gkliYCsWcHQ9Pfibi5AFHUM2U2TIdjqWcEW4DbiAvNySAZkSdx oF47gpPQwVO/Kq7td2dq+/ZDUOuqIjSHHN9x2eUyOCshiwc5I23uhj4Ik+2OCVOuNfH0 1xqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779889285; x=1780494085; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EcF/LO4YfqSS2ARnboxZ+flFU1P58FX+oV9Y6yXSPGM=; b=WoaQJMIri2xB/GueFyzI3gk7rX1Dp5ckiR/fDIYPhoyJOb666wdg0Qi3goaBkrLGKx wH8uCFz0/xs0Qc2NJlbAKj6OzAmz3LOqO5BzMb1CPabHcrYkPDLs5quKB2xuyfcJADjw L1CzW+k/Gk75DojqlC9/5TG28f5yxzBl0UVyFkJ1wGVXWT5S+vTg008BmgVs8g00XYZZ hW7/juCT2+y19GBbtKdCO+90vMpW/MC6ChkGH32WobgVYbz7xtofCI64BMKuR5Y9Bv/8 WDsXEnkfoAYh9neR1N1PJQExfKVJEiASfNwropk8PE0wVQteIFxHTF0NV53xzbl0Cgya LNFQ== X-Forwarded-Encrypted: i=1; AFNElJ+Db8oOcKnbsgDbBJLF5Z1h7f3yZPqWNYzUu+DDg1PFj+LBwWOjanWNf3bUtYIq0ekF1tOjZjkgbADd1dQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxLv8M5FWA2tuccaMsyV7bid2L7BgIniOoLYTLdE4SgFQxfU41T d7twLsy4rIkMrMAQ+98RLBRZj3jhkT+Cdb2OqJV8oXNs+VfyAiREMD1GnAYbVCQtLscxUza1bb8 6Mn3BvgMeAsIY66rMSA== X-Received: from wrrw11.prod.google.com ([2002:adf:f9cb:0:b0:44c:2fb:a56c]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:25e1:b0:449:9aee:4575 with SMTP id ffacd0b85a97d-45eb389fd2emr36824679f8f.30.1779889284888; Wed, 27 May 2026 06:41:24 -0700 (PDT) Date: Wed, 27 May 2026 13:41:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAH30FmoC/x3MMQqAMBAF0avI1i7EiBG9iliI+eo2iWxEhODdD ZavmMmUoIJEY5VJcUuSGAqauqL1WMIOFl9M1lhnOttzwsV4LgQPz1CNyrDr0vYwbnCeSngqNnn +6TS/7wf4nJJtZAAAAA== X-Change-Id: 20260527-set-extended-error-e2ca37e0696d X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1550; i=aliceryhl@google.com; h=from:subject:message-id; bh=LeUS4h0dAZFMR118R/wSEgBwYTGlXM0bV41TWFIWpWU=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBqFvR/cIwJ0wIRo2NQEAKrPozLiXiTML/lhWcRV WH7CV39rqGJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCahb0fwAKCRAEWL7uWMY5 RmM2EACCfg3cMc8eTmm9+Vj1Co70ZV4OI/h8ofoPKZcYPgyk63W7RVd1lnt9zATusgigW4J7A8U +tK1KyqX2nWARqYb8Ini5VYVHjSs3w5bh49MDYkNpwurp1tREB/MDas4ASZrNvmeTzkJwDAXSng K+tATFxQfSjhHHFHVnRnXE9kjjilP9YjDr9jnQ4yh2W2Wr6ZLG7WF9QR6SAp0HnUgWcgfwp0ZT6 SCEexi9rzTZq0FMUUiBKUwU1cJajEhpeGU+J/jFne0MW9qnXf3IItrPlrbyjswu5009vTqZIKEM BvbWSibmYISxJzqulX7Jp3YfrrcPceIz11BZ+9B9F91ePsPc0Q7iU/e54il1DkF29Fg5QvdgJac lyMJh4YR70q7MAWVEMfM/cFH1wCEahUvyyzdDEcnK2MpDxRUEPxSLp8etqDP/4A1Apj83Nz1C8J 8st2n6a43+h+nGtTAE6gqrzXZXPemUZMEpI1ueL1SzMxBwbWcmZHNCwfPUHkV+FO3Lt3mkYYGwI IJydN40W3esfD+xsIJ2IkRsMqwUOcXHwLziVcQ5N2U4s4KggbioVJGu1J7W28WUi4AIADXUE/ar vq5NVFp9GPI281pXDUuc7mkBjSrMSZ8v120U7Yatmky1vwGXSHQMmC0KDAI0i5eRcvKCKX5IT6z Kc2EpQ1+MKk84ew== X-Mailer: b4 0.14.3 Message-ID: <20260527-set-extended-error-v1-1-407b4b466035@google.com> Subject: [PATCH] rust_binder: fix setting the extended_error From: Alice Ryhl To: Greg Kroah-Hartman , Carlos Llamas Cc: Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This code currently copies the ExtendedError struct to the stack, modifies the copy, and then doesn't modify the original. Thus, fix it. Clearly nobody actually uses this feature, because nobody noticed that this is broken until they tried changing userspace to make some errors fatal. A test in userspace is being added along with this change. Cc: stable@vger.kernel.org Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver") Signed-off-by: Alice Ryhl --- drivers/android/binder/thread.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/android/binder/thread.rs b/drivers/android/binder/thre= ad.rs index 97d5f31e8fe3..0c74436c4e62 100644 --- a/drivers/android/binder/thread.rs +++ b/drivers/android/binder/thread.rs @@ -1249,9 +1249,9 @@ fn transaction(self: &Arc, cmd: u32, reader: &m= ut UserSliceReader) -> Resu info.reply =3D err.reply; =20 { - let mut ee =3D self.inner.lock().extended_error; - ee.command =3D err.reply; - ee.param =3D source.to_errno(); + let mut inner =3D self.inner.lock(); + inner.extended_error.command =3D err.reply; + inner.extended_error.param =3D source.to_errno(); } =20 pr_warn!( --- base-commit: 7fd2df204f342fc17d1a0bfcd474b24232fb0f32 change-id: 20260527-set-extended-error-e2ca37e0696d Best regards, --=20 Alice Ryhl