From nobody Mon Jun 8 19:42:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428F31946DA; Wed, 27 May 2026 00:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779840154; cv=none; b=cW+Jx2lKmwD5G0x0MZUXj/2ESE4WDp3EVKmFcP2PCltWr3OQtsdHbAlRc/7zLSICjD+gjV4cQJYfHKBiLjRF0Tc/f0z9l60KCA/fTcd91JRnyZxx1MBLVeC3AreoexPOToje90KYJLahqfQ7xU/yx9qqnPgMEZr31ueblSsBXCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779840154; c=relaxed/simple; bh=t7znY4VIaXJRFN+3es/fkU/NyIevyYaFTBMNWJ0UOWs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FpOcPZmPj9+aJ2QI+czAapPsshdVwcuwe4+m/NVRvd9OPEW8izrs4Rqxy+aQyAb8HB0Rai1qKmXgTjJk0HzvYqKhrFU9yU2n+pSwMNzxmO8dOk4LjQvol7ZbbnulivNRkCHLDaD0+MaxfWn2WUpYKj8dy8TpvN3cPq7GT5QNGMs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A6jIJSbU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A6jIJSbU" Received: by smtp.kernel.org (Postfix) with ESMTPS id 30346C2BCC4; Wed, 27 May 2026 00:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779840152; bh=t7znY4VIaXJRFN+3es/fkU/NyIevyYaFTBMNWJ0UOWs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=A6jIJSbUKX9kzsrBICRUVjm6WA1JbxOzrGimvrb/SKk5JOV9qU5KRoRNrqNiPCbgl gughqwN9LLaCtAxbKWfy8tjhzpRTFB6JeQoHgxJki3HKlaS3dRxtTdhb6L6iqVh+iR 1xFKuwCnzpK2AqXLiEcrSs78vFCPcnd57fxHBw4Z2di8HeEqZROId5z5bD/qnpXmEq H/S5DpZ+KVHCDLXzJTKLKnq9CdLkG7ewP1fQqsLeQa4mnkPHfluhNUcNU8ZunvKmT9 o7XQLEdcez3ZYeT6fcOFRhkgVzg33pe+Grg72z2UTe1NhkL0ED++E8JFkqxB1h4Vo3 +jobilzunoxGg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C24ECD5BDE; Wed, 27 May 2026 00:02:32 +0000 (UTC) From: Amit Sunil Dhamne via B4 Relay Date: Wed, 27 May 2026 00:02:25 +0000 Subject: [PATCH v2 1/2] power: supply: Add helpers to get and put arrays of power supply handles Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260527-batt-status-v2-1-4282985165f3@google.com> References: <20260527-batt-status-v2-0-4282985165f3@google.com> In-Reply-To: <20260527-batt-status-v2-0-4282985165f3@google.com> To: Sebastian Reichel , Badhri Jagan Sridharan , Heikki Krogerus , Greg Kroah-Hartman , Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Peter Griffin , RD Babiera , Kyle Tso , Amit Sunil Dhamne X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779840151; l=5925; i=amitsd@google.com; s=20241031; h=from:subject:message-id; bh=ijjk2ySMN0dL36fe0OTjSfQADrJgWHjO1SJEZMi/CKY=; b=z2ksABg47kx5ufLiDUjWcv7ibc5t+tO8aEyiWgsPEbXTrAe1ZcTVjXv+QJwGgTDnf0x5u8Bvg TPjdPmmxmblBfo0/4sFYAQ1IW2FA2K+gqs9oE7zUtTsH5emfOlMK55B X-Developer-Key: i=amitsd@google.com; a=ed25519; pk=wD+XZSST4dmnNZf62/lqJpLm7fiyT8iv462zmQ3H6bI= X-Endpoint-Received: by B4 Relay for amitsd@google.com/20241031 with auth_id=262 X-Original-From: Amit Sunil Dhamne Reply-To: amitsd@google.com From: Amit Sunil Dhamne Add power_supply_get_battery_all() to allow drivers to obtain a list of registered battery type power supply references in the system. Also add power_supply_put_array() to release references to the power supplies when no longer needed. Signed-off-by: Amit Sunil Dhamne --- drivers/power/supply/power_supply_core.c | 137 +++++++++++++++++++++++++++= ++++ include/linux/power_supply.h | 12 +++ 2 files changed, 149 insertions(+) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/suppl= y/power_supply_core.c index a446d3d086fc..04e5c1083e8f 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c @@ -482,6 +482,127 @@ struct power_supply *power_supply_get_by_name(const c= har *name) } EXPORT_SYMBOL_GPL(power_supply_get_by_name); =20 +static int __power_supply_get_num_battery(struct power_supply *epsy, void = *data) +{ + int *count =3D data; + + if (epsy->desc->type =3D=3D POWER_SUPPLY_TYPE_BATTERY) + (*count)++; + + return 0; +} + +static int power_supply_get_num_battery(struct device *dev) +{ + int ret, count =3D 0; + + ret =3D power_supply_for_each_psy(&count, __power_supply_get_num_battery); + + dev_dbg(dev, "%s: count: %d ret %d\n", __func__, count, ret); + + if (ret) + return ret; + + return count; +} + +struct psy_get_supplies_data { + int cnt; + int size; + struct power_supply **psys; +}; + +static int __power_supply_populate_battery_array(struct power_supply *epsy, + void *_data) +{ + struct psy_get_supplies_data *data =3D _data; + + if (epsy->desc->type =3D=3D POWER_SUPPLY_TYPE_BATTERY) { + if (data->size <=3D data->cnt) + return -EOVERFLOW; + + get_device(&epsy->dev); + data->psys[data->cnt] =3D epsy; + atomic_inc(&epsy->use_cnt); + data->cnt++; + } + + return 0; +} + +static int power_supply_populate_battery_array(struct device *dev, int siz= e, + struct power_supply **batteries) +{ + int ret; + + struct psy_get_supplies_data data =3D { + .cnt =3D 0, + .size =3D size, + .psys =3D batteries, + }; + + ret =3D power_supply_for_each_psy(&data, __power_supply_populate_battery_= array); + + dev_dbg(dev, "%s Found %d batteries with array size %d ret %d\n", + __func__, data.cnt, data.size, ret); + + if (ret < 0) { + power_supply_put_array(batteries, data.cnt); + return ret; + } + + return data.cnt; +} + +/** + * power_supply_get_battery_all() - Fetches references to all battery type= power + * supplies. + * @dev: Pointer to device requesting the power supply refs. + * @psys: Pointer to an array of power supply refs. + * + * Helper function to get handles to all battery type power supplies. + * If acquiring a ref to a power supply fails, then the search for battery + * type power supplies will abort and the acquired power supply references= will + * be released. + * + * Return: Indicates the number of battery type power supplies returned on + * success or a negative error code on failure. + * + * The caller should invoke power_supply_put_array() on the returned array + * of psy refs and free the array returned by this function using kfree() + * after use. + */ +int __must_check power_supply_get_battery_all(struct device *dev, + struct power_supply ***psys) +{ + int ret; + + if (!psys) + return -EINVAL; + + ret =3D power_supply_get_num_battery(dev); + if (ret < 0) + return ret; + + if (!ret) { + *psys =3D NULL; + return 0; + } + + *psys =3D kzalloc_objs(**psys, ret); + if (!*psys) + return -ENOMEM; + + ret =3D power_supply_populate_battery_array(dev, ret, *psys); + if (ret <=3D 0) { + kfree(*psys); + *psys =3D NULL; + } + + return ret; +} +EXPORT_SYMBOL_GPL(power_supply_get_battery_all); + /** * power_supply_put() - Drop reference obtained with power_supply_get_by_n= ame * @psy: Reference to put @@ -496,6 +617,22 @@ void power_supply_put(struct power_supply *psy) } EXPORT_SYMBOL_GPL(power_supply_put); =20 +/** + * power_supply_put_array() - Drop references to an array of power supplie= s. + * @psys: Array of power supply references to put. + * @count: Number of elements in the array. + */ +void power_supply_put_array(struct power_supply **psys, int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + if (psys[i]) + power_supply_put(psys[i]); + } +} +EXPORT_SYMBOL_GPL(power_supply_put_array); + static int power_supply_match_device_fwnode(struct device *dev, const void= *data) { return dev->parent && dev_fwnode(dev->parent) =3D=3D data; diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 7a5e4c3242a0..026412164a88 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -806,11 +806,23 @@ extern int power_supply_reg_notifier(struct notifier_= block *nb); extern void power_supply_unreg_notifier(struct notifier_block *nb); #if IS_ENABLED(CONFIG_POWER_SUPPLY) extern struct power_supply *power_supply_get_by_name(const char *name); +extern int __must_check power_supply_get_battery_all(struct device *dev, + struct power_supply ***psys); +extern void power_supply_put_array(struct power_supply **psys, int count); extern void power_supply_put(struct power_supply *psy); #else static inline void power_supply_put(struct power_supply *psy) {} static inline struct power_supply *power_supply_get_by_name(const char *na= me) { return NULL; } +static inline int __must_check power_supply_get_battery_all(struct device = *dev, + struct power_supply ***psys) +{ + if (psys) + *psys =3D NULL; + return 0; +} + +static inline void power_supply_put_array(struct power_supply **psys, int = count) {} #endif extern struct power_supply *power_supply_get_by_reference(struct fwnode_ha= ndle *fwnode, const char *property); --=20 2.54.0.746.g67dd491aae-goog From nobody Mon Jun 8 19:42:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 429F41F4176; Wed, 27 May 2026 00:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779840154; cv=none; b=mGw/QAtrLO2R2kmCp+g2WtI3e6fJ1OV9xph6fk8GzxYVKq4Lve3fiMi/jAu0TpdhYjQ9OHFT1wKdJl3GplLrHO4MuOrhih1+PcoDvBL9gZQAW8WU+tN9EN835s5Mt7w6nn9xd3Luf5IWYif1kQP293tCFL/wUvg42Sa5O8z3/SI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779840154; c=relaxed/simple; bh=/RYy7S3oX1NQbXQX7pWHFLdmUwgSd81LE27BXoJwJ78=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PfP8u4bNQdePDgGae5mrbhVjl2oSlEh4Sk6Xmc6zPxtsaTL0sx/uBAmaZqRbQUf9Hn4pRoCnYiW7rBIdQS9j8XoawFAZSYdEM3SGA+0qr3OrqkPIu8SPbaZXMbj4tCZVW+OkY8CWivyo6mMMrBPS4h9ECK0Lux9ZyurZnvZlii0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EkxcCm07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EkxcCm07" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3C7FCC2BCB8; Wed, 27 May 2026 00:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779840152; bh=/RYy7S3oX1NQbXQX7pWHFLdmUwgSd81LE27BXoJwJ78=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=EkxcCm07fTq2vyQRxyvzdmGMBODo+5+WstX3EjuZ0CsY8p1sgsU6eZDRzpX4kxeDH RBbwjRg0nKnnlA93qDPtgTU5x4cWWM7l6gK4CLHwyuPtcEe2dmgE+9Y5SBxIJLubJ+ weZdY/KsE8NBI8b7Xzm4gba6i2uo8y1SQLv2Np5ZTCc+6aiwc/ikredo2SwxQV8d/8 618pDFlB0ZXLzZCz6ZqNAS2FqXSvXml+zodPFIwgKDgk8mm1ddMrPDgCl+19wSFp+x hD9Y0B42kucDxDCdz+tuCQ2PG5PcijCdfPYWfeVxsTJAuEC5jFl5ZyzHGBYH23Gjx3 r/k1pBimiDE7A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB8DCD6E43; Wed, 27 May 2026 00:02:32 +0000 (UTC) From: Amit Sunil Dhamne via B4 Relay Date: Wed, 27 May 2026 00:02:26 +0000 Subject: [PATCH v2 2/2] usb: typec: tcpm: Add support for Battery Status response message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260527-batt-status-v2-2-4282985165f3@google.com> References: <20260527-batt-status-v2-0-4282985165f3@google.com> In-Reply-To: <20260527-batt-status-v2-0-4282985165f3@google.com> To: Sebastian Reichel , Badhri Jagan Sridharan , Heikki Krogerus , Greg Kroah-Hartman , Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Peter Griffin , RD Babiera , Kyle Tso , Amit Sunil Dhamne X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779840151; l=9647; i=amitsd@google.com; s=20241031; h=from:subject:message-id; bh=qKRqCEXot0xm1jdW2q1ZIPlkhG7l4AKhLEe78OTckcQ=; b=v1xW142VcQEfaxffdZThTVOIy2cGZGCP4LVL6Tpg8vI6guyM6Ps9CnpCMmkjgHd+CieVmCIbZ eDI5VKyX/OJDdT8PCRXwwlUWU58nWqclI+uDNLmmSNiFk/+x7N1XQzn X-Developer-Key: i=amitsd@google.com; a=ed25519; pk=wD+XZSST4dmnNZf62/lqJpLm7fiyT8iv462zmQ3H6bI= X-Endpoint-Received: by B4 Relay for amitsd@google.com/20241031 with auth_id=262 X-Original-From: Amit Sunil Dhamne Reply-To: amitsd@google.com From: Amit Sunil Dhamne Add support for responding to a Get_Battery_Status request with a Battery_Status message. The port partner shall request the status of a port's battery by providing an index in the Get_Battery_Status AMS. In case of failure to identify the battery, the port shall reply with an appropriate message indicating so. Support for Battery_Status message is required for sinks that contain battery as specified in USB PD Rev3.1 v1.8 ("Applicability of Data Messages" section). Signed-off-by: Amit Sunil Dhamne Reviewed-by: Badhri Jagan Sridharan --- drivers/usb/typec/tcpm/tcpm.c | 151 ++++++++++++++++++++++++++++++++++++++= +++- include/linux/usb/pd.h | 29 ++++++++ 2 files changed, 177 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index dfbb94ddc98a..ee45d90dbf98 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -232,7 +232,8 @@ enum pd_msg_request { PD_MSG_DATA_SINK_CAP, PD_MSG_DATA_SOURCE_CAP, PD_MSG_DATA_REV, - PD_MSG_EXT_SINK_CAP_EXT + PD_MSG_EXT_SINK_CAP_EXT, + PD_MSG_DATA_BATT_STATUS }; =20 enum adev_actions { @@ -389,6 +390,14 @@ struct pd_timings { /* Convert microwatt to watt */ #define UW_TO_W(pow) ((pow) / 1000000) =20 +/* + * As per USB PD Spec Rev 3.18 (Sec. 6.5.13.11), the number of fixed batte= ries + * that a port can be queried is restricted to 4. + */ +#define MAX_NUM_FIXED_BATT 4 + +#define BATTERY_PROPERTY_UNKNOWN 0xffff + /* * struct pd_identifier - Contains info about PD identifiers * @vid: Vendor ID (assigned by USB-IF) @@ -683,6 +692,9 @@ struct tcpm_port { =20 struct pd_identifier pd_ident; struct sink_caps_ext_data sink_caps_ext; + struct power_supply *fixed_batt[MAX_NUM_FIXED_BATT]; + u32 fixed_batt_cnt; + u32 batt_request_id; #ifdef CONFIG_DEBUG_FS struct dentry *dentry; struct mutex logbuffer_lock; /* log buffer access lock */ @@ -1391,6 +1403,37 @@ static int tcpm_pd_send_revision(struct tcpm_port *p= ort) return tcpm_pd_transmit(port, TCPC_TX_SOP, &msg); } =20 +static void tcpm_init_fixed_batt(struct tcpm_port *port) +{ + struct power_supply **batteries; + int ret, i; + + if (port->fixed_batt_cnt > 0) + return; + + ret =3D power_supply_get_battery_all(port->dev, &batteries); + if (ret < 0) { + tcpm_log(port, "Failed to fetch batteries refs ret=3D%d", ret); + return; + } + + for (i =3D 0; i < ret; i++) { + if (!batteries[i]) + continue; + + if (port->fixed_batt_cnt < MAX_NUM_FIXED_BATT) + port->fixed_batt[port->fixed_batt_cnt++] =3D batteries[i]; + else + break; + } + + if (i < ret) + power_supply_put_array(batteries + i, ret - i); + + if (ret) + kfree(batteries); +} + static int tcpm_pd_send_source_caps(struct tcpm_port *port) { struct pd_message msg; @@ -1476,6 +1519,8 @@ static int tcpm_pd_send_sink_cap_ext(struct tcpm_port= *port) =20 if (!port->self_powered) data->spr_op_pdp =3D operating_snk_watt; + else + tcpm_init_fixed_batt(port); =20 /* * SPR Sink Minimum PDP indicates the minimum power required to operate @@ -1502,6 +1547,7 @@ static int tcpm_pd_send_sink_cap_ext(struct tcpm_port= *port) skedb.load_step =3D data->load_step; skedb.load_char =3D cpu_to_le16(data->load_char); skedb.compliance =3D data->compliance; + skedb.batt_info =3D port->fixed_batt_cnt; skedb.modes =3D data->modes; skedb.spr_min_pdp =3D data->spr_min_pdp; skedb.spr_op_pdp =3D data->spr_op_pdp; @@ -1520,6 +1566,87 @@ static int tcpm_pd_send_sink_cap_ext(struct tcpm_por= t *port) port->message_id, data_obj_cnt, 1 /* Denotes if ext header */)); + + return tcpm_pd_transmit(port, TCPC_TX_SOP, &msg); +} + +static int tcpm_pd_send_batt_status(struct tcpm_port *port) +{ + u16 present_charge =3D BATTERY_PROPERTY_UNKNOWN; + bool batt_present =3D false, invalid_ref =3D true; + u32 batt_id =3D port->batt_request_id; + union power_supply_propval val; + struct power_supply *batt; + u8 charging_status =3D 0; + struct pd_message msg; + int ret, charge_now; + u64 energy_now; + u32 bsdo; + + memset(&msg, 0, sizeof(msg)); + + if (batt_id >=3D port->fixed_batt_cnt || !port->fixed_batt[batt_id]) + goto send_status; + + invalid_ref =3D false; + batt =3D port->fixed_batt[batt_id]; + ret =3D power_supply_get_property(batt, POWER_SUPPLY_PROP_PRESENT, &val); + if (ret) + tcpm_log(port, + "Failed to fetch power_supply_prop_present ret %d", + ret); + else + batt_present =3D val.intval > 0; + + ret =3D power_supply_get_property(batt, POWER_SUPPLY_PROP_CHARGE_NOW, + &val); + if (!ret) { + charge_now =3D val.intval; + + ret =3D power_supply_get_property(batt, + POWER_SUPPLY_PROP_VOLTAGE_AVG, + &val); + if (!ret) { + energy_now =3D ((u64)charge_now * val.intval) / 1000000; + + /* + * Battery Present Charge is reported in + * increments of 0.1WH. + */ + present_charge =3D (u16)UW_TO_W(energy_now * 10); + } + } + + ret =3D power_supply_get_property(batt, POWER_SUPPLY_PROP_STATUS, &val); + if (!ret) { + switch (val.intval) { + case POWER_SUPPLY_STATUS_CHARGING: + charging_status =3D BSDO_BATTERY_INFO_CHARGING; + break; + case POWER_SUPPLY_STATUS_DISCHARGING: + charging_status =3D BSDO_BATTERY_INFO_DISCHARGING; + break; + case POWER_SUPPLY_STATUS_NOT_CHARGING: + case POWER_SUPPLY_STATUS_FULL: + charging_status =3D BSDO_BATTERY_INFO_IDLE; + break; + default: + charging_status =3D BSDO_BATTERY_INFO_RSVD; + break; + } + } + +send_status: + + bsdo =3D BSDO(present_charge, charging_status, batt_present, invalid_ref); + msg.payload[0] =3D cpu_to_le32(bsdo); + msg.header =3D PD_HEADER_LE(PD_DATA_BATT_STATUS, + port->pwr_role, + port->data_role, + port->negotiated_rev, + port->message_id, + 1); + return tcpm_pd_transmit(port, TCPC_TX_SOP, &msg); } =20 @@ -3854,6 +3981,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port = *port, { enum pd_ext_msg_type type =3D pd_header_type_le(msg->header); unsigned int data_size =3D pd_ext_header_data_size_le(msg->ext_msg.header= ); + const struct pd_chunked_ext_message_data *ext_msg =3D &msg->ext_msg; =20 /* stopping VDM state machine if interrupted by other Messages */ if (tcpm_vdm_ams(port)) { @@ -3862,7 +3990,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port = *port, mod_vdm_delayed_work(port, 0); } =20 - if (!(le16_to_cpu(msg->ext_msg.header) & PD_EXT_HDR_CHUNKED)) { + if (!(le16_to_cpu(ext_msg->header) & PD_EXT_HDR_CHUNKED)) { tcpm_pd_handle_msg(port, PD_MSG_CTRL_NOT_SUPP, NONE_AMS); tcpm_log(port, "Unchunked extended messages unsupported"); return; @@ -3887,9 +4015,17 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port= *port, NONE_AMS, 0); } break; + case PD_EXT_GET_BATT_STATUS: + if (data_size >=3D 1) { + port->batt_request_id =3D ext_msg->data[0]; + tcpm_pd_handle_msg(port, PD_MSG_DATA_BATT_STATUS, + GETTING_BATTERY_STATUS); + } else { + tcpm_set_state(port, SOFT_RESET_SEND, 0); + } + break; case PD_EXT_SOURCE_CAP_EXT: case PD_EXT_GET_BATT_CAP: - case PD_EXT_GET_BATT_STATUS: case PD_EXT_BATT_CAP: case PD_EXT_GET_MANUFACTURER_INFO: case PD_EXT_MANUFACTURER_INFO: @@ -4100,6 +4236,14 @@ static bool tcpm_send_queued_message(struct tcpm_por= t *port) ret); tcpm_ams_finish(port); break; + case PD_MSG_DATA_BATT_STATUS: + ret =3D tcpm_pd_send_batt_status(port); + if (ret) + tcpm_log(port, + "Failed to send battery status ret=3D%d", + ret); + tcpm_ams_finish(port); + break; default: break; } @@ -8597,6 +8741,7 @@ void tcpm_unregister_port(struct tcpm_port *port) hrtimer_cancel(&port->vdm_state_machine_timer); hrtimer_cancel(&port->state_machine_timer); =20 + power_supply_put_array(port->fixed_batt, port->fixed_batt_cnt); tcpm_reset_port(port); =20 tcpm_port_unregister_pd(port); diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h index 337a5485af7c..afb9c2c65588 100644 --- a/include/linux/usb/pd.h +++ b/include/linux/usb/pd.h @@ -724,4 +724,33 @@ void usb_power_delivery_unlink_device(struct usb_power= _delivery *pd, struct devi =20 #endif /* CONFIG_TYPEC */ =20 +/* Battery Status Data Object */ +#define BSDO_PRESENT_CAPACITY GENMASK(31, 16) +#define BSDO_CHG_STATUS GENMASK(11, 10) +#define BSDO_BATTERY_PRESENT BIT(9) +#define BSDO_INVALID_BATTERY_REFERENCE BIT(8) + +/* + * Battery Charge Status: Battery Charging Status Values as defined in + * "USB PD Spec Rev3.1 Ver1.8", "Table 6-46 Battery Status Data Object (BS= DO)". + */ +#define BSDO_BATTERY_INFO_CHARGING 0x0 +#define BSDO_BATTERY_INFO_DISCHARGING 0x1 +#define BSDO_BATTERY_INFO_IDLE 0x2 +#define BSDO_BATTERY_INFO_RSVD 0x3 + +/** + * BSDO() - Pack data into Battery Status Data Object format. + * @batt_charge: Battery's present state of charge in 0.1WH increment. + * @chg_status: Battery charge status. + * @batt_present: Indicates that battery is present/attached when set else= absent when unset. + * @invalid_ref: Indicates that an invalid battery reference was made in t= he Get_Battery_Status + * request. + */ +#define BSDO(batt_charge, chg_status, batt_present, invalid_ref) \ + ((FIELD_PREP(BSDO_PRESENT_CAPACITY, batt_charge)) | \ + (FIELD_PREP(BSDO_CHG_STATUS, chg_status)) | \ + ((batt_present) ? BSDO_BATTERY_PRESENT : 0) | \ + ((invalid_ref) ? BSDO_INVALID_BATTERY_REFERENCE : 0)) + #endif /* __LINUX_USB_PD_H */ --=20 2.54.0.746.g67dd491aae-goog