From nobody Mon Jun 8 21:47:55 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1722D3FDBE9 for ; Tue, 26 May 2026 13:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779803496; cv=none; b=NEoQkRDjBQsCDmSKqAH4jN1UlhAnPmB3IGc7B+bHndVjqFg4pwHHnb0uBesPU7OF7zMVEvOa8jcv17Ct6PJVcFd76WAwau5qj1Mc4DWONalC6JmnMBZKGeBohF+LjGSgpmuj5NvklBjw6EkpIDQTlVtkYUAG0X3/F9v6/o/k/d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779803496; c=relaxed/simple; bh=g3XL6UHQ5X/eraQCFiYaUWLICWC+349yDBHJ+dUy8ik=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MI+Ec7PWgHH7/hbT4BHeGAlF4t2CHMFhiDmYLJ4Bu8Wm/UmhkQyJ4fpYhkgevVA+s1Oywo34fDKkC44dd86CPIctMj2aLpGHBopXUpME79yWZASEF+L3WiGmCZ27jIwBAcofkeYYlvei6UQHIYNGNHNX7nkaFw/3cYqBvDnwork= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MnWZhb9S; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MnWZhb9S" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8367df48711so4617738b3a.1 for ; Tue, 26 May 2026 06:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779803493; x=1780408293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vwSbnjkxGnXGaLUaGKOC4vnl3KT7tW87Ya/uzx+HPaI=; b=MnWZhb9Sat5PQx4MGh/ixLsZLTfWvQc9miO2UDgECInMkr1ENBYKjeWNwno2LC+vgg bo/EGfopznPZp78k6FRvp4esdDCDbovv5OBWhGolE6+5uutsK4t4fcbIEDVZl1c0py+7 zIhjk56LPdKBFcmuhOLV2CK0QorBAzXhVTB/GEfVBwvc6plX3deevkzzURJL89awtOcY 4Yp0R/MPmC7Vwh9WJs2Bm6f6IW3rsavR+jZgriNmlQ7sEASwSe3sFf6h4i//K/vEX8cY T7upeXJ6U/Vy3R4xSXW+y6PQ9CpTaa3FB3x/Oo3CL8hv6dc3ySK4IONVU/w/JpTgrECH GK/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779803493; x=1780408293; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vwSbnjkxGnXGaLUaGKOC4vnl3KT7tW87Ya/uzx+HPaI=; b=GjeY4hCQDt/bobFrQvvMMX6wwKC6jLY6JiSr9OPUz4ADxtMzKd++Jw4awbDW4pYXA/ r8jDc6cLjMN19Tjm6KhqWOwnMQKATa3aAKb7wu9y7WJt330b5mXO8cWNvhsbYQR6Udlk X7QNeKFR7fXO2zUETmrMk8zODbMkWM9RGK0Nq9MgP+c+zRpOylvNSu/dlonJmurPxEhl yJzRyjDgOp6h6fcg5VE6pWLPm4M64dlWeWqdVPyxqGinAq0zXhCM2gNrFUZ0cMNrq2D6 5dnD2UXN/XRB8rd/ASjDDVigdWTyQ3VbMQSjwSqcu2A+sYX3g8fV306Sqlo4lIR97h+i KS7Q== X-Forwarded-Encrypted: i=1; AFNElJ+UrIQaatnFbJGmqaG5wmeijaCmm8aZEMIBjAXYYnk6oBdEnPd018gWB5mqiWFSLKO3WD5IC7+6JuINt7k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0vAL5uyR9ZUhNcm9l3HoVEu3ME+PAFGYb2FF7kV3kNNYqutl9 Q9bulBOOeiuzi4iTdmNwY63k+8PAceA2/5wA51LYv4XClihIki+tAWrQ X-Gm-Gg: Acq92OHBo527K/3x7wpkg8fUyzDCTpzLVnjFoXPzZfxhiZIFhVAh5mpypsIz23PPk5I FWJ+i1qFQKJEbjjzU8xL9zhRJCE+7id6ZUzkNIyXgNohy+bzYfJwItocRkgvaJC0/TTTi4B+rUU 656iCh1GLWGNpjMWx0aEGLrW8GU+3sfdG6LHlSwIMEZlE7V/Cp5rMU++vFT8TA47eeHnczxs5Zy iNvd32DdUesgNKLhzA+rDo1TEHFz8HraUMHBxHo152mXvn+wAaeUc70DPPQO7uP4o8I17EFCI9l W4qe3pTWoU4HkQmefuV/LuVytvTrGVR+BRCGdxv5a/ExNCv25c11lKwpMdl10qNTZXiaaqFsx8x Lm+5WP2Gqwz/3HyvFxRYEHXeoFHCtmojwX1nfdQ56EVf8dMxJZqVgreKdIciphzQDeOF1j+T4iI 09FJS0ZsF6L9qdJOsZl73QGrWnWOf85GOVyPEyCYIix93/uag= X-Received: by 2002:a05:6a00:908b:b0:83d:446c:2a8c with SMTP id d2e1a72fcca58-8415f406c9amr18309716b3a.25.1779803493442; Tue, 26 May 2026 06:51:33 -0700 (PDT) Received: from DESKTOP-QGNVECK.localdomain ([139.159.170.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164fb3083sm12523110b3a.43.2026.05.26.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 06:51:32 -0700 (PDT) From: Zicheng Qu To: tj@kernel.org, void@manifault.com, arighi@nvidia.com, changwoo@igalia.com, enjuk@amazon.com, emil@etsalapatis.com, sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org Cc: tanghui20@huawei.com, zhangqiao22@huawei.com, quzicheng@huawei.com, quzicheng315@gmail.com Subject: [PATCH] tools/sched_ext: Fix scx_show_state per-scheduler state reads Date: Tue, 26 May 2026 21:51:23 +0800 Message-ID: <20260526135123.1892092-1-quzicheng315@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zicheng Qu scx_show_state.py still reads scx_aborting and scx_bypass_depth as global symbols. Those symbols no longer exist after the state was moved into struct scx_sched, so the drgn script fails when it reaches either field. Fixes: 5c8d98a1b4de ("sched_ext: Move bypass state into scx_sched") Fixes: c1743da43cf5 ("sched_ext: Move aborting flag to per-scheduler field") Signed-off-by: Zicheng Qu Reviewed-by: Andrea Righi --- tools/sched_ext/scx_show_state.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/sched_ext/scx_show_state.py b/tools/sched_ext/scx_show_s= tate.py index 02e43c184d43..446d82807f90 100644 --- a/tools/sched_ext/scx_show_state.py +++ b/tools/sched_ext/scx_show_state.py @@ -27,18 +27,25 @@ def read_static_key(name): def state_str(state): return prog['scx_enable_state_str'][state].string_().decode() =20 +def read_root_ops_name(): + if root: + return root.ops.name.string_().decode() + return '' + +def read_root_field(name, default): + if root: + return getattr(root, name).value_() + return default + root =3D prog['scx_root'] enable_state =3D read_atomic("scx_enable_state_var") =20 -if root: - print(f'ops : {root.ops.name.string_().decode()}') -else: - print('ops : ') +print(f'ops : {read_root_ops_name()}') print(f'enabled : {read_static_key("__scx_enabled")}') print(f'switching_all : {read_int("scx_switching_all")}') print(f'switched_all : {read_static_key("__scx_switched_all")}') print(f'enable_state : {state_str(enable_state)} ({enable_state})') -print(f'aborting : {prog["scx_aborting"].value_()}') -print(f'bypass_depth : {prog["scx_bypass_depth"].value_()}') +print(f'aborting : {read_root_field("aborting", False)}') +print(f'bypass_depth : {read_root_field("bypass_depth", 0)}') print(f'nr_rejected : {read_atomic("scx_nr_rejected")}') print(f'enable_seq : {read_atomic("scx_enable_seq")}') --=20 2.43.0