From nobody Mon Jun 8 21:58:56 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946AD3DDDBD; Tue, 26 May 2026 10:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779792501; cv=none; b=mTmYhXMqCW/AKFl1SXqMSzVm0v9DfGD6RBTjkoHKlP7eEnBMDiGgl7UW6hnRsOr2hgbITtbQf6yB0fixMCIASD/sdUv7F1WvogQ28AmARHleD5+eRxlCyWyCw6JvEeuHSJ0fcWWYuew/uLoQkayg373TtlIQK/SYZhvygpn/Y9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779792501; c=relaxed/simple; bh=MTpJxKTuens6DDUF5s3lKZOugiQSoVatfQj2hgjmCR8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=adrMUOjFeDpg2W4tYt95TLX8N/ZLdKBaXQndtuyTy0qIb7zpwzY3C2NgePxZeACWdGjN+ZY0P9e8UEOuZTV/X4D5rs+drJxIsU2AKoWZzk8ZgmO3Mwk7v4dj+sRUtLb+dtACiYV36/JzHk1raSG/BNnRffnC92EX37v77eenuWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fuZ4QRQD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fuZ4QRQD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 211541F000E9; Tue, 26 May 2026 10:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779792500; bh=WEAysOJhYWScktWySeX+/hXiUj2AW4y6blrSCBK852s=; h=From:To:Cc:Subject:Date; b=fuZ4QRQDTCyNZCqf+VzbJ3OEA/ucV1ybEhaJ3ZKzfgZ/LujfhOdE+NOxz/mYBE06i MXQYSzCgyVL72T5wkfhsTjn6Jqg/0MkJ+Y+Y1oHEDQaeALOsQkXHyUSinY/k8ue9Hp q9Upes6n1tC0/JY3YWJJGSVMFj8VxGWOm+z02n90I0GOB91nkfNcJyzflDPYFancja /xdJQ+ZTUyBh7Sg3TMqjDCoyClzjy9QL2yc9RniPXh8OP823mV5YAgYN8Wl1kIeqpz TonAUlHUh4oJYlpXMr5gTzAt97W7kvgXZD+W/b/Nw8n/7Ri2HAX9EQV9fbZ5a/2j+d MeFiHc19m/f+A== From: Arnd Bergmann To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Greg Kroah-Hartman , Andy Shevchenko , Arnd Bergmann Cc: Dan Carpenter , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: udc: pxa: fix error handling Date: Tue, 26 May 2026 12:47:52 +0200 Message-Id: <20260526104810.3906090-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann As Dan Carpenter points out, my recent change makes subtle changes to the error handling that were not intended. Move the warning print up so it does not get skipped in case of an error, but handle -EPROBE_DEFER properly now. Change the devm_gpiod_get() to the _optional variant, which is in line with the intended behavior and the DT binding, though this did not work previously. Reported-by: Dan Carpenter Link: https://lore.kernel.org/linux-usb/ag6-xhfFjb5NpXQz@stanley.mountain/ Fixes: 25bd55f46032 ("usb: udc: pxa: remove unused platform_data") Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa27x_udc.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/p= xa27x_udc.c index 640f81988c04..df5cca43afbe 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2374,9 +2374,10 @@ static int pxa_udc_probe(struct platform_device *pde= v) struct pxa_udc *udc =3D &memory; int retval =3D 0; =20 - udc->gpiod =3D devm_gpiod_get(&pdev->dev, NULL, GPIOD_ASIS); + udc->gpiod =3D devm_gpiod_get_optional(&pdev->dev, NULL, GPIOD_ASIS); if (IS_ERR(udc->gpiod)) - return PTR_ERR(udc->gpiod); + return dev_err_probe(&pdev->dev, PTR_ERR(udc->gpiod), + "Couldn't find or request D+ gpio\n"); =20 udc->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(udc->regs)) @@ -2395,11 +2396,6 @@ static int pxa_udc_probe(struct platform_device *pde= v) udc->transceiver =3D usb_get_phy(USB_PHY_TYPE_USB2); } =20 - if (IS_ERR(udc->gpiod)) { - dev_err(&pdev->dev, "Couldn't find or request D+ gpio : %ld\n", - PTR_ERR(udc->gpiod)); - return PTR_ERR(udc->gpiod); - } if (udc->gpiod) gpiod_direction_output(udc->gpiod, 0); =20 --=20 2.39.5