From nobody Mon Jun 8 21:47:54 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7F3F3BB136 for ; Tue, 26 May 2026 10:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779790599; cv=none; b=HZ2Pm7qRznMQqjFZv84cST5DGU0SEFTsJovvO2u7vw+sdUuVV/2zhbgCwSXvOx3FMALu6tm1+d5vJrCKDH4nWnSFLZcZZfVuxsxZC/QYFF2HpojQ/FV1oIW2iTsPPAWF7tYnw0w8PRVMyb2c7eLvQUxXu3RvjmqXv2z6IATjlHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779790599; c=relaxed/simple; bh=Nh+C+Fy0FqiBHKrNXaY08YwYU34+UqfXLUWTYrNpkdk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fD+NDIQYi/KI7Rgm8J9Ab4sBIFvxnn/QV5FLj7r4C1E26+YtBeCH+IepcbyrFAL92lcZOT+ACBPfLn4ALMNQDIc2W8oEGsA/3Gzt2p7hgkSs1xZxjK66oSMvBA+f9wP1NT9oCTGy6kGYlV55BwSJYiRhm4xe9WFV9A0b+WXd2JQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aerlync.com; spf=pass smtp.mailfrom=aerlync.com; dkim=fail (0-bit key) header.d=aerlync.com header.i=@aerlync.com header.b=MbufjXYK reason="key not found in DNS"; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aerlync.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aerlync.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=aerlync.com header.i=@aerlync.com header.b="MbufjXYK" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b9fcf7c91bso117874185ad.0 for ; Tue, 26 May 2026 03:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aerlync.com; s=google; t=1779790597; x=1780395397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XrZ4NvK5jrlaPy7QvhC9XeQXCUzbUpfIVsVCaVJAXRU=; b=MbufjXYKrB08/BqOEE5RCssY4owMi0cOiWdNN7OjPdiTTaWqawCuC78DrHZOpQbikj wFIzwXjFi2YP3BNvJ957LkNZVZE/bdWVS6se2WyLE0y0xpcln7JSIn5uxi47/zpvKnoh Jtt7Ji8KmlqUMBlRzGCS6nEioaH9oa4021XxBU65NiHAoptHBTlT4ajFUm37DAUIfGrB n0xtQ23tFOCfrvBQDOQhPyRmP8TgNedusvs7qnzL2eUlWXvMQnHFfy79EEwOsLAtKftX pkL0/XxoOIbqxeDqtxgzE8fBtVPoSIVk77Dc8HlQ+ln1BsHGa008ftjBzo7FepyeYATn 2aTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779790597; x=1780395397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XrZ4NvK5jrlaPy7QvhC9XeQXCUzbUpfIVsVCaVJAXRU=; b=co6xai5Ldq3S2QfkE4fP2lgaoXG+vOBCzjnKlSdb/cScBhy74Wu5Be+M275a8CV7m9 bM0pze7RsknTjK3z0aJro1gre+1KFcHUyERRzN6DMiib1jBuZHIOH+qUccsWFW1+Whpn ZAZLgsFCX+WbPF43vudaqDezpPaECCOp/pMcHOy08DxVlZTJQwOyumebNiN1FLBt3W3T Ox7/b/Q+TSnt9nSMgQKELuta/3N1wIvx67Zgpoc1i+oTog3dtZtIsPjJn9XOCtuv4m7x 4kV3siz03tT+y7/1xTLuJi7F7wH8FjJXz3x6H/4xuyKbIgtE+oSpqNRG/v2bddP+I1Y1 iXvQ== X-Forwarded-Encrypted: i=1; AFNElJ9oH/JoMZFW7PQwl2JUs8USVHPHU4cCgPbSdP/pHYvg/t7fkIGuVrvLW2Jh/k9wdIM0BY9ncByLqwNsmEA=@vger.kernel.org X-Gm-Message-State: AOJu0YzTda/MvxPYxP33VF3rKhGDZ4Lio/iifcp4woQ9hRdF51CRtTBw 9Z4ghDweSGkG0yWvw5NcejlcMg1f3dTrtb8cUG5uBM+qCcSb3yDNI6He/z5xIPr+Apg= X-Gm-Gg: Acq92OHxETeoDS0WoVFhHG6w2L25NOjv3z6mPssIQHDMQUTwPPM86uRCCVTUWc9YYyd +LgGvRUVlvg/FfdJvRrCXli2YxbGaO6CvuCgdapnM8janpWfbOcdMohwJTUgvQIpJj8M6OVFTg4 ezs+Zt1x6hppG9USGGHYmt+78X9uaA6OQwQthyGRjDewmx3xkt7nrYVB2u9JqD6LIx+k8nejSr4 ADfW7nrpjBSr+i9lDFkVfk/lINzPKyOqDGWLDJ3dyWGrL+3lCPyr7bkSVlN0JRu5btEFM/JT2J5 OZUmyIcu5goOnlb3+1efVeit/OvgXRD7S97fxfux7KRlov5hjGmHC/3E77lHpiY0oF+AgFqY0JT mHH9wlRuErASg2UQMODuCVhmYQ3rZY+to9SURfba8+sKyygoS1DG5wIAv4ezFicpTo7GEohrYCt 6IpugPhqp5sXxH7dxRc1cS6th63IakOT+9NBKWhWxWf2AKKBa5AnW9DfO1ejW/L8WXg1ZjZg== X-Received: by 2002:a17:903:3bcf:b0:2ba:df8c:11d3 with SMTP id d9443c01a7336-2beb06c0336mr204209215ad.32.1779790597039; Tue, 26 May 2026 03:16:37 -0700 (PDT) Received: from manjaro ([103.186.230.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56bc46esm127812265ad.25.2026.05.26.03.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 03:16:36 -0700 (PDT) From: Sayooj K Karun To: netdev@vger.kernel.org Cc: dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, Sayooj K Karun Subject: [PATCH] net/ipv6: icmp: fix is_ineligible() to block errors for Redirect packets Date: Tue, 26 May 2026 15:46:22 +0530 Message-ID: <20260526101622.38536-1-sayooj@aerlync.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RFC 4443 section 2.4(e.2) mandates that an ICMPv6 error message MUST NOT be originated in response to an ICMPv6 Redirect message (type 137). Add check for NDISC_REDIRECT (137) so that redirect packets become ineligible and error packets are not generated for Redirect messages. Signed-off-by: Sayooj K Karun --- net/ipv6/icmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index efb23807a026..3fdb3a97dd8e 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -157,7 +157,8 @@ static bool is_ineligible(const struct sk_buff *skb) */ if (!tp && frag_off !=3D 0) return false; - else if (!tp || !(*tp & ICMPV6_INFOMSG_MASK)) + else if (!tp || !(*tp & ICMPV6_INFOMSG_MASK) || + *tp =3D=3D NDISC_REDIRECT) return true; } return false; --=20 2.53.0