From nobody Mon Jun 8 21:59:58 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013013.outbound.protection.outlook.com [40.107.201.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4659F2C1788 for ; Tue, 26 May 2026 10:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779790004; cv=fail; b=mohMpjoPtyu8HFGpG0b+VXgxUZH41QJezs/zRSeqhjNNmfJJZRq69wmjiNNOKJ6LzRhExipEIR7hCHI+6xge85mP9st0Os5oiGd5naL1q0n3DaTy/zgfD4wv7+h49nhsqwJmoiZJ0nFOdxjfin5777k3M0JeD//KozHiwpNDmU8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779790004; c=relaxed/simple; bh=r2svGw7yf+4cv3WK2hMeKRUSK80gBz5NA1RTVAVeaVM=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=MDWbku4tJ2ZA5Cd9L0I56tJDqx38m34GgZZdtDwHN+tMzMv6+N39BmgNFLLXz39YtUol67MdWyJ4wNnB+jiNSmmx/2HOrdg8uQWRNNSQj+IRyFk2hZamdtcpzKHUf7UJ8+oSEtYiptaz7m53/7PdYSvnVE+mtRBzaHWrAEh3m54= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=p44+oolQ; arc=fail smtp.client-ip=40.107.201.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="p44+oolQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fbwd0c2uTxM/Qh8cHqHMrK1hZ4v5W3tu3zp9GFisxaRTvsqhHETudpxIPKy4+GksXQTuZfWH1dZZHXB3Wj2jbfMKVWqxDtDx9snxs0R7XU7EtJEfiFUraMdjbGmFcYSnb1xqmfDjiIKhgrY5ADn8vW8DqPalX4hy7N2PVNRC0HSqNZ2uL0LqfSt7byaWhAtGmlagpDyzrQ88dsz99M2DlbKnzxDnSuJEtWiG8ymNF0Kmo8fZXnOcbCbMKHuu8JPrRq0/00zZAurR1Y53tBMiEaSzsW+ypqoRz0C7hP8B0azBtXrPjboISBWQDf1L87STvjZXcdbaJFyPDrEyVRAiOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3A0gwyOwYBbaijo21bq+DDWUtPnMitjZ7DrFtwlDUz8=; b=afe/8SOqTw3JNnm9FMdn+dDdUHBnaeGZrOQOzKljIPG3yQ/FQ5jOkwq+bCBC/p2sNPc2mNz4l0fGvxDOiVSzQ270XnDKbeU7yZy/GSX8GgdbALKDsrdT8TVMsFGti+AIgIS/D6gqoe4iPaaKBc8/uhc7aAitPxDh1P1pOP5aIzfBpZAN/JcgGSxoLuvNnj79tadTZdNaCw2Bi4SYzhGPJAdHdg5/j/LIX7UcbVcZicWPXkp0GM8W1mIzMcWxlpx5NH2irhAOd6rfUI9tSgQtVsy7WbEIfvGzClaTSivUCVbeEcV10YAe9gupWe7wkldJAQ0xCpwHtz+oW8OIkFYklw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3A0gwyOwYBbaijo21bq+DDWUtPnMitjZ7DrFtwlDUz8=; b=p44+oolQNLSJWHJwLQ9bCx49vNCcXy1ADEfarSr3ox4O7WzJyFqpll53IoCcOsns+Trp9YtKJbKyMhOUxLE4c8DC3SDI2+JuOYkjR8GgZzOk6jnee5yLKV1rztmz34/WHIP2cMvVoumF1qq679EE5f791i3ayr79oXQtLOPTDlOXxAqEx2irQ9QBhRY6zLhADJcXHBkIv5CcuvlhXuVHxelEFfe3QBgY+bScIgHoDQ4wRqOpppNVksIoTNWcEYJCUItXxdVI9LEhunsG5gRTdfD2J1i/rfjbfSsafmcu2JsWWZtFakfymKe9cYAtNLfJc1L0AahVkEXE7KHj5VbPfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) by PH8PR12MB6987.namprd12.prod.outlook.com (2603:10b6:510:1be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.12; Tue, 26 May 2026 10:06:39 +0000 Received: from DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c]) by DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c%4]) with mapi id 15.21.0071.010; Tue, 26 May 2026 10:06:39 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , linux-kernel@vger.kernel.org Subject: [PATCH] sched/deadline: Reject debugfs dl_server writes for offline CPUs Date: Tue, 26 May 2026 12:06:32 +0200 Message-ID: <20260526100632.576069-1-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MI1P293CA0017.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::13) To DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4827:EE_|PH8PR12MB6987:EE_ X-MS-Office365-Filtering-Correlation-Id: 200b0c9a-6512-4baf-c4c6-08debb0e7a88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|18002099003|56012099003|6133799003|11063799006; X-Microsoft-Antispam-Message-Info: +AlDMXJa9ZLWPjNcNnHhZoeSGNXBqLsEz+0FXaiU7z+zw0XQaLGHNZcpom+rtzUNp2z6i1hMdB1vQzYneg5Uplt/fWQsffOJERpA7lQ3kHyYSuRnKnlTBdFXn22QHLQqRD0oWKnbdMwt4JAY0laP4IkXnMe3dtreKRigdyqy2NLZrVjPlOKMXxVXrM1BxUUPeZD7o3hH77Zkm6jXg/EeASzaDi+Bln8O1IflxBsbiWy31KyXgmaE+Pp8LobHee+Zbdk99G3lzpYXmJVqxqahjUOXx0nT+2Gz5SXkiSPjKZh2XG66JJmdgDavw9PpOFRv9UbvwhK7+ZWXorywj/azrTHH4gh0uH3YbxrXVJqv9iyy/iRzuWDGhcxZKhGQXPofijxdtzkY+as+83tkM8j5c4gmIeMoJWdgm4z7cLciclR6d1f/5XWHhUW7rF8yEe+r4nlT64D2hP7+3x0YqRSGObnb4MyK/mek1/2gKiACm8+nmTFxLRYVogXTPxZWVu2HDAHhmrEde2a7ULnh1n+E7h7NutGGpjErQwdp9y90ymKKz/XG13k/CFGuJwXNb1cqEyfH68hv/cR6OpWQA7BJVhz7tZaG+jQPmf8Slcpm2rmJciHvn/wHQbOAin3aVdzUyb55SYLh8im1imrHPB7MY1s6M0tHAbOVCXR//yRr0mnlMjNutpd7rh+qRsBQ9q4ampzhhPOs0aEytltICHYYgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4827.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(18002099003)(56012099003)(6133799003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uNa4aJfw1oCG5ZaWBMaCd78aJJ1LUnFQtOo1oxkNDKlqR66WaMjTj4bArG5j?= =?us-ascii?Q?BL7Y/yVcIyAnnDBzjSTVgYVWm2dq3w7tPwysQ/ifJfMAZzsa/Tz9X4Anx2k1?= =?us-ascii?Q?mFV5dAd4Y7rPvKTtXvdseRnBiTiFqW/AuuXfRDzLSKwSlZbmiXGHKhsHjVsb?= =?us-ascii?Q?lrx6ze2TzWrcObfZX4Nv7TnfE8X60vVSUUTYvfW/UW0gFflQhFhqPJIsXUNP?= =?us-ascii?Q?jKlJECNwlH0w3xf0ZAzSbtDwuLLy0lhpraFDQh3b7e8UySXoo9JHRwCfOmyk?= =?us-ascii?Q?0atlcuUWd23qep2gS7bPZbDS5NElA7fbK6imG8+FRE3pqek9+5pebW1EZ7UK?= =?us-ascii?Q?D4WDiM4j4mEE8+Ikxdypb9siYM/9qzRzd+DszChHxAnOtlMNiHKV7eWTIvql?= =?us-ascii?Q?gUHtsIJ1lY+ERpCzXFroFfDlYvw2kxSU53QUEE7kBw91V/trECYZQ3JSRmyy?= =?us-ascii?Q?OT7NoOsfGrWZN4um1wSc0XFnr5oZ833s5vHEJcAr2ahY+sA0M+EM574XrOWA?= =?us-ascii?Q?qQhwWiYxg28txwuhpJCJ/FEs2cA/YfpviyykEcqVigI/EE1zGo0qqGyIp6kE?= =?us-ascii?Q?QXxilrWV/rdLwax3vRGu8AQchxZCBXk8oxk5d3YKBnEamBKAZ/bdhwbdWm4u?= =?us-ascii?Q?Ri+eL7eIAfIMO7qMMCKCB+otStBnWEq3OJ5jARlT36UifY4StaiSIKw/87WZ?= =?us-ascii?Q?4vgf9MOldXT8kxkC0pumdpti62elJLsA+RkBl9EnbNBevgKaiO/XcMA4DlgZ?= =?us-ascii?Q?6x9lEeGN3zT2nYjX9EJAtCBFZCZwSYaUD4206Vzq1sIDWW/ZVqPWIQhR3Tq9?= =?us-ascii?Q?wlL4lPslFF63q9teIiq5kt3yYndVl/6YwxMe28KBDKs8G1Cyk7gCcklbBLpV?= =?us-ascii?Q?qyNMNjuTQAYweGXFhSHLjr2aJ2lwoAdJGqDA+x/10vb62670eAGtLtyiMzxd?= =?us-ascii?Q?cPcV2wKkDSWZ1+A7ODW/vOI5Ic4HnP5QXM85hBCmU5XZr3HMiPh/wfCExme4?= =?us-ascii?Q?SDMac3QeU78QAwj+eLT1sChnMLmbAtpUaqnOPXLkS/KHbq2RyqZT6OHN36lD?= =?us-ascii?Q?UuSKglIbfdwnr0Mu9KHfwATmu9Rz0BCIBwXFr4DuS9Ayt9w2tyhm4zgpgm6o?= =?us-ascii?Q?Sb4mK79WdAdLEWrHROLV+mdmyEA7/2Tfkq2CAjVCo9Sv1ixLRJRaowU9vUcj?= =?us-ascii?Q?nY16GFrKmbx6T0mz8R8/iNfo4+cOCv3Ve7gc3GanM88etIx3uxN7Uu5lMZ2+?= =?us-ascii?Q?vlN5TcQSlcxu64khvg3VnrFytpLV/bUFZ6hlvxcpE2WWPLt6BFILzMlIN3DI?= =?us-ascii?Q?dZ/0T1ZiEUeYYAQbpcD7XxR5ewac6hfnd2pArpjaWRQhXZguz3okj53rrlL8?= =?us-ascii?Q?rizabfmAlZbwcsuMHmM7cCOkl8a4i6deH/eSpNsUSRrO5L6k7Y2aKK51MVsz?= =?us-ascii?Q?evEIPvo9WMmLLcC6fkEt/hFL5jlApiiEd6Rir44c6PjbCTNrDfXPtLRW/fpu?= =?us-ascii?Q?auGLGBxYaJSa5GcMj/bV/R5AkvRXjFxPYSKZ8UTmFPpzmhuymsJy3Lcn68Nr?= =?us-ascii?Q?tDSuTBVfjWpZWgcv2ZVkIpX4Fp2iW0aqWdqDlY1X7DVw48E6kSTbD2qUywVs?= =?us-ascii?Q?QSJImvGiRu9UVMfWYlB42R090oCwPf4GMF0bD7nHUMy8bqLo47onyuPUvhZK?= =?us-ascii?Q?9q4CU/OeC7Il3c6Z4jCsLMfcyXHf56rV8GbegMD/EAYXZYjk?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 200b0c9a-6512-4baf-c4c6-08debb0e7a88 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4827.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2026 10:06:39.4272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: trN9IJHANZSGueyA4svu7W6yLJ1kUwoz5psI+eVQbMVaeiphi1ViYrQuLy3EuvbNpJXnZU7QGJmrMykCp6stAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6987 Content-Type: text/plain; charset="utf-8" Writing runtime or period via the per-CPU dl_server debugfs files (/sys/kernel/debug/sched/{fair,ext}_server/cpu*/{runtime,period}) on an offline CPU can trigger two distinct kernel issues: 1) Divide-by-zero in dl_server_apply_params(): Oops: divide error: 0000 [#1] SMP NOPTI RIP: 0010:dl_server_apply_params+0x239/0x3a0 Call Trace: sched_server_write_common.isra.0+0x21a/0x3c0 full_proxy_write+0x78/0xd0 vfs_write+0xe7/0x6e0 Both __dl_sub() and __dl_add() divide by cpus internally, which can be 0 once the CPU has been removed from any active root-domain span (this has been latent since the debugfs interface was introduced). 2) WARN_ON_ONCE in dl_server_start(): WARNING: kernel/sched/deadline.c:1805 at dl_server_start+0x232/0x270 Commit ee6e44dfe6e5 ("sched/deadline: Stop dl_server before CPU goes offline") added this check to catch enqueueing the server on an offline rq. There's no meaningful semantics for re-configuring the per-CPU dl_server bandwidth while the CPU is offline, so simply reject the write with -EBUSY so userspace gets a clear error. Reported-by: Sashiko Closes: https://lore.kernel.org/all/20260526092228.3B6891F00A3A@smtp.kernel= .org/ Fixes: d741f297bcea ("sched/fair: Fair server interface") Signed-off-by: Andrea Righi Tested-by: abaci-kreproducer --- kernel/sched/debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index ed3a0d65da0ca..e57ad8c78a60e 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -415,6 +415,9 @@ static ssize_t sched_server_write_common(struct file *f= ilp, const char __user *u return -EINVAL; } =20 + if (!cpu_online(cpu_of(rq))) + return -EBUSY; + update_rq_clock(rq); dl_server_stop(dl_se); retval =3D dl_server_apply_params(dl_se, runtime, period, 0); base-commit: 7b197f597bc895b01204d8389a4cf3b00780bd21 --=20 2.54.0