From nobody Mon Jun 8 21:59:15 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554413CC323 for ; Tue, 26 May 2026 09:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786735; cv=none; b=IACW8YQSfFtQmCAAspyo31mJaapQewoUDgqSURPTpJZ30yJmNsQKqluX5eJp6QEPxIIphCPlLrbMxSVPAR19Oq8Y1DHY+2yDHZ3UXEimiXQ2xJ4S2gJvSrMPoRkG0WLYG/Nd8IHetpvbVYH8ot+PfQUCySzoMRQJXnwxwhs7SoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786735; c=relaxed/simple; bh=p6iVCpL3J8aW/Nu69aB1Mb72NYp8ofaV6E+JPgD5s+k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=c6f4DUqzdi3V0LF2/k88kjqKNHk3I+N2VNYt5zBGHqO20d6YKwph0s7XLJKQJ0fPx1/sfikhagoe8XfRaibqP4OqeDK++zlFCM7ktRBYIp2HT5fS4hUDJMttgc78QGF7CPUZPoh81y86Xzjqlx9BVW0rX5eXgduXtWP7aOhPiv0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bi9Sqhrt; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bi9Sqhrt" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-44a5174670eso5807185f8f.1 for ; Tue, 26 May 2026 02:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779786733; x=1780391533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XVdGlC73dpgrqg3jmTOepym9CG4JSTdsRd09/R/VHZ8=; b=bi9SqhrtHuI95qcc+qzoHKzJmB4SLlESwZbGKVwcZsk9wmiHDGpYTxa4B35xQSF5Fb bl/3rxSbkeFrJydBlFo0POfG21oxgwR0F7qHsctd7ALHcg7vEsVmSkRqwan5j8ZsGm/h QeICymllM0Ul1WaY8CYoq8PYEYNm1RL8zPnTqM6fS45sIxm/klk+RUkm07YBx6LWItxV BamAdjaqEiFwaE4Nu7E9T45ZE/+YU8ReVpIBt3mnpKW7yhV0mdZ3U2xNrn7Bo1Elecbu 2wHCEI7y50ldiGykGF2dkd29cV9EFi3t7/I1ZM2+omoklCQuuQdz44z/gyOTg9doMEHf 22YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779786733; x=1780391533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XVdGlC73dpgrqg3jmTOepym9CG4JSTdsRd09/R/VHZ8=; b=WkRsI3TBltqkbfw81/yPhOJhKN61KLTMhbOsdvpBv6DPZgDfDYpJZbj2LI5C/AZbJm CFhRwT3pTHhjsJ7E+Du5yPKVFoqqIZZdGs97tt5bowGLZ5D+9Mfgwjklwj52jAUNii+0 Qfl7hOOlg8Hiw+dOxbw93gGtA6sOZ/bw3qa1Q8sNc7D70LOGVajpnX6RVBhcboAR7Hn7 SdvY8aMQT8j84CxGw6s3zawVwiowYr+u/aERZFc/Di4SnB9JoufDkRUUZlsQCF0deDb4 uVeXT8tg+TIAZAbiP1VQPsb2dY+A7WwWuTUmwaPK2OngO8u2cDJq2gFtuqCl92JSedUC M0BA== X-Forwarded-Encrypted: i=1; AFNElJ+RSloEAesyD0vsA+/X+YRCGWZ6/3fBd01lu7aJy9f4wB0bHVLhq/sNtJy1Y4eBUeDCsuFI0G1Z6WolJOw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLJerlC9f7mOboFaOlTGliyW670tAY48GG9+TNhB7c8pnpQNDM GuzaFsY0v0R9kmNUAP5ht8rRm5PiL4uj43+YVzxCPE5h82p2yWGWMU5d X-Gm-Gg: Acq92OEC5jBV+bg9qDUdZwReB53Qg1vsHTek79atW/wOgEmmQq5aHKpqFwgj3QBoIpU paaAUlyckJUx9XlkSBuXL+jIVcga1PxDxBY7sUM/CQNskO6IPe+gQpFeHqvPgK6PR3qGPrFsVje wQHz424b4+vI/pAbWW9exCAN4qc2/XHc1bUX2JlcvBs5fifPQ3EdVIzbUWRtGF/F039ZBGuINah zfaiUByvZB6RUbT3ejyzlFojJZPY0J3rUjBJ8BSKf0iCwm/zbWqZ/tFwWgvoktLTdQ6N7zPPvmO ZSdmrIFy6ruf67DX/aaXNcEyef2ez1qRoylHmFCuDZySwtSWkkrdG0W+a0Cr/Dx7YHdHSKHpCtY WhXgd+nKTQOFeKufsRF3FsYH8y29SmSQkOyU0HP70YZJACk3uafiNvc7UERuhESHctokOv2FX0+ FIkK5yCVnPyEug3KP7Fkc5++NdZAtdn4snY1pShpv58iA02xxB4sNjPTbH4KbcBZJVLCudQDVP2 I2J3TQu8j1MGQ== X-Received: by 2002:a05:6000:1a87:b0:43f:e2b7:7160 with SMTP id ffacd0b85a97d-45eb3673319mr31634787f8f.4.1779786732366; Tue, 26 May 2026 02:12:12 -0700 (PDT) Received: from localhost.localdomain ([90.173.102.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d5e363sm34749267f8f.28.2026.05.26.02.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 02:12:11 -0700 (PDT) From: =?UTF-8?q?Guillermo=20Rodr=C3=ADguez?= To: Pierre-Yves MORDRET , Alain Volmat , Andi Shyti , Maxime Coquelin , Alexandre Torgue , Wolfram Sang Cc: =?UTF-8?q?Guillermo=20Rodr=C3=ADguez?= , linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: stm32f7: fix timing computation ignoring i2c-analog-filter Date: Tue, 26 May 2026 11:12:09 +0200 Message-Id: <20260526091210.20383-1-guille.rodriguez@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable stm32f7_i2c_compute_timing() uses i2c_dev->analog_filter to pick the analog filter delay, but i2c_dev->analog_filter is parsed from the "i2c-analog-filter" DT property only after the compute_timing loop in stm32f7_i2c_setup_timing(), so in practice the timing calculations always ignore the analog filter. On an STM32MP1 board with clock-frequency =3D <400000> and i2c-analog-filter set, measured SCL frequency was ~382 kHz. This also affects (widens) the computed SDADEL range. At high bus clock speeds, this can select an SDADEL value that violates tVD;DAT (data valid time). Fix by parsing "i2c-analog-filter" before the compute_timing loop. Fixes: 83c3408f7b9c ("i2c: stm32f7: support DT binding i2c-analog-filter") Cc: stable@vger.kernel.org Signed-off-by: Guillermo Rodr=C3=ADguez Acked-by: Alain Volmat --- drivers/i2c/busses/i2c-stm32f7.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm3= 2f7.c index 53d9df70ebe4..067af255bd22 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -694,6 +694,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_= dev *i2c_dev, if (!of_property_read_bool(i2c_dev->dev->of_node, "i2c-digital-filter")) i2c_dev->dnf_dt =3D STM32F7_I2C_DNF_DEFAULT; =20 + i2c_dev->analog_filter =3D of_property_read_bool(i2c_dev->dev->of_node, + "i2c-analog-filter"); + do { ret =3D stm32f7_i2c_compute_timing(i2c_dev, setup, &i2c_dev->timing); @@ -715,9 +718,6 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_= dev *i2c_dev, return ret; } =20 - i2c_dev->analog_filter =3D of_property_read_bool(i2c_dev->dev->of_node, - "i2c-analog-filter"); - dev_dbg(i2c_dev->dev, "I2C Speed(%i), Clk Source(%i)\n", setup->speed_freq, setup->clock_src); dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", --=20 2.25.1