From nobody Mon Jun 8 22:53:04 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662A13B7B83 for ; Tue, 26 May 2026 04:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779768812; cv=none; b=NOKlwn2fkLy4N5AMuFOLk7PbwS7D7tvhgusUPm1Dxef3EAFEBvTWpxQOc3qchx22+lUF86Gjo/IQls3lKw83BWX/lQLO630Ed+v4Iz85Z6K/M1mThH/RjAwBw/tVBzN0qfDfUN4fjtw3c+8Ajfpf2u/vjnuvdDdOK8zAYWyZS7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779768812; c=relaxed/simple; bh=xTsHZDYQwum2QlLXYNCH2s59XPiw2BSHIOY5zFmiYa8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f3SI5VKeDBEgK/oqjzwSsGu4OQnnsjblhgd18xi77kWvGxVb7FxamhtRcI+GGbmhKybvMChoNTImOqLkQKBeEmcL3NRbHSYBWsrBiETQi2eqklsVYXn5o6JkYL11XoqOKp3HL+wWzpBfmXEuzX4TMwvkVT/hwgYRvW58aeL2gEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sAQCPTVO; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sAQCPTVO" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c7ffe8eeaf2so4139074a12.0 for ; Mon, 25 May 2026 21:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779768802; x=1780373602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C0Q5miFwy3tG8zNhMFBCq3/h29OE3WocoHy+YY3lzMM=; b=sAQCPTVOmuY3blXNbz091iDLaCVketnrQpPS5nlboK5orOOaUNAaDQD/6ea5gZkK99 cgZ91wF+souanutGl6YESsvIU4y/uJaWME7oqR2stspYaKPiEwqqxuUuCaDxBds0hcJy d/KGtpXrPiDEYM0dQIs+5xCAw4jUgvucunuDbHKMk3dpXjtcOJGpDnOg8yT375giALkW fda2OGcjY/gpX0EChJukADI1dJeovsZzgVncH9rl16s3hyUOAmmVYDHlrMs8/1Z5aAVl 3oaTfc2B0+n8hquC6+Ip7jE/V4KrEO2IRunumHo7ZpHK68r9LIrRzbDzlMFMF/VpHTiz OnNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779768802; x=1780373602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C0Q5miFwy3tG8zNhMFBCq3/h29OE3WocoHy+YY3lzMM=; b=p30+4duS9qkNGaHPjxbXt6sGEJFQdhwkwogtYHOUspbQfx43gdaukK/Nr0YAHlMkVx ZlyIeA3sMoyznzk45Cqos8OA/jlDLlYs8KUMLSZibVIuSVYqWtQEKi0Fd50O/aX7Y5DI pbd1LRNLwef1cyneuB0xlPQKP/UnCXawuUQLxj3ULqzs8NPGGh1NClUPQPARqngPXTBD Wf41YSvUd10maiWsZLYriCVIwwpOr65tTaR3Zr5Dvl7m74ArmIR0IUPZesi2hTK8KmF0 qiJnggU5r0C/P3ef8GVjqVF51Tg070+xl+yyAn1ywaxELElKjWNtyWBGmQzVVyf6H9Hp O0kg== X-Forwarded-Encrypted: i=1; AFNElJ9rgP3SdC9oK+joImq9X/TrtTlIRVSFQ2PUlWVKsHE/kBNN/zhtiTW+t4ag+/xvOQyFCkjGn8+pomZEDnI=@vger.kernel.org X-Gm-Message-State: AOJu0YzqyY7LBOTqQ2CN4zQR1K3D/2eyqVH6N7H1dXSbuPHWHBhU7LRo DOF3XIDIRmsY2A0/fa5YkI7M0BxgvLIAsnPNEIq/w6yB6g+LNuU+b0Wx X-Gm-Gg: Acq92OHGb0UOB67Hb8DXFHaRK548hQhpnKwhf6DKty7KF5sNg28a6XUNRrydMaLf2Lv PcC4Iqc3CZ87n13EnY5SCyx8KIatn9Rff4oX5FkDl0pv8eaciFj47OGJTZBfRYeUBkInZ3O73BB ZfeaKyPcrbGmJAnyXHWLVkmoBF+/VcJlu71UOnyWquMuzsfOMSt1toBtKk3SJLg4OgQLd5HgR7P qJLZNKumyUo5BZiA1+WoRdlPpTarMtnzFWiFJetY+/KX+iA4PXAVtWysOlN/uCT48EbEgakRwwG WPGOVKJ9PQk8kfNcPVSMCjMbfoJa5Y2n5oYyntzjCgClIdOB5jlWDAWn1dFRV74Hed4kIIKqMJ5 b3pGHBfN6UqQS2k2WgYJpnH8chgpfxXuvr6aX99cBY7dfvcccqy3iroxzMi5j2dnI4ZyWtfQ7MK Pn56eSKrqq3Ej2SEWnwSjNDNTmCIVYENSysgMjbQ== X-Received: by 2002:a17:902:f60f:b0:2b0:5795:9ead with SMTP id d9443c01a7336-2beb02cb6bamr182900635ad.0.1779768801981; Mon, 25 May 2026 21:13:21 -0700 (PDT) Received: from fedora ([2001:ee0:4fc8:5b0:526c:3adf:8a0d:13a8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56f4343sm144349485ad.36.2026.05.25.21.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 21:13:21 -0700 (PDT) From: lazyming To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, sowmini.varadhan@oracle.com, willemdebruijn.kernel@gmail.com, w@1wt.eu, security@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, asml.silence@gmail.com, achender@kernel.org, mst@redhat.com, jasowang@redhat.com, Minh Nguyen , Willem de Bruijn Subject: [PATCH net v2] net: skbuff: fix missing zerocopy reference in pskb_carve helpers Date: Tue, 26 May 2026 11:12:39 +0700 Message-ID: <20260526041240.329462-1-minhnguyen.080505@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Minh Nguyen pskb_carve_inside_header() and pskb_carve_inside_nonlinear() both copy the old skb_shared_info header into a new buffer via memcpy(), which includes the destructor_arg pointer (uarg) for MSG_ZEROCOPY skbs. Neither function calls net_zcopy_get() for the new shinfo, creating an unaccounted holder: every skb_shared_info with destructor_arg set will call skb_zcopy_clear() once when freed, but the corresponding net_zcopy_get() was never called for the new copy. Repeated calls drive uarg->refcnt to zero prematurely, freeing ubuf_info_msgzc while TX skbs still hold live destructor_arg pointers. KASAN reports use-after-free on a freed ubuf_info_msgzc: BUG: KASAN: slab-use-after-free in skb_release_data+0x77b/0x810 Read of size 8 at addr ffff88801574d3e8 by task poc/220 Call Trace: skb_release_data+0x77b/0x810 kfree_skb_list_reason+0x13e/0x610 skb_release_data+0x4cd/0x810 sk_skb_reason_drop+0xf3/0x340 skb_queue_purge_reason+0x282/0x440 rds_tcp_inc_free+0x1e/0x30 rds_recvmsg+0x354/0x1780 __sys_recvmsg+0xdf/0x180 Allocated by task 219: msg_zerocopy_realloc+0x157/0x7b0 tcp_sendmsg_locked+0x2892/0x3ba0 Freed by task 219: ip_recv_error+0x74a/0xb10 tcp_recvmsg+0x475/0x530 The skb consuming the late access still referenced the same uarg via shinfo->destructor_arg copied by pskb_carve_inside_nonlinear() without a refcount bump. This has been verified to be reliably exploitable: a working proof-of-concept achieves full root privilege escalation from an unprivileged local user on a default kernel configuration. The fix follows the pattern of pskb_expand_head() which has the same memcpy/cloned structure. For pskb_carve_inside_header(), net_zcopy_get() is placed after skb_orphan_frags() succeeds, so the orphan error path needs no cleanup. For pskb_carve_inside_nonlinear(), net_zcopy_get() is placed after all failure points and just before skb_release_data(), so no error path needs cleanup at all -- matching pskb_expand_head() more closely and avoiding the need for a balancing net_zcopy_put(). Fixes: 6fa01ccd8830 ("skbuff: Add pskb_extract() helper function") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Minh Nguyen Reviewed-by: Willem de Bruijn Reviewed-by: Pavel Begunkov --- v2: - Use real name in From/Signed-off-by (Jakub Kicinski) - Add Reviewed-by tag (Willem de Bruijn) net/core/skbuff.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 44ac121cf..6a1a2c203 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -6810,6 +6810,8 @@ static int pskb_carve_inside_header(struct sk_buff *s= kb, const u32 off, skb_kfree_head(data); return -ENOMEM; } + if (skb_zcopy(skb)) + net_zcopy_get(skb_zcopy(skb)); for (i =3D 0; i < skb_shinfo(skb)->nr_frags; i++) skb_frag_ref(skb, i); if (skb_has_frag_list(skb)) @@ -6953,6 +6955,8 @@ static int pskb_carve_inside_nonlinear(struct sk_buff= *skb, const u32 off, skb_kfree_head(data); return -ENOMEM; } + if (skb_zcopy(skb)) + net_zcopy_get(skb_zcopy(skb)); skb_release_data(skb, SKB_CONSUMED); =20 skb->head =3D data; base-commit: 94e3dd6874bf04d5939bc8431b9f7852f3a4a121 --=20 2.54.0