From nobody Mon Jun 8 22:54:20 2026 Received: from canpmsgout08.his.huawei.com (canpmsgout08.his.huawei.com [113.46.200.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A50029E10F; Tue, 26 May 2026 01:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.223 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779760555; cv=none; b=LhKvhW2519xVUTQ14aH0YPmub24fsAcssVm3XEzo7TflD07B+ZYdW/MTMxx1ubMRl0OCZ2AijoFNNyFhDhKZNTn3e0qyBBvUQxzBO1/rrGc+SP7SZ4pBbHxDAY4l+cS0jFSN6rPF/QcEU/o3MlE+cbUxja2oATXFUKSQuHy2aKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779760555; c=relaxed/simple; bh=vlcyG20a44xK5NP4c5hbAi30HisFbU79Yg9eRc0mvbk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TLPXtGg8YaSd2yA/0ewBTCxzxn2Ccbn/XcEVLsC1qVrdWnffZzT43I3FeJe/dPnKOPSHW0pusu4AuOrZMLKmhbsZqOsLJ73ZfkuTlcSruzAfT9JNHUIpyV6rSdD2n4Z+1hwtzkkRbcgJ+w8MG7gdn8nedohjmY7X0LjpSrW1lsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=HS3b8kIR; arc=none smtp.client-ip=113.46.200.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="HS3b8kIR" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=gEIvW/6wtZnScM7ws+i7IkXSapQJNZN2tini6VXnhhg=; b=HS3b8kIRVbrL4V5eFfTDFb0GXN+X3pbxUAibaEKzR3qmy9BXYZC7YENkizK8Q0lh6WrXEMyLN mK/ZdGdtJoAowq2GktW+yvwqj+szmf4/NH8ylXh3fYw52lBWPbjtwK2TPsGnqKMM/enK6KSRS2/ 3ubRxCXlQ+vmX4trNHlhujE= Received: from mail.maildlp.com (unknown [172.19.163.127]) by canpmsgout08.his.huawei.com (SkyGuard) with ESMTPS id 4gPbHR2pmDzmVCF; Tue, 26 May 2026 09:48:03 +0800 (CST) Received: from kwepemj100018.china.huawei.com (unknown [7.202.194.12]) by mail.maildlp.com (Postfix) with ESMTPS id 783BE402AB; Tue, 26 May 2026 09:55:49 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by kwepemj100018.china.huawei.com (7.202.194.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Tue, 26 May 2026 09:55:48 +0800 From: Xingui Yang To: , , , CC: , , , , , , Subject: [PATCH v4 1/2] scsi: libsas: refactor sas_ex_to_ata() using new helper sas_ex_to_dev() Date: Tue, 26 May 2026 09:54:17 +0800 Message-ID: <20260526015418.2022398-2-yangxingui@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260526015418.2022398-1-yangxingui@huawei.com> References: <20260526015418.2022398-1-yangxingui@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemj100018.china.huawei.com (7.202.194.12) Content-Type: text/plain; charset="utf-8" The sas_ex_to_ata() function checks for an attached ATA device on an expander phy. Refactor it to use a new helper function sas_ex_to_dev() which returns any device type attached to an expander phy, improving code reuse and allowing other code paths to find attached devices regardless of type. No functional changes intended. Signed-off-by: Xingui Yang Reviewed-by: John Garry Reviewed-by: Jason Yan --- drivers/scsi/libsas/sas_expander.c | 12 ++++++++---- drivers/scsi/libsas/sas_internal.h | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_e= xpander.c index f471ab464a78..f55ae9a979cd 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -345,11 +345,9 @@ static void sas_set_ex_phy(struct domain_device *dev, = int phy_id, SAS_ADDR(phy->attached_sas_addr), type); } =20 -/* check if we have an existing attached ata device on this expander phy */ -struct domain_device *sas_ex_to_ata(struct domain_device *ex_dev, int phy_= id) +struct domain_device *sas_ex_to_dev(struct domain_device *ex_dev, int phy_= id) { struct ex_phy *ex_phy =3D &ex_dev->ex_dev.ex_phy[phy_id]; - struct domain_device *dev; struct sas_rphy *rphy; =20 if (!ex_phy->port) @@ -359,7 +357,13 @@ struct domain_device *sas_ex_to_ata(struct domain_devi= ce *ex_dev, int phy_id) if (!rphy) return NULL; =20 - dev =3D sas_find_dev_by_rphy(rphy); + return sas_find_dev_by_rphy(rphy); +} + +/* check if we have an existing attached ata device on this expander phy */ +struct domain_device *sas_ex_to_ata(struct domain_device *ex_dev, int phy_= id) +{ + struct domain_device *dev =3D sas_ex_to_dev(ex_dev, phy_id); =20 if (dev && dev_is_sata(dev)) return dev; diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_i= nternal.h index 7dce0f587149..350a70484bde 100644 --- a/drivers/scsi/libsas/sas_internal.h +++ b/drivers/scsi/libsas/sas_internal.h @@ -91,6 +91,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy); =20 void sas_device_set_phy(struct domain_device *dev, struct sas_port *port); struct domain_device *sas_find_dev_by_rphy(struct sas_rphy *rphy); +struct domain_device *sas_ex_to_dev(struct domain_device *ex_dev, int phy_= id); struct domain_device *sas_ex_to_ata(struct domain_device *ex_dev, int phy_= id); int sas_ex_phy_discover(struct domain_device *dev, int single); int sas_get_report_phy_sata(struct domain_device *dev, int phy_id, --=20 2.43.0 From nobody Mon Jun 8 22:54:20 2026 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A8112D0292; Tue, 26 May 2026 01:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779760556; cv=none; b=b64Iqq9H9jb+FO9Mh4ZFzV5ktfYBpt2Cufvn9pDB+7qQystUj09mlo4d/A86pVbn3i8Eyf6ecvjHIFZDlhqvqCUpwO9eGJlGvGtKbzuzDMc/r1SLWJF9GF/E1jd4dId0WvNRSTWeAQ5ss1TRuHJW/ndtDvZlBfi+1KjRhbO9Ssg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779760556; c=relaxed/simple; bh=T4vcKlwy7qLyp4ZuvdYsQ+O5BMqPiwfYibNl2GT2Xm0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jQcM9oFYDhmhU1tpbsZXSoBWFMKAWM6ATorD3D2K/o1fVn5r3lZ4jKFRb4+A6VzkbcW2nTemjnWumRzh2JvwKlhIZuPlCMIcL5qqlZGCZjFsJ4lXwjSSDsprKRDy8hz9XUx9SCtBpXT+J+UDaN/IGCh0Nbui20og5wtKMgvH97U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=pwytdp9l; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="pwytdp9l" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=2zqnTLnUw/loyc0Q7keUARTef/j8IBwu1gIANLADZ1A=; b=pwytdp9ls+LmtFIc8bnkLbJMhrMgI2ygrJaxQjzahwUpRiIK4slazOjKkSTcSKM+9ubkaq8ep MliAiFqlqN9NMPpeCl+te0imLwOp7mwSHQsU+vOe8akLSy6RDoVwgTyJCg/IUBBxNhYpXVbqrMa t+sIDwaxhJt5qnr1r3reZ7Y= Received: from mail.maildlp.com (unknown [172.19.162.223]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4gPbHB5Ws7z1T4Fv; Tue, 26 May 2026 09:47:50 +0800 (CST) Received: from kwepemj100018.china.huawei.com (unknown [7.202.194.12]) by mail.maildlp.com (Postfix) with ESMTPS id 1343840561; Tue, 26 May 2026 09:55:50 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by kwepemj100018.china.huawei.com (7.202.194.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Tue, 26 May 2026 09:55:49 +0800 From: Xingui Yang To: , , , CC: , , , , , , Subject: [PATCH v4 2/2] scsi: libsas: Add linkrate and sas_addr change detection in rediscover Date: Tue, 26 May 2026 09:54:18 +0800 Message-ID: <20260526015418.2022398-3-yangxingui@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260526015418.2022398-1-yangxingui@huawei.com> References: <20260526015418.2022398-1-yangxingui@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemj100018.china.huawei.com (7.202.194.12) Content-Type: text/plain; charset="utf-8" In sas_rediscover_dev(), when detecting a "flutter" condition (same SAS address and compatible device type), the code assumes the device remains unchanged and only handles SATA pending state recovery. However, this approach misses two important scenarios: First, the flutter detection only compares SAS address and device type, ignoring potential linkrate changes that may have already occurred. Second, after sas_ex_phy_discover() re-queries the expander phy, both linkrate and attached SAS address may be updated. The current code does not validate these changes against the existing child device. Additionally, the replace code path (different SAS address detected) has a sysfs duplication issue: sas_unregister_devs_sas_addr() only marks the device as gone, but the actual sysfs cleanup happens later in sas_destruct_devices(). Calling sas_discover_new() immediately after unregister causes sysfs_warn_dup() errors. Introduce sas_is_flutter() to check whether it is a true flutter with validation for linkrate and sas_addr changes. It returns true for normal flutter and false when changes are detected requiring rediscovery. Introduce sas_rediscover_phy() to handle async rediscovery for both flutter and replace cases. When invoked: - Set phy_change_count and ex_change_count to -1 to force revalidation - Unregister the device via sas_unregister_devs_sas_addr() - Queue DISCE_REVALIDATE_DOMAIN event The old device sysfs is cleaned up by sas_destruct_devices() at the end of current revalidation work. The new event triggers discovery via sas_discover_new() since attached_sas_addr is cleared, avoiding the sysfs duplication issue. Signed-off-by: Xingui Yang Suggested-by: John Garry --- drivers/scsi/libsas/sas_expander.c | 67 +++++++++++++++++++++++------- 1 file changed, 53 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_e= xpander.c index f55ae9a979cd..4e8e1b339889 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -1962,6 +1962,56 @@ static bool dev_type_flutter(enum sas_device_type ne= w, enum sas_device_type old) return false; } =20 +static void sas_rediscover_phy(struct domain_device *dev, int phy_id, + bool last) +{ + struct expander_device *ex =3D &dev->ex_dev; + struct ex_phy *phy =3D &ex->ex_phy[phy_id]; + + phy->phy_change_count =3D -1; + ex->ex_change_count =3D -1; + sas_unregister_devs_sas_addr(dev, phy_id, last); + sas_discover_event(dev->port, DISCE_REVALIDATE_DOMAIN); +} + +static bool sas_is_flutter(struct domain_device *dev, int phy_id, + u8 *sas_addr, enum sas_device_type type) +{ + struct expander_device *ex =3D &dev->ex_dev; + struct ex_phy *phy =3D &ex->ex_phy[phy_id]; + struct domain_device *child_dev; + char *action =3D ""; + + if (SAS_ADDR(sas_addr) !=3D SAS_ADDR(phy->attached_sas_addr) || + !dev_type_flutter(type, phy->attached_dev_type)) + return false; + + child_dev =3D sas_ex_to_dev(dev, phy_id); + + sas_ex_phy_discover(dev, phy_id); + + if (child_dev && dev_is_sata(child_dev) && + phy->attached_dev_type =3D=3D SAS_SATA_PENDING) { + action =3D ", needs recovery"; + } else if (child_dev && child_dev->linkrate !=3D phy->linkrate) { + pr_info("ex %016llx phy%02d linkrate changed from %d to %d\n", + SAS_ADDR(dev->sas_addr), phy_id, + child_dev->linkrate, phy->linkrate); + return false; + } else if (child_dev && + SAS_ADDR(child_dev->sas_addr) !=3D SAS_ADDR(phy->attached_sas_addr)) { + pr_info("ex %016llx phy%02d sas_addr changed from %016llx to %016llx\n", + SAS_ADDR(dev->sas_addr), phy_id, + SAS_ADDR(child_dev->sas_addr), + SAS_ADDR(phy->attached_sas_addr)); + return false; + } + + pr_debug("ex %016llx phy%02d broadcast flutter%s\n", + SAS_ADDR(dev->sas_addr), phy_id, action); + return true; +} + static int sas_rediscover_dev(struct domain_device *dev, int phy_id, bool last, int sibling) { @@ -2015,27 +2065,16 @@ static int sas_rediscover_dev(struct domain_device = *dev, int phy_id, if (res =3D=3D 0) sas_set_ex_phy(dev, phy_id, disc_resp); goto out_free_resp; - } else if (SAS_ADDR(sas_addr) =3D=3D SAS_ADDR(phy->attached_sas_addr) && - dev_type_flutter(type, phy->attached_dev_type)) { - struct domain_device *ata_dev =3D sas_ex_to_ata(dev, phy_id); - char *action =3D ""; - - sas_ex_phy_discover(dev, phy_id); + } =20 - if (ata_dev && phy->attached_dev_type =3D=3D SAS_SATA_PENDING) - action =3D ", needs recovery"; - pr_debug("ex %016llx phy%02d broadcast flutter%s\n", - SAS_ADDR(dev->sas_addr), phy_id, action); + if (sas_is_flutter(dev, phy_id, sas_addr, type)) goto out_free_resp; - } =20 /* we always have to delete the old device when we went here */ pr_info("ex %016llx phy%02d replace %016llx\n", SAS_ADDR(dev->sas_addr), phy_id, SAS_ADDR(phy->attached_sas_addr)); - sas_unregister_devs_sas_addr(dev, phy_id, last); - - res =3D sas_discover_new(dev, phy_id); + sas_rediscover_phy(dev, phy_id, last); out_free_resp: kfree(disc_resp); return res; --=20 2.43.0