From nobody Mon Jun 8 21:47:07 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E2C43DA7EC for ; Tue, 26 May 2026 11:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779794923; cv=none; b=I+LfwiJBcZbFIwdwTIxRUPKOmpKwZmAkgSDBh6UqnYswXANHPd84Y2XOcI8QyFuRqfovW8/NkYxeIHVWC+D+e6FoKS6zufnzu3S/F33GGdYYwXULkypBE/6F+nMG8cbN2sRp+47cMT+985QjE3RBKA0NCTmT1SpPZfdnjwNoHsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779794923; c=relaxed/simple; bh=CBsOtoU8c2acc8GLWgHV8gzC9H9b1DFgPOKfk/lGM8Y=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=p1VDRsQxmQ3E3AsDFmDUndOfTO2G5WEBfBpEgtQbFqbo0uXch7/0pwGRhDSmgDmOfhhxVBbp1cmkX0HgD6FB9vJgijc241ER8JoOS3PgVCn4CxICrKUzFALTncjMlZeJKG/19iiAlc2ckue4KemCC6MH/pbn7zOGqpSyutg0BaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jnSk1Rj/; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jnSk1Rj/" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-490261c79fcso34939975e9.0 for ; Tue, 26 May 2026 04:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779794921; x=1780399721; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=T2QBGqDxu1pEa0HDUW9WH6vK3RxwxPcJXfkG/NS5ntw=; b=jnSk1Rj/X9u5sYYFMtGQIiXQbt0av3ywjPe377E9VogfzjtrFtB2CiYVJlSS/7s3Y8 dyQXSuDOt5FPQ1N7TO45Fh+M1S9DlmGKNnLpuCsRDIa90Tz897minXc3Wrf61y7Lwga1 y4NWK0M0e533tziYvU9ofjPTu+ipnmQVF38GZRVDEudFKHLnCXHXAuzN+HdzFuLrXKvu 3Wn0ZFC1qT6N4zfLAqA9cH0MA/MD3lrO3ZYvrkGNT8O5jSAgREZdNfflUiuOl5FR/PxT lOLZYka8Zt+Eb4f5KLjDOJD4Egc0hefsACZem2KSYhc0DnA5PK6ZeEHtw/0J9H5Y2dxq bK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779794921; x=1780399721; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T2QBGqDxu1pEa0HDUW9WH6vK3RxwxPcJXfkG/NS5ntw=; b=kB9qqosgHHoJ6CCiOZiJC6VL2cszid4+Wi/aWBo7lJfZ+jUxKTgO1JCUfAkFBsh+/k +ulOcw7v903BfjbhE+2u0NAMuMeP6e2gPgyNzYdNDjBveveV6lKQc7EzvxX2I4WzYY59 d+2Nv/5zH8n2tYwBOrsUuegvwbesTaXM5//VutZmqEGmyCESYmTqN+ZiSS/gOMxpZ4v1 uWQCrMZeL7QAt64jyX7mWB1UVxzqyEpZpsXejqFa5DmIuc7ROqNKkUaV13eT3p2MMKLw Whl4OpF+YmGQ8qTU8pzCBKn/akYXKQDDAC292NdKeQqZcJPJbg8tTj/ob/z6qepHBSeE AsPQ== X-Forwarded-Encrypted: i=1; AFNElJ8Ivs6y26wxL38Q/AjhKI2b2HyZldTauU2OkjtDU2VQVojYyO9BgIFcoIWujeMSS11lJWS8BRMfWRy896M=@vger.kernel.org X-Gm-Message-State: AOJu0YwJn9XC1oqabv3zCwomFURWJJgQxC37t5ECLlcmG+gWqD3mJtjr pT7GaheUtux950AUOD5jB+LidlGuegGK369HAadzZgckp/HMc5cKB/j/w8cwNqW6gPFYSc2rv3d PqPfMUI3Qrl1Tbw== X-Received: from wmsm15.prod.google.com ([2002:a05:600c:3b0f:b0:487:304a:7fdd]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a7b:c7ca:0:b0:490:4b89:5372 with SMTP id 5b1f17b1804b1-4904b8956c5mr154388755e9.11.1779794920584; Tue, 26 May 2026 04:28:40 -0700 (PDT) Date: Tue, 26 May 2026 11:28:36 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAOODFWoC/3WNUQvCIBRG/8q4z91QlyE99T9ihNM7J2xTtEYx/ O/ZoMcez4HvfBtkSp4yXJoNEq0++7BUEIcGzKgXR+htZRBMnJnkAqN2dNfTFAw+l1nHSBZjooi m1cRaxa1UPdR5lYN/7elbV3n0+RHSe39a+df+ou3/6MqRodXGDvLERE/q6kJwEx1NmKErpXwAC gmZrMEAAAA= X-Change-Id: 20260512-page_alloc-unmapped-prep-c3ae0381d58b X-Mailer: b4 0.14.2 Message-ID: <20260526-page_alloc-unmapped-prep-v2-1-412f4d486115@google.com> Subject: [PATCH v2] mm/page_alloc: remove VM_BUG_ON()s from pindex helpers From: Brendan Jackman To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Vlastimil pointed out that the VM_BUG_ON()s have fallen out of favour, so remove them. Suggested-by: Vlastimil Babka (SUSE) Link: https://lore.kernel.org/all/4074a816-9e75-45a6-8141-25459bcc106b@kern= el.org/ Signed-off-by: Brendan Jackman Reviewed-by: Vlastimil Babka (SUSE) --- Changes in v2: - Rebased onto mm-new, removed VM_BUG_ON()s - Link to v1: https://lore.kernel.org/r/20260513-page_alloc-unmapped-prep-v= 1-0-dacdf5402be8@google.com --- mm/page_alloc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1b5b1e556f76feadf21f3f44a9440fe883fb7651..e47679e7a9dbc772aa27f550a10= aa8c0e95af55a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -653,13 +653,8 @@ static inline unsigned int order_to_pindex(int migrate= type, int order) if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { bool movable =3D migratetype =3D=3D MIGRATE_MOVABLE; =20 - if (order > PAGE_ALLOC_COSTLY_ORDER) { - VM_BUG_ON(!is_pmd_order(order)); - + if (order > PAGE_ALLOC_COSTLY_ORDER) return NR_LOWORDER_PCP_LISTS + movable; - } - } else { - VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER); } =20 return (MIGRATE_PCPTYPES * order) + migratetype; @@ -672,8 +667,6 @@ static inline int pindex_to_order(unsigned int pindex) if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { if (pindex >=3D NR_LOWORDER_PCP_LISTS) order =3D HPAGE_PMD_ORDER; - } else { - VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER); } =20 return order; --- base-commit: da0a06486ac3ce47c6ffb603d2fd332229d41592 change-id: 20260512-page_alloc-unmapped-prep-c3ae0381d58b Best regards, --=20 Brendan Jackman