From nobody Mon Jun 8 22:52:41 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682E3233149 for ; Mon, 25 May 2026 17:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779731180; cv=none; b=KTmCpqjVURj0q6ID81TYgz2IhjUalFM4zP3TZkxxcTS8Wy0552iMlt/Pbare2kzpFrWfcoo7hZc+FdRPTzl4mgC2BHvCba2Qk6Tdsns6tsO/eRZNWJqHGYxqheXfWJQY585AACp9K64iIGQkZ2zADNjziMIegZQ8K96Nrxg98ko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779731180; c=relaxed/simple; bh=n7HVhrncspr10qbBa4sII0538CmxoZUHUMIHIe9Bljg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mx+TCtTHrAjPGgCytgBRl4ob5rEdpQXlAviVB88DnlSyiOMcDsgQJOXB+uWziLMw0cGU1x7vvJOYW4hEUpgRntGN02oj0ppdCzNO1Gt0fmZB9WPxwIfs4fX9aeNIs8Vu6Si6w+Q9fItD3jUKhRrBTpC9sEVHe0SqcjaCB6oXpNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F/aCjVgd; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F/aCjVgd" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-914bd98faafso229640585a.0 for ; Mon, 25 May 2026 10:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779731178; x=1780335978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bxCYMuiUoPFXfA4b1WnIaiXxDWxjUVKA/EAz/4H7APs=; b=F/aCjVgd526UMK5lAV4SWZ9g14poIunz2UWwCS0TzUyCdniMyx+xbXTTIm8Z/1x94A pvKS4tWP5qYR/dHXvciKa1NRgBZ9IXbwbVxQkpRm+sdD5uBPnmaftbGiA8A4lL9u+lI9 zEhqhq9LWqjRUY4qL1UBOBD8Y8HdknX09bAEYUzYO12exxejSBtkcgvElEikDXJXd6FC OF2upgJURwq3qwCcbwibSm8LAQk4LLm20Eb7BmiUA9j6ZhF+OGGGeJR9xsQChqn4vu9X y2wPrVK9y+XiosZEgHlUg61IeYrbhdorhKArxfTJLD24ArCAzn0aSSYVW2GkDqQEZwIC 2kFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779731178; x=1780335978; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bxCYMuiUoPFXfA4b1WnIaiXxDWxjUVKA/EAz/4H7APs=; b=QWo7fTgE2A9PS0frIuUuwvnT91fOj+bAO7Fh/xwkgzWxlzj6oeyAtYQqW3DQbE4J/q +TMpqhOAP/ijhMIU5gD67giJJsAEKX6lyB/3y0JvSqP3arcFTvTkKaUSqqiWyUMSZCey UfQ67iJq7Cx5deXTuo2mx/5xvLY1qMItZI/x8YZa8Ag7c85kzsmc/hXNuQf+5tqTHC26 g2oD7crT6rkibwJb2cJ5KIwlPAHiuzaoLNYjcHocPRcT0pRm9O7ZcDQN17cwk3sqCN0K r1E6jhjj3n8rQyfiAPuahX5WFCr+SUYouStt740Ce25Pmbhr+0ZA9YfRMhHOLHNLJYRz N1vw== X-Forwarded-Encrypted: i=1; AFNElJ+lJ8lAx6+G+gpPPQZe8JNxD/0rAmi/PUs3CAJp53CMcoszV4uE5+GFsHtPzni+x9sR8IaJg7LxrU1VWFw=@vger.kernel.org X-Gm-Message-State: AOJu0YxH9pKsPvgDNqjOyU3WWk21s7lSEaQHGFDB5N+vw/H4eg3Yy8XJ /KQrfW5NOq5TMqgL7L625Um8qK1iHiMLG61mM1PDG5uWnJxMxEiK4GUp X-Gm-Gg: Acq92OEgpBS028XLwoiX/eoZFi9ymROSPu54Q6aoUI5YIG1CVAZYaKbE6/O624EstH4 +meKf0EqYkiZTRxX6GQUKrXgFrzQH4tzvD8E0IUBDs/k70dLcCPFPzo9wqAjIQHKPHbX18FBGqb 2a1YG7N/SWKtGrljkSK5z/wQWig5XMr2PLBML4i18Tqk7d2jXi1O0qTwpiiQawFELJ7Wjnm3lTp XlhGRPTINyC81xOB295VK5IZG754Ev8T+RTGZODlTKqF5jniPVgDy5PsFlyGB6PgwsdkM1yOMDV 5J6VKH0tcQcH9Y6IojF9JB/t9ViJRaYsi8YkruqQ/0NOkkrOl7KeXLWZ+WCmrWu6tAbdoiqF72M vKd6xCRrH2zaU23cYccvd2AMunkspY/agIMs5nx/OlnefdvZlRGXwI4IX4f+FqXndAq5mHPYeWb eYeLBILhKkrglVIcdodj60jdgSt8yr7TDy6nUlrIm5 X-Received: by 2002:a05:620a:2a08:b0:8b1:2853:673f with SMTP id af79cd13be357-914b48e5aeemr2262725785a.15.1779731178255; Mon, 25 May 2026 10:46:18 -0700 (PDT) Received: from gfl-XPS-13-9340.xiphos.ca ([99.209.85.164]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914bba1b49csm1050653185a.44.2026.05.25.10.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 10:46:17 -0700 (PDT) From: Gaetan Florio To: broonie@kernel.org Cc: michal.simek@amd.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gaetan Florio Subject: [PATCH] spi: zynq-qspi: Remove redundant clock enables in setup Date: Mon, 25 May 2026 13:46:14 -0400 Message-ID: <20260525174614.1052191-1-gaetansjo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The QSPI clocks are already enabled in probe() with clk_prepare_enable(). zynq_qspi_setup_op() enables them again with clk_enable(), but the extra enable is never balanced. This leaves the clock enable count elevated and can trigger warnings when unbinding the driver. Remove the redundant clock enables from the setup callback. Signed-off-by: Gaetan Florio --- drivers/spi/spi-zynq-qspi.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index 5f23e902b..2aa2c9621 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -437,21 +437,10 @@ static int zynq_qspi_setup_op(struct spi_device *spi) { struct spi_controller *ctlr =3D spi->controller; struct zynq_qspi *qspi =3D spi_controller_get_devdata(ctlr); - int ret; =20 if (ctlr->busy) return -EBUSY; =20 - ret =3D clk_enable(qspi->refclk); - if (ret) - return ret; - - ret =3D clk_enable(qspi->pclk); - if (ret) { - clk_disable(qspi->refclk); - return ret; - } - zynq_qspi_write(qspi, ZYNQ_QSPI_ENABLE_OFFSET, ZYNQ_QSPI_ENABLE_ENABLE_MASK); =20 --=20 2.43.0