From nobody Mon Jun 8 23:56:06 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6449A2E424F for ; Mon, 25 May 2026 15:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779722511; cv=none; b=VC3k/+XevKZYM27pdnthC17ibcVpu1YQU2o5URYoYEkZAhjG/54wu1xtU/g+rJvUDR1+gVhMw6eGLcXHeLc+a6bLqjAi+9arqijH45NMOSMqPvSUc1FNZHtlV5sh8ubAOigxDks1dE4JAz/sHzpbyokwAoT9CKuWWRIjTODywBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779722511; c=relaxed/simple; bh=Zih5qrvP0uYey2pj2Tiz2fmyOiEkYiF9CfhRE3bbwSg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=arcCliOMjDWV6FZl2qn0paTods5t1UTE/N5fZPcSLoLk5Av1gIFnfAXDedpf/g9DsGLn4qy1M6hH4UDk87k9aNC+1BrTd+6P2OEKvC8KuS369EGSsRMJTfnhV3CpYSBD5S3fr7RRf8+bdR5s6sokkXFrLYcVWRN/FiFvef3GM2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vb9HAldB; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vb9HAldB" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a8985fe4e6so921685e87.0 for ; Mon, 25 May 2026 08:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779722509; x=1780327309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3szcHfwW0La5jre2jpVClNipxO4MhebWvrDcZivRLXc=; b=Vb9HAldBdUHOrsnK3tFAA4aCucxtQgTMfbrVxca6+RFmUtbeYLZMsXQP+PoaMbUmH1 40TvF0NUYzrOJOrLmvZWBP31s3ZmgVJ6ppKOtm2nqNDWzY8qlN0z9w+jGCn/0mjJOG6d IfODqa8slqcOBZbt8pdMW7O5Oouf14HaFkfQe9QYyIi/x46zpBWbbHdCc60Pdq/1logv 2XFNetqoxAIrKP+b3zEqH+kjNmZ+nm+VqfsWeAf1oVClbDuBUCmhhHz0rKbZpBHasqof De4lL5OJwwoRY6q98aU94I0i/d/V5tcrhmDajiJrvDehwRYEqSHIrSZkIJORoDujTDbZ Ft7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779722509; x=1780327309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3szcHfwW0La5jre2jpVClNipxO4MhebWvrDcZivRLXc=; b=HDiFmipo6wBpx9DfBi4x2189kf//mDYwEkoBcor+pJWNGcGLOWuaOaJhk2r6UIOUPE bom8d28mFRbTMwRsZBJGsEnL5GCx7Yphb4tqI4hpzRoDOUtmFt6mzGR0fACDX1bOVgLn 2iYLs9syGqWI8duRWGQz1kQ5N2p/fUXcJIQ+QppwCksoimECyu1L0l/PM92gNSJG30fl DxZ/Ux6YvtMjm1KxZS0uiVOIiuj2uVAtc3T4kX9g5C5+Q4xwxnGV//h/+z6BZi96LzqB Pdkn9LvipX9E8NYgvkvcMkArpFRz4VcSjGa1hpNbIlRcLkJMruySZDDung/yi9F97Pvp 4SxA== X-Forwarded-Encrypted: i=1; AFNElJ/Fl7USLLenlJpNZliHh8d9zwt8UX+CnPkEEdxUzxB+RuFxTexd3NZ2OiAj8gzwRohdZV3y7Zyj1v3rh9M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1idoBHJA/2XCkDBeNxHUZt3NNz1l7fcO+lQmNlNWyHFL4yipV k9739BmcjydodMKWvzrPvRX57ySo9aQ77szyND3qRvlXbf2p57gZ3yYi X-Gm-Gg: Acq92OHaPliGo/h3Mv7T4TZRWBKxKRJgVbb7s2XEq7AezWzJGq3YvLUpz/7IaUNpvct SfO0hCwEO2wxWYVmCpHhFqHnF9V+asbNW5fPJJSZeyVNUzF6q+JrCEdoDfhZSl5KYX5qwaJN/1Q R0vekYhIy8yQRskduI2plGZSd3DYf0kmUgYyfvkp9PTXePfB/FeRmtDEDYIdTKbOWqxL/9jRWdY fidULlmdfGexav/ILZjvOpUYglKKW1OLCwrlN3Iys4YxyhTmv4bB3FA4L0UNAF930TXoJrkAmv3 u1ETe3h2BFhTeKs06sOyp4k4H8hzfDAwdHhMv8Rg2Pj0mxFGyqt5SyxvUljUqfJK8cEnT6qBjJ0 oDrzdlvVeL8fTIOvWn6k3XhQEHbRwl567/g1RXJK7YoTKtFlDxP6uTCvrVlWagOlgWF8hBUk0Lz nC3xOoAKHThFjVR01eMPktC1DCCkCM1/+cJGX5KAj0kIln X-Received: by 2002:a2e:a593:0:b0:38e:2183:2287 with SMTP id 38308e7fff4ca-395d8d28ba9mr24558311fa.6.1779722508386; Mon, 25 May 2026 08:21:48 -0700 (PDT) Received: from localhost.localdomain ([94.158.61.193]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395dcc2d61fsm22930941fa.33.2026.05.25.08.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 08:21:48 -0700 (PDT) From: Stepan Ionichev To: wbg@kernel.org Cc: m32285159@gmail.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sozdayvek@gmail.com Subject: [PATCH v2] counter: ti-eqep: balance pm_runtime on devm_clk_get_enabled() failure Date: Mon, 25 May 2026 20:21:37 +0500 Message-Id: <20260525152137.7428-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ti_eqep_probe() calls pm_runtime_enable() and pm_runtime_get_sync() before devm_clk_get_enabled(). If the clk call fails, the function returns directly via dev_err_probe(), leaving runtime PM enabled and the usage counter incremented. Route the clk error through the same err_pm cleanup as counter_add() so the runtime PM state is unwound on every failure path. Fixes: f213729f6796 ("counter: new TI eQEP driver") Signed-off-by: Stepan Ionichev Reviewed-by: Joshua Crofts --- v2: - Collapse the dev_err_probe()+assignment pair into a single line using its return value (Maxwell) - Add Fixes tag v1: https://lore.kernel.org/all/20260523184448.7609-1-sozdayvek@gmail.com/ drivers/counter/ti-eqep.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c index d21c157e5..4f3b17939 100644 --- a/drivers/counter/ti-eqep.c +++ b/drivers/counter/ti-eqep.c @@ -548,17 +548,21 @@ static int ti_eqep_probe(struct platform_device *pdev) pm_runtime_get_sync(dev); =20 clk =3D devm_clk_get_enabled(dev, NULL); - if (IS_ERR(clk)) - return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); + if (IS_ERR(clk)) { + err =3D dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); + goto err_pm; + } =20 err =3D counter_add(counter); - if (err < 0) { - pm_runtime_put_sync(dev); - pm_runtime_disable(dev); - return err; - } + if (err < 0) + goto err_pm; =20 return 0; + +err_pm: + pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + return err; } =20 static void ti_eqep_remove(struct platform_device *pdev) --=20 2.43.0