From nobody Mon Jun 8 23:56:08 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E12423ECBC3 for ; Mon, 25 May 2026 15:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779722086; cv=none; b=NVxO+NfnBuoUUb/dMLUzI66U/SuxgqR24hPtMfghthA3dlfepeyzuhVm8Ym1wj7t+NYNo/uweUA/YPr/aw1B/b6wRzRNyaZsNezIeF4/sh3H+4/LVthRZdVnGz/ykjS5hilY/dGfVs3zwFevW3NGFpFE2RhzNyAAMN24zUnVgls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779722086; c=relaxed/simple; bh=yZfleqqgRxjy4Am5CNAwgS6zya8iAH/d6o7PPJgGwaM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GmwTzGVkYCx+h8KrPObCWVqoMqbVFNzE7sUtknBVaLVoy+/EDX7eM6x+8IUdjhsDPC5SfvLp08z4/7wTWlIEfro2UyDyeuaIjZGf/Cy6avgnxgL1p/BkiUpuwZNUpw/iIpueR0Z11+l023ZYmlicz3OZvnBjSxo6NRWbm1f34ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwhJpUAg; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwhJpUAg" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-367cbac9c37so5613665a91.2 for ; Mon, 25 May 2026 08:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779722084; x=1780326884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8ekN9RA6xWGM9vsTg+kkP2fzePZkZ7mF7z+5w6nzPco=; b=RwhJpUAgVWVYMKpF+DhH7H22vz5C78oQYac7V6CTJ8G9qyEY57Ke+CzaEtAtH+qMBd zF3fRgQvEqwgDpnwrl0v7u/83tlWEc/bNoBg+7ZNw2zDLaL0JHoB4SMkjL/g0m3zfy51 dL92Ctei0X4jLpmmTBmfrMb7J0S4Mc/C8Hz4UW7wUOIjYqivKrRXVZe7He8B9tgYQtPr pnLMY40TaXNqd9irUyws1r88LECH73N4GsOpyr1mAnKL/mZoTi3Ih7gZu97NaSUzZdaz QE1ClFUC4g9qswsNYw5E1IKKeH1QKtbJ8cIhprvxMRlbmWKZfV/CEuseChlQMRTwKQx+ pTqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779722084; x=1780326884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8ekN9RA6xWGM9vsTg+kkP2fzePZkZ7mF7z+5w6nzPco=; b=TWcM8z4j8uyXDdIpDeSU9xkBR8iKq5V/xLuo8n3uqPP8ACD23q5xR2Vbg1KUXgNpOY +LzUkJFaOmeMDI5peeX3qCduAZ4uClxEoLD7tH7rMF42uWAzdn6GCbG7ZZ4EZsge0R/w O/aRdGnxeWlOVCvxci0C3x2s6Tc7AaNL+77q1TKfRuaF4yMIixUt5pI2mmZkJIxf4Zdk 8xhirVOq+RHYg9bpqpjI4udujAKtwXAmQ4CFGg0zf0P+RtHGf85fm36u62a8JTE3c57F +7E1tuesvZ6C+VE/y+wl1xprxbH49BkcMS6Pt9/lbZyAtrLqnv5GMBkQnti4Wh3itxfT AWgA== X-Forwarded-Encrypted: i=1; AFNElJ8P9cq+5CSo8zkPsOxXzBfrByU/Sv0i2DKz5Cc8LZzdTmJc403qIr7mOKyk0Iskh0SAj4phLwiUdA7+HWs=@vger.kernel.org X-Gm-Message-State: AOJu0YxyULcaqjV8E979JviDwRb7Bx3PL5xvXGPwrfDP02oXbENDNkA5 1h/2yKQdz1B0un94McgDdLcxS6qQOUgzGu2dAVpcylAjxrXrQumNp47P X-Gm-Gg: Acq92OE8ZryVTKMW5zmkiKCAIooRsGgw+d7FKBnAZldiFfPq45sRCwJRQpqE4tmLhEL /DOa9BQXsHSAgwg5QDaRlbyySxp2ryn6mW7KzoHWJ+RXJPtHADDoZbzy/O2nKJyZJWr/YO1TdNu V9ylysgQrtxcX0h0dZPTUdyK2fkopZk3d54NMCdQQpzpmaHs/Cpc1jks7yQPolanY8+ffwsnFvL ByDQJRt0ghwlWmIf2RB0LNY7xKgL1kz031KqYtip5ltM/6a7Yy1v4rGVtau8VEfX0UnwsoxiCV0 WAcAF/PX/5olhtGaiDdh2QmPTm9c++QwCac/hAKTonyYn1XXslO/p2S52dgbOG8vP+kbRyUk7ZL dHKcdpbo8C858lokYAv60kVuccvUh/fF01pRl1/WN4sXx4l0LS0lnpGvPJm4SQTBE4SwJGBMkx7 ov4hjOrLMq6Te9Y88dbm8zP2gzlTlvD2QBCTIj27VJ3bwhyRyuyVOpsFHtSHRy7PEnm0unlwg5 X-Received: by 2002:a17:90b:4d0a:b0:368:f0a:1c48 with SMTP id 98e67ed59e1d1-36a671e2735mr14075939a91.0.1779722084256; Mon, 25 May 2026 08:14:44 -0700 (PDT) Received: from lza-virtual-machine.localdomain ([223.160.230.107]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a721c7cf9sm10097658a91.10.2026.05.25.08.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 08:14:43 -0700 (PDT) From: Zhian Liang To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhian Liang Subject: [PATCH] Input: ims-pcu - fix use-after-free in probe error path Date: Mon, 25 May 2026 23:14:10 +0800 Message-Id: <20260525151410.42750-1-liangzhan5dev@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the driver fails during init (e.g. in ims_pcu_init_application_mode),the= error path frees the pcu struct without clearing the interface data. If the device is disconnected while in this state, the disconnect handler w= ill retrieve the stale pointer from usb_get_intfdata() and trigger a use-after-free Fix this by setting the interface data to NULL in the probe before freeing = the pcu struct. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: Signed-off-by: Zhian Liang --- drivers/input/misc/ims-pcu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 4c022a36dbe8..fce3232ebf07 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -2063,6 +2063,10 @@ static int ims_pcu_probe(struct usb_interface *intf, ims_pcu_buffers_free(pcu); err_unclaim_intf: usb_driver_release_interface(&ims_pcu_driver, pcu->data_intf); + goto err_clear_intfdata; +err_clear_intfdata: + if (pcu->ctrl_intf) + usb_set_intfdata(pcu->ctrl_intf, NULL); err_free_mem: kfree(pcu); return error; --=20 2.34.1