From nobody Mon Jun 8 23:56:24 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1943F39E5 for ; Mon, 25 May 2026 15:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779721948; cv=none; b=PcKt4XrJXbahLk/c5eEVUXjhPHmktxIrbzfAqoPF1Jg9ZVhRfsUGj0THvQmll/oJHnPxxfaLrHf63Uae/tXDd2Ei8tM3bpLpUrR4pEdF4v+TU5mKUbExR1tfbg0JzgS/z48vdxCrRfMbBjiNRZh2O9E/ZB/ymY+AyPRehIuYpaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779721948; c=relaxed/simple; bh=pO4iPLthvwVVCs/LNnJQDxDexEOiWW2Bi3DdBaUpWsY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rWLbbeMKURgFxUIBc8IbliUVhyITmOXJXb4dXfEd35OEdWg2lNh41bgS/269hJZeo9V1DV5CxZD4g/BVjr7VwimzLpsEjBm5VLf/tktGORDVnIpgvLDlUaxCA4fD+taGYCs2u40uRVCeDEb5GSQYrZuVigbdqDlXSY/Qv2FKVZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yms+GLCX; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yms+GLCX" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a4002b1183so661592e87.3 for ; Mon, 25 May 2026 08:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779721945; x=1780326745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YVQ6aFlL0VJIn4hbLuPi82/xQjX/foF5fGQImUXGhy4=; b=Yms+GLCX69p2vBPBIcgqdmARh0xC1DxvD4pZPYYfwwzlsXGwX4so3zHsRjhn3fS/b9 Uqn6C7uzIMcvFhCpYd+h6r/d4Pltai8om3W6eLnGFWesjFRY6cbrG0q65pjudzxL0ZO2 cPSgn+sbClS9d5NdyjCkQD6CMjQr/XzvTq34NB/0ex4P7ePsw77jmSH1S7igUtEn4wcQ kAl2R49gto+Yqg06sBm+0EE5H+LjBrMONt4TpcHKkj7V7N7pNbv4j3jf9IenBk4mzeYi 8yfTil8nVSO2iUYZEppNdNvJgzOsorSDoxtnB+nUGe6IZN6cQcGDbXgXItG1CM5V61ws EDGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779721945; x=1780326745; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YVQ6aFlL0VJIn4hbLuPi82/xQjX/foF5fGQImUXGhy4=; b=UpSAnUwrTluMi/umODVs4QnUK0yBaUKJUq0arsMZ5wX4U/x9I2EpfX2kcE1hzKJIzx Qmg/ZZNNKZSMDPaWJYvXCjDPNhVcw1NHT0jtakhDQMthwsPAksQzS7N4O19VqhXlOiEA mTCvfzPutxSMmvAgPuxsVBk4BevoGYdarPPEAyCUAwLTXHHHVcc+KIXXk6p81ZO2q6RS t5BGpKf8hp4q9taLE9HG0Q8B1uAznJWNmi0y7+k02dcEQyX2fVm6gAS5NFPtahln6bFD 2IoF5VuhUwXR7r+CIbp7w50ArqQc4bZI94f9sajl4WPp1JCu5yq4V39ueL4WY/bnrZfv vMng== X-Forwarded-Encrypted: i=1; AFNElJ/fbFK3kbIn3nuVOsqCrp0IhL/A8BvHku06km+eAtuk31eUgmUQPDRAhDlVYK+KXkvzXGtYUA/WBn9bvko=@vger.kernel.org X-Gm-Message-State: AOJu0YxOOzeLfcfKzxLocwNFgel9AvgCnBReunS19qjaSCpITg/avGQX Okpm830++CEwWVzSC1OtQPet6PtL+uQVb+8S/pKIvUHGvg+RzRFhB7IC X-Gm-Gg: Acq92OFZI+2Yjr87CMpGMwNvRCxGetau9lX8ABJPsyRzd8oMTpdXJDuGZIsDGxOn3Tf 6jWXY78qS9PxqRccTL8QFm6fdm5tK7QlVHDMRCY7V8GPxoXQWB7pZUrS/LPqbaE/+0pZD2mfpQs cmRYnVuxQqOFAeauqJ9EfXK3cbR8PvS8ZW8n6Fgd5jFj4F0XmypaGKbI2HHWc1G7KmBI91pMHhl TZ++GhrwN3dR5qfT31YLaBTMeYA42WWqi2Qo+MqfXjeZ48wIPxa2+VKl0DBH+sTfxw8pTWAkRhb StjNbSDw+AznHYIjb3ogkMEzr4xvjeo5WZe7StHNXAEOLq7y1KTW+xNcS5tHZDDvNafY/nympsQ OXcMI0IBMryzQr2+KG6mm2Q0mkE3ojYgdTUlnmksHslNne+jb7Y5ABVCR1ml+KL556Jb5m8PICe Doc2MMF7CscFWAvNzCe3WbmrtZtTHDAqpisaCvHvSAbnN8 X-Received: by 2002:a05:6512:6091:b0:5a8:6f8c:24b1 with SMTP id 2adb3069b0e04-5aa3a34a49dmr843592e87.1.1779721944651; Mon, 25 May 2026 08:12:24 -0700 (PDT) Received: from localhost.localdomain ([94.158.61.193]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32ceb5a2sm2734384e87.38.2026.05.25.08.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 08:12:24 -0700 (PDT) From: Stepan Ionichev To: wbg@kernel.org Cc: o.rempel@pengutronix.de, kernel@pengutronix.de, joshua.crofts1@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, andy@kernel.org, sozdayvek@gmail.com Subject: [PATCH v2] counter: interrupt-cnt: use devm_mutex_init() Date: Mon, 25 May 2026 20:11:52 +0500 Message-Id: <20260525151152.7238-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" interrupt_cnt_probe() calls mutex_init() but neither this driver nor the counter core issues a matching mutex_destroy() on unbind, which leaks the lock debug state when CONFIG_DEBUG_MUTEXES is enabled. Switch to devm_mutex_init() so the mutex is torn down in the same devm scope it was set up in. Fixes: a55ebd47f21f ("counter: add IRQ or GPIO based counter") Reviewed-by: Joshua Crofts Signed-off-by: Stepan Ionichev --- v2: - Add Fixes tag and clarify the leak is only visible under CONFIG_DEBUG_MUTEXES (William, Joshua) - Add Reviewed-by from Joshua v1: https://lore.kernel.org/all/20260523184418.7586-1-sozdayvek@gmail.com/ drivers/counter/interrupt-cnt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cn= t.c index e6100b5fb..cd475382a 100644 --- a/drivers/counter/interrupt-cnt.c +++ b/drivers/counter/interrupt-cnt.c @@ -233,7 +233,9 @@ static int interrupt_cnt_probe(struct platform_device *= pdev) if (ret) return ret; =20 - mutex_init(&priv->lock); + ret =3D devm_mutex_init(dev, &priv->lock); + if (ret) + return ret; =20 ret =3D devm_counter_add(dev, counter); if (ret < 0) --=20 2.43.0