From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EA00282F3E for ; Mon, 25 May 2026 14:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720445; cv=none; b=oWkQh9yHt3KJoYd6FOflsaMdPLQhc8FPF+bVAelaniy6C7KdzWnEp3/iwTJf+kJJ4orf4hqNymFyBeixZIeKmKDox3A/EOOal+CP2K125B2fpx4Jf+FakeL2m9CvIL6MpJ3ThGDXGxiG/EoC2rFOVEAuRF0oHT4vY59ku3za56Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720445; c=relaxed/simple; bh=DLsg2y1+bliXCGG/reyDyV3bIVP7ZQeG9EfRj65TbF4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VYbQHfnMLqweEzoLt4B+XytUsmvtuFPNyJYgAdIJWv98FMe0oGNc0avmx/Y/OPgT1BshWz7mhKYeUnRGwuKgHvO8BBQJb5A8xZ6li8rFn4xo+YgbEy5Rca0kg7pROsxn9sX+78eeMYiT60HrfnrMt0ax2w1bwTQKNcNC4FJCNmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JGGlizXL; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JGGlizXL" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36a7bbb9698so1715613a91.2 for ; Mon, 25 May 2026 07:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720444; x=1780325244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYwtJECaHP5wUeZHKflBOjjaT0Cdv+xswmxDcx7ZgJo=; b=JGGlizXLFOdXxSL3LwmSAX5532L9SEsX5fI4bLNm2kQmqrVgQG2+c/OyyHmAyDHS78 N8butyk0xZ3eHFiXZExuQQaTWYC5/xiD8yKRSPR433jJ3q40G/6wJCe/MVthxSE17ar+ f39ON8WjbjhavWzVG4VqinC7WcjHaMWDtW4v+zJS4KE7tabYpP++Jl+274wrLtBy4xPh Rsk6aD79zPGd128FUBX0d55bGRnqWO3o5p9YS8bJB2/hkiAtPD4FoA9Ezm5MK43KdQAF dfTgc+G6N9X6xfZYWrKpwoIurQT4DkvjHNwgDW530ppEazyRl5/dEXJLsSQQ0O0UdeVV LkuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720444; x=1780325244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MYwtJECaHP5wUeZHKflBOjjaT0Cdv+xswmxDcx7ZgJo=; b=gyhJhrPg0SDUceM17W7ncZLNv38VXTwz1cAN0E+Ggk1N5o3bGUTjX3y5UBN2P2H3Dh WHiUI88tDX6usyK4E0ERK88Yet7mfeaIFSObQHJyYgrsebX9cy6dV1PFDz0UI2sXSeht 9kLtv4JghDOK3Y6CK73rZEkb1nOhQLgCZDrS8A7tfdinm7qEz4ZqQzH5mnGXYBMHJJ9Z BMEZ7qokjR+lOwOC/KgC60N/9xGn4YVuBAdIb7tgz0QfXRqXW6SceXdJSs9Ik1Hvc6FD YLhaGIQTDyTXd2jGuhANVJie9hJw9e8IAXPzKpvA1jMhrP9yEcsyVCw5RZcOUU2EE5Xb OnNA== X-Forwarded-Encrypted: i=1; AFNElJ8Fn0vsWkhCbtfWzTuDByIhyfMCe6RddkGKeojUsTnb/gx5Hxci1E7nXf5DA/7GXNzsNirSt4gtsia5gfU=@vger.kernel.org X-Gm-Message-State: AOJu0YyKsq5UyijAGeQFybLrbM3KNT3z6avociWIShZjz5aHpiaCqgS2 I+blQU8mq1vPUUM/86l+CCEmI8J+7wig2RS5l0QgpdSeNabJnK4Rb9W8 X-Gm-Gg: Acq92OFMgUPxjGo+o04wCJiQBxbW9kduxoUDOb4twQeCgC5shXoCD/8GSlbnidelY+q NwI8iRaVJ/ZHL+SqVOoB+y+8BQAbhwFCwAxb4HEDp4wAiqT/Qr9jhBhbeTBPmGhC9opLX+1IDtl pjm8kQiHdBHvEFo/TWWvrWYDrxeTOUt2WgDlwFmlLzthyFigaYpmyKazcaCHgpoMuPM3VkyRHFk h+FemdOQxQmVy+WMpOAvxL3c45zgm2+VC/D42YtucdvEEdFh+QEJl7rfIwgxPx6CYdhMjVdVh5w IyUayX0ud8ya2BCb4hHcQJQECQMtdt+UnZhT1DZrHUGqBPIpuegPfYIguubq7fVUuVefeg/cwee mnhUwTGHglFUs+dxhR9gDV60SV1bk0tIIfM4CnDhCJ/655YFqn6JGK+U/B44hHIdvfdKEAoTvTu VClNj4SRnJ9xqW7mg8EHHpZVl663R5CSh+QsNVL8E= X-Received: by 2002:a17:90b:1b07:b0:369:a9e8:dbf5 with SMTP id 98e67ed59e1d1-36a6749ea42mr13774833a91.3.1779720443648; Mon, 25 May 2026 07:47:23 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:23 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Claudiu Beznea , Wei Xu , Sudeep Holla , Tony Lindgren , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Patrice Chotard , Kunihiko Hayashi , Michal Simek , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 1/6] dt-bindings: leds: issi,is31fl319x: Update description for the shutdown-gpios property Date: Mon, 25 May 2026 22:46:07 +0800 Message-ID: <20260525144629.498630-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL319X series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Update description for the shutdown down (SDB) pin and fix the example device tree binding. Fixes: dbc801b472c1 ("dt-bindings: leds: Convert is31fl319x to dtschema") Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/leds/issi,is31fl319x.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml index 906735acfbaf..ebf2bed51e7f 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml @@ -39,7 +39,12 @@ properties: =20 shutdown-gpios: maxItems: 1 - description: GPIO attached to the SDB pin. + description: | + GPIO attached to the chip's SDB pin. + Driving this GPIO low places the chip into hardware shutdown mode + for power saving. All register contents are preserved and registers + are not reset during shutdown. The chip exits hardware shutdown mode + when the SDB pin is pulled high. =20 audio-gain-db: default: 0 @@ -174,7 +179,7 @@ examples: #address-cells =3D <1>; #size-cells =3D <0>; =20 - shutdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; =20 led@1 { reg =3D <1>; --=20 2.54.0 From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A4D3859D2 for ; Mon, 25 May 2026 14:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720454; cv=none; b=I4qiaPpNrA96cL6NDdZgrLjtZxkEHrI8IWt21GlGZz7y9ER00xyGNRvs2JwQQBmeo1d5vtSn1n3CoxpUbbz9xO5V6t7WELyLFo49QwoV9o/osfGo2Fu45l2zyrnvZYhobp69s2yPU/oqEzcKUldrMk0NpAXKt1rWK2cIdWmTA4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720454; c=relaxed/simple; bh=J1/LbVdtBZ+LOAFAQJmwliG2jdxMbt8JaagyM4ndmvk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vEAQI3ildlrFyc/JVp/DuwdNpezs3VefV+pqCg8RrRis/XOZVkTfcLbwEmwhnLGS2etZGks2hSWB3lm0uEbx/oX52/4WbMvWiYN012f/6akPQEZbjTTQ1e6IVYg428F1QAqbOQkaxN9z4JPGwIByL0M+OWpusiykqt7eYTqbt30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JHrBesYQ; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JHrBesYQ" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36900945df5so4814673a91.0 for ; Mon, 25 May 2026 07:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720452; x=1780325252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wCToqKFCbrUX7FSNvgPMJdWqTINioLrARjrzWOT0nyY=; b=JHrBesYQRaI5e4WC2b9ogmODLsFEjp7JtJD5RtSokDayoX/n6TfDtV9wLkQHob6eYK EQsDldfFFXOWxZo8mJOEvYmKJzWy502c1rC0l9s+dcOf0xLcVU5tphZg9IhgfxQ1xoR3 OuuBYDFfJe3z6b/FId/yHfJn0CZ1KcPsGJ05AeclJPrgZqzdEY/7zYlNPVZr363Q0mEi 6ABSPEY6N2wgGNj+oYphiyGSPu47u4IyzG8dslqRcS7cb2bJDS+k40r1DiiUU2/Rm286 Ma4rpn++bP2t1eEVW6ogN1Vx9x/jo8g5HdG6P7D5uzf28WyYMLOOW94GfVwMnDzwUG+y pLDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720452; x=1780325252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wCToqKFCbrUX7FSNvgPMJdWqTINioLrARjrzWOT0nyY=; b=hCH3v/ehKer0B5Wro5Xt9PxmxB/obQ9FZD2kqzlbkQbK1JkC/OeFjtmFINZYple080 2psYkGGZMqSN7fRhPykUAc9q6sytIcMqeOJdQMGngmCutZUSw8ZPxkflIXNcyKIR6P5O qaEujVuHfgh3BhzvnriWCVyYSh2KkFAebMC4dg3tFDC9JrYPp4sllOKKOpZ4RwsBVrZO NwaMuNy5KnrSaM6X6D69on5K/ud86nPsCHcLad5m+l12OiqH3czqiAkrYJ/q1N4iduql e1mN2+xx1u9/hoJ4ppm6YqkcWngE4XS1rmiN9CJXf3W4ZuQhOirsDd1iBWTMnu4S7ov9 5Ysg== X-Forwarded-Encrypted: i=1; AFNElJ/0p2ErujyD6zc26MhLq4RkCGDkDt6xZp7UNO+4S5gPBypNHZdqKgcMygAXcS+8Nl2h8yQhMrpxe2ibFHs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcsFakvOyvL9f4JYgeGSqS+GFg17oayCLIJAPKrUroBo4rAuXu x2dKJOLcdqt9f4oGYXSGB/a3DKXsaYYxhKswQ4D9YV7vMzpTCGDVpjeI X-Gm-Gg: Acq92OHy+8J01qznTz61exX9d8yu9uYiH1KjcDmx2T1ca0PmFE4WTbE3PSj0osRpqQl p8Bb6wU88CzU6OSDWbX63HuUaWPNG30iyI6J3+h6pbzEuQMCEbphpU++7+QPOphPo5YrSLYdOUz hfG/4Gmltrj7xJxKebhHNttymMq3MreNPG1HXJ9uaMrEbD+5u9jekU9sNgxpBwGB65kCPTtHp38 JgdODj9fGuH8HT7o8hZETp2Obstq1CciMmX05prtoz2DyofZMivWjPM6Q5Xy+cumiLoAbU2i4R/ 1qKtGjjJfVUZ2slMICT87cmRdNv7iMHrWj3OYd61JR89KdysY4cGruJ8trE43lhaYv4rqNERnA8 5EPcw26sGGcx+IWxV1JzSWw8EYtVE0Agh/B0oP9f8c+11TO+P32IwuSTlTgYutxe6b/qQ8+T+R+ q8o70saAZkfQRUVVIMll/DrAvw/qRCm37f8Oz5Szo= X-Received: by 2002:a17:90b:2f88:b0:369:a962:8cd7 with SMTP id 98e67ed59e1d1-36a6749afa1mr15044923a91.12.1779720452269; Mon, 25 May 2026 07:47:32 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:31 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Geert Uytterhoeven , Viresh Kumar , Florian Fainelli , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Shawn Guo , Michal Simek , Heiko Stuebner , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Date: Mon, 25 May 2026 22:46:08 +0800 Message-ID: <20260525144629.498630-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is active-low. Fix incorrect initial GPIO level to properly release the chip from shutdown state. 2. According to datasheet [1] definition: Shutdown mode can either be used as a means of reducing power consumption or generating a flashing display (repeatedly entering and leaving shutdown mode). During shutdown mode all registers retain their data. shutdown mode does NOT perform chip reset.A dedicated software reset is already implemented in driver by writing 0 to reset chip. Remove redundant unnecessary toggling of the shutdown GPIO. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: dddb4e38c6ba ("leds: is31fl319x: Add shutdown pin and generate a 5ms= low pulse when startup") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl319x.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index e411cee06dab..41087ed262cb 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -396,7 +396,10 @@ static int is31fl319x_parse_fw(struct device *dev, str= uct is31fl319x_chip *is31) int count; int ret; =20 - is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", GPIOD_OU= T_HIGH); + /* Driving this GPIO line low (in fact high) takes the chip out of shutdo= wn, + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tr= ee). + */ + is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", GPIOD_OU= T_LOW); if (IS_ERR(is31->shutdown_gpio)) return dev_err_probe(dev, PTR_ERR(is31->shutdown_gpio), "Failed to get shutdown gpio\n"); @@ -506,12 +509,6 @@ static int is31fl319x_probe(struct i2c_client *client) if (err) return err; =20 - if (is31->shutdown_gpio) { - gpiod_direction_output(is31->shutdown_gpio, 0); - mdelay(5); - gpiod_direction_output(is31->shutdown_gpio, 1); - } - is31->client =3D client; is31->regmap =3D devm_regmap_init_i2c(client, is31->cdef->is31fl319x_regm= ap_config); if (IS_ERR(is31->regmap)) --=20 2.54.0 From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADAA63F1AA4 for ; Mon, 25 May 2026 14:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720463; cv=none; b=JK0UMt0GPlEtlpBdalafvMmHtJyFZSuQwGy3+g/idJbAbQV0pOxEaf3cm5BdnsUeN9/sQ9uNXpME11bM0I04ZrBrPypwR3TBrWRNpr7YNPtu2gP/oFVZgsy55gBERYzVB38AUSoNVZLnszqw+rZAPs0m8iHMxLwIuZ6KiUJgHqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720463; c=relaxed/simple; bh=pjFlrB7uGN0vyMl1RGqGgvMd8ocGBWVXot5mcHQGLcM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XSldcFiwRdobB7ocFv0gCcSKqKg88jZefCTrAydPx/TNYsOrBsqeI4RFnFzqGFY7duY+8PFvu0cbbNOmGN8mF1h2MM3mzbIbdtBNKnNV20PfzIvqigcd0byyz3EoWNQNjCRHdcyoBaJfWOdRJaSiyCD4Ogu1F7+lM2gxKdNL2tU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pqwHijrb; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pqwHijrb" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36ac67f489aso786486a91.0 for ; Mon, 25 May 2026 07:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720461; x=1780325261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qt5GF4ec4Tz+ThdSwkffpWxOTLLBMBcFoFVLeUcmmpQ=; b=pqwHijrb35hlGp/Z9U7y+lbVHEX5mXpcl4mrG/XyVwNd8RFb/oYj2bH29RKUZwu2Qy MXQs/iWVeUWpulfQpdKxXDYzHzsBAHrGHgazwgsM8okP9aCuRZAynvZOwca1N0qtGOen UFf0SQyTVzmaT4ohrlP7B7x8GvlhtezmCyyHhXRNpWJzC0rH0OTxqtazs4t3vUA6DjI9 fk4iWCW4uGdQzftH9F9NLt192LzqkztJm4VZYnIUU5UNk9XR3fgEmfaw6SpZRWTvHM8V Ap8yVb9j3FqG45ZJl0GK+GzUm+Qr+CIK0Jtb0BbYT4t8ldlNaglYiiiyMeABx8aCgLF0 ZJVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720461; x=1780325261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Qt5GF4ec4Tz+ThdSwkffpWxOTLLBMBcFoFVLeUcmmpQ=; b=ewWkskNGMqCfXbiwvXaTEzNZFJPVC7cvznBtrw87q9XSU6cXBaxmlkVLUssjiOvWqD AWMgzNmY4vGCkl2/aQeMCHW6U3vf9Ti+vLhVqQo86sXuo4r5qxTcrH687gXyokEuPsSM YoSHGQfQ8J6oYAA0Auhq3CPVRHppuCN7ueuNN002LpSGuAcuGDZfYUvze2UAa4cwPdBj mG3eUrjP/pHlj6sR8RcfbXLldVmlUIEqmckIOLlbNJ4TE8dXLW8m0vVDS36srqcoYieT PNjmw/3Bn6Wm1ygvqPBqEcNo2U6s28AUGKpU3bK2Fj8c3nBZxW4aLzitdFT0OPiCRHEn QSRw== X-Forwarded-Encrypted: i=1; AFNElJ9p7ICAMd8HGu78GK3+gyQyFTGCRXL+PmpqgdY+tQUMXfpwjreJmvHm1C6Z8HgDr7LntyzLTggtjF0Pj7A=@vger.kernel.org X-Gm-Message-State: AOJu0YyIspB5bfCzz7sHSja+FW1ek26yoausN1zMrLkeQDwExSu7kG6Q DBebuS/qbu+w7KQpsl4Mw9epM6YhoBRpEbGm6fxr/Zri6E0bt8XO5JIl X-Gm-Gg: Acq92OHIqOZ3ccTyMw+rJJgeZd7Ab+KxgFAvpNVQ/+g5hOe0Kq1IgAZph7iXU6UyH2V xJ/5qaRzBo8z5mKqRpiNO3v91Mp6hbRID9o7emu1thw+LPZ5HE6isGoVOXwl5ObGz813+nQnl5S bB5+DdkfzCWayi9cfdKo1CHX9e8Vfb1KdBjsDTiz3C8V3FMb3CUzA+2onOFb3yj5G0FNe1F4n6/ V4wLqLKUPug4Ze+HO++CxeD/rSYzpDv5ukHBdXwLVVdPCgB6/E0hBQSQnizsotYCSBm8fCTsC1g 54hNW6Iy0zlQs2M5IGybwdL0AVgr3ciV9Mh9Ikl/cl6erYCSZrNGJlwbxF5JiwPzxL8m3djSBNV IgvfzmCCLV7gFQimmmn2ZNGkQFmDC+dZY4wA8IX845Pe2b4PZohIi6HwaQkFOjfhER95doooxdk xr9QxVfaoYmyaejP1WkQqGQj88CnRIh5f2zhATn3o= X-Received: by 2002:a17:90b:3e4f:b0:365:8fd4:925c with SMTP id 98e67ed59e1d1-36a6c65330amr11990238a91.8.1779720460900; Mon, 25 May 2026 07:47:40 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:40 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Tony Lindgren , Sudeep Holla , Romain Perier , Jesper Nilsson , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Wei Xu , Geert Uytterhoeven , Peter Rosin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line Date: Mon, 25 May 2026 22:46:09 +0800 Message-ID: <20260525144629.498630-4-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable According to the IS31FL319x datasheet[1], the SDB pin is active=E2=80=91low. However, existing device tree incorrectly configure it as active=E2=80=91hi= gh. Add a fixup to force the consumer active low for legacy device trees. [1] https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf Signed-off-by: Jun Yan Acked-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib-of.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index ef1ac68b94b7..8a79aaadc9ea 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -194,6 +194,16 @@ static void of_gpio_try_fixup_polarity(const struct de= vice_node *np, { "himax,hx8357", "gpios-reset", false }, { "himax,hx8369", "gpios-reset", false }, #endif +#if IS_ENABLED(CONFIG_LEDS_IS31FL319X) + /* + * According to the IS31FL319x datasheet, the SDB pin is active=E2=80=91= low. + * However, existing device tree incorrectly configure it + * as active=E2=80=91high. + */ + { "issi,is31fl3199", "shutdown-gpios", false }, + { "si-en,sn3190", "shutdown-gpios", false }, + { "si-en,sn3193", "shutdown-gpios", false }, +#endif #if IS_ENABLED(CONFIG_MTD_NAND_JZ4780) /* * The rb-gpios semantics was undocumented and qi,lb60 (along with --=20 2.54.0 From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8362D3F076F for ; Mon, 25 May 2026 14:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720471; cv=none; b=BHFuVzQkS2DaWov47xGu7Az2afTjfINok9SKrfnpobHt0KxH96R0BfMT5A1FET4XGPaKIkaL/LanZ0q4GnrdHyYRYiRiJnXe/yv/TofZKIZx+gykWgcUNJwMqI+ID07WHxasXivKQTJ52CPjkGx8jtTxEKw1Hmmoe21vmTLasYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720471; c=relaxed/simple; bh=rQev9snjUDQDOjiwl73HCrNzxpOg3GjolVgiv9srQUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dydNkMB/ilWm8SabK87dTts5E/Fd55mOiBOvlPnUkJiFlocJifhhgRcJQFZH7gKCpXF23wxCnsWQcwAcpscWEL5sW+5MhyUMw28z3VlavJMy4xtFoL8kM6QBLqxCDG/2ShmmR6ZKGa1nVE8nKz/Y1frbdxupyBBe/Y2R8Ow6VCM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UlFEFbtE; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UlFEFbtE" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3665a90bcd3so10578729a91.1 for ; Mon, 25 May 2026 07:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720470; x=1780325270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rVVGG9O42cYkv4+MEhpJhN2Gsiqdr8SLjGLZwhgYa/0=; b=UlFEFbtE4LX8kXg4191YimQ3eaMGAtBr7w0P51NQTkYRRd/JGvwIF6zH4KVfzCEFsf ck860WhFm07gR+HHLGAW3m5LbhgNvOFwjqfBX/eGYW9o2BMDi4T2mcqF2yKfgOfLkf7B c9YvT39L8wBDCebbfMvJpaY5vpmu6S8VP5b8gTEWqfqA2JkB2U3KfOWIwPg+N71ShVkd 2my3IJnbNudbfyMSjOEDBG7pzWqQNpmaOXPmIWBPq5t2tzmiCEZ4WEr8RQs9OzMzrk2h Y5xGzLepZ6VsIY8bogN1TU6nrewVqakKLoo0SO/EAwo1/L3Wllh5KLmUW/SHo8Yif3YL J3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720470; x=1780325270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rVVGG9O42cYkv4+MEhpJhN2Gsiqdr8SLjGLZwhgYa/0=; b=PuKwmgdsMgQyZAiaKwTZs48Gv7R7KqLDjXeOJ8qs/BVN1QRqpo0CR1MZfd+tB7QAN5 hwPXomj/InxGjpiO652UQBa/AB8TCJISe3DdvYfx9VT13wIJpemXmhIn8/tky4ipHdRz zAmw9viCt6cUlk7EL1oh+nkJPNnWHS6wBluIyCEKBYchQ9W6V9EHoW2h/WiTxj/b+x3A TYErkp5T4lQxKngyRS+R8JJYxHLxtm0j0zfpjYW6yywu6JkaVqAIWjE5zx00KezPO6bY eq07bOMfAGGB0kp/n34Qyqc6ylqIDbWLdWrYLz1u4fr+EQnBlVm91aXPLg7KTbtWl0Cj UPOA== X-Forwarded-Encrypted: i=1; AFNElJ/4URkG5svNqF6JE76qDincxNOQRexcbbRnfnt15BJtYA3+z6Ls4GmHp7lFISAA4Q/bs/0XHOQ343IEgpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxQVAiBjuIl9KWLrPx6P4qQcUuIESavV702Iv+2LUP8+nWKujWn 87ivNoinUws2LHvaVpp7Rdx/aY7ogxzdbgkxPr5QCbUqA8ZbiKtLI3Pw X-Gm-Gg: Acq92OGm1Gunk8s0YJjWRYiR0vuqeBgH/Svrr69QivmolTToV3BRL+L6eQicj8k/E1a +pFl4X9tOxUGdUWufynbejbzhPAXQmupAlTJfkHwVTsLOdB8OW/c87N0OwWchRujOlaq0saCGsW U8t4rnI6W66j1pUk3J+5ICXhF/o1LbFNbSNzQKu4SI86AsBVwfoiBEerFZKLuD/HmSfrYSnhvco oaHKQ7b8nkDH6Wcb0gslCsmmS3SlUJ8Nny70Glcikk5xHew7aoyCHW9ummd3xQYsglLnyr+dCLV BfdvkJTi2gQJkWc6fRtjebNFEJVK6sBVMw0GLfxzUttZzAyKBNcOQqK5HMyAnbIwSmmqbP550QG 21eEd3DY9daa15bZJEiMsWMh36b2+CbyK1r6IkjIdoIchvuZSAIrCxlqOgI9N+AT4fGWzXN5/ZU Efe28mk/KD5TQ67jyLOlQJg++MyT8gOmQtSATcMsg= X-Received: by 2002:a17:90b:5284:b0:35f:b7f5:9b3 with SMTP id 98e67ed59e1d1-36a67420e95mr13511527a91.3.1779720469769; Mon, 25 May 2026 07:47:49 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:49 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Viresh Kumar , Heiko Stuebner , Sudeep Holla , Florian Fainelli , Robert Marko Cc: Jun Yan , Konrad Dybcio , Pavel Machek , Krzysztof Kozlowski , Wei Xu , Romain Perier , Geert Uytterhoeven , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 4/6] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Date: Mon, 25 May 2026 22:46:10 +0800 Message-ID: <20260525144629.498630-5-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sn3190 shutdown pin is active-low [1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf Fixes: 1c8cc183d070 ("arm64: dts: qcom: msm8916-alcatel-idol347: add LED in= dicator") Signed-off-by: Jun Yan Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/ar= m64/boot/dts/qcom/msm8916-alcatel-idol347.dts index 2de8b6f9531b..6d51d6efcbac 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts @@ -197,7 +197,7 @@ &blsp_i2c6 { led-controller@68 { compatible =3D "si-en,sn3190"; reg =3D <0x68>; - shutdown-gpios =3D <&tlmm 89 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&tlmm 89 GPIO_ACTIVE_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&led_enable_default &led_shutdown_default>; #address-cells =3D <1>; --=20 2.54.0 From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03BD3EDE44 for ; Mon, 25 May 2026 14:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720480; cv=none; b=rhMq2TtDhb03ENY1MP2QvlnqW2hir2L0MGBUM8gS0tFXIwkb161z28Y7aeFx2cipoEq+RYEPdkTz3QAy6+MOZ7FpQin2IppSTBSZI3Ymb5NObLmkvTxxmU9E8XSYB2/5CcntzycSRRsBxgLmFvmyp8EhRGK9bjjIipFCzOzIsYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720480; c=relaxed/simple; bh=ApyTNGQqGjBxvFRvwMaHvvYHMwId1OBVvi//Xkx5AxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UgZYQAjZ3eSIuCtn5LxRC41QZzCEluS03PzjY6s7AGRu8ijfdrMN/FL3t7b7wro5Oc806wiKqF3HYtE19S/sEJ0+Cwi9omIBcrT6E0QY9Ix9FkkDHZFoZS3KvBhAfFAowTqFy6FmHtfKe8rS8UDJuvP5gjoRjUIsVxjqtguFkRA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MoQ7A+EY; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MoQ7A+EY" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3697c35eab7so5819027a91.0 for ; Mon, 25 May 2026 07:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720478; x=1780325278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pqwtJk8xmatM/f20tiZM3MnIEuWEW+BjNIaufm9TpJE=; b=MoQ7A+EYfe7BKJLVo0cLGDctXXJ1skLbBTwRPdiT5c/mACHra88EM8jRRPMcdroUj1 SJxpG++n4pqxLuqzrmWZ8mFq5MT+W+nMlOpyxdZ2nciSxERtFw+nZD/A8UlCk0rvPksI xxkx8sRcAv+Ui8GyF7mGegHYbVShHUjczntM2J+YEtV6KN5li/EwXfSRZqHgfRCVQPPu y+QNN7r1EW3omWbmOyaBnRXIN+BFd68PfUIf2dq7sm1M2txLnjUcQicvwWo2Fptr3UtK JKfE1c1t4cKFBK+/7KVEWiHBsfUC0VB8iO6XNG0eHKLEtwh4Si1qKehYrmUODVq6Uc1b 2fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720478; x=1780325278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pqwtJk8xmatM/f20tiZM3MnIEuWEW+BjNIaufm9TpJE=; b=W0X0d5ecdEmzi8x5z8FXZXI5ySKeTse+gcZTl9mrWWBbXM1xgNLnypz4pl6PKMgDsm Jifye26cprAmS1dBMPc1rsbyDCVsSmQsq/OTiTPXgmkrXge2JZ6k1o3mWf/SxS4gP0Ks Pw524XPMljqsENFuEOaU6S520nIxI/wfPo4e+xHphjBRrAET5OC2isBBAT0NdWl8yvdF ifufvnPSqXfNJ43kRrNAmeXa8K6IRGean3HtaKlzrW9QRTTWcHYhD6VL7aJIleUAEfuE M9CsOqp6l/wTNNczuZmk7szE+VEpRwtiBIpEE1D/JyNn3IZL4ybma+rfzsqYImR+2bJc YHuA== X-Forwarded-Encrypted: i=1; AFNElJ+uPBEAhoW9m5BVqy71IVq9Goy/KeU+bpFZhzfsHDNXkH4bclhc5GniKT2ExV/IvJFpsd1Tqn1EHqye3L4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6d53WtdAtyN6RdpkkIitqqyrNN6OLdjdEyQAT5/hLIgn7ZlPd 5mRLMLdFJf8u8W2F1hEB9DafBGrKgC/VOdJxjwx0Ig0lpwCIuzil3X7c X-Gm-Gg: Acq92OFTYoSPBk7yTalMLMNqs6NxeBRsC1pawu5XkBbfUkwOR6hvuYUMGj3VqTL2Cv7 gA9jSf48Dw1pWe9CEvexP9nPkmLUGGEs9MJsETGU1xlmhGBlqMvhS8QeGfG53QwzHL9J8SLbKL0 UCgRMn9k/H5NljALYYQcF5rsrwfH62IoKMKr4TCWg7now+zcazRAYnbJxLoEbz0lxXVO90hbYp8 h3flJ7tdXFjdR+VTkltvQHD2iitqEZqkR7G+1T2fVnAlNmFx3M3fGJURpzXE5hvGy3k5eU2pFvB jg3fn3CN8Llh8BB6692psdAMLrw52R2O4zhqSTOA5VAgfNxDWUsAo49CtEdBnjZZaV2dpClaBui s1bIfg9eDt0b71TE0OXt4eP8yxlOmRCy7jbRIfzDCSOgaOeBY4ZFnzY/yW4p3+6gTP5En6+T+R3 dKDNdBSl5M1RvOsTV4U+VlulpM5BbSMisl7hx3nXGr9KfuoRzWCw== X-Received: by 2002:a17:90b:274d:b0:36a:caa9:47d2 with SMTP id 98e67ed59e1d1-36acaa94cb2mr5894653a91.1.1779720478207; Mon, 25 May 2026 07:47:58 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:57 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Alexandre TORGUE , Kunihiko Hayashi , Robert Marko Cc: Jun Yan , Konrad Dybcio , Pavel Machek , Krzysztof Kozlowski , Geert Uytterhoeven , Sudeep Holla , Baruch Siach , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity Date: Mon, 25 May 2026 22:46:11 +0800 Message-ID: <20260525144629.498630-6-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sn3193 shutdown pin is active-low[1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: 724ba6751532 ("ARM: dts: Move .dts files to vendor sub-directories") Signed-off-by: Jun Yan Reviewed-by: Konrad Dybcio --- arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts b/arc= h/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts index 258bbbecd927..c528d42bade5 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts @@ -147,7 +147,7 @@ led-controller@68 { compatible =3D "si-en,sn3193"; reg =3D <0x68>; =20 - shutdown-gpios =3D <&tlmm 45 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&tlmm 45 GPIO_ACTIVE_LOW>; =20 #address-cells =3D <1>; #size-cells =3D <0>; --=20 2.54.0 From nobody Mon Jun 8 23:56:40 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C01903F0AAD for ; Mon, 25 May 2026 14:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720489; cv=none; b=Se/07chjUS5zYxojxI3Vi0VW+S3n0aD6dHVnnSSqSwTi7wSg7I4JGmKp5p0OpG7HX+TxhWshUqDGiYmVStAOkuosslg0krd43PCfdoksIYpyxO3Crg1Wt2W5jlQABdnA4gKXUdV4EcjnJfOMHywp6ka1Ljm7Vvdj6Vs2fA543OM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720489; c=relaxed/simple; bh=ow2Pp8Yde2ialN0PVZ+ngSDDkSxMoIzeQ2w8Qc4ooeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A6EjZd9Z4M5i1OpebDKjQe6/5ZmqQBTXnINjZB4rak0HVFCCVHChKohtFpFwtrooB6+tMMcde/QZWslhj7mnfs5kCaDvDZSB3za07yD+FFvMAmcIVrWC5F010ATFetnUHkX8K6BDCtcG6NkbsheH5ZMNHhdz21sCWWrK3w5FS8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Admtch7U; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Admtch7U" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3664df30f53so5723958a91.1 for ; Mon, 25 May 2026 07:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720487; x=1780325287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IY5VpH1QCqNL+Hxqm+EMdHN3zeBtEzU6Oz9nJybwNNI=; b=Admtch7UI0gu5S8ZMD2Q1X5linI28LEuf2Znabbk/HF89K7f/+QpiKWvfsRGy1riXr zolhcnbGN2MoA7M2jfcEhw3bh9/hvifTRHtsFOQt3rrz7/Jf5kY78O0p4TMTm+A+lqVe LldrbdJog8Se0y6HZMUYuLWOOndczHvpMDOXWGCiJ07GxhHZgq9dKrDq9iFLjSaDesu+ YVfVTWovmuG9ghuT5InQ9mC55D3dXEP5kCoD4Vbh0M9MtOC+3z87bMoYTHh9sSCffmLv wSmSeYuqYYLoSiFbE9/rHj1Tcd/73zBcy8VOOaWCAkEpfg8oEcE4KhCaHqUEoHeKIIfj VsRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720487; x=1780325287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IY5VpH1QCqNL+Hxqm+EMdHN3zeBtEzU6Oz9nJybwNNI=; b=LUM5kS+OvClhvT9+3+1herE+WXHEsYPOMAlO7qNwh7ZI7hAaxJ+MRpcLs/QfvQ7k1s SgfuebiDUQQBsGFOp1KR1JcTOTJ9pwx2kFC2wEgWHoWE2wvxXsf/ELGPKoDc6gbbugl7 D9MnJ1f+BidsFHoshN/bM1Md465vAsUa/JtudPGjkzJSYtezwwz6+xzN+dndEYTT5QOR t4sWXBPevwz3WQ6VMfNgahMe4QmYx5wi/n60NsC3t7g0TBKMwwS+PCsWJfjFWkHcSU9I Dyu8/gcWPdTQr874h/ekMxlLkFYHTU3s1KYmJBRl1KF75++chPbRioArfTKscuCnLsX/ e8ww== X-Forwarded-Encrypted: i=1; AFNElJ8ojNaO4r1DYd9hj+XL4sB0uUentF6qk7NqzpEpxS9Aq41btLl3yyPS4Ojwue+i9CpHkGCpfILKP1bf1eY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw0BMRO6OLdDCr0yGlnCZut629neMMW0RaH13grhckTLrXnJ+c KlRiDXiJ+Ca0ZVMEB5wxWDHRMJ20rGR5ZILsTR7RgeKsm5sJFrcJxgOU X-Gm-Gg: Acq92OFG5Jyzgt1xlIqfV2Wds3TkNY8C0fnPbKFb+7KzacmXle2uq8ZEUl+oh0nP10q cVF8fG/9ktFmKEfC9daTWxd4RIimO2xzRLJzy6jO0G5PzOwreIkM1XFo+o69fAwBkJ4JYBix9S1 QUxGtBUNFOcDLrQilVcLgfSEdfqgNe95fK3qTJV6bPcyoEhxKRdBs8fYqiRhoZ0ICZ/OX3VxUHC MFweL0q0+vqHyY4noYEPBYpRjNU7JTsusva5Iu2YhdyAFtcENhwaMsFa8H8b48OZysTjw8hDGlO NbURtBsSyRQqvcraaLhq1QN4MXo8oeBXnXUEpve4vCJuKsv5hzLqpeV/EVC/4ZIaS9miuVlp0q7 swhpguUI+uUKlVBv5S+xno3JfxnM8dIohuB++go6kKUu3Ph6n1D8Nouf/mc/RFY2QYtorKmsM+V FjUxm2RH7Ow4i9VZkTDNh2olxKm+6P9Ag+Jg21ZgJcuRxFNrAGpdlGTjUNYHAT X-Received: by 2002:a17:90b:2e88:b0:369:a359:b18e with SMTP id 98e67ed59e1d1-36a67449708mr14002024a91.9.1779720486941; Mon, 25 May 2026 07:48:06 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:48:06 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Baruch Siach , Shawn Guo , Paul Barker , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Wei Xu , Geert Uytterhoeven , Patrice Chotard , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 shutdown GPIO polarity Date: Mon, 25 May 2026 22:46:12 +0800 Message-ID: <20260525144629.498630-7-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The is31fl3199 shutdown pin is active-low [1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf Fixes: 737929191283 ("arm64: dts: marvell: add Globalscale MOCHAbin") Signed-off-by: Jun Yan --- arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/ar= m64/boot/dts/marvell/armada-7040-mochabin.dts index 6bdc4f1e6939..cf690a85cc2a 100644 --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts @@ -236,7 +236,7 @@ leds@64 { #size-cells =3D <0>; pinctrl-names =3D "default"; pinctrl-0 =3D <&is31_sdb_pins>; - shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_LOW>; reg =3D <0x64>; =20 led1_red: led@1 { --=20 2.54.0