From nobody Mon Jun 8 23:56:25 2026 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE57B3B19D0 for ; Mon, 25 May 2026 14:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779718567; cv=none; b=VA6epUdRTXxMu6s2s6gbvxObyDACEIxrf5fkpLH6xjcNnKFqwdyT9SFZVPZtQG//MLf9syw+KdhCFvrzFwltUVrUjLGD8Niq0AIVJBz6YtGwtpF9LPCBxEUCVmeeDdcXy2FXT4LNzHLS1MSoIYElATbEcvgb5ATmeI6oxGjK0j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779718567; c=relaxed/simple; bh=97TcSk7c6BRe9ZZo0iCmpFWTVvCvOAMfpbkGNdYidDc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IH1CpzjOjkc9fHe5/dJTlOaMFtYS7k8mdJ7qUMu7jS7IgPCKvNrCU30YdxE1bWjaHY19AzMnHzx8lzw74aaJUrbgQhjA5bYMcYzmPGTe9JcsLnyXRUsb1NVZB0VyAr3g6kLFluNOZtVCzpoN7iENTjVsscbw5gvMsueE4FhQ/Jc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DGIMW12u; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DGIMW12u" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7dcdd1b492eso9713672a34.1 for ; Mon, 25 May 2026 07:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779718561; x=1780323361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TnXyCVWggg3/qEkvLDg7uPlDc01HqQ/Q3+WVp/VlN0w=; b=DGIMW12uCBivuUxH6a+VlhdI2nc8YiI/Aa0Tu0Mjzm+4fD/IG06awA8dFj4v3wxhkn DKC19jhdWlKQwnl3ZgbJkJTlyMX3gFTSSQ6GlC5giiBjlusl38UpkdiKN3ocjuW0GOXJ MckumuEbOmOB9paqcxO35GjV1pvzLzuL5mQ/JhbcyP+sn/W73YzlHpdSEa9GwEolFOuJ ZG+UPiAqTi+oPpAdJxcNgq8LdfQmsEzwTXuSyporEj6gWJDGow8nvJujRta07pXaq14M rlFFxyTO1s06oECKpbR3xu7LVxTtvXC7LlzWqPhM8BBUSAQWrFIsNVuKyhAgpvoVROjH f21A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779718561; x=1780323361; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TnXyCVWggg3/qEkvLDg7uPlDc01HqQ/Q3+WVp/VlN0w=; b=e6yD5dQAaKS+17rn5LE+l93PAEK+Ln8uN9NbpIsDeexBYz+2b5aOEQp7aZF+a8Tc54 y0Syr1qmYpuaSCmGfmOsUdB7M3LbwfCV7Vd9O57WXvlVZe0XZdsYcZLXrDVoK2s4M3ak +yVta//Xhje1IjvHlFwjBlwnaIZdMkSu2upVJCeyM7AtKAxumVBqZ11Rq2wY3Sw/1+9G eDtgBPM0SB0ZPIE6XQuL7F3m1H8+uBHvIIVmUjbqrQ7Z7p+YBDsJVBYsS5Bm63MgKBc9 ENF5dl2t2nZIfQgjvev3NUAvSa6iOFY51M1g73lSvacBTz5JOqz/H5kEJhAXqwpJBwmg FxCg== X-Forwarded-Encrypted: i=1; AFNElJ8JgiMdyYpzYjUJZ7SKNVVvjA+IJ7jCOcikdO0jrr+0pmgaBas0tKUVK5DIF4zRXQ2Jfh9Ny7hS6N1VY7o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw54gNPKhs9URPPRK8W/9wgHeEBmhktviLJ/ENmdGQre/3gNq2b vuy7M/q3vE/R5RPL8xCiqgZC3zSHnndLc+BEx+D1W91hP4LMrmA/adJC X-Gm-Gg: Acq92OEl+x9DnhSrS+y848W5oJgbLJtK4zQgp8nCIU91Bi+sbK9mxw61f+j/q5u9Zub pezwoOinsv9G0EEXo+FiSIQzZnOgezNwQn6CDY/NTFt9/MlZ5nm8WmqLB2n7v3fMugm9xh/LiZ4 a0AoG6e5TCKbQPLYUECi1Wt+mw6pGdEsRc+m1KAPz+CQWzcsSsFISfWXqxGejIHHB8ZDbSqavk9 Wfyxm0BHgjOzK70xWapWG+CaG4Wk+V26MxgAmo89Qc/RSnOO5uE+C7FGHVm05WrPcB2CqWJiyti eTE34b2qfgOUWr8ijCoYFmFit70QQoA3YdXnnM6ZBf5gPNKPk/lfW4NoBRS+pG2klWQqKDnWa4g CScZAEq7y3UdtalHnFJsQKalnoHoQIBHyhpIzbhQZhZ3ytu5sCINvFjQWmI7Owp74WtulwRngI9 nxKA/E4n5jGekgs+cUfvO5Rmcd2x/VOV01+5oFHJ9jUu8LBdzMnYY= X-Received: by 2002:a05:6830:6e0c:b0:7e6:69f:d208 with SMTP id 46e09a7af769-7e6069fd4f3mr5253693a34.2.1779718561041; Mon, 25 May 2026 07:16:01 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc812e657csm121728406d6.24.2026.05.25.07.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:16:00 -0700 (PDT) From: Yuho Choi To: Vinicius Costa Gomes , Vinod Koul Cc: Dave Jiang , Frank Li , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v3] dmaengine: idxd: fix fdev setup failure cleanup in idxd_cdev_open() Date: Mon, 25 May 2026 10:15:50 -0400 Message-ID: <20260525141550.1385581-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The failed_dev_add and failed_dev_name paths drop the file-device reference while wq->wq_lock is still held. If put_device(fdev) drops the last reference, idxd_file_dev_release() runs synchronously and tries to take wq->wq_lock again, deadlocking. Those paths also fall through into the later ctx cleanup labels even though idxd_file_dev_release() owns that cleanup and frees ctx. This can make idxd_xa_pasid_remove(ctx) and kfree(ctx) operate on a freed context. Move idxd_wq_get() before file-device setup can fail, since the release callback always calls idxd_wq_put(). Then unlock wq->wq_lock before put_device(fdev) and return directly from the file-device setup failure path, leaving ctx cleanup to the release callback. Fixes: e6fd6d7e5f0fe ("dmaengine: idxd: add a device to represent the file = opened") Signed-off-by: Yuho Choi --- Changes in v3: - Drop scoped __free(put_device) cleanup and use explicit cleanup, as suggested by Dave Jiang. - Keep idxd_wq_get() before file-device setup can fail so the release callback always balances a matching WQ reference. Changes in v2: - Use __free(put_device) for the file-device reference. - Take the WQ reference before fdev can be released so the release callback's idxd_wq_put() has a matching idxd_wq_get(). drivers/dma/idxd/cdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index 0366c7cf3502..82b07cf942ef 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c @@ -288,6 +288,7 @@ static int idxd_cdev_open(struct inode *inode, struct f= ile *filp) fdev->parent =3D cdev_dev(idxd_cdev); fdev->bus =3D &dsa_bus_type; fdev->type =3D &idxd_cdev_file_type; + idxd_wq_get(wq); =20 rc =3D dev_set_name(fdev, "file%d", ctx->id); if (rc < 0) { @@ -301,13 +302,14 @@ static int idxd_cdev_open(struct inode *inode, struct= file *filp) goto failed_dev_add; } =20 - idxd_wq_get(wq); mutex_unlock(&wq->wq_lock); return 0; =20 failed_dev_add: failed_dev_name: + mutex_unlock(&wq->wq_lock); put_device(fdev); + return rc; failed_ida: failed_set_pasid: if (device_user_pasid_enabled(idxd)) --=20 2.43.0